153528 2016-01-26 19:02:02 -0800 [EFL] All API tests are broken on 15.10 2016-02-01 06:51:22 -0800 1 1 1 Unclassified WebKit WebKit EFL WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 153211 150619 1 gyuyoung.kim jh718.park achristensen commit-queue jh718.park lucas.de.marchi mcatanzaro oldest_to_newest 1159176 0 gyuyoung.kim 2016-01-26 19:02:02 -0800 When running EFL API tests on Ubuntu 15.10, all tests are failed. Need to fix it to bump Ubuntu version. 1160419 1 jh718.park 2016-01-29 21:48:32 -0800 It seems that this issue is caused by https://bugs.webkit.org/show_bug.cgi?id=153211. When I revert it, I found that API tests execution works well in 15.10 as well as 15.04. 1160654 2 270340 jh718.park 2016-01-31 06:40:01 -0800 Created attachment 270340 Patch 1160692 3 270340 gyuyoung.kim 2016-01-31 16:23:02 -0800 Comment on attachment 270340 Patch rs=me. 1160702 4 270340 commit-queue 2016-01-31 17:21:01 -0800 Comment on attachment 270340 Patch Clearing flags on attachment: 270340 Committed r195945: <http://trac.webkit.org/changeset/195945> 1160703 5 commit-queue 2016-01-31 17:21:05 -0800 All reviewed patches have been landed. Closing bug. 1160740 6 mcatanzaro 2016-01-31 19:48:30 -0800 Hm, this defeats the point of putting those statements in conditionals, and will break Windows. See the bottom of bug #153211. We should think about how to make this work for both EFL and Windows. It's also rather fragile to have code that depends on include order. Maybe we should just set the directories for Windows in the toplevel CMakeLists.txt, to make this more clear. 1160763 7 gyuyoung.kim 2016-01-31 20:57:11 -0800 (In reply to comment #6) > Hm, this defeats the point of putting those statements in conditionals, and > will break Windows. See the bottom of bug #153211. Now I don't know this change still causes to copy files to bin instead of bin64 on win port. Now I'm checking it. 1160764 8 jh718.park 2016-01-31 20:59:36 -0800 (In reply to comment #6) > Hm, this defeats the point of putting those statements in conditionals, and > will break Windows. See the bottom of bug #153211. > > We should think about how to make this work for both EFL and Windows. It's > also rather fragile to have code that depends on include order. Maybe we > should just set the directories for Windows in the toplevel CMakeLists.txt, > to make this more clear. (In reply to comment #6) > Hm, this defeats the point of putting those statements in conditionals, and > will break Windows. See the bottom of bug #153211. > > We should think about how to make this work for both EFL and Windows. It's > also rather fragile to have code that depends on include order. Maybe we > should just set the directories for Windows in the toplevel CMakeLists.txt, > to make this more clear. First of all, OptionsEfl.cmake:46's statement add_definitions(-DWEBKIT-EXEC_PATH=\"${CMAKE_RUNTIME_OUTPUT_DIRECTORY}\") uses the value otherwise all the api tests goes to be blocked, so I put this change in. I have seen the bottom of the link you had left, https://bugs.webkit.org/show_bug.cgi?id=153211. And as you said, this change makes the conditional meaningless truly, but it seems that current cmake working is fine because the CMAKE_FOO_OUTPUT_DIRECTORY will be overwritten by OptionsWin.cmake and then the values will be used. So I think this change is not breaking Windows, but if I missed something please let me know. And as you said some changes would be needed including removing the conditionals or the ordering dependency causing the code fragile. 1160781 9 gyuyoung.kim 2016-01-31 21:48:22 -0800 (In reply to comment #7) > (In reply to comment #6) > > Hm, this defeats the point of putting those statements in conditionals, and > > will break Windows. See the bottom of bug #153211. > > Now I don't know this change still causes to copy files to bin instead of > bin64 on win port. Now I'm checking it. In my local win port build is fine after merging this change. Besides MiniBrowser works well. But unfortunately my local windows box is 32bit. So I'm not sure if my test is fine or not. Alex, could you let check if this changes breaks something on win port ? 1160838 10 mcatanzaro 2016-02-01 06:51:22 -0800 I think Joonghun is right, Windows should be fine since it will overwrite these values after they're set. We should still clean this up, though. 270340 2016-01-31 06:40:01 -0800 2016-01-31 17:21:01 -0800 Patch bug-153528-20160131233927.patch text/plain 1970 jh718.park U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1Nzk2CmRpZmYgLS1naXQgYS9DTWFrZUxpc3RzLnR4dCBi L0NNYWtlTGlzdHMudHh0CmluZGV4IDVkNjY0NGFhMGQ2NzVhYTg5NjQ0YWRiMzRjODRhNzY3OWNi ZDkxYzguLmQ1ODMyMTU4YTY4M2RhOTk5NjRkNjRmODI3NGVlMzE4ZjA5YWNlZTUgMTAwNjQ0Ci0t LSBhL0NNYWtlTGlzdHMudHh0CisrKyBiL0NNYWtlTGlzdHMudHh0CkBAIC0xMDUsMTEgKzEwNSw2 IEBAIHNldChXZWJDb3JlVGVzdFN1cHBvcnRfTElCUkFSWV9UWVBFIFNUQVRJQykKIG9wdGlvbihT SE9VTERfSU5TVEFMTF9KU19TSEVMTCAiZ2VuZXJhdGUgYW4gaW5zdGFsbGF0aW9uIHJ1bGUgdG8g aW5zdGFsbCB0aGUgYnVpbHQgSmF2YVNjcmlwdCBzaGVsbCIpCiAKICMgLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0KLSMgQ29tbW9uIGNvbmZpZ3VyYXRpb24KLSMtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLWlu Y2x1ZGUoV2ViS2l0Q29tbW9uKQotCi0jIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAjIE91dHB1dCBk aXJlY3RvcmllcwogIy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogaWYgKE5PVCBDTUFLRV9BUkNISVZF X09VVFBVVF9ESVJFQ1RPUlkpCkBAIC0xMjMsNiArMTE4LDExIEBAIGlmIChOT1QgQ01BS0VfUlVO VElNRV9PVVRQVVRfRElSRUNUT1JZKQogZW5kaWYgKCkKIAogIyAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQorIyBDb21tb24gY29uZmlndXJhdGlvbgorIy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQoraW5jbHVk ZShXZWJLaXRDb21tb24pCisKKyMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KICMgRW5hYmxlIEFQSSB1 bml0IHRlc3RzIGFuZCBjcmVhdGUgYSB0YXJnZXQgZm9yIHRoZSB0ZXN0IHJ1bm5lcgogIyAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQogaWYgKEVOQUJMRV9BUElfVEVTVFMpCmRpZmYgLS1naXQgYS9DaGFu Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZDJlZGM2Mjk5Y2UwZmYzYzQ4Zjc2MTIxZDUwNzExODE2 OWY5ZmYyMi4uYWZkNmZmZTk3MjQ1MjFmZjM1NTk4MzE4NzlmYzBhYjMyYzE2NTU1MiAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAx LTMxICBKb29uZ2h1biBQYXJrICA8amg3MTgucGFya0BzYW1zdW5nLmNvbT4KKworICAgICAgICBb RUZMXSBBbGwgQVBJIHRlc3RzIGFyZSBicm9rZW4gb24gMTUuMTAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzUyOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IEhhdmluZyBp bmNsdWRlKFdlYktpdENvbW1vbikgc3RhdGVtZW50IGZvbGxvdworICAgICAgICBDTUFLRV9GT09f T1VUUFVUX0RJUkVDVE9SWSBvdGhlcndpc2UgYWxsIHRoZSBBUEkgdGVzdHMgZ2V0cyBibG9ja2Vk LgorCiAyMDE2LTAxLTI3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAg ICAgICAgIFJlbW92ZSBFTkFCTEVfQ1VSUkVOVFNSQwo=