153518 2016-01-26 15:25:27 -0800 B3's integer range analysis should know that Mul'ing two sufficiently small numbers will yield a number that still has a meaningful range 2016-01-26 16:49:27 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 150507 1 fpizlo fpizlo barraclough benjamin commit-queue ggaren keith_miller mark.lam mhahnenb msaboff oliver saam sam oldest_to_newest 1159061 0 fpizlo 2016-01-26 15:25:27 -0800 I almost added these optimizations to the DFG integer range optimization phase. That phase is very complicated. B3's integer range analysis is trivial. So I added it to B3. Eventually we'll want this same machinery in DFG also. 1159064 1 269936 fpizlo 2016-01-26 15:27:47 -0800 Created attachment 269936 the patch 1159065 2 commit-queue 2016-01-26 15:30:42 -0800 Attachment 269936 did not pass style-queue: ERROR: Source/JavaScriptCore/b3/B3ReduceStrength.cpp:1968: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1159101 3 fpizlo 2016-01-26 16:49:27 -0800 Landed in http://trac.webkit.org/changeset/195637 269936 2016-01-26 15:27:47 -0800 2016-01-26 15:33:38 -0800 the patch blah.patch text/plain 7116 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1NjI4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE2LTAxLTI2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QjMncyBpbnRlZ2VyIHJhbmdlIGFuYWx5c2lzIHNob3VsZCBrbm93IHRoYXQgTXVsJ2luZyB0d28g c3VmZmljaWVudGx5IHNtYWxsIG51bWJlcnMgd2lsbCB5aWVsZCBhIG51bWJlciB0aGF0IHN0aWxs IGhhcyBhIG1lYW5pbmdmdWwgcmFuZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MzUxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE9jdGFuZS9lbmNyeXB0IGhhZCBhbiBhZGRpdGlvbiBvdmVyZmxvdyBj aGVjayB0aGF0IGNhbiBiZSBwcm92ZWQgYXdheSBieSBiZWluZyBzdWZmaWNpZW50bHkKKyAgICAg ICAgc25lYWt5IGFib3V0IHRoZSBhbmFseXNpcyBvZiBhZGRzLCBtdWx0aXBsaWVzLCBhbmQgc2hp ZnRzLgorCisgICAgICAgIEkgYWxtb3N0IGFkZGVkIHRoZXNlIG9wdGltaXphdGlvbnMgdG8gdGhl IERGRyBpbnRlZ2VyIHJhbmdlIG9wdGltaXphdGlvbiBwaGFzZS4gVGhhdCBwaGFzZSBpcworICAg ICAgICB2ZXJ5IGNvbXBsaWNhdGVkLiBCMydzIGludGVnZXIgcmFuZ2UgYW5hbHlzaXMgaXMgdHJp dmlhbC4gU28gSSBhZGRlZCBpdCB0byBCMy4gRXZlbnR1YWxseQorICAgICAgICB3ZSdsbCB3YW50 IHRoaXMgc2FtZSBtYWNoaW5lcnkgaW4gdGhlIERGRyBhbHNvLgorCisgICAgICAgIDglIHNwZWVk LXVwIG9uIE9jdGFuZS9lbmNyeXB0LgorCisgICAgICAgICogYjMvQjNSZWR1Y2VTdHJlbmd0aC5j cHA6CisgICAgICAgICogYjMvQjNWYWx1ZS5jcHA6CisgICAgICAgIChKU0M6OkIzOjpWYWx1ZTo6 ZHVtcCk6IER1bXBpbmcgYSBjb25zdGFudCB2YWx1ZSdzIG5hbWUgbm93IGR1bXBzIGl0cyB2YWx1 ZS4gVGhpcyBtYWtlcyBhIGh1Z2UgZGlmZmVyZW5jZSBmb3IgcmVhZGluZyBJUi4KKyAgICAgICAg KEpTQzo6QjM6OlZhbHVlOjpjbG9uZUltcGwpOgorICAgICAgICAoSlNDOjpCMzo6VmFsdWU6OmRl ZXBEdW1wKToKKwogMjAxNi0wMS0yNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIEl0IHNob3VsZCBiZSBwb3NzaWJsZSB0byBkaXNhYmxlIEZUTCBmb3IgYSByYW5n ZSBsaWtlIHdlIGRpc2FibGUgREZHIGZvciBhIHJhbmdlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL0IzUmVkdWNlU3RyZW5ndGguY3BwCShyZXZpc2lvbiAxOTU2MjIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI1Miw2ICsyNTIsMTAyIEBAIHB1YmxpYzoKICAgICAgICAgfQogICAgIH0KIAorICAg IHRlbXBsYXRlPHR5cGVuYW1lIFQ+CisgICAgSW50UmFuZ2Ugc2hsKGludDMyX3Qgc2hpZnRBbW91 bnQpCisgICAgeworICAgICAgICBUIG5ld01pbiA9IHN0YXRpY19jYXN0PFQ+KG1fbWluKSA8PCBz aGlmdEFtb3VudDsKKyAgICAgICAgVCBuZXdNYXggPSBzdGF0aWNfY2FzdDxUPihtX21heCkgPDwg c2hpZnRBbW91bnQ7CisKKyAgICAgICAgaWYgKChuZXdNaW4gPj4gc2hpZnRBbW91bnQpICE9IHN0 YXRpY19jYXN0PFQ+KG1fbWluKSkKKyAgICAgICAgICAgIG5ld01pbiA9IHN0ZDo6bnVtZXJpY19s aW1pdHM8VD46Om1pbigpOworICAgICAgICBpZiAoKG5ld01heCA+PiBzaGlmdEFtb3VudCkgIT0g c3RhdGljX2Nhc3Q8VD4obV9tYXgpKQorICAgICAgICAgICAgbmV3TWF4ID0gc3RkOjpudW1lcmlj X2xpbWl0czxUPjo6bWF4KCk7CisKKyAgICAgICAgcmV0dXJuIEludFJhbmdlKG5ld01pbiwgbmV3 TWF4KTsKKyAgICB9CisKKyAgICBJbnRSYW5nZSBzaGwoaW50MzJfdCBzaGlmdEFtb3VudCwgVHlw ZSB0eXBlKQorICAgIHsKKyAgICAgICAgc3dpdGNoICh0eXBlKSB7CisgICAgICAgIGNhc2UgSW50 MzI6CisgICAgICAgICAgICByZXR1cm4gc2hsPGludDMyX3Q+KHNoaWZ0QW1vdW50KTsKKyAgICAg ICAgY2FzZSBJbnQ2NDoKKyAgICAgICAgICAgIHJldHVybiBzaGw8aW50NjRfdD4oc2hpZnRBbW91 bnQpOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JF QUNIRUQoKTsKKyAgICAgICAgICAgIHJldHVybiBJbnRSYW5nZSgpOworICAgICAgICB9CisgICAg fQorCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KKyAgICBJbnRSYW5nZSBhZGQoY29uc3QgSW50 UmFuZ2UmIG90aGVyKQorICAgIHsKKyAgICAgICAgaWYgKGNvdWxkT3ZlcmZsb3dBZGQ8VD4ob3Ro ZXIpKQorICAgICAgICAgICAgcmV0dXJuIHRvcDxUPigpOworICAgICAgICByZXR1cm4gSW50UmFu Z2UobV9taW4gKyBvdGhlci5tX21pbiwgbV9tYXggKyBvdGhlci5tX21heCk7CisgICAgfQorCisg ICAgSW50UmFuZ2UgYWRkKGNvbnN0IEludFJhbmdlJiBvdGhlciwgVHlwZSB0eXBlKQorICAgIHsK KyAgICAgICAgc3dpdGNoICh0eXBlKSB7CisgICAgICAgIGNhc2UgSW50MzI6CisgICAgICAgICAg ICByZXR1cm4gYWRkPGludDMyX3Q+KG90aGVyKTsKKyAgICAgICAgY2FzZSBJbnQ2NDoKKyAgICAg ICAgICAgIHJldHVybiBhZGQ8aW50NjRfdD4ob3RoZXIpOworICAgICAgICBkZWZhdWx0OgorICAg ICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgIHJldHVy biBJbnRSYW5nZSgpOworICAgICAgICB9CisgICAgfQorCisgICAgdGVtcGxhdGU8dHlwZW5hbWUg VD4KKyAgICBJbnRSYW5nZSBzdWIoY29uc3QgSW50UmFuZ2UmIG90aGVyKQorICAgIHsKKyAgICAg ICAgaWYgKGNvdWxkT3ZlcmZsb3dTdWI8VD4ob3RoZXIpKQorICAgICAgICAgICAgcmV0dXJuIHRv cDxUPigpOworICAgICAgICByZXR1cm4gSW50UmFuZ2UobV9taW4gLSBvdGhlci5tX21heCwgbV9t YXggLSBvdGhlci5tX21pbik7CisgICAgfQorCisgICAgSW50UmFuZ2Ugc3ViKGNvbnN0IEludFJh bmdlJiBvdGhlciwgVHlwZSB0eXBlKQorICAgIHsKKyAgICAgICAgc3dpdGNoICh0eXBlKSB7Cisg ICAgICAgIGNhc2UgSW50MzI6CisgICAgICAgICAgICByZXR1cm4gc3ViPGludDMyX3Q+KG90aGVy KTsKKyAgICAgICAgY2FzZSBJbnQ2NDoKKyAgICAgICAgICAgIHJldHVybiBzdWI8aW50NjRfdD4o b3RoZXIpOworICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9U X1JFQUNIRUQoKTsKKyAgICAgICAgICAgIHJldHVybiBJbnRSYW5nZSgpOworICAgICAgICB9Cisg ICAgfQorCisgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KKyAgICBJbnRSYW5nZSBtdWwoY29uc3Qg SW50UmFuZ2UmIG90aGVyKQorICAgIHsKKyAgICAgICAgaWYgKGNvdWxkT3ZlcmZsb3dNdWw8VD4o b3RoZXIpKQorICAgICAgICAgICAgcmV0dXJuIHRvcDxUPigpOworICAgICAgICByZXR1cm4gSW50 UmFuZ2UoCisgICAgICAgICAgICBzdGQ6Om1pbigKKyAgICAgICAgICAgICAgICBzdGQ6Om1pbiht X21pbiAqIG90aGVyLm1fbWluLCBtX21pbiAqIG90aGVyLm1fbWF4KSwKKyAgICAgICAgICAgICAg ICBzdGQ6Om1pbihtX21heCAqIG90aGVyLm1fbWluLCBtX21heCAqIG90aGVyLm1fbWF4KSksCisg ICAgICAgICAgICBzdGQ6Om1heCgKKyAgICAgICAgICAgICAgICBzdGQ6Om1heChtX21pbiAqIG90 aGVyLm1fbWluLCBtX21pbiAqIG90aGVyLm1fbWF4KSwKKyAgICAgICAgICAgICAgICBzdGQ6Om1h eChtX21heCAqIG90aGVyLm1fbWluLCBtX21heCAqIG90aGVyLm1fbWF4KSkpOworICAgIH0KKwor ICAgIEludFJhbmdlIG11bChjb25zdCBJbnRSYW5nZSYgb3RoZXIsIFR5cGUgdHlwZSkKKyAgICB7 CisgICAgICAgIHN3aXRjaCAodHlwZSkgeworICAgICAgICBjYXNlIEludDMyOgorICAgICAgICAg ICAgcmV0dXJuIG11bDxpbnQzMl90PihvdGhlcik7CisgICAgICAgIGNhc2UgSW50NjQ6CisgICAg ICAgICAgICByZXR1cm4gbXVsPGludDY0X3Q+KG90aGVyKTsKKyAgICAgICAgZGVmYXVsdDoKKyAg ICAgICAgICAgIFJFTEVBU0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgICAgICByZXR1 cm4gSW50UmFuZ2UoKTsKKyAgICAgICAgfQorICAgIH0KKwogcHJpdmF0ZToKICAgICBpbnQ2NF90 IG1fbWluIHsgMCB9OwogICAgIGludDY0X3QgbV9tYXggeyAwIH07CkBAIC0xODM5LDggKzE5MzUs MTMgQEAgcHJpdmF0ZToKICAgICAgICAgfQogICAgIH0KIAotICAgIEludFJhbmdlIHJhbmdlRm9y KFZhbHVlKiB2YWx1ZSkKKyAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgcmVhbGx5IGJlIGEgZm9y d2FyZCBhbmFseXNpcy4gSW5zdGVhZCwgd2UgdXNlcyBhIGJvdW5kZWQtc2VhcmNoIGJhY2t3YXJk cworICAgIC8vIGFuYWx5c2lzLgorICAgIEludFJhbmdlIHJhbmdlRm9yKFZhbHVlKiB2YWx1ZSwg dW5zaWduZWQgdGltZVRvTGl2ZSA9IDUpCiAgICAgeworICAgICAgICBpZiAoIXRpbWVUb0xpdmUp CisgICAgICAgICAgICByZXR1cm4gSW50UmFuZ2U6OnRvcCh2YWx1ZS0+dHlwZSgpKTsKKyAgICAg ICAgCiAgICAgICAgIHN3aXRjaCAodmFsdWUtPm9wY29kZSgpKSB7CiAgICAgICAgIGNhc2UgQ29u c3QzMjoKICAgICAgICAgY2FzZSBDb25zdDY0OiB7CkBAIC0xODYzLDYgKzE5NjQsMjQgQEAgcHJp dmF0ZToKICAgICAgICAgICAgICAgICByZXR1cm4gSW50UmFuZ2U6OnJhbmdlRm9yWlNocih2YWx1 ZS0+Y2hpbGQoMSktPmFzSW50MzIoKSwgdmFsdWUtPnR5cGUoKSk7CiAgICAgICAgICAgICBicmVh azsKIAorICAgICAgICBjYXNlIFNobDoKKyAgICAgICAgICAgIGlmICh2YWx1ZS0+Y2hpbGQoMSkt Pmhhc0ludDMyKCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIHJhbmdlRm9yKHZhbHVlLT5jaGls ZCgwKSwgdGltZVRvTGl2ZSAtIDEpLnNobCgKKyAgICAgICAgICAgICAgICAgICAgdmFsdWUtPmNo aWxkKDEpLT5hc0ludDMyKCksIHZhbHVlLT50eXBlKCkpOworICAgICAgICAgICAgYnJlYWs7CisK KyAgICAgICAgY2FzZSBBZGQ6CisgICAgICAgICAgICByZXR1cm4gcmFuZ2VGb3IodmFsdWUtPmNo aWxkKDApLCB0aW1lVG9MaXZlIC0gMSkuYWRkKAorICAgICAgICAgICAgICAgIHJhbmdlRm9yKHZh bHVlLT5jaGlsZCgxKSwgdGltZVRvTGl2ZSAtIDEpLCB2YWx1ZS0+dHlwZSgpKTsKKworICAgICAg ICBjYXNlIFN1YjoKKyAgICAgICAgICAgIHJldHVybiByYW5nZUZvcih2YWx1ZS0+Y2hpbGQoMCks IHRpbWVUb0xpdmUgLSAxKS5zdWIoCisgICAgICAgICAgICAgICAgcmFuZ2VGb3IodmFsdWUtPmNo aWxkKDEpLCB0aW1lVG9MaXZlIC0gMSksIHZhbHVlLT50eXBlKCkpOworCisgICAgICAgIGNhc2Ug TXVsOgorICAgICAgICAgICAgcmV0dXJuIHJhbmdlRm9yKHZhbHVlLT5jaGlsZCgwKSwgdGltZVRv TGl2ZSAtIDEpLm11bCgKKyAgICAgICAgICAgICAgICByYW5nZUZvcih2YWx1ZS0+Y2hpbGQoMSks IHRpbWVUb0xpdmUgLSAxKSwgdmFsdWUtPnR5cGUoKSk7CisKICAgICAgICAgZGVmYXVsdDoKICAg ICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YjMvQjNWYWx1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0Iz VmFsdWUuY3BwCShyZXZpc2lvbiAxOTU2MjIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMv QjNWYWx1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMSw3ICsxMTEsMzMgQEAgdm9pZCBWYWx1 ZTo6cmVwbGFjZVdpdGhQaGkoKQogCiB2b2lkIFZhbHVlOjpkdW1wKFByaW50U3RyZWFtJiBvdXQp IGNvbnN0CiB7CisgICAgYm9vbCBpc0NvbnN0YW50ID0gZmFsc2U7CisKKyAgICBzd2l0Y2ggKG1f b3Bjb2RlKSB7CisgICAgY2FzZSBDb25zdDMyOgorICAgICAgICBvdXQucHJpbnQoIiQiLCBhc0lu dDMyKCksICIoIik7CisgICAgICAgIGlzQ29uc3RhbnQgPSB0cnVlOworICAgICAgICBicmVhazsK KyAgICBjYXNlIENvbnN0NjQ6CisgICAgICAgIG91dC5wcmludCgiJCIsIGFzSW50NjQoKSwgIigi KTsKKyAgICAgICAgaXNDb25zdGFudCA9IHRydWU7CisgICAgICAgIGJyZWFrOworICAgIGNhc2Ug Q29uc3RGbG9hdDoKKyAgICAgICAgb3V0LnByaW50KCIkIiwgYXNGbG9hdCgpLCAiKCIpOworICAg ICAgICBpc0NvbnN0YW50ID0gdHJ1ZTsKKyAgICAgICAgYnJlYWs7CisgICAgY2FzZSBDb25zdERv dWJsZToKKyAgICAgICAgb3V0LnByaW50KCIkIiwgYXNEb3VibGUoKSwgIigiKTsKKyAgICAgICAg aXNDb25zdGFudCA9IHRydWU7CisgICAgICAgIGJyZWFrOworICAgIGRlZmF1bHQ6CisgICAgICAg IGJyZWFrOworICAgIH0KKyAgICAKICAgICBvdXQucHJpbnQoZHVtcFByZWZpeCwgbV9pbmRleCk7 CisKKyAgICBpZiAoaXNDb25zdGFudCkKKyAgICAgICAgb3V0LnByaW50KCIpIik7CiB9CiAKIFZh bHVlKiBWYWx1ZTo6Y2xvbmVJbXBsKCkgY29uc3QKQEAgLTEyNyw3ICsxNTMsNyBAQCB2b2lkIFZh bHVlOjpkdW1wQ2hpbGRyZW4oQ29tbWFQcmludGVyJiBjCiAKIHZvaWQgVmFsdWU6OmRlZXBEdW1w KGNvbnN0IFByb2NlZHVyZSogcHJvYywgUHJpbnRTdHJlYW0mIG91dCkgY29uc3QKIHsKLSAgICBv dXQucHJpbnQobV90eXBlLCAiICIsICp0aGlzLCAiID0gIiwgbV9vcGNvZGUpOworICAgIG91dC5w cmludChtX3R5cGUsICIgIiwgZHVtcFByZWZpeCwgbV9pbmRleCwgIiA9ICIsIG1fb3Bjb2RlKTsK IAogICAgIG91dC5wcmludCgiKCIpOwogICAgIENvbW1hUHJpbnRlciBjb21tYTsK