15350 2007-10-02 16:08:22 -0700 skip extra hash lookup and avoid converting char* to UString for 19% speedup on CK JS array test 2007-10-02 20:51:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://celtickane.com/projects/jsspeed2007.php P2 Normal --- 1 mjs mjs oldest_to_newest 57679 0 mjs 2007-10-02 16:08:22 -0700 The Celtic Kane JavaScript Benchmark "Array" test can be sped up 19% by using the return value from add() to avoid an extra hash lookup for contains(), and by storing some strings in function-scope static UString variables instead of as constant strings used to make new UStrings every time. These issues mainly affect the Array "join" and "toString" operations, which unfortunately seem to make up the vast majority of time on this benchmark. 57682 1 16509 mjs 2007-10-02 16:30:12 -0700 Created attachment 16509 patch implementing these two optimizations 57684 2 16509 oliver 2007-10-02 16:37:17 -0700 Comment on attachment 16509 patch implementing these two optimizations ooh, nice and simple 16509 2007-10-02 16:30:12 -0700 2007-10-02 16:37:17 -0700 patch implementing these two optimizations array-join-speedups.patch.txt text/plain 1512 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI1OTI5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTAt MDIgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gc2tpcCBleHRyYSBoYXNo IGxvb2t1cCBhbmQgYXZvaWQgY29udmVydGluZyBjaGFyKiB0byBVU3RyaW5nIGZvciAxOSUgc3Bl ZWR1cCBvbiBDSyBKUyBhcnJheSB0ZXN0IAorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTM1MAorCisgICAgICAgICoga2pzL2FycmF5X29iamVjdC5jcHA6 CisgICAgICAgIChBcnJheVByb3RvRnVuYzo6Y2FsbEFzRnVuY3Rpb24pOiBJbXBsZW1lbnQgdGhl IHR3byBtZW50aW9uZWQgb3B0aW1pemF0aW9ucy4KKwogMjAwNy0wOS0yOSAgSG9sZ2VyIEhhbnMg UGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBNYXJrLgpJbmRleDoga2pzL2FycmF5X29iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0ga2pzL2Fy cmF5X29iamVjdC5jcHAJKHJldmlzaW9uIDI1ODEwKQorKysga2pzL2FycmF5X29iamVjdC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTUzNSwxMiArNTM1LDE0IEBAIEpTVmFsdWUqIEFycmF5UHJvdG9G dW5jOjpjYWxsQXNGdW5jdGlvbigKICAgICAvLyBmYWxsIHRocm91Z2gKICAgY2FzZSBKb2luOiB7 CiAgICAgc3RhdGljIEhhc2hTZXQ8SlNPYmplY3QqPiB2aXNpdGVkRWxlbXM7Ci0gICAgaWYgKHZp c2l0ZWRFbGVtcy5jb250YWlucyh0aGlzT2JqKSkKLSAgICAgICAgcmV0dXJuIGpzU3RyaW5nKCIi KTsKLSAgICBVU3RyaW5nIHNlcGFyYXRvciA9ICIsIjsKLSAgICBVU3RyaW5nIHN0ciA9ICIiOwor ICAgIHN0YXRpYyBjb25zdCBVU3RyaW5nIGVtcHR5KCIiKTsKKyAgICBzdGF0aWMgY29uc3QgVVN0 cmluZyBjb21tYSgiLCIpOworICAgIGJvb2wgYWxyZWFkeVZpc2l0ZWQgPSAhdmlzaXRlZEVsZW1z LmFkZCh0aGlzT2JqKS5zZWNvbmQ7CisgICAgaWYgKGFscmVhZHlWaXNpdGVkKQorICAgICAgICBy ZXR1cm4ganNTdHJpbmcoZW1wdHkpOworICAgIFVTdHJpbmcgc2VwYXJhdG9yID0gY29tbWE7Cisg ICAgVVN0cmluZyBzdHIgPSBlbXB0eTsKIAotICAgIHZpc2l0ZWRFbGVtcy5hZGQodGhpc09iaik7 CiAgICAgaWYgKGlkID09IEpvaW4gJiYgIWFyZ3NbMF0tPmlzVW5kZWZpbmVkKCkpCiAgICAgICAg IHNlcGFyYXRvciA9IGFyZ3NbMF0tPnRvU3RyaW5nKGV4ZWMpOwogICAgIGZvciAodW5zaWduZWQg aW50IGsgPSAwOyBrIDwgbGVuZ3RoOyBrKyspIHsK