153496 2016-01-26 11:47:00 -0800 [webkitdirs] Removed check for bison, gperf, and flex. 2016-01-26 13:38:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned achristensen commit-queue dbates lforschler oldest_to_newest 1158898 0 annulen 2016-01-26 11:47:00 -0800 bison, gperf, and flex are basic prerequisites of build, and condition already included all ports present in trunk. 1158901 1 269899 annulen 2016-01-26 11:48:12 -0800 Created attachment 269899 Patch 1158902 2 annulen 2016-01-26 11:48:45 -0800 Also removed outdated comment from 2006. 1158945 3 269899 achristensen 2016-01-26 12:57:22 -0800 Comment on attachment 269899 Patch I think we could completely remove this check. They are done in WebKitCommon.cmake, and bison, gperf, and flex don't necessarily need to be in the PATH 1158975 4 269910 annulen 2016-01-26 13:23:25 -0800 Created attachment 269910 Patch 1158978 5 269910 commit-queue 2016-01-26 13:38:30 -0800 Comment on attachment 269910 Patch Clearing flags on attachment: 269910 Committed r195617: <http://trac.webkit.org/changeset/195617> 1158979 6 commit-queue 2016-01-26 13:38:33 -0800 All reviewed patches have been landed. Closing bug. 269899 2016-01-26 11:48:12 -0800 2016-01-26 13:23:18 -0800 Patch bug-153496-20160126224745.patch text/plain 1541 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NjA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjdiYmJmYjU0ZjJkMTg0OTAxZTBkZTIzZjgyY2VlOWEx YmEzYmNlYS4uMzI1YjhhOTEzODdjMDA1Y2E4OTUyM2E1M2NjOTBhYjk5ZDM2MmE4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAxLTI2ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICBbd2Via2l0ZGlyc10gQWxsIHBvcnRzIGFyZSByZXF1aXJlZCB0byBoYXZlIGJp c29uLCBncGVyZiwgYW5kIGZsZXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTM0OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGNoZWNrUmVx dWlyZWRTeXN0ZW1Db25maWcpOgorCiAyMDE2LTAxLTI2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVz QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgV2ViS2l0U3lzdGVtSW50ZXJmYWNlIGZvciBpT1Mg OS4yCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3Jp cHRzL3dlYmtpdGRpcnMucG0KaW5kZXggZDBkYzIxNDA3YTkwOWE3YmVhNjIyNzhiZmRmYjQ2MDA0 ZTNjMThlYy4uZGYxN2FkZWJlNzhhZGQ2NDdmOTE0Njk3OTYwMjQ2M2MxMWQ3ZGE2OSAxMDA3NTUK LS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQpAQCAtMTUwMCw3ICsxNTAwLDcgQEAgc3ViIGNoZWNrUmVxdWlyZWRTeXN0ZW1D b25maWcKICAgICAgICAgICAgIHByaW50ICJtb3N0IGxpa2VseSBmYWlsLiBUaGUgbGF0ZXN0IFhj b2RlIGlzIGF2YWlsYWJsZSBmcm9tIHRoZSBBcHAgU3RvcmUuXG4iOwogICAgICAgICAgICAgcHJp bnQgIioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKipcbiI7CiAgICAgICAgIH0KLSAgICB9IGVsc2lmIChpc0d0aygpIG9yIGlzRWZsKCkg b3IgaXNXaW5kb3dzKCkgb3IgaXNDeWd3aW4oKSkgeworICAgIH0gZWxzZSB7CiAgICAgICAgIG15 IEBjbWRzID0gcXcoYmlzb24gZ3BlcmYgZmxleCk7CiAgICAgICAgIG15IEBtaXNzaW5nID0gKCk7 CiAgICAgICAgIG15ICRvbGRQYXRoID0gJEVOVntQQVRIfTsKQEAgLTE1MTMsNyArMTUxMyw2IEBA IHN1YiBjaGVja1JlcXVpcmVkU3lzdGVtQ29uZmlnCiAgICAgICAgICAgICBkaWUgIkVSUk9SOiAk bGlzdCBtaXNzaW5nIGJ1dCByZXF1aXJlZCB0byBidWlsZCBXZWJLaXQuXG4iOwogICAgICAgICB9 CiAgICAgfQotICAgICMgV2luMzIgYW5kIG90aGVyIHBsYXRmb3JtcyBtYXkgd2FudCB0byBjaGVj ayBmb3IgbWluaW11bSBjb25maWcKIH0KIAogc3ViIGRldGVybWluZVdpbmRvd3NTb3VyY2VEaXIo KQo= 269910 2016-01-26 13:23:25 -0800 2016-01-26 13:38:30 -0800 Patch bug-153496-20160127002259.patch text/plain 1746 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NjA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjdiYmJmYjU0ZjJkMTg0OTAxZTBkZTIzZjgyY2VlOWEx YmEzYmNlYS4uYWZjNTIzN2I4ZTZlZjY3YjYzMjdkYTY2OWM0MzBlNGRjYjVkZGRjZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE2LTAxLTI2ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICBbd2Via2l0ZGlyc10gUmVtb3ZlZCBjaGVjayBmb3IgYmlzb24sIGdwZXJmLCBh bmQgZmxleC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MzQ5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgcHJlcmVxdWlzaXRlcyBhcmUgY2hlY2tlZCBpbiBXZWJLaXRDb21tb24uY21ha2UgYW5k IGRvbid0CisgICAgICAgIGhhdmUgdG8gYmUgaW4gJFBBVEguCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdGRpcnMucG06CisgICAgICAgIChjaGVja1JlcXVpcmVkU3lzdGVtQ29uZmlnKToKKwog MjAxNi0wMS0yNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAg QWRkIFdlYktpdFN5c3RlbUludGVyZmFjZSBmb3IgaU9TIDkuMgpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4 IGQwZGMyMTQwN2E5MDlhN2JlYTYyMjc4YmZkZmI0NjAwNGUzYzE4ZWMuLjM0ZDkzZDZkMzU5ZTE0 NGU1ZjA0OGVlNWZjMTQzZTliMTY2ZTBmOTAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE1MDAsMjAg KzE1MDAsNyBAQCBzdWIgY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZwogICAgICAgICAgICAgcHJp bnQgIm1vc3QgbGlrZWx5IGZhaWwuIFRoZSBsYXRlc3QgWGNvZGUgaXMgYXZhaWxhYmxlIGZyb20g dGhlIEFwcCBTdG9yZS5cbiI7CiAgICAgICAgICAgICBwcmludCAiKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKlxuIjsKICAgICAgICAg fQotICAgIH0gZWxzaWYgKGlzR3RrKCkgb3IgaXNFZmwoKSBvciBpc1dpbmRvd3MoKSBvciBpc0N5 Z3dpbigpKSB7Ci0gICAgICAgIG15IEBjbWRzID0gcXcoYmlzb24gZ3BlcmYgZmxleCk7Ci0gICAg ICAgIG15IEBtaXNzaW5nID0gKCk7Ci0gICAgICAgIG15ICRvbGRQYXRoID0gJEVOVntQQVRIfTsK LSAgICAgICAgZm9yZWFjaCBteSAkY21kIChAY21kcykgewotICAgICAgICAgICAgcHVzaCBAbWlz c2luZywgJGNtZCBpZiBub3QgY29tbWFuZEV4aXN0cygkY21kKTsKLSAgICAgICAgfQotCi0gICAg ICAgIGlmIChAbWlzc2luZykgewotICAgICAgICAgICAgbXkgJGxpc3QgPSBqb2luICIsICIsIEBt aXNzaW5nOwotICAgICAgICAgICAgZGllICJFUlJPUjogJGxpc3QgbWlzc2luZyBidXQgcmVxdWly ZWQgdG8gYnVpbGQgV2ViS2l0LlxuIjsKLSAgICAgICAgfQogICAgIH0KLSAgICAjIFdpbjMyIGFu ZCBvdGhlciBwbGF0Zm9ybXMgbWF5IHdhbnQgdG8gY2hlY2sgZm9yIG1pbmltdW0gY29uZmlnCiB9 CiAKIHN1YiBkZXRlcm1pbmVXaW5kb3dzU291cmNlRGlyKCkK