153483 2016-01-26 06:21:50 -0800 kill-old-processes: allow to specify on the environment of the bot a list of process that should be killed. 2016-01-26 07:48:09 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=127352 https://bugs.webkit.org/show_bug.cgi?id=133215 P2 Normal --- 1 clopez clopez ap bugs-noreply dbates lforschler ossy thorton oldest_to_newest 1158798 0 clopez 2016-01-26 06:21:50 -0800 We are having an issue with the GTK+ bots because of bug 127352 that is causing that thousands of at-spi-bus-launcher and dbus-daemon process remain open. On r166798 I tried to workaround this by killing dbus-daemon on the script kill-old-processes that the bots run before any new build. However this turned out to be problematic for the performance bots so it was reverted on r169343. So, I think we still want to kill dbus-daemon (and maybe at-spi-bus-launcher) also on the test bots but not on the performance bots. An idea to achieve this is to implement on kill-old-processes support for killing any task defined on a given environment variable. This way the admin of each bot can set this variable accordingly 1158799 1 269880 clopez 2016-01-26 06:30:19 -0800 Created attachment 269880 Patch 1158805 2 269880 ossy 2016-01-26 07:14:54 -0800 Comment on attachment 269880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269880&action=review LGTM, let's add this environment variable to be able hack bots easier. > Tools/BuildSlaveSupport/kill-old-processes:111 > + tasksToKill = os.getenv('WEBKITBOT_TASKSTOKILL', "").split() nit: Could you use '' or "" for both parameters to have better looking code? 1158809 3 clopez 2016-01-26 07:48:09 -0800 Committed r195587: <http://trac.webkit.org/changeset/195587> 269880 2016-01-26 06:30:19 -0800 2016-01-26 07:14:54 -0800 Patch bug-153483-20160126152952.patch text/plain 2278 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTg2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzhiMmQ5MGIzZjVjNThjYWFmNTk1Mjk2ZDk4MGYxNTA5 NTkzNTgxYS4uMzRlMjc0ZGIwNDI2MmFhZDljNTY4YjEwNjA5MWYyYjVlYmJhNjAwZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAxLTI2ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIGtpbGwtb2xkLXByb2Nlc3NlczogYWxsb3cgdG8gc3BlY2lmeSBv biB0aGUgZW52aXJvbm1lbnQgb2YgdGhlIGJvdCBhIGxpc3Qgb2YgcHJvY2VzcyB0aGF0IHNob3Vs ZCBiZSBraWxsZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTM0ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3NlczoKKyAgICAgICAgKG1h aW4pOiBBbGxvdyB0byBzcGVjaWZ5IGV4dHJhIHRhc2tzIHRvIGtpbGwgdmlhIHRoZSBlbnZpcm9u bWVudCB2YXJpYWJsZSBXRUJLSVRCT1RfVEFTS1NUT0tJTEwKKwogMjAxNi0wMS0yNSAgU2ltb24g RnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBHaXZlIHRoZSBsYXlv dXQgdGVzdCByZXN1bHRzIGZpbGUgYSA8dGl0bGU+IHNob3dpbmcgdGhlIGRhdGUgYW5kIHRpbWUg dGhlIHRlc3RzIHdlcmUgcnVuCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9r aWxsLW9sZC1wcm9jZXNzZXMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9raWxsLW9sZC1wcm9j ZXNzZXMKaW5kZXggMmI2ZGNhZGExOTZkYzA1OWZiYmZjNmZmMThiNTc1YjMzZmUzZmM4MS4uNDZk ODAzOTdmYTMzMjA5ZDA0MGEzOGQ4ODgyNTcyYzk4YThkNDE5NiAxMDA3NTUKLS0tIGEvVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQva2lsbC1vbGQtcHJvY2Vzc2VzCisrKyBiL1Rvb2xzL0J1aWxkU2xh dmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3NlcwpAQCAtMTA3LDE2ICsxMDcsMTggQEAgZGVmIG1h aW4oKToKICAgICAgICAgIlh2ZmIiLAogICAgIF0KIAorICAgICMgVGhpcyBhbGxvd3MgdG8gc3Bl Y2lmeSBvbiB0aGUgZW52aXJvbm1lbnQgb2YgdGhlIGJvdCBhIGxpc3Qgb2YgcHJvY2VzcyB0aGF0 IHNob3VsZCBiZSBraWxsZWQuCisgICAgdGFza3NUb0tpbGwgPSBvcy5nZXRlbnYoJ1dFQktJVEJP VF9UQVNLU1RPS0lMTCcsICIiKS5zcGxpdCgpCiAgICAgaWYgc3lzLnBsYXRmb3JtID09ICdkYXJ3 aW4nOgotICAgICAgICBmb3IgdGFzayBpbiB0YXNrc1RvS2lsbE1hYzoKKyAgICAgICAgZm9yIHRh c2sgaW4gdGFza3NUb0tpbGwgKyB0YXNrc1RvS2lsbE1hYzoKICAgICAgICAgICAgIG9zLnN5c3Rl bSgia2lsbGFsbCAtOSAtdiAtbSAiICsgdGFzaykKICAgICAgICAgIyBLaWxsIGFsbCBpbnN0YW5j ZXMgb2YgcHl0aG9uIGV4ZWN1dGluZyBydW4td2Via2l0LXRlc3RzCiAgICAgICAgIG9zLnN5c3Rl bSgicHMgYXV4IHwgZ3JlcCAtRSAnLisvUHl0aG9uIC4rKHJ1bl93ZWJraXRfdGVzdHN8cnVuLXdl YmtpdC10ZXN0c3xtb2RfcHl3ZWJzb2NrZXQpJyB8IGdyZXAgLXYgZ3JlcCB8IGF3ayAne3ByaW50 ICQyfScgfCB4YXJncyBraWxsIikKICAgICBlbGlmIHN5cy5wbGF0Zm9ybSA9PSAnY3lnd2luJyBv ciBzeXMucGxhdGZvcm0gPT0gJ3dpbjMyJzoKLSAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tp bGxXaW46CisgICAgICAgIGZvciB0YXNrIGluIHRhc2tzVG9LaWxsICsgdGFza3NUb0tpbGxXaW46 CiAgICAgICAgICAgICBvcy5zeXN0ZW0oInRhc2traWxsIC90IC9mIC9pbSAiICsgdGFzaykKICAg ICBlbGlmIHN5cy5wbGF0Zm9ybS5zdGFydHN3aXRoKCdsaW51eCcpOgotICAgICAgICBmb3IgdGFz ayBpbiB0YXNrVG9LaWxsVW5peDoKKyAgICAgICAgZm9yIHRhc2sgaW4gdGFza3NUb0tpbGwgKyB0 YXNrVG9LaWxsVW5peDoKICAgICAgICAgICAgIG9zLnN5c3RlbSgia2lsbGFsbCAtOSAtdiAiICsg dGFzaykKICAgICAgICAgb3Muc3lzdGVtKCJwcyBhdXggfCBncmVwIC1QICcuKy9weXRob24gLiso cnVuX3dlYmtpdF90ZXN0c3xydW4td2Via2l0LXRlc3RzfG1vZF9weXdlYnNvY2tldCknIHwgZ3Jl cCAtdiBncmVwIHwgYXdrICd7cHJpbnQgJDJ9JyB8IHhhcmdzIGtpbGwiKQogICAgIGVsc2U6Cg==