153466 2016-01-25 16:46:47 -0800 [GTK][EFL] JSC Sampling profiler is not enabled. 2016-02-07 17:36:39 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED DUPLICATE 153638 P2 Normal --- 153638 153565 1 clopez webkit-unassigned bugs-noreply cgarcia dpino fpizlo joepeck mcatanzaro ossy saam wingo ysuzuki zan oldest_to_newest 1158601 0 clopez 2016-01-25 16:46:47 -0800 Revision r194840 <http://trac.webkit.org/194840> implemented a Sampling profiler in JSC for the Inspector UI. This feature is not enabled in the GTK+ port. There are some layout tests regarding this feature that are timing out on the GTK+ bots. I'm going to mark such tests as skipped on the GTK+ port. I'm also opening this bug for anyone interested in enabling and testing this feature on the GTK+ port. 1158640 1 clopez 2016-01-25 18:02:21 -0800 Skipped inspector/sampling-profiler tests on https://trac.webkit.org/r195573 1159482 2 joepeck 2016-01-27 15:38:52 -0800 I think currently trunk Web Inspector will not be including any JavaScript profiling data in the Timeline without this. Either the Sampling Profiler needs to be implemented / tests on Linux ports, or Web Inspector needs to fallback to the Legacy Profiler for these ports to get any JavaScript profiling. Is there someone who might be interested in trying ENABLE(SAMPLING_PROFILER) on Linux ports? 1159701 3 clopez 2016-01-28 06:18:20 -0800 (In reply to comment #2) > Is there someone who might be interested in trying ENABLE(SAMPLING_PROFILER) > on Linux ports? I have just tested this patch on top of r195735: --- a/Source/WTF/wtf/Platform.h +++ b/Source/WTF/wtf/Platform.h @@ -799,7 +799,7 @@ /* The SamplingProfiler is the probabilistic and low-overhead profiler used by * JSC to measure where time is spent inside a JavaScript program. */ -#if (OS(DARWIN) || OS(WINDOWS)) && ENABLE(JIT) +#if (OS(DARWIN) || OS(LINUX) || OS(WINDOWS)) && ENABLE(JIT) #define ENABLE_SAMPLING_PROFILER 1 #else #define ENABLE_SAMPLING_PROFILER 0 And tried to build the GTK+ port (release). I got this build error: ../../Source/JavaScriptCore/heap/MachineStackMarker.cpp:528:2: error: Need a way to get the frame pointer for another thread on this platform #error Need a way to get the frame pointer for another thread on this platform ^ ../../Source/JavaScriptCore/heap/MachineStackMarker.cpp:577:2: error: Need a way to get the instruction pointer for another thread on this platform #error Need a way to get the instruction pointer for another thread on this platform ^ 2 errors generated. Looking at where it fails, it looks this tries to do some OS/arch-specific low-level stuff with the instruction pointers that I'm afraid I won't have the time and expertise required to fix. If somebody else is willing to take this, feel free. Regards. 1159721 4 saam 2016-01-28 08:24:42 -0800 I spoke to Yusuke last night on IRC and he said he'd be willing to help implement these few functions to make the sampling profiler work on other platforms. The only functions that need to be implemented for it to work are the ones behind ENABLE(SAMPLING_PROFILER) guard in heap/MachineStackMarker 1159809 5 mcatanzaro 2016-01-28 11:30:05 -0800 See also: https://lists.webkit.org/pipermail/webkit-dev/2016-January/027888.html 1159869 6 saam 2016-01-28 13:58:15 -0800 see this patch: https://bugs.webkit.org/show_bug.cgi?id=153584 1162803 7 ysuzuki 2016-02-07 17:36:39 -0800 Landed! http://trac.webkit.org/changeset/196245 *** This bug has been marked as a duplicate of bug 153638 ***