153463 2016-01-25 16:29:53 -0800 [mips] don't save to a callee saved register too early 2016-01-31 03:42:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 108664 1 guijemont webkit-unassigned annulen commit-queue jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1158590 0 guijemont 2016-01-25 16:29:53 -0800 If we save $gp to $s4 in pichdr, then in some cases, we were overwriting $s4 before LLInt's pushCalleeSaves() is called (as pichdr is at the very beginning of a function). 1158592 1 269812 guijemont 2016-01-25 16:32:43 -0800 Created attachment 269812 Patch 1158732 2 annulen 2016-01-25 23:24:08 -0800 Tested on my device, works fine and fixes lots of test crashes. 1158758 3 269812 jbriance 2016-01-26 01:19:41 -0800 Comment on attachment 269812 Patch I just took a look at the generated code in LLIntAssembly.h and this looks wrong to me. I mean, if this patch fixes crashes, there is a better way to do the fix as this patch is actually removing the $gp save/restore mechanism. 1159158 4 guijemont 2016-01-26 18:09:06 -0800 (In reply to comment #3) > Comment on attachment 269812 [details] > Patch > > I just took a look at the generated code in LLIntAssembly.h and this looks > wrong to me. > I mean, if this patch fixes crashes, there is a better way to do the fix as > this patch is actually removing the $gp save/restore mechanism. I might be missing a need for the $gp save/restore mechanism, but my understanding so far is that it is only needed when making a function call (jal/jalr), and I think that there are no other cases where $gp would get overwritten (LLInt itself does not seem to touch $gp apart from that mechanism and pichdr through cpload). Under that assumption, I don't think we need to save $gp at the beginning of each function, but rather only when we are calling another PIC function (would it be from LLInt or somewhere else), which is what this patch does. And indeed it makes sense to save it in a callee saved register, since if a function will modify it it would take care of saving it. 1159260 5 jbriance 2016-01-27 02:54:14 -0800 Argh, I forgot that gnu as reorders MIPS opcodes, and I thought that the "move $gp, $s4" instruction in the following code of LLIntAssembly.h was executed in the delay slot: ... move $s4, $gp jalr $t9 move $gp, $s4 ... Whereas after compilation, it is reordered like this by the assembler: ... jalr $t9 move $s4, $gp move $gp, $s4 ... I'll try to look at your patch more carefully if I have time, meanwhile I remove my r- 1159281 6 269812 jbriance 2016-01-27 06:36:36 -0800 Comment on attachment 269812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269812&action=review > Source/JavaScriptCore/offlineasm/mips.rb:562 > + preList << Instruction.new(operand.codeOrigin, "move", [MIPS_GP_REG, MIPS_GPSAVE_REG]) I'm not a huge fan of this. Instead, can you add something like ' emit "move $s4, $gp" ' at the end of the pushCalleeSaves macro ? And also take the opportunity to set CalleeSaveRegisterCount to 1 for MIPS and just save/restore $s4 register instead of the $s0-$s4 range. It seems to work fine on my mips board and slightly reduces the number of generated opcodes in LLInt. 1159557 7 270073 guijemont 2016-01-27 17:58:17 -0800 Created attachment 270073 Patch New version of the patch that saves to in pushCalleeSaves() and also only push/pop 1159559 8 guijemont 2016-01-27 17:59:53 -0800 (In reply to comment #7) > Created attachment 270073 [details] > Patch > > New version of the patch that saves to in pushCalleeSaves() and also only > push/pop "saves to $s4". Got bitten by shell interpretation, I'll use single quotes next time ;). 1159659 9 270073 jbriance 2016-01-28 00:07:20 -0800 Comment on attachment 270073 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=270073&action=review Thanks that's great. Please just address my comment. > Source/JavaScriptCore/llint/LowLevelInterpreter.asm:433 > elsif SH4 or MIPS Let the sh4 port have its 5 registers :) 1159921 10 270156 guijemont 2016-01-28 15:37:37 -0800 Created attachment 270156 Patch New version of the patch that doesn't change CalleeSaveRegisterCount for SH4 1159922 11 jbriance 2016-01-28 15:44:10 -0800 Nice fix, LGTM 1160635 12 270156 msaboff 2016-01-30 22:50:48 -0800 Comment on attachment 270156 Patch r=me 1160649 13 270156 commit-queue 2016-01-31 03:42:01 -0800 Comment on attachment 270156 Patch Clearing flags on attachment: 270156 Committed r195926: <http://trac.webkit.org/changeset/195926> 1160650 14 commit-queue 2016-01-31 03:42:06 -0800 All reviewed patches have been landed. Closing bug. 269812 2016-01-25 16:32:43 -0800 2016-01-27 17:58:12 -0800 Patch bug-153463-20160125183216.patch text/plain 2077 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YTc1YTBjNGE4ZDU5NTE3ZTU2ZDI4YTlkMTc0MWYyZjFlZjI1ZjlkLi40YTU1NDQ5NmExZTM5OWM0 OGNmNjIwNjVlY2U2YTcyYWIxYzAwY2UxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNi0wMS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CiAKKyAgICAgICAgW21pcHNdIGRvbid0IHNhdmUgdG8gYSBjYWxsZWUgc2F2ZWQgcmVn aXN0ZXIgdG9vIGVhcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTM0NjMKKworICAgICAgICBJZiB3ZSBzYXZlICRncCB0byAkczQgaW4gcGljaGRy LCB0aGVuIGluIHNvbWUgY2FzZXMsIHdlIHdlcmUKKyAgICAgICAgb3ZlcndyaXRpbmcgJHM0IGJl Zm9yZSBMTEludCdzIHB1c2hDYWxsZWVTYXZlcygpIGlzIGNhbGxlZCAoYXMgcGljaGRyCisgICAg ICAgIGlzIGF0IHRoZSB2ZXJ5IGJlZ2lubmluZyBvZiBhIGZ1bmN0aW9uKS4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG9mZmxpbmVhc20vbWlwcy5y YjoKKyAgICAgICAgTW92ZSB0aGUgc2F2aW5nIG9mICRncCB0byAkczQgZnJvbSBwaWNoZHIgdG8g dGhlIG5lZWRSZXN0b3JlIGNhc2Ugb2YKKyAgICAgICAgbWlwc0FzUmVnaXN0ZXIoKS4KKworMjAx Ni0wMS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CisKICAgICAg ICAgW21pcHNdIFlhcnJKSVQ6IGltcGxlbWVudCBnZW5lcmF0ZUVudGVyKCkgYW5kIGdlbmVyYXRl UmV0dXJuKCkKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1MzQ1NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9t aXBzLnJiIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgppbmRleCAz N2FhODA0ZWNjMGNiMTUzNTA0Y2U0NGEyNzI0YWYxNzllYzkxZjdhLi5hM2IxM2VlNjkzODJmM2Zm OGFlYWMwZTk2ODAyNTNkMDc3YWFhMDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvb2ZmbGluZWFzbS9taXBzLnJiCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5l YXNtL21pcHMucmIKQEAgLTU1OSw2ICs1NTksNyBAQCBkZWYgbWlwc0FzUmVnaXN0ZXIocHJlTGlz dCwgcG9zdExpc3QsIG9wZXJhbmQsIG5lZWRSZXN0b3JlKQogICAgICAgICB0bXAgPSBvcGVyYW5k CiAgICAgZW5kCiAgICAgaWYgbmVlZFJlc3RvcmUKKyAgICAgICAgcHJlTGlzdCA8PCBJbnN0cnVj dGlvbi5uZXcob3BlcmFuZC5jb2RlT3JpZ2luLCAibW92ZSIsIFtNSVBTX0dQX1JFRywgTUlQU19H UFNBVkVfUkVHXSkKICAgICAgICAgcG9zdExpc3QgPDwgSW5zdHJ1Y3Rpb24ubmV3KG9wZXJhbmQu Y29kZU9yaWdpbiwgIm1vdmUiLCBbTUlQU19HUFNBVkVfUkVHLCBNSVBTX0dQX1JFR10pCiAgICAg ZW5kCiAgICAgdG1wCkBAIC0xMDQxLDcgKzEwNDIsNiBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAg ICAgICAgICAgJGFzbS5wdXRzICJzbHR1ICN7b3BlcmFuZHNbMF0ubWlwc09wZXJhbmR9LCAje29w ZXJhbmRzWzFdLm1pcHNPcGVyYW5kfSwgI3tvcGVyYW5kc1syXS5taXBzT3BlcmFuZH0iCiAgICAg ICAgIHdoZW4gInBpY2hkciIKICAgICAgICAgICAgICRhc20ucHV0U3RyKCJPRkZMSU5FX0FTTV9D UExPQUQoI3tNSVBTX0NBTExfUkVHLm1pcHNPcGVyYW5kfSkiKQotICAgICAgICAgICAgJGFzbS5w dXRzICJtb3ZlICN7TUlQU19HUFNBVkVfUkVHLm1pcHNPcGVyYW5kfSwgI3tNSVBTX0dQX1JFRy5t aXBzT3BlcmFuZH0iCiAgICAgICAgIHdoZW4gIm1lbWZlbmNlIgogICAgICAgICAgICAgJGFzbS5w dXRzICJzeW5jIgogICAgICAgICBlbHNlCg== 270073 2016-01-27 17:58:17 -0800 2016-01-28 15:37:30 -0800 Patch bug-153463-20160127195751.patch text/plain 3474 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh ZGI5YjFmY2FkYmMzMzA4MDdlZDA1Y2JiNGExMGZlNzdjYWY0Y2M1Li5hOTAwOWY4YzEyZGEwZDlj ZTQ3YWIzZWEwYTQ0NWI4NGE0NTNkNDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wMS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW21pcHNdIGRvbid0IHNhdmUgdG8gYSBjYWxsZWUgc2F2ZWQgcmVn aXN0ZXIgdG9vIGVhcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTM0NjMKKworICAgICAgICBJZiB3ZSBzYXZlICRncCB0byAkczQgaW4gcGljaGRy LCB0aGVuIGluIHNvbWUgY2FzZXMsIHdlIHdlcmUKKyAgICAgICAgb3ZlcndyaXRpbmcgJHM0IGJl Zm9yZSBMTEludCdzIHB1c2hDYWxsZWVTYXZlcygpIGlzIGNhbGxlZCAoYXMgcGljaGRyCisgICAg ICAgIGlzIGF0IHRoZSB2ZXJ5IGJlZ2lubmluZyBvZiBhIGZ1bmN0aW9uKS4gTm93IHdlIHNhdmUg JGdwIHRvICRzNCBhdCB0aGUKKyAgICAgICAgZW5kIG9mIHB1c2hDYWxsZWVTYXZlcygpLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogb2ZmbGluZWFz bS9taXBzLnJiOgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorICAg ICAgICBNb3ZlIHRoZSBzYXZpbmcgb2YgJGdwIHRvICRzNCBmcm9tIHBpY2hkciB0byBwdXNoQ2Fs bGVlU2F2ZXMoKS4gVGFrZQorICAgICAgICB0aGUgb3Bwb3J0dW5pdHkgdG8gb25seSBzYXZlICRz NCBhcyB3ZSBuZXZlciB1c2UgdGhlIG90aGVyIGNhbGxlZQorICAgICAgICBzYXZlZCByZWdpc3Rl cnMuCisKIDIwMTYtMDEtMjAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTUzNzUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20gYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KaW5kZXgg MDk4YTljMDI3MjQ5MTQ2ODVlOTA0MjBmYjViYTI5ZTBkZWVhN2U4Mi4uMzBlYWMxM2I3ZDVlZjRi ZDUyZTQ2Njk4Y2Q0ZWJlZjc5YWQ5ZTY0NiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQpAQCAtNDMxLDcgKzQzMSw3IEBAIGlm IENfTE9PUCBvciBBUk02NCBvciBYODZfNjQgb3IgWDg2XzY0X1dJTgogZWxzaWYgQVJNIG9yIEFS TXY3X1RSQURJVElPTkFMIG9yIEFSTXY3CiAgICAgY29uc3QgQ2FsbGVlU2F2ZVJlZ2lzdGVyQ291 bnQgPSA3CiBlbHNpZiBTSDQgb3IgTUlQUwotICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNv dW50ID0gNQorICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gMQogZWxzaWYgWDg2 IG9yIFg4Nl9XSU4KICAgICBjb25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9IDMKIGVuZApA QCAtNDQ5LDEyICs0NDksMTAgQEAgbWFjcm8gcHVzaENhbGxlZVNhdmVzKCkKICAgICBlbHNpZiBB Uk12NwogICAgICAgICBlbWl0ICJwdXNoIHtyNC1yNiwgcjgtcjExfSIKICAgICBlbHNpZiBNSVBT Ci0gICAgICAgIGVtaXQgImFkZGl1ICRzcCwgJHNwLCAtMjAiCi0gICAgICAgIGVtaXQgInN3ICQy MCwgMTYoJHNwKSIKLSAgICAgICAgZW1pdCAic3cgJDE5LCAxMigkc3ApIgotICAgICAgICBlbWl0 ICJzdyAkMTgsIDgoJHNwKSIKLSAgICAgICAgZW1pdCAic3cgJDE3LCA0KCRzcCkiCi0gICAgICAg IGVtaXQgInN3ICQxNiwgMCgkc3ApIgorICAgICAgICBlbWl0ICJhZGRpdSAkc3AsICRzcCwgLTQi CisgICAgICAgIGVtaXQgInN3ICRzNCwgMCgkc3ApIgorICAgICAgICAjIHNhdmUgJGdwIHRvICRz NCBzbyB0aGF0IHdlIGNhbiByZXN0b3JlIGl0IGFmdGVyIGEgZnVuY3Rpb24gY2FsbAorICAgICAg ICBlbWl0ICJtb3ZlICRzNCwgJGdwIgogICAgIGVsc2lmIFNINAogICAgICAgICBlbWl0ICJtb3Yu bCByMTMsIEAtcjE1IgogICAgICAgICBlbWl0ICJtb3YubCByMTEsIEAtcjE1IgpAQCAtNDc5LDEy ICs0NzcsOCBAQCBtYWNybyBwb3BDYWxsZWVTYXZlcygpCiAgICAgZWxzaWYgQVJNdjcKICAgICAg ICAgZW1pdCAicG9wIHtyNC1yNiwgcjgtcjExfSIKICAgICBlbHNpZiBNSVBTCi0gICAgICAgIGVt aXQgImx3ICQxNiwgMCgkc3ApIgotICAgICAgICBlbWl0ICJsdyAkMTcsIDQoJHNwKSIKLSAgICAg ICAgZW1pdCAibHcgJDE4LCA4KCRzcCkiCi0gICAgICAgIGVtaXQgImx3ICQxOSwgMTIoJHNwKSIK LSAgICAgICAgZW1pdCAibHcgJDIwLCAxNigkc3ApIgotICAgICAgICBlbWl0ICJhZGRpdSAkc3As ICRzcCwgMjAiCisgICAgICAgIGVtaXQgImx3ICRzNCwgMCgkc3ApIgorICAgICAgICBlbWl0ICJh ZGRpdSAkc3AsICRzcCwgNCIKICAgICBlbHNpZiBTSDQKICAgICAgICAgZW1pdCAibW92LmwgQHIx NSssIHI4IgogICAgICAgICBlbWl0ICJtb3YubCBAcjE1KywgcjkiCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL29mZmxpbmVhc20vbWlwcy5yYgppbmRleCAzN2FhODA0ZWNjMGNiMTUzNTA0Y2U0NGEyNzI0 YWYxNzllYzkxZjdhLi4xOTgyNTAxYTlhNDFjYjBmMjRiMmE2ZmY0Mjg4MGY1ZjMzMzgxYjIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKQEAgLTEwNDEsNyArMTA0 MSw2IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAgICAkYXNtLnB1dHMgInNsdHUgI3tv cGVyYW5kc1swXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9LCAje29w ZXJhbmRzWzJdLm1pcHNPcGVyYW5kfSIKICAgICAgICAgd2hlbiAicGljaGRyIgogICAgICAgICAg ICAgJGFzbS5wdXRTdHIoIk9GRkxJTkVfQVNNX0NQTE9BRCgje01JUFNfQ0FMTF9SRUcubWlwc09w ZXJhbmR9KSIpCi0gICAgICAgICAgICAkYXNtLnB1dHMgIm1vdmUgI3tNSVBTX0dQU0FWRV9SRUcu bWlwc09wZXJhbmR9LCAje01JUFNfR1BfUkVHLm1pcHNPcGVyYW5kfSIKICAgICAgICAgd2hlbiAi bWVtZmVuY2UiCiAgICAgICAgICAgICAkYXNtLnB1dHMgInN5bmMiCiAgICAgICAgIGVsc2UK 270156 2016-01-28 15:37:37 -0800 2016-01-31 03:42:01 -0800 Patch bug-153463-20160128173711.patch text/plain 3537 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1Mzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh ZGI5YjFmY2FkYmMzMzA4MDdlZDA1Y2JiNGExMGZlNzdjYWY0Y2M1Li5hOTAwOWY4YzEyZGEwZDlj ZTQ3YWIzZWEwYTQ0NWI4NGE0NTNkNDMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wMS0yNSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgW21pcHNdIGRvbid0IHNhdmUgdG8gYSBjYWxsZWUgc2F2ZWQgcmVn aXN0ZXIgdG9vIGVhcmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTM0NjMKKworICAgICAgICBJZiB3ZSBzYXZlICRncCB0byAkczQgaW4gcGljaGRy LCB0aGVuIGluIHNvbWUgY2FzZXMsIHdlIHdlcmUKKyAgICAgICAgb3ZlcndyaXRpbmcgJHM0IGJl Zm9yZSBMTEludCdzIHB1c2hDYWxsZWVTYXZlcygpIGlzIGNhbGxlZCAoYXMgcGljaGRyCisgICAg ICAgIGlzIGF0IHRoZSB2ZXJ5IGJlZ2lubmluZyBvZiBhIGZ1bmN0aW9uKS4gTm93IHdlIHNhdmUg JGdwIHRvICRzNCBhdCB0aGUKKyAgICAgICAgZW5kIG9mIHB1c2hDYWxsZWVTYXZlcygpLgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogb2ZmbGluZWFz bS9taXBzLnJiOgorICAgICAgICAqIGxsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtOgorICAg ICAgICBNb3ZlIHRoZSBzYXZpbmcgb2YgJGdwIHRvICRzNCBmcm9tIHBpY2hkciB0byBwdXNoQ2Fs bGVlU2F2ZXMoKS4gVGFrZQorICAgICAgICB0aGUgb3Bwb3J0dW5pdHkgdG8gb25seSBzYXZlICRz NCBhcyB3ZSBuZXZlciB1c2UgdGhlIG90aGVyIGNhbGxlZQorICAgICAgICBzYXZlZCByZWdpc3Rl cnMuCisKIDIwMTYtMDEtMjAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxOTUzNzUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20gYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20KaW5kZXgg MDk4YTljMDI3MjQ5MTQ2ODVlOTA0MjBmYjViYTI5ZTBkZWVhN2U4Mi4uNzAxZjA2MjU2ZGE5MmQ4 MjVhYzhhMmEyM2YxMjFkMWZkOWRmZTU0NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIuYXNtCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQpAQCAtNDMwLDggKzQzMCwxMCBAQCBp ZiBDX0xPT1Agb3IgQVJNNjQgb3IgWDg2XzY0IG9yIFg4Nl82NF9XSU4KICAgICBjb25zdCBDYWxs ZWVTYXZlUmVnaXN0ZXJDb3VudCA9IDAKIGVsc2lmIEFSTSBvciBBUk12N19UUkFESVRJT05BTCBv ciBBUk12NwogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gNwotZWxzaWYgU0g0 IG9yIE1JUFMKK2Vsc2lmIFNINAogICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0g NQorZWxzaWYgTUlQUworICAgIGNvbnN0IENhbGxlZVNhdmVSZWdpc3RlckNvdW50ID0gMQogZWxz aWYgWDg2IG9yIFg4Nl9XSU4KICAgICBjb25zdCBDYWxsZWVTYXZlUmVnaXN0ZXJDb3VudCA9IDMK IGVuZApAQCAtNDQ5LDEyICs0NTEsMTAgQEAgbWFjcm8gcHVzaENhbGxlZVNhdmVzKCkKICAgICBl bHNpZiBBUk12NwogICAgICAgICBlbWl0ICJwdXNoIHtyNC1yNiwgcjgtcjExfSIKICAgICBlbHNp ZiBNSVBTCi0gICAgICAgIGVtaXQgImFkZGl1ICRzcCwgJHNwLCAtMjAiCi0gICAgICAgIGVtaXQg InN3ICQyMCwgMTYoJHNwKSIKLSAgICAgICAgZW1pdCAic3cgJDE5LCAxMigkc3ApIgotICAgICAg ICBlbWl0ICJzdyAkMTgsIDgoJHNwKSIKLSAgICAgICAgZW1pdCAic3cgJDE3LCA0KCRzcCkiCi0g ICAgICAgIGVtaXQgInN3ICQxNiwgMCgkc3ApIgorICAgICAgICBlbWl0ICJhZGRpdSAkc3AsICRz cCwgLTQiCisgICAgICAgIGVtaXQgInN3ICRzNCwgMCgkc3ApIgorICAgICAgICAjIHNhdmUgJGdw IHRvICRzNCBzbyB0aGF0IHdlIGNhbiByZXN0b3JlIGl0IGFmdGVyIGEgZnVuY3Rpb24gY2FsbAor ICAgICAgICBlbWl0ICJtb3ZlICRzNCwgJGdwIgogICAgIGVsc2lmIFNINAogICAgICAgICBlbWl0 ICJtb3YubCByMTMsIEAtcjE1IgogICAgICAgICBlbWl0ICJtb3YubCByMTEsIEAtcjE1IgpAQCAt NDc5LDEyICs0NzksOCBAQCBtYWNybyBwb3BDYWxsZWVTYXZlcygpCiAgICAgZWxzaWYgQVJNdjcK ICAgICAgICAgZW1pdCAicG9wIHtyNC1yNiwgcjgtcjExfSIKICAgICBlbHNpZiBNSVBTCi0gICAg ICAgIGVtaXQgImx3ICQxNiwgMCgkc3ApIgotICAgICAgICBlbWl0ICJsdyAkMTcsIDQoJHNwKSIK LSAgICAgICAgZW1pdCAibHcgJDE4LCA4KCRzcCkiCi0gICAgICAgIGVtaXQgImx3ICQxOSwgMTIo JHNwKSIKLSAgICAgICAgZW1pdCAibHcgJDIwLCAxNigkc3ApIgotICAgICAgICBlbWl0ICJhZGRp dSAkc3AsICRzcCwgMjAiCisgICAgICAgIGVtaXQgImx3ICRzNCwgMCgkc3ApIgorICAgICAgICBl bWl0ICJhZGRpdSAkc3AsICRzcCwgNCIKICAgICBlbHNpZiBTSDQKICAgICAgICAgZW1pdCAibW92 LmwgQHIxNSssIHI4IgogICAgICAgICBlbWl0ICJtb3YubCBAcjE1KywgcjkiCmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJiIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL29mZmxpbmVhc20vbWlwcy5yYgppbmRleCAzN2FhODA0ZWNjMGNiMTUzNTA0Y2U0 NGEyNzI0YWYxNzllYzkxZjdhLi4xOTgyNTAxYTlhNDFjYjBmMjRiMmE2ZmY0Mjg4MGY1ZjMzMzgx YjIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFzbS9taXBzLnJi CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL21pcHMucmIKQEAgLTEwNDEs NyArMTA0MSw2IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAgICAkYXNtLnB1dHMgInNs dHUgI3tvcGVyYW5kc1swXS5taXBzT3BlcmFuZH0sICN7b3BlcmFuZHNbMV0ubWlwc09wZXJhbmR9 LCAje29wZXJhbmRzWzJdLm1pcHNPcGVyYW5kfSIKICAgICAgICAgd2hlbiAicGljaGRyIgogICAg ICAgICAgICAgJGFzbS5wdXRTdHIoIk9GRkxJTkVfQVNNX0NQTE9BRCgje01JUFNfQ0FMTF9SRUcu bWlwc09wZXJhbmR9KSIpCi0gICAgICAgICAgICAkYXNtLnB1dHMgIm1vdmUgI3tNSVBTX0dQU0FW RV9SRUcubWlwc09wZXJhbmR9LCAje01JUFNfR1BfUkVHLm1pcHNPcGVyYW5kfSIKICAgICAgICAg d2hlbiAibWVtZmVuY2UiCiAgICAgICAgICAgICAkYXNtLnB1dHMgInN5bmMiCiAgICAgICAgIGVs c2UK