153447 2016-01-25 14:24:51 -0800 Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample counts 2016-01-25 16:26:04 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 saam saam bburg ggaren graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1158501 0 saam 2016-01-25 14:24:51 -0800 ... 1158503 1 webkit-bug-importer 2016-01-25 14:25:25 -0800 <rdar://problem/24334137> 1158509 2 timothy 2016-01-25 14:33:40 -0800 <rdar://problem/24329305> 1158537 3 269801 saam 2016-01-25 15:15:20 -0800 Created attachment 269801 patch 1158552 4 269801 joepeck 2016-01-25 15:26:20 -0800 Comment on attachment 269801 patch View in context: https://bugs.webkit.org/attachment.cgi?id=269801&action=review r=me handling backwards combat > Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js:65 > + get callCount() > + { > + return this._callCount; > + } We should only do this when we are using the sampling profiler. Otherwise when it actually says "Call Count" instead of "Samples" we will see some # for "Script Evaluated" which doesn't make sense. You could make this: get callCount() { // COMPATIBILITY(iOS 9): Before the ScriptProfilerAgent we did not have sample data. Return NaN to match old behavior. if (!window.ScriptProfilerAgent) return NaN; // NOTE: callCount here is actually the number of samples. return this._callCount; } 1158587 5 saam 2016-01-25 16:26:04 -0800 landed in: http://trac.webkit.org/changeset/195566 269801 2016-01-25 15:15:20 -0800 2016-01-25 15:26:20 -0800 patch c-backup.diff text/plain 2953 saam SW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1NTU5KQorKysgU291cmNl L1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTAxLTI1ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYiBJbnNwZWN0b3I6IEhhdmUgdG9wLWxldmVsIFNjcmlwdFRpbWVsaW5lRGF0YUdyaWROb2Rl IGV2ZW50cyBzaG93IHNhbXBsZSBjb3VudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MzQ0NworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQzMzQx Mzc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qczoKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5TY3JpcHRUaW1lbGluZVJlY29yZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu U2NyaXB0VGltZWxpbmVSZWNvcmQucHJvdG90eXBlLmdldCBwcm9maWxlKToKKyAgICAgICAgKFdl Ykluc3BlY3Rvci5TY3JpcHRUaW1lbGluZVJlY29yZC5wcm90b3R5cGUuZ2V0IGNhbGxDb3VudCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2NyaXB0VGltZWxpbmVSZWNvcmQucHJvdG90eXBlLmlz R2FyYmFnZUNvbGxlY3Rpb24pOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNjcmlwdFRpbWVsaW5l UmVjb3JkLnByb3RvdHlwZS5faW5pdGlhbGl6ZVByb2ZpbGVGcm9tUGF5bG9hZCk6CisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZURhdGFHcmlkTm9kZS5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5TY3JpcHRUaW1lbGluZURhdGFHcmlkTm9kZS5wcm90b3R5cGUu Z2V0IGRhdGEpOgorCiAyMDE2LTAxLTI1ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVkdWNlIHVubmVjZXNzYXJ5IGZvcmNl ZCBsYXlvdXRzIGluIFRpbWVsaW5lT3ZlcnZpZXcKSW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvU2NyaXB0VGlt ZWxpbmVSZWNvcmQuanMJKHJldmlzaW9uIDE5NTU1NSkKKysrIFNvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRUaW1lbGluZVJlY29yZC5qcwkod29ya2luZyBj b3B5KQpAQCAtMzgsNiArMzgsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0VGltZWxpbmVSZWNvcmQg PSBjbGFzCiAgICAgICAgIHRoaXMuX2RldGFpbHMgPSBkZXRhaWxzIHx8ICIiOwogICAgICAgICB0 aGlzLl9wcm9maWxlUGF5bG9hZCA9IHByb2ZpbGVQYXlsb2FkIHx8IG51bGw7CiAgICAgICAgIHRo aXMuX3Byb2ZpbGUgPSBudWxsOworICAgICAgICB0aGlzLl9jYWxsQ291bnQgPSAwOwogICAgIH0K IAogICAgIC8vIFB1YmxpYwpAQCAtNTgsNiArNTksMTEgQEAgV2ViSW5zcGVjdG9yLlNjcmlwdFRp bWVsaW5lUmVjb3JkID0gY2xhcwogICAgICAgICByZXR1cm4gdGhpcy5fcHJvZmlsZTsKICAgICB9 CiAKKyAgICBnZXQgY2FsbENvdW50KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLl9jYWxs Q291bnQ7CisgICAgfQorCiAgICAgaXNHYXJiYWdlQ29sbGVjdGlvbigpCiAgICAgewogICAgICAg ICByZXR1cm4gdGhpcy5fZXZlbnRUeXBlID09PSBXZWJJbnNwZWN0b3IuU2NyaXB0VGltZWxpbmVS ZWNvcmQuRXZlbnRUeXBlLkdhcmJhZ2VDb2xsZWN0ZWQ7CkBAIC0xNTksNiArMTY1LDkgQEAgV2Vi SW5zcGVjdG9yLlNjcmlwdFRpbWVsaW5lUmVjb3JkID0gY2xhcwogICAgICAgICAgICAgfQogICAg ICAgICB9CiAKKyAgICAgICAgZm9yIChsZXQgaSA9IDA7IGkgPCByb290Tm9kZXMubGVuZ3RoOyBp KyspCisgICAgICAgICAgICB0aGlzLl9jYWxsQ291bnQgKz0gcm9vdE5vZGVzW2ldLmNhbGxJbmZv LmNhbGxDb3VudDsKKwogICAgICAgICB0aGlzLl9wcm9maWxlID0gbmV3IFdlYkluc3BlY3Rvci5Q cm9maWxlKHJvb3ROb2Rlcyk7CiAgICAgfQogfTsKSW5kZXg6IFNvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFRpbWVsaW5lRGF0YUdyaWROb2RlLmpzCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njcmlw dFRpbWVsaW5lRGF0YUdyaWROb2RlLmpzCShyZXZpc2lvbiAxOTU1NTUpCisrKyBTb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRUaW1lbGluZURhdGFHcmlkTm9k ZS5qcwkod29ya2luZyBjb3B5KQpAQCAtODMsNyArODMsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0 VGltZWxpbmVEYXRhR3JpZE5vZGUgCiAgICAgICAgICAgICBzZWxmVGltZTogZHVyYXRpb24sCiAg ICAgICAgICAgICB0b3RhbFRpbWU6IGR1cmF0aW9uLAogICAgICAgICAgICAgYXZlcmFnZVRpbWU6 IGR1cmF0aW9uLAotICAgICAgICAgICAgY2FsbENvdW50OiBOYU4sCisgICAgICAgICAgICBjYWxs Q291bnQ6IHRoaXMuX3JlY29yZC5jYWxsQ291bnQsCiAgICAgICAgICAgICBsb2NhdGlvbjogY2Fs bEZyYW1lT3JTb3VyY2VDb2RlTG9jYXRpb24KICAgICAgICAgfTsKICAgICB9Cg==