153429 2016-01-25 10:55:03 -0800 Do not convert GlyphBufferAdvance to FloatSize 2016-01-26 10:37:51 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue koivisto mmaxfield simon.fraser oldest_to_newest 1158381 0 annulen 2016-01-25 10:55:03 -0800 GlyphBufferAdvance is not necessaryly conversible to FloatSize. Also, this code was doing extra work by transforming height value. 1158382 1 269760 annulen 2016-01-25 10:56:42 -0800 Created attachment 269760 Patch 1158383 2 269761 annulen 2016-01-25 10:58:03 -0800 Created attachment 269761 Patch 1158863 3 269761 commit-queue 2016-01-26 10:37:46 -0800 Comment on attachment 269761 Patch Clearing flags on attachment: 269761 Committed r195596: <http://trac.webkit.org/changeset/195596> 1158865 4 commit-queue 2016-01-26 10:37:51 -0800 All reviewed patches have been landed. Closing bug. 269760 2016-01-25 10:56:42 -0800 2016-01-25 10:57:55 -0800 Patch bug-153429-20160125215615.patch text/plain 1893 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdkZjQwY2M4ZDQ3MWU0 ZGQ0Njc0MDEyMTFhNTczZDNkZWZlOGRiNS4uMzg4M2FjYjVjMDQ5MGYxN2IwM2E1ZjQ2OTc3YjIz ZTcwMmQzMmU4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAxLTI1ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEbyBub3QgY29u dmVydCBHbHlwaEJ1ZmZlckFkdmFuY2UgdG8gRmxvYXRTaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM0MjkKKworICAgICAgICBHbHlwaEJ1ZmZl ckFkdmFuY2UgaXMgbm90IG5lY2Vzc2FyeWx5IGNvbnZlcnNpYmxlIHRvIEZsb2F0U2l6ZS4KKyAg ICAgICAgQWxzbywgdGhpcyBjb2RlIHdhcyBkb2luZyBleHRyYSB3b3JrIGJ5IHRyYW5zZm9ybWlu ZyBoZWlnaHQgdmFsdWUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9zdmcv U1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHR2x5 cGhUb1BhdGhUcmFuc2xhdG9yOjpleHRlbnRzKToKKwogMjAxNi0wMS0yNSAgQnJhZHkgRWlkc29u ICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kZXJuIElEQjogSW1wbGVtZW50IGdl dEluZGV4UmVjb3JkIGluIHRoZSBTUUxpdGUgYmFja2luZyBzdG9yZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4 dC5jcHAKaW5kZXggZjNmMzE4ODE0YjQxZDc1ODExMzJkMjJkYWFjNjMyOGRhNmE5YTY3ZS4uNzU2 OGI2YTA2MmQ4NmIzMTI1MDg3NzZhOTNkMjJhNmYzYTUzNjI5MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4 dC5jcHAKQEAgLTE3Niw4ICsxNzYsOCBAQCBzdGQ6OnBhaXI8ZmxvYXQsIGZsb2F0PiBTVkdHbHlw aFRvUGF0aFRyYW5zbGF0b3I6OmV4dGVudHMoKQogewogICAgIEFmZmluZVRyYW5zZm9ybSBnbHlw aFBhdGhUcmFuc2Zvcm0gPSB0cmFuc2Zvcm0oKTsKICAgICBGbG9hdFBvaW50IGJlZ2lubmluZyA9 IGdseXBoUGF0aFRyYW5zZm9ybS5tYXBQb2ludChtX2N1cnJlbnRQb2ludCk7Ci0gICAgRmxvYXRT aXplIGVuZCA9IGdseXBoUGF0aFRyYW5zZm9ybS5tYXBTaXplKEZsb2F0U2l6ZShtX2dseXBoQnVm ZmVyLmFkdmFuY2VBdChtX2luZGV4KSkpOwotICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihiZWdp bm5pbmcueCgpLCBiZWdpbm5pbmcueCgpICsgZW5kLndpZHRoKCkpOworICAgIGZsb2F0IHdpZHRo ID0gbmFycm93UHJlY2lzaW9uVG9GbG9hdChtX2dseXBoQnVmZmVyLmFkdmFuY2VBdChtX2luZGV4 KS53aWR0aCgpICogZ2x5cGhQYXRoVHJhbnNmb3JtLnhTY2FsZSgpKTsKKyAgICByZXR1cm4gc3Rk OjptYWtlX3BhaXIoYmVnaW5uaW5nLngoKSwgYmVnaW5uaW5nLngoKSArIHdpZHRoKTsKIH0KIAog YXV0byBTVkdHbHlwaFRvUGF0aFRyYW5zbGF0b3I6OnVuZGVybGluZVR5cGUoKSAtPiBHbHlwaFVu ZGVybGluZVR5cGUK 269761 2016-01-25 10:58:03 -0800 2016-01-26 10:37:46 -0800 Patch bug-153429-20160125215736.patch text/plain 1893 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTdkZjQwY2M4ZDQ3MWU0 ZGQ0Njc0MDEyMTFhNTczZDNkZWZlOGRiNS4uZDI4ODMxZTE4MjUzYWM5NTMxZTBhY2QzODA5MWNi NTNkNTBmMTM2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAxLTI1ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEbyBub3QgY29u dmVydCBHbHlwaEJ1ZmZlckFkdmFuY2UgdG8gRmxvYXRTaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM0MjkKKworICAgICAgICBHbHlwaEJ1ZmZl ckFkdmFuY2UgaXMgbm90IG5lY2Vzc2FyeWx5IGNvbnZlcnRpYmxlIHRvIEZsb2F0U2l6ZS4KKyAg ICAgICAgQWxzbywgdGhpcyBjb2RlIHdhcyBkb2luZyBleHRyYSB3b3JrIGJ5IHRyYW5zZm9ybWlu ZyBoZWlnaHQgdmFsdWUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHJlbmRlcmluZy9zdmcv U1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHR2x5 cGhUb1BhdGhUcmFuc2xhdG9yOjpleHRlbnRzKToKKwogMjAxNi0wMS0yNSAgQnJhZHkgRWlkc29u ICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgTW9kZXJuIElEQjogSW1wbGVtZW50IGdl dEluZGV4UmVjb3JkIGluIHRoZSBTUUxpdGUgYmFja2luZyBzdG9yZS4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdmcvU1ZHVGV4dFJ1blJlbmRlcmluZ0NvbnRleHQuY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4 dC5jcHAKaW5kZXggZjNmMzE4ODE0YjQxZDc1ODExMzJkMjJkYWFjNjMyOGRhNmE5YTY3ZS4uNzU2 OGI2YTA2MmQ4NmIzMTI1MDg3NzZhOTNkMjJhNmYzYTUzNjI5MSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4dC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N2Zy9TVkdUZXh0UnVuUmVuZGVyaW5nQ29udGV4 dC5jcHAKQEAgLTE3Niw4ICsxNzYsOCBAQCBzdGQ6OnBhaXI8ZmxvYXQsIGZsb2F0PiBTVkdHbHlw aFRvUGF0aFRyYW5zbGF0b3I6OmV4dGVudHMoKQogewogICAgIEFmZmluZVRyYW5zZm9ybSBnbHlw aFBhdGhUcmFuc2Zvcm0gPSB0cmFuc2Zvcm0oKTsKICAgICBGbG9hdFBvaW50IGJlZ2lubmluZyA9 IGdseXBoUGF0aFRyYW5zZm9ybS5tYXBQb2ludChtX2N1cnJlbnRQb2ludCk7Ci0gICAgRmxvYXRT aXplIGVuZCA9IGdseXBoUGF0aFRyYW5zZm9ybS5tYXBTaXplKEZsb2F0U2l6ZShtX2dseXBoQnVm ZmVyLmFkdmFuY2VBdChtX2luZGV4KSkpOwotICAgIHJldHVybiBzdGQ6Om1ha2VfcGFpcihiZWdp bm5pbmcueCgpLCBiZWdpbm5pbmcueCgpICsgZW5kLndpZHRoKCkpOworICAgIGZsb2F0IHdpZHRo ID0gbmFycm93UHJlY2lzaW9uVG9GbG9hdChtX2dseXBoQnVmZmVyLmFkdmFuY2VBdChtX2luZGV4 KS53aWR0aCgpICogZ2x5cGhQYXRoVHJhbnNmb3JtLnhTY2FsZSgpKTsKKyAgICByZXR1cm4gc3Rk OjptYWtlX3BhaXIoYmVnaW5uaW5nLngoKSwgYmVnaW5uaW5nLngoKSArIHdpZHRoKTsKIH0KIAog YXV0byBTVkdHbHlwaFRvUGF0aFRyYW5zbGF0b3I6OnVuZGVybGluZVR5cGUoKSAtPiBHbHlwaFVu ZGVybGluZVR5cGUK