153426 2016-01-25 09:22:09 -0800 [B3] Fix control reaches end of non-void function GCC warning after r195139 2016-01-26 17:11:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152952 1 ossy ossy commit-queue fpizlo keith_miller mark.lam mcatanzaro msaboff saam oldest_to_newest 1158348 0 ossy 2016-01-25 09:22:09 -0800 https://trac.webkit.org/changeset/195139 broke the B3 debug build on Linux: In file included from ../../Source/JavaScriptCore/b3/air/AirCCallingConvention.h:31:0, from ../../Source/JavaScriptCore/b3/air/AirLowerAfterRegAlloc.cpp:31: ../../Source/JavaScriptCore/b3/air/AirArg.h: In static member function 'static JSC::B3::Air::Arg::Role JSC::B3::Air::Arg::cooled(JSC::B3::Air::Arg::Role)': ../../Source/JavaScriptCore/b3/air/AirArg.h:261:5: error: control reaches end of non-void function [-Werror=return-type] cc1plus: all warnings being treated as errors ( Since https://trac.webkit.org/changeset/194858 we use ASSERT_NOT_REACHED() to be able to catch possible bugs in debug mode. And this warnings are suppressed in release mode not to cause performance slowdown. ) 1158349 1 269755 ossy 2016-01-25 09:23:04 -0800 Created attachment 269755 Patch 1159090 2 mcatanzaro 2016-01-26 16:21:34 -0800 (In reply to comment #0) > ( Since https://trac.webkit.org/changeset/194858 we use ASSERT_NOT_REACHED() > to be able to catch possible bugs in debug mode. And this warnings are > suppressed in release mode not to cause performance slowdown. ) Oh, I didn't know that; I've been using RELEASE_ASSERT_NOT_REACHED() for this. 1159119 3 269755 commit-queue 2016-01-26 17:11:07 -0800 Comment on attachment 269755 Patch Clearing flags on attachment: 269755 Committed r195640: <http://trac.webkit.org/changeset/195640> 1159120 4 commit-queue 2016-01-26 17:11:11 -0800 All reviewed patches have been landed. Closing bug. 269755 2016-01-25 09:23:04 -0800 2016-01-26 17:11:07 -0800 Patch bug-153426-20160125182237.patch text/plain 1215 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm MTkyMzE1NTI5MGYzYWE3ZGExZjhhYzk0M2Y1Y2E0ZWQyNmYzZTUyLi42Yjg0MmQyYWY2NDg0Mzcy Y2I3ZmJkYzUxZWJmM2QwZGNlNWU0OTUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMyBAQAorMjAxNi0wMS0yNSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtCM10gRml4IGNvbnRyb2wgcmVhY2hlcyBlbmQgb2Ygbm9uLXZvaWQg ZnVuY3Rpb24gR0NDIHdhcm5pbmcgYWZ0ZXIgcjE5NTEzOQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzNDI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiMy9haXIvQWlyQXJnLmg6CisgICAgICAgIChK U0M6OkIzOjpBaXI6OkFyZzo6Y29vbGVkKToKKwogMjAxNi0wMS0yNSAgQW5kcmVhcyBLbGluZyAg PGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIG51bWJlciBvZiBTdHJ1Y3R1cmVz IGNyZWF0ZWQgYXQgc3RhcnR1cC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My9haXIvQWlyQXJnLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpckFyZy5oCmlu ZGV4IDJhMjQyYjhlN2E2YzY0NTE4MWQzZmZkODIwZWQwOTI3MzFiZGY2MGMuLjgxNGFkMmFjYjUy ZWIwZWUxODM1YjdjODI5YTM4NGZjNTI5MDM1YWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9iMy9haXIvQWlyQXJnLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fp ci9BaXJBcmcuaApAQCAtMjU4LDYgKzI1OCw3IEBAIHB1YmxpYzoKICAgICAgICAgY2FzZSBMYXRl VXNlOgogICAgICAgICAgICAgcmV0dXJuIExhdGVDb2xkVXNlOwogICAgICAgICB9CisgICAgICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0KIAogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0 aGUgUm9sZSBpbXBsaWVzIHRoYXQgdGhlIEluc3Qgd2lsbCBVc2UgdGhlIEFyZyBiZWZvcmUgZG9p bmcgYW55dGhpbmcgZWxzZS4K