153421 2016-01-25 04:08:08 -0800 Do not convert GlyphBufferAdvance to FloatSize 2016-01-25 10:59:16 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned commit-queue mmaxfield simon.fraser zalan oldest_to_newest 1158278 0 annulen 2016-01-25 04:08:08 -0800 In Qt port we have GlyphBufferAdvance based on point type, not size type, however this code seems to work equally well with both point- and size-based GlyphBufferAdvance. 1158283 1 269740 annulen 2016-01-25 04:10:34 -0800 Created attachment 269740 Patch 1158284 2 269741 annulen 2016-01-25 04:25:08 -0800 Created attachment 269741 Patch 1158339 3 simon.fraser 2016-01-25 09:00:37 -0800 I think it's bad that these platform types propagate around masquerading as cross-platform types. 1158340 4 annulen 2016-01-25 09:05:24 -0800 If you are interested in this kind of patches, could you help me with SVGGlyphToPathTranslator::extents (rendering/svg/SVGTextRunRenderingContext.cpp)? It has similar issue: mapSize is used to convert width of GlyphBufferAdvance, which is converted to FloatSize for this purpose. 1158357 5 269741 commit-queue 2016-01-25 09:49:31 -0800 Comment on attachment 269741 Patch Clearing flags on attachment: 269741 Committed r195539: <http://trac.webkit.org/changeset/195539> 1158358 6 commit-queue 2016-01-25 09:49:36 -0800 All reviewed patches have been landed. Closing bug. 1158384 7 annulen 2016-01-25 10:59:16 -0800 Did not come up with anything more elegant than https://bugs.webkit.org/show_bug.cgi?id=153429 269740 2016-01-25 04:10:34 -0800 2016-01-25 04:25:01 -0800 Patch bug-153421-20160125151006.patch text/plain 1406 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjA4ZWY4MTk0MDU2MjI0 Y2VhMDJlMGM1MjU3YTY1ZjVhZWZmMTY1Yy4uMjEzZDQwZTA5YTc5ZDM2YWM2ZGYzOTMwZjY4OWFh YTkwYTM2MmFlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAxLTI1ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEbyBub3QgY29u dmVydCBHbHlwaEJ1ZmZlckFkdmFuY2UgdG8gRmxvYXRTaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM0MjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0SXRlbXMuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OkRyYXdHbHlwaHM6OmNvbXB1dGVCb3Vu ZHMpOgorCiAyMDE2LTAxLTI1ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk1NTMxLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlM aXN0SXRlbXMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp c3RzL0Rpc3BsYXlMaXN0SXRlbXMuY3BwCmluZGV4IDJlNDkzYWIxOGMwMzRkMjJjMzgzY2U3NzNl NjE1ZmE4OTc3YjYzMGMuLjJlMzUyZjgzYjllODFmZTM5NmMzOGE3OWEwMTkyNTg3NDRhZmQxOGEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0 cy9EaXNwbGF5TGlzdEl0ZW1zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtcy5jcHAKQEAgLTM5MSw3ICszOTEsNyBA QCB2b2lkIERyYXdHbHlwaHM6OmNvbXB1dGVCb3VuZHMoKQogICAgICAgICBGbG9hdFJlY3QgZ2x5 cGhSZWN0ID0gRmxvYXRSZWN0KGN1cnJlbnQueCgpLCBjdXJyZW50LnkoKSAtIGFzY2VudCwgYWR2 YW5jZS53aWR0aCgpLCBhc2NlbnQgKyBkZXNjZW50KTsKICAgICAgICAgbV9ib3VuZHMudW5pdGUo Z2x5cGhSZWN0KTsKIAotICAgICAgICBjdXJyZW50ICs9IEZsb2F0U2l6ZShhZHZhbmNlKTsKKyAg ICAgICAgY3VycmVudCArPSBhZHZhbmNlOwogICAgIH0KIH0KIAo= 269741 2016-01-25 04:25:08 -0800 2016-01-25 09:49:31 -0800 Patch bug-153421-20160125152440.patch text/plain 1435 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjA4ZWY4MTk0MDU2MjI0 Y2VhMDJlMGM1MjU3YTY1ZjVhZWZmMTY1Yy4uMjEzZDQwZTA5YTc5ZDM2YWM2ZGYzOTMwZjY4OWFh YTkwYTM2MmFlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAxLTI1ICBLb25z dGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KKworICAgICAgICBEbyBub3QgY29u dmVydCBHbHlwaEJ1ZmZlckFkdmFuY2UgdG8gRmxvYXRTaXplCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM0MjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlMaXN0SXRlbXMuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OkRyYXdHbHlwaHM6OmNvbXB1dGVCb3Vu ZHMpOgorCiAyMDE2LTAxLTI1ICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTk1NTMxLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxpc3RzL0Rpc3BsYXlM aXN0SXRlbXMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZGlzcGxheWxp c3RzL0Rpc3BsYXlMaXN0SXRlbXMuY3BwCmluZGV4IDJlNDkzYWIxOGMwMzRkMjJjMzgzY2U3NzNl NjE1ZmE4OTc3YjYzMGMuLmU0MTQzMzNlYTUyM2FiYzkwOGViNDJhYmI2YTY3OWEzYzUzM2IxZWEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Rpc3BsYXlsaXN0 cy9EaXNwbGF5TGlzdEl0ZW1zLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9kaXNwbGF5bGlzdHMvRGlzcGxheUxpc3RJdGVtcy5jcHAKQEAgLTM5MSw3ICszOTEsNyBA QCB2b2lkIERyYXdHbHlwaHM6OmNvbXB1dGVCb3VuZHMoKQogICAgICAgICBGbG9hdFJlY3QgZ2x5 cGhSZWN0ID0gRmxvYXRSZWN0KGN1cnJlbnQueCgpLCBjdXJyZW50LnkoKSAtIGFzY2VudCwgYWR2 YW5jZS53aWR0aCgpLCBhc2NlbnQgKyBkZXNjZW50KTsKICAgICAgICAgbV9ib3VuZHMudW5pdGUo Z2x5cGhSZWN0KTsKIAotICAgICAgICBjdXJyZW50ICs9IEZsb2F0U2l6ZShhZHZhbmNlKTsKKyAg ICAgICAgY3VycmVudC5tb3ZlKGFkdmFuY2Uud2lkdGgoKSwgYWR2YW5jZS5oZWlnaHQoKSk7CiAg ICAgfQogfQogCg==