153413 2016-01-24 18:13:20 -0800 Colormap should be freed when XWindow is destroyed on X11Helper. 2016-02-01 16:46:42 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sunny.nam webkit-unassigned cgarcia commit-queue gyuyoung.kim mcatanzaro mrobinson yoon zan oldest_to_newest 1158182 0 sunny.nam 2016-01-24 18:13:20 -0800 Colormap is needed to create XWindow and it should be freed when XWindow is destroyed. Unless Colormap is freed before destroying XWindow, memory leak is suspected. XFreeColormap therefore is needed on X11Helper. 1158184 1 269712 sunny.nam 2016-01-24 18:20:15 -0800 Created attachment 269712 Patch 1158185 2 269713 sunny.nam 2016-01-24 18:22:11 -0800 Created attachment 269713 Patch 1160833 3 269713 zan 2016-02-01 06:12:42 -0800 Comment on attachment 269713 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269713&action=review > Source/WebCore/platform/graphics/surfaces/glx/X11Helper.cpp:296 > + XWindowAttributes attribute; > + XGetWindowAttributes(display, windowId, &attribute); > + > + XFreeColormap(display, attribute.colormap); r=me 1161090 4 269713 mcatanzaro 2016-02-01 15:58:59 -0800 Comment on attachment 269713 Patch Thanks! 1161129 5 269713 commit-queue 2016-02-01 16:46:39 -0800 Comment on attachment 269713 Patch Clearing flags on attachment: 269713 Committed r195992: <http://trac.webkit.org/changeset/195992> 1161130 6 commit-queue 2016-02-01 16:46:42 -0800 All reviewed patches have been landed. Closing bug. 269712 2016-01-24 18:20:15 -0800 2016-01-24 18:22:00 -0800 Patch bug-153413-20160125112007.patch text/plain 5133 sunny.nam U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU2YjJhZjQxMDFkMzkz OGJlNjU0M2VhODAyODc1MDU1MGQyOWJhYy4uYWNhOTJiYTUxZGYyMjAzY2VkNmViOWFjMWJmOTM5 YWRiZjg2ODA3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAxLTI0ICBTdW4t d29vIE5hbSAgPHN1bm55Lm5hbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGcmVlIENvbG9ybWFw IHdoZW4gWFdpbmRvdyBpcyBkZXN0cm95ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb2xvcm1hcCBpcyBuZWVkZWQgdG8gY3JlYXRlIFhXaW5kb3cg YW5kIGl0IHNob3VsZCBiZSBmcmVlZCB3aGVuIFhXaW5kb3cgaXMgZGVzdHJveWVkLgorICAgICAg ICBVbmxlc3MgQ29sb3JtYXAgaXMgZnJlZWQgYmVmb3JlIGRlc3Ryb3lpbmcgWFdpbmRvdywgbWVt b3J5IGxlYWsgaXMgc3VzcGVjdGVkLgorICAgICAgICBYRnJlZUNvbG9ybWFwIHRoZXJlZm9yZSBp cyBuZWVkZWQgb24gWDExSGVscGVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc3Vy ZmFjZXMvZ2x4L1gxMUhlbHBlci5jcHA6IEFkZGVkIFhGcmVlQ29sb3JtYXAuCisgICAgICAgIChX ZWJDb3JlOjpYMTFIZWxwZXI6OmRlc3Ryb3lXaW5kb3cpOgorCiAyMDE2LTAxLTI0ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlIGR1bXBl ZCBkaXNwbGF5IGxpc3QgcmVwcmVzZW50YXRpb24gYSBiaXQgbW9yZSBjb21wYWN0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9HTFRyYW5zcG9y dFN1cmZhY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMv R0xUcmFuc3BvcnRTdXJmYWNlLmNwcAppbmRleCBjNjQ3OTVjZjU3NTQwMWQ0N2RiYmIzMWExZjA0 YmJhMjg4Y2U3NTBhLi40MTk4YTMwYzlkZjZhYWQxMzZlOTkyZDUwZGI2MTUwNzA3NzExZmU2IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9HTFRy YW5zcG9ydFN1cmZhY2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3N1cmZhY2VzL0dMVHJhbnNwb3J0U3VyZmFjZS5jcHAKQEAgLTQ1LDYgKzQ1LDcgQEAgc3RhdGlj IGJvb2wgdmVydGV4QXJyYXlPYmplY3RTdXBwb3J0ZWQgPSBmYWxzZTsKIAogc3RkOjp1bmlxdWVf cHRyPEdMVHJhbnNwb3J0U3VyZmFjZT4gR0xUcmFuc3BvcnRTdXJmYWNlOjpjcmVhdGVUcmFuc3Bv cnRTdXJmYWNlKGNvbnN0IEludFNpemUmIHNpemUsIFN1cmZhY2VBdHRyaWJ1dGVzIGF0dHJpYnV0 ZXMpCiB7CisgICAgcHJpbnRmKCJHTFRyYW5zcG9ydFN1cmZhY2U6OmNyZWF0ZVRyYW5zcG9ydFN1 cmZhY2VcbiIpOwogICAgIHN0ZDo6dW5pcXVlX3B0cjxHTFRyYW5zcG9ydFN1cmZhY2U+IHN1cmZh Y2U7CiAjaWYgVVNFKEdMWCkKICAgICBzdXJmYWNlID0gc3RkOjptYWtlX3VuaXF1ZTxHTFhUcmFu c3BvcnRTdXJmYWNlPihzaXplLCBhdHRyaWJ1dGVzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL0dyYXBoaWNzU3VyZmFjZS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9HcmFwaGljc1N1cmZhY2UuY3Bw CmluZGV4IDhmYTVhYjVkOWQyNjU4NzQ2ODU5MDhkNTE3ZTZhMzU0NWNlZDM2MjAuLmZjOTRkNjY1 MGYxMTUxMDNlN2M2YjBlNjE2OWNiYzg5ZDQyYWM2MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL0dyYXBoaWNzU3VyZmFjZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc3VyZmFjZXMvR3JhcGhpY3NTdXJmYWNl LmNwcApAQCAtMzIsNiArMzIsNyBAQCBQYXNzUmVmUHRyPEdyYXBoaWNzU3VyZmFjZT4gR3JhcGhp Y3NTdXJmYWNlOjpjcmVhdGUoY29uc3QgSW50U2l6ZSYgc2l6ZSwgRmxhZ3MgZgogCiBQYXNzUmVm UHRyPEdyYXBoaWNzU3VyZmFjZT4gR3JhcGhpY3NTdXJmYWNlOjpjcmVhdGUoY29uc3QgSW50U2l6 ZSYgc2l6ZSwgR3JhcGhpY3NTdXJmYWNlOjpGbGFncyBmbGFncywgY29uc3QgUGxhdGZvcm1HcmFw aGljc0NvbnRleHQzRCBzaGFyZUNvbnRleHQpCiB7CisgICAgcHJpbnRmKCJHcmFwaGljc1N1cmZh Y2U6OmNyZWF0ZVxuIik7CiAgICAgcmV0dXJuIHBsYXRmb3JtQ3JlYXRlKHNpemUsIGZsYWdzLCBz aGFyZUNvbnRleHQpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9zdXJmYWNlcy9lZmwvR3JhcGhpY3NTdXJmYWNlQ29tbW9uLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VmbC9HcmFwaGljc1N1cmZhY2VDb21t b24uY3BwCmluZGV4IGVjMTMwNDBkMjFkNGVhN2EwMGUzZGRiODJjNWE0YjEzOTQ5NjUzMDcuLjlk ZGI3MWI0YTJjZTJhMTZiMjIyOGU5ZTgwMTYwZmZkOGM4ZjlmN2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2VmbC9HcmFwaGljc1N1cmZhY2VD b21tb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2Vz L2VmbC9HcmFwaGljc1N1cmZhY2VDb21tb24uY3BwCkBAIC03MSw2ICs3MSw3IEBAIHN0cnVjdCBH cmFwaGljc1N1cmZhY2VQcml2YXRlIHsKIAogICAgIGJvb2wgaW5pdGlhbGl6ZVRyYW5zcG9ydFN1 cmZhY2UoY29uc3QgSW50U2l6ZSYgc2l6ZSwgR3JhcGhpY3NTdXJmYWNlOjpGbGFncyBmbGFncywg Y29uc3QgUGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCBzaGFyZUNvbnRleHQpCiAgICAgeworICAg ICAgICBwcmludGYoImluaXRpYWxpemVUcmFuc3BvcnRTdXJmYWNlXG4iKTsKICAgICAgICAgR0xQ bGF0Zm9ybVN1cmZhY2U6OlN1cmZhY2VBdHRyaWJ1dGVzIHNoYXJlZFN1cmZhY2VBdHRyaWJ1dGVz ID0gR0xQbGF0Zm9ybVN1cmZhY2U6OkRlZmF1bHQ7CiAgICAgICAgIG1fc2l6ZSA9IHNpemU7CiAK QEAgLTIwNCw2ICsyMDUsNyBAQCBJbnRTaXplIEdyYXBoaWNzU3VyZmFjZTo6cGxhdGZvcm1TaXpl KCkgY29uc3QKIAogUGFzc1JlZlB0cjxHcmFwaGljc1N1cmZhY2U+IEdyYXBoaWNzU3VyZmFjZTo6 cGxhdGZvcm1DcmVhdGUoY29uc3QgSW50U2l6ZSYgc2l6ZSwgRmxhZ3MgZmxhZ3MsIGNvbnN0IFBs YXRmb3JtR3JhcGhpY3NDb250ZXh0M0Qgc2hhcmVDb250ZXh0KQogeworICAgIHByaW50ZigiR3Jh cGhpY3NTdXJmYWNlOjpwbGF0Zm9ybUNyZWF0ZVxuIik7CiAgICAgLy8gR3JhcGhpY3NTdXJmYWNl IGRvZXNuJ3QgeWV0IHN1cHBvcnQgY29weVRvVGV4dHVyZSBvciBzaW5nbGVidWZmZXJlZCBzdXJm YWNlLgogICAgIGlmIChmbGFncyAmIFN1cHBvcnRzQ29weVRvVGV4dHVyZSB8fCBmbGFncyAmIFN1 cHBvcnRzU2luZ2xlQnVmZmVyZWQpCiAgICAgICAgIHJldHVybiBQYXNzUmVmUHRyPEdyYXBoaWNz U3VyZmFjZT4oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3N1cmZhY2VzL2VnbC9FR0xTdXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3N1cmZhY2VzL2VnbC9FR0xTdXJmYWNlLmNwcAppbmRleCA3NmJlZDIyODgwZjRhYmY3 NWJhYjIyOGQ0YTE3ZDM1ZDQ4MmQ2NDNkLi4zYzMxZWI3ODhkYTJiZDViOGE0ZTFhMjI3MTQ5OWIx MDhhOTYzMTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9z dXJmYWNlcy9lZ2wvRUdMU3VyZmFjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc3VyZmFjZXMvZWdsL0VHTFN1cmZhY2UuY3BwCkBAIC00MCw2ICs0MCw3IEBAIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogc3RkOjp1bmlxdWVfcHRyPEdMVHJhbnNwb3J0U3VyZmFjZT4g RUdMVHJhbnNwb3J0U3VyZmFjZTo6Y3JlYXRlVHJhbnNwb3J0U3VyZmFjZShjb25zdCBJbnRTaXpl JiBzaXplLCBTdXJmYWNlQXR0cmlidXRlcyBhdHRyaWJ1dGVzKQogeworICAgIHByaW50ZigiRUdM VHJhbnNwb3J0U3VyZmFjZTo6Y3JlYXRlVHJhbnNwb3J0U3VyZmFjZVxuIik7CiAgICAgc3RkOjp1 bmlxdWVfcHRyPEdMVHJhbnNwb3J0U3VyZmFjZT4gc3VyZmFjZTsKICNpZiBQTEFURk9STShYMTEp CiAgICAgc3VyZmFjZSA9IHN0ZDo6bWFrZV91bmlxdWU8RUdMV2luZG93VHJhbnNwb3J0U3VyZmFj ZT4oc2l6ZSwgYXR0cmlidXRlcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9zdXJmYWNlcy9nbHgvWDExSGVscGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9YMTFIZWxwZXIuY3BwCmluZGV4IGZhOGM0YzAw OTUwZDBlZGY4MzcxNDI2OTE3M2Y1NGE5NDhlOTIwYzMuLmIwZmVjNmJhZmFiY2ExODJhY2FiZDBl ZDMxMTBhYzJmOWU0M2NlOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3N1cmZhY2VzL2dseC9YMTFIZWxwZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9YMTFIZWxwZXIuY3BwCkBAIC0yOTAsNiArMjkw LDEwIEBAIHZvaWQgWDExSGVscGVyOjpkZXN0cm95V2luZG93KGNvbnN0IHVpbnQzMl90IHdpbmRv d0lkKQogICAgIGlmICghZGlzcGxheSkKICAgICAgICAgcmV0dXJuOwogCisgICAgWFdpbmRvd0F0 dHJpYnV0ZXMgYXR0cmlidXRlOworICAgIFhHZXRXaW5kb3dBdHRyaWJ1dGVzKGRpc3BsYXksIHdp bmRvd0lkLCAmYXR0cmlidXRlKTsKKworICAgIFhGcmVlQ29sb3JtYXAoZGlzcGxheSwgYXR0cmli dXRlLmNvbG9ybWFwKTsKICAgICBYRGVzdHJveVdpbmRvdyhkaXNwbGF5LCB3aW5kb3dJZCk7CiB9 CiAK 269713 2016-01-24 18:22:11 -0800 2016-02-01 16:46:39 -0800 Patch bug-153413-20160125112204.patch text/plain 1626 sunny.nam U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODU2YjJhZjQxMDFkMzkz OGJlNjU0M2VhODAyODc1MDU1MGQyOWJhYy4uYWNhOTJiYTUxZGYyMjAzY2VkNmViOWFjMWJmOTM5 YWRiZjg2ODA3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAxLTI0ICBTdW4t d29vIE5hbSAgPHN1bm55Lm5hbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGcmVlIENvbG9ybWFw IHdoZW4gWFdpbmRvdyBpcyBkZXN0cm95ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTM0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb2xvcm1hcCBpcyBuZWVkZWQgdG8gY3JlYXRlIFhXaW5kb3cg YW5kIGl0IHNob3VsZCBiZSBmcmVlZCB3aGVuIFhXaW5kb3cgaXMgZGVzdHJveWVkLgorICAgICAg ICBVbmxlc3MgQ29sb3JtYXAgaXMgZnJlZWQgYmVmb3JlIGRlc3Ryb3lpbmcgWFdpbmRvdywgbWVt b3J5IGxlYWsgaXMgc3VzcGVjdGVkLgorICAgICAgICBYRnJlZUNvbG9ybWFwIHRoZXJlZm9yZSBp cyBuZWVkZWQgb24gWDExSGVscGVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc3Vy ZmFjZXMvZ2x4L1gxMUhlbHBlci5jcHA6IEFkZGVkIFhGcmVlQ29sb3JtYXAuCisgICAgICAgIChX ZWJDb3JlOjpYMTFIZWxwZXI6OmRlc3Ryb3lXaW5kb3cpOgorCiAyMDE2LTAxLTI0ICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlIGR1bXBl ZCBkaXNwbGF5IGxpc3QgcmVwcmVzZW50YXRpb24gYSBiaXQgbW9yZSBjb21wYWN0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9zdXJmYWNlcy9nbHgvWDExSGVs cGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9Y MTFIZWxwZXIuY3BwCmluZGV4IGZhOGM0YzAwOTUwZDBlZGY4MzcxNDI2OTE3M2Y1NGE5NDhlOTIw YzMuLmIwZmVjNmJhZmFiY2ExODJhY2FiZDBlZDMxMTBhYzJmOWU0M2NlOWMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9YMTFIZWxwZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3N1cmZhY2VzL2dseC9Y MTFIZWxwZXIuY3BwCkBAIC0yOTAsNiArMjkwLDEwIEBAIHZvaWQgWDExSGVscGVyOjpkZXN0cm95 V2luZG93KGNvbnN0IHVpbnQzMl90IHdpbmRvd0lkKQogICAgIGlmICghZGlzcGxheSkKICAgICAg ICAgcmV0dXJuOwogCisgICAgWFdpbmRvd0F0dHJpYnV0ZXMgYXR0cmlidXRlOworICAgIFhHZXRX aW5kb3dBdHRyaWJ1dGVzKGRpc3BsYXksIHdpbmRvd0lkLCAmYXR0cmlidXRlKTsKKworICAgIFhG cmVlQ29sb3JtYXAoZGlzcGxheSwgYXR0cmlidXRlLmNvbG9ybWFwKTsKICAgICBYRGVzdHJveVdp bmRvdyhkaXNwbGF5LCB3aW5kb3dJZCk7CiB9CiAK