153365 2016-01-22 11:55:31 -0800 AX: Crash in setTextMarkerDataWithCharacterOffset 2016-01-22 12:53:46 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 n_wang webkit-unassigned aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig jdiggs mario n_wang samuel_white webkit-bug-importer oldest_to_newest 1157767 0 n_wang 2016-01-22 11:55:31 -0800 We should add a null check for the accessibilityObject in setTextMarkerDataWithCharacterOffset. 1157768 1 n_wang 2016-01-22 11:55:42 -0800 <rdar://problem/24287924> 1157771 2 269597 n_wang 2016-01-22 12:03:47 -0800 Created attachment 269597 patch 1157782 3 269597 commit-queue 2016-01-22 12:53:42 -0800 Comment on attachment 269597 patch Clearing flags on attachment: 269597 Committed r195468: <http://trac.webkit.org/changeset/195468> 1157783 4 commit-queue 2016-01-22 12:53:46 -0800 All reviewed patches have been landed. Closing bug. 269597 2016-01-22 12:03:47 -0800 2016-01-22 12:53:42 -0800 patch patch.txt text/plain 4748 n_wang SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NTQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTIyICBOYW4gV2Fu ZyAgPG5fd2FuZ0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IENyYXNoIGluIHNldFRleHRNYXJr ZXJEYXRhV2l0aENoYXJhY3Rlck9mZnNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMzY1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDI4Nzky ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTb21l dGltZXMgd2hlbiB3ZSB0cnkgdG8gY3JlYXRlIGEgdGV4dCBtYXJrZXIgcmFuZ2UgZnJvbSBhIHN0 YWxlIHRleHQgbWFya2VyIHdpdGggYSByZW1vdmVkCisgICAgICAgIG5vZGUsIGl0IHdpbGwgY2F1 c2UgY3Jhc2guIEZpeGVkIGl0IGJ5IGFkZGluZyBhIG51bGwgY2hlY2sgZm9yIHRoZSBBY2Nlc3Np YmlsaXR5T2JqZWN0IHdlCisgICAgICAgIGNyZWF0ZSBpbiBzZXRUZXh0TWFya2VyRGF0YVdpdGhD aGFyYWN0ZXJPZmZzZXQuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJpbGl0eS90ZXh0LW1hcmtl ci90ZXh0LW1hcmtlci1yYW5nZS13aXRoLXJlbW92ZWQtbm9kZS1jcmFzaC5odG1sCisKKyAgICAg ICAgKiBhY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QVhPYmplY3RDYWNoZTo6c2V0VGV4dE1hcmtlckRhdGFXaXRoQ2hhcmFjdGVyT2Zmc2V0KToKKwog MjAxNi0wMS0yMiAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAg ICAgIEFYOiA8Y29kZT4gZ3JvdXAgYW5kIGZyaWVuZHMgc2hvdWxkIGhhdmUgYSBjdXN0b20gc3Vi cm9sZQpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuY3BwCShyZXZpc2lvbiAxOTU0MTEpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FYT2JqZWN0Q2FjaGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjE2LDYgKzE2MTYsOCBAQCB2 b2lkIEFYT2JqZWN0Q2FjaGU6OnNldFRleHRNYXJrZXJEYXRhV2l0CiAgICAgfQogICAgIAogICAg IFJlZlB0cjxBY2Nlc3NpYmlsaXR5T2JqZWN0PiBvYmogPSB0aGlzLT5nZXRPckNyZWF0ZShkb21O b2RlKTsKKyAgICBpZiAoIW9iaikKKyAgICAgICAgcmV0dXJuOwogICAgIAogICAgIC8vIENvbnZl cnQgdG8gdmlzaWJsZSBwb3NpdGlvbi4KICAgICBWaXNpYmxlUG9zaXRpb24gdmlzaWJsZVBvc2l0 aW9uID0gdmlzaWJsZVBvc2l0aW9uRnJvbUNoYXJhY3Rlck9mZnNldChvYmouZ2V0KCksIGNoYXJh Y3Rlck9mZnNldCk7CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxOTU0MTEpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNi0wMS0yMiAgTmFu IFdhbmcgIDxuX3dhbmdAYXBwbGUuY29tPgorCisgICAgICAgIEFYOiBDcmFzaCBpbiBzZXRUZXh0 TWFya2VyRGF0YVdpdGhDaGFyYWN0ZXJPZmZzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzM2NQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjQy ODc5MjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBhY2Nlc3NpYmlsaXR5L3RleHQtbWFya2VyL3RleHQtbWFya2VyLXJhbmdlLXdpdGgtcmVtb3Zl ZC1ub2RlLWNyYXNoLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS90ZXh0LW1hcmtlci90ZXh0LW1hcmtlci1yYW5nZS13aXRoLXJlbW92ZWQtbm9kZS1jcmFzaC5o dG1sOiBBZGRlZC4KKwogMjAxNi0wMS0yMSAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxh d2FAYXBwbGUuY29tPgogCiAgICAgICAgIEEgY3Jhc2ggcmVwcm9kdWNpYmxlIGluIFBhdGg6Omlz RW1wdHkoKSB1bmRlciBSZW5kZXJTVkdTaGFwZTo6cGFpbnQoKQpJbmRleDogTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS90ZXh0LW1hcmtlci90ZXh0LW1hcmtlci1yYW5nZS13aXRoLXJlbW92ZWQt bm9kZS1jcmFzaC1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS90ZXh0LW1hcmtlci90ZXh0LW1hcmtlci1yYW5nZS13aXRoLXJlbW92ZWQtbm9kZS1j cmFzaC1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L3RleHQtbWFya2VyL3RleHQtbWFya2VyLXJhbmdlLXdpdGgtcmVtb3ZlZC1ub2RlLWNyYXNo LWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDEwIEBACitUaGlzIHRlc3Rz IHRoYXQgd2hlbiB3ZSBjcmVhdGUgYSB0ZXh0IG1hcmtlciByYW5nZSBmcm9tIGEgbWFya2VyIHdp dGggcmVtb3ZlZCB0ZXh0IG5vZGUsIGl0IHdvbid0IGNyYXNoLgorCitPbiBzdWNjZXNzLCB5b3Ug d2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBD T01QTEVURSIuCisKKwordGV4dCB0byBiZSByZW1vdmVkCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNl ZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS90ZXh0LW1hcmtlci90ZXh0LW1hcmtlci1yYW5nZS13aXRoLXJlbW92ZWQtbm9kZS1jcmFz aC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdGV4dC1tYXJr ZXIvdGV4dC1tYXJrZXItcmFuZ2Utd2l0aC1yZW1vdmVkLW5vZGUtY3Jhc2guaHRtbAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvdGV4dC1tYXJrZXIvdGV4dC1tYXJr ZXItcmFuZ2Utd2l0aC1yZW1vdmVkLW5vZGUtY3Jhc2guaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDM3IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9F TiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+CisKKzxib2R5IGlkPSJib2R5Ij4KKworPGRpdiBp ZD0idG9CZVJlbW92ZWQiPnRleHQgdG8gYmUgcmVtb3ZlZDwvZGl2PgorCis8cCBpZD0iZGVzY3Jp cHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorCisgICAg ZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB3aGVuIHdlIGNyZWF0ZSBhIHRleHQgbWFya2Vy IHJhbmdlIGZyb20gYSBtYXJrZXIgd2l0aCByZW1vdmVkIHRleHQgbm9kZSwgaXQgd29uJ3QgY3Jh c2guIik7CisKKyAgICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisKKyAg ICAgICAgICB2YXIgdGV4dEVsZW1lbnQgPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3Np YmxlRWxlbWVudEJ5SWQoInRvQmVSZW1vdmVkIik7CisgICAgICAgICAgdmFyIHRleHRNYXJrZXJS YW5nZSA9IHRleHRFbGVtZW50LnRleHRNYXJrZXJSYW5nZUZvckVsZW1lbnQodGV4dEVsZW1lbnQp OworICAgICAgICAgIGRlYnVnKHRleHRFbGVtZW50LnN0cmluZ0ZvclRleHRNYXJrZXJSYW5nZSh0 ZXh0TWFya2VyUmFuZ2UpKTsKKyAgICAgICAgICAKKyAgICAgICAgICB2YXIgc3RhcnRNYXJrZXIg PSB0ZXh0RWxlbWVudC5zdGFydFRleHRNYXJrZXJGb3JUZXh0TWFya2VyUmFuZ2UodGV4dE1hcmtl clJhbmdlKTsKKyAgICAgICAgICB2YXIgZW5kTWFya2VyID0gdGV4dEVsZW1lbnQuZW5kVGV4dE1h cmtlckZvclRleHRNYXJrZXJSYW5nZSh0ZXh0TWFya2VyUmFuZ2UpOworICAgICAgICAgIAorICAg ICAgICAgIC8vIFJlbW92ZSB0aGUgdGV4dCBub2RlIGFuZCByZWNyZWF0ZSBhIHRleHQgbWFya2Vy IHJhbmdlLCBtYWtlIHN1cmUgaXQgd29uJ3QgY3Jhc2guCisgICAgICAgICAgdmFyIHRleHQgPSBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgidG9CZVJlbW92ZWQiKTsKKyAgICAgICAgICB0ZXh0LnJl bW92ZUNoaWxkKHRleHQuZmlyc3RDaGlsZCk7CisgICAgICAgICAgdGV4dE1hcmtlclJhbmdlID0g dGV4dEVsZW1lbnQudGV4dE1hcmtlclJhbmdlRm9yTWFya2VycyhzdGFydE1hcmtlciwgZW5kTWFy a2VyKTsKKyAgICB9CisKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQo=