153350 2016-01-22 02:17:43 -0800 Fix the !ENABLE(INDEXED_DATABASE) build after r195443 2016-01-22 08:49:07 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 153318 1 ossy ossy achristensen beidson commit-queue ossy oldest_to_newest 1157627 0 ossy 2016-01-22 02:17:43 -0800 http://trac.webkit.org/changeset/195443 broke the !ENABLE(INDEXED_DATABASE) build, including the Apple Windows and the WinCairo build too. 1157628 1 269561 ossy 2016-01-22 02:18:52 -0800 Created attachment 269561 Patch for landing 1157631 2 ossy 2016-01-22 02:23:08 -0800 just to document, build logs can be found here: - https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/53084 - https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/75280 Otherwise please check the EWS before landing and the waterfall after landing a patch to avoid build breaks. 1157644 3 269561 commit-queue 2016-01-22 03:06:15 -0800 Comment on attachment 269561 Patch for landing Clearing flags on attachment: 269561 Committed r195449: <http://trac.webkit.org/changeset/195449> 1157645 4 commit-queue 2016-01-22 03:06:17 -0800 All reviewed patches have been landed. Closing bug. 1157674 5 beidson 2016-01-22 08:49:07 -0800 (In reply to comment #2) > just to document, build logs can be found here: > - https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/53084 > - > https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/ > 75280 > > Otherwise please check the EWS before landing and the > waterfall after landing a patch to avoid build breaks. EWS was in epically bad shape last night due to the server spitting 503s and having to be rebooted, and the commit queue is actually what landed this patch. I've been tooting this horn for years now - If we are going to rely on tools, the tools have to actually do the job perfectly (or at least better than an attentive person would). And they are far from that standard. See: The Automation Paradox. Sorry about the break and thanks for the fix. 269561 2016-01-22 02:18:52 -0800 2016-01-22 03:06:15 -0800 Patch for landing bug-153350-20160122021823.patch text/plain 1239 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTlhZjY0NmUwM2JlZDYz NmJhMDliYjcxNmIzN2Q2NjBhMWEyNmQ1ZS4uYzcxZTdjZjIzZGQwMGQyNDAyZGUyNGNjNzUxZGE0 N2Q1NzExY2M0MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAxLTIyICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAhRU5B QkxFKElOREVYRURfREFUQUJBU0UpIGJ1aWxkIGFmdGVyIHIxOTU0NDMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzM1MAorCisgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGRmaXguCisKKyAgICAgICAgKiBwYWdlL1BhZ2UuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UGFnZTo6c2V0U2Vzc2lvbklEKToKKwogMjAxNi0wMS0yMiAgQ2hhbmdTZW9rIE9oICA8 Y2hhbmdzZW9rLm9oQGNvbGxhYm9yYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVtb3ZlIGEgZm9j dXMgcmluZyBvbiBhbmNob3Igbm9kZSB3aGVuIGZvY3VzZWQgYnkgbW91c2UuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9QYWdl LmNwcAppbmRleCAzY2QyZWFhMzE5ZmIxOGYzZjFlMGEyYmM5YzZiYmE2NjdhZDk4NTNjLi43MTE5 ZTQzNWQ0MjE0NThhMjIxNzM1ZTYwNDUwNzgwZmIzMjkxNjI5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAK QEAgLTE3MzUsOCArMTczNSwxMCBAQCB2b2lkIFBhZ2U6OnNldFNlc3Npb25JRChTZXNzaW9uSUQg c2Vzc2lvbklEKQogewogICAgIEFTU0VSVChzZXNzaW9uSUQuaXNWYWxpZCgpKTsKIAorI2lmIEVO QUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIGlmIChzZXNzaW9uSUQgIT0gbV9zZXNzaW9uSUQp CiAgICAgICAgIG1faWRiSURCQ29ubmVjdGlvblRvU2VydmVyID0gbnVsbHB0cjsKKyNlbmRpZgog CiAgICAgYm9vbCBwcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5nZWQgPSAoc2Vzc2lvbklELmlzRXBo ZW1lcmFsKCkgIT0gbV9zZXNzaW9uSUQuaXNFcGhlbWVyYWwoKSk7CiAK