153331 2016-01-21 16:22:51 -0800 Handle soft spaces after accepted candidates 2016-01-25 12:32:58 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned bdakin commit-queue enrica sam simon.fraser thorton oldest_to_newest 1157489 0 bdakin 2016-01-21 16:22:51 -0800 Handle soft spaces after accepted candidates rdar://problem/23958418 1157498 1 269518 bdakin 2016-01-21 16:35:35 -0800 Created attachment 269518 Patch 1157507 2 commit-queue 2016-01-21 17:15:51 -0800 Attachment 269518 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:3526: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style. 1158125 3 269518 darin 2016-01-24 11:58:35 -0800 Comment on attachment 269518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269518&action=review > Source/WebCore/editing/Editor.cpp:3567 > + if (!acceptedCandidate.replacement.endsWith(" ")) Should be endsWith(' ') to avoid unnecessary work. > Source/WebCore/editing/Editor.cpp:3568 > + insertText(String(" "), 0); Should be ASCIILiteral instead of String, although not sure how helpful that optimization is in cases like this. 1158433 4 269518 simon.fraser 2016-01-25 11:59:41 -0800 Comment on attachment 269518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269518&action=review > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:638 > + NSRange m_softSpaceRange; Can this be initialized with { NSNotFound, 0 } ? 1158445 5 bdakin 2016-01-25 12:30:26 -0800 Thanks Darin and Simon! http://trac.webkit.org/changeset/195547 1158446 6 bdakin 2016-01-25 12:32:58 -0800 (In reply to comment #5) > Thanks Darin and Simon! http://trac.webkit.org/changeset/195547 I should note that I made all of the suggested changes. 269518 2016-01-21 16:35:35 -0800 2016-01-24 11:58:35 -0800 Patch for-review.txt text/plain 7034 bdakin SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NTQyOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTIxICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgc29mdCBzcGFjZXMgYWZ0 ZXIgYWNjZXB0ZWQgY2FuZGlkYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUzMzMxCisgICAgICAgIC1hbmQgY29ycmVzcG9uZGluZy0KKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMjM5NTg0MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDYW5kaWRhdGVzIG5vdyBjb21lIHdpdGggYnVpbHQtaW4gc3Bh Y2VzLCBzbyB3ZSBzaG91bGQgbm90IGluc2VydCBhIHNwYWNlIGZvciAKKyAgICAgICAgdGhlbS4K KyAgICAgICAgKiBlZGl0aW5nL0VkaXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFZGl0b3I6 OmhhbmRsZUFjY2VwdGVkQ2FuZGlkYXRlKToKKworICAgICAgICBOZXcgU1BJIHRvIHByb3Blcmx5 IGhhbmRsZSB0aGVzZSBzb2Z0IHNwYWNlcy4KKyAgICAgICAgKiBwbGF0Zm9ybS9zcGkvbWFjL05T U3BlbGxDaGVja2VyU1BJLmg6CisKIDIwMTYtMDEtMjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBw bGUuY29tPgogCiAgICAgICAgIEFkZCB0aGUgYWJpbGl0eSB0byB1cGRhdGUgV2ViS2l0QWRkaXRp b25zIHRvIFdLMgpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcAkocmV2aXNpb24gMTk1 NDE2KQorKysgU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zNTYyLDcgKzM1NjIsMTAgQEAgdm9pZCBFZGl0b3I6OmhhbmRsZUFjY2VwdGVkQ2FuZGlk YXRlKFRleAogICAgICAgICBtX2ZyYW1lLnNlbGVjdGlvbigpLnNldFNlbGVjdGVkUmFuZ2UoY2Fu ZGlkYXRlUmFuZ2UuZ2V0KCksIFVQU1RSRUFNLCB0cnVlKTsKIAogICAgIGluc2VydFRleHQoYWNj ZXB0ZWRDYW5kaWRhdGUucmVwbGFjZW1lbnQsIDApOwotICAgIGluc2VydFRleHQoU3RyaW5nKCIg IiksIDApOworCisgICAgLy8gU29tZSBjYW5kaWRhdGVzIGNvbWUgd2l0aCBhIHNwYWNlIGJ1aWx0 IGluLCBhbmQgd2UgZG8gbm90IG5lZWQgdG8gYWRkIGFub3RoZXIgc3BhY2UgaW4gdGhhdCBjYXNl LgorICAgIGlmICghYWNjZXB0ZWRDYW5kaWRhdGUucmVwbGFjZW1lbnQuZW5kc1dpdGgoIiAiKSkK KyAgICAgICAgaW5zZXJ0VGV4dChTdHJpbmcoIiAiKSwgMCk7CiB9CiAKIGJvb2wgRWRpdG9yOjp1 bmlmaWVkVGV4dENoZWNrZXJFbmFibGVkKCkgY29uc3QKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL3NwaS9tYWMvTlNTcGVsbENoZWNrZXJTUEkuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9zcGkvbWFjL05TU3BlbGxDaGVja2VyU1BJLmgJKHJldmlzaW9uIDE5 NTQyMSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9tYWMvTlNTcGVsbENoZWNrZXJT UEkuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsNiArMzEsNyBAQAogCiBAaW50ZXJmYWNlIE5TU3Bl bGxDaGVja2VyICgpCiAtIChOU0ludGVnZXIpcmVxdWVzdENhbmRpZGF0ZXNGb3JTZWxlY3RlZFJh bmdlOihOU1JhbmdlKXNlbGVjdGVkUmFuZ2UgaW5TdHJpbmc6KE5TU3RyaW5nICopc3RyaW5nVG9D aGVjayB0eXBlczooTlNUZXh0Q2hlY2tpbmdUeXBlcyljaGVja2luZ1R5cGVzIG9wdGlvbnM6KE5T RGljdGlvbmFyeTxOU1N0cmluZyAqLCBpZD4gKilvcHRpb25zIGluU3BlbGxEb2N1bWVudFdpdGhU YWc6KE5TSW50ZWdlcil0YWcgY29tcGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5TSW50ZWdlciBz ZXF1ZW5jZU51bWJlciwgTlNBcnJheTxOU1RleHRDaGVja2luZ1Jlc3VsdCAqPiAqY2FuZGlkYXRl cykpY29tcGxldGlvbkhhbmRsZXI7CistIChCT09MKWRlbGV0ZXNBdXRvc3BhY2VCZWZvcmVTdHJp bmc6KE5TU3RyaW5nICopc3RyaW5nIGxhbmd1YWdlOihOU1N0cmluZyAqKWxhbmd1YWdlOwogQGVu ZAogCiAjZW5kaWYgLy8gUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JF UVVJUkVEID49IDEwMjAwMApJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1NDI4KQorKysgU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIw MTYtMDEtMjEgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisgICAgICAgIEhhbmRs ZSBzb2Z0IHNwYWNlcyBhZnRlciBhY2NlcHRlZCBjYW5kaWRhdGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMzMzEKKyAgICAgICAgLWFuZCBjb3Jy ZXNwb25kaW5nLQorICAgICAgICByZGFyOi8vcHJvYmxlbS8yMzk1ODQxOAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5ldyBtZW1iZXIgdmFyaWFibGUg bV9zb2Z0U3BhY2VSYW5nZSBrZWVwcyB0cmFjayB0byB0aGUgTlNSYW5nZSBvZiBhIHNvZnQgCisg ICAgICAgIHNwYWNlIGlmIHRoZSBsYXN0IHRleHQgdGhhdCB3YXMgaW5zZXJ0ZWQgaGFzIGEgc29m dCBzcGFjZSBhdCB0aGUgZW5kLgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1w bC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OldlYlZpZXdJbXBsKToKKworICAgICAgICBUaGUgc3BhY2Ug YXQgdGhlIGVuZCBvZiBjYW5kaWRhdGVzIGlzIGEgc29mdCBzcGFjZS4gSWYgdGhhdCBzcGFjZSBl eGlzdHMsIAorICAgICAgICBjYWNoZSB0aGUgcmFuZ2Ugb2YgdGhlIHNwYWNlIGluIG1fc29mdFNw YWNlUmFuZ2UuCisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpoYW5kbGVBY2NlcHRlZENh bmRpZGF0ZSk6CisKKyAgICAgICAgV2hlbiBuZXcgdGV4dCBpcyBpbnNlcnRlZCwgZmluZCBvdXQg aWYgaXQgaXMgYmVpbmcgaW5zZXJ0ZWQgcmlnaHQgYWZ0ZXIgYSAKKyAgICAgICAgc29mdCBzcGFj ZS4gSWYgaXQgaXMsIHRoZW4gW05TU3BlbGxDaGVja2VyIGRlbGV0ZXNBdXRvc3BhY2VCZWZvcmVT dHJpbmddIHdpbGwgCisgICAgICAgIHRlbGwgdXMgaWYgdGhlIHNwYWNlIG5lZWRzIHRvIGJlIHJl bW92ZWQuIElmIHRoYXQgaXMgdGhlIGNhc2UsIHRoZW4gc2V0IHRoZSAKKyAgICAgICAgcmVwbGFj ZW1lbnRTdHJpbmcgdG8gdGhlIHNvZnQgc3BhY2UuCisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJ bXBsOjppbnNlcnRUZXh0KToKKwogMjAxNi0wMS0yMSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBs ZS5jb20+CiAKICAgICAgICAgW2lPU10gQ3Jhc2ggaW4gX2VuZFBvdGVudGlhbFRhcEFuZEVuYWJs ZURvdWJsZVRhcEdlc3R1cmVzSWZOZWNlc3NhcnkKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oCShyZXZpc2lvbiAxOTU0MjEpCisrKyBTb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwuaAkod29ya2luZyBjb3B5KQpAQCAt NjM1LDYgKzYzNSw3IEBAIHByaXZhdGU6CiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMDEyMDAKICAgICBTdHJpbmcgbV9sYXN0U3RyaW5nRm9yQ2FuZGlkYXRlUmVxdWVz dDsKICNlbmRpZgorICAgIE5TUmFuZ2UgbV9zb2Z0U3BhY2VSYW5nZTsKIH07CiAgICAgCiB9IC8v IG5hbWVzcGFjZSBXZWJLaXQKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9X ZWJWaWV3SW1wbC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29j b2EvV2ViVmlld0ltcGwubW0JKHJldmlzaW9uIDE5NTQyMSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQkod29ya2luZyBjb3B5KQpAQCAtNDkyLDYgKzQ5 Miw4IEBAIFdlYlZpZXdJbXBsOjpXZWJWaWV3SW1wbChOU1ZpZXcgPFdlYlZpZXcKICAgICBtX3Zp ZXcubGF5ZXJDb250ZW50c1BsYWNlbWVudCA9IE5TVmlld0xheWVyQ29udGVudHNQbGFjZW1lbnRU b3BMZWZ0OwogCiAgICAgV2ViUHJvY2Vzc1Bvb2w6OnN0YXRpc3RpY3MoKS53a1ZpZXdDb3VudCsr OworCisgICAgbV9zb2Z0U3BhY2VSYW5nZSA9IE5TTWFrZVJhbmdlKE5TTm90Rm91bmQsIDApOwog fQogCiBXZWJWaWV3SW1wbDo6fldlYlZpZXdJbXBsKCkKQEAgLTIyMTAsNiArMjIxMiwxNCBAQCB2 b2lkIFdlYlZpZXdJbXBsOjpoYW5kbGVBY2NlcHRlZENhbmRpZGF0CiAgICAgaWYgKG1fbGFzdFN0 cmluZ0ZvckNhbmRpZGF0ZVJlcXVlc3QgIT0gcG9zdExheW91dERhdGEuc3RyaW5nRm9yQ2FuZGlk YXRlUmVxdWVzdCkKICAgICAgICAgcmV0dXJuOwogCisgICAgTlNSYW5nZSByYW5nZSA9IFthY2Nl cHRlZENhbmRpZGF0ZSByYW5nZV07CisgICAgaWYgKGFjY2VwdGVkQ2FuZGlkYXRlLnJlcGxhY2Vt ZW50U3RyaW5nICYmIFthY2NlcHRlZENhbmRpZGF0ZS5yZXBsYWNlbWVudFN0cmluZyBsZW5ndGhd ID4gMCkgeworICAgICAgICBOU1JhbmdlIHJlcGxhY2VkUmFuZ2UgPSBOU01ha2VSYW5nZShyYW5n ZS5sb2NhdGlvbiwgW2FjY2VwdGVkQ2FuZGlkYXRlLnJlcGxhY2VtZW50U3RyaW5nIGxlbmd0aF0p OworICAgICAgICBOU1JhbmdlIHNvZnRTcGFjZVJhbmdlID0gTlNNYWtlUmFuZ2UoTlNNYXhSYW5n ZShyZXBsYWNlZFJhbmdlKSAtIDEsIDEpOworICAgICAgICBpZiAoW2FjY2VwdGVkQ2FuZGlkYXRl LnJlcGxhY2VtZW50U3RyaW5nIGhhc1N1ZmZpeDpAIiAiXSkKKyAgICAgICAgICAgIG1fc29mdFNw YWNlUmFuZ2UgPSBzb2Z0U3BhY2VSYW5nZTsKKyAgICB9CisKICAgICBtX3BhZ2UtPmhhbmRsZUFj Y2VwdGVkQ2FuZGlkYXRlKHRleHRDaGVja2luZ1Jlc3VsdEZyb21OU1RleHRDaGVja2luZ1Jlc3Vs dChhY2NlcHRlZENhbmRpZGF0ZSkpOwogfQogI2VuZGlmIC8vIF9fTUFDX09TX1hfVkVSU0lPTl9N SU5fUkVRVUlSRUQgPj0gMTAxMjAwCkBAIC0zNTExLDEzICszNTIxLDIyIEBAIHZvaWQgV2ViVmll d0ltcGw6Omluc2VydFRleHQoaWQgc3RyaW5nLCAKICAgICB9IGVsc2UKICAgICAgICAgdGV4dCA9 IHN0cmluZzsKIAorICAgIEJPT0wgbmVlZFRvUmVtb3ZlU29mdFNwYWNlID0gTk87CisjaWYgX19N QUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDEyMDAKKyAgICBpZiAobV9zb2Z0U3Bh Y2VSYW5nZS5sb2NhdGlvbiAhPSBOU05vdEZvdW5kICYmIChyZXBsYWNlbWVudFJhbmdlLmxvY2F0 aW9uID09IE5TTWF4UmFuZ2UobV9zb2Z0U3BhY2VSYW5nZSkgfHwgcmVwbGFjZW1lbnRSYW5nZS5s b2NhdGlvbiA9PSBOU05vdEZvdW5kKSAmJiByZXBsYWNlbWVudFJhbmdlLmxlbmd0aCA9PSAwICYm IFtbTlNTcGVsbENoZWNrZXIgc2hhcmVkU3BlbGxDaGVja2VyXSBkZWxldGVzQXV0b3NwYWNlQmVm b3JlU3RyaW5nOnRleHQgbGFuZ3VhZ2U6bmlsXSkgeworICAgICAgICByZXBsYWNlbWVudFJhbmdl ID0gbV9zb2Z0U3BhY2VSYW5nZTsKKyAgICAgICAgbmVlZFRvUmVtb3ZlU29mdFNwYWNlID0gWUVT OworICAgIH0KKyNlbmRpZgorICAgIG1fc29mdFNwYWNlUmFuZ2UgPSBOU01ha2VSYW5nZShOU05v dEZvdW5kLCAwKTsKKwogICAgIC8vIGluc2VydFRleHQgY2FuIGJlIGNhbGxlZCBmb3Igc2V2ZXJh bCByZWFzb25zOgogICAgIC8vIC0gSWYgaXQncyBmcm9tIG5vcm1hbCBrZXkgZXZlbnQgcHJvY2Vz c2luZyAoaW5jbHVkaW5nIGtleSBiaW5kaW5ncyksIHdlIHNhdmUgdGhlIGFjdGlvbiB0byBwZXJm b3JtIGl0IGxhdGVyLgogICAgIC8vIC0gSWYgaXQncyBmcm9tIGFuIGlucHV0IG1ldGhvZCwgdGhl biB3ZSBzaG91bGQgaW5zZXJ0IHRoZSB0ZXh0IG5vdy4KICAgICAvLyAtIElmIGl0J3Mgc2VudCBv dXRzaWRlIG9mIGtleWJvYXJkIGV2ZW50IHByb2Nlc3NpbmcgKGUuZy4gZnJvbSBDaGFyYWN0ZXIg Vmlld2VyLCBvciB3aGVuIGNvbmZpcm1pbmcgYW4gaW5saW5lIGlucHV0IGFyZWEgd2l0aCBhIG1v dXNlKSwKICAgICAvLyB0aGVuIHdlIGFsc28gZXhlY3V0ZSBpdCBpbW1lZGlhdGVseSwgYXMgdGhl cmUgd2lsbCBiZSBubyBvdGhlciBjaGFuY2UuCiAgICAgVmVjdG9yPFdlYkNvcmU6OktleXByZXNz Q29tbWFuZD4qIGtleXByZXNzQ29tbWFuZHMgPSBtX2NvbGxlY3RlZEtleXByZXNzQ29tbWFuZHM7 Ci0gICAgaWYgKGtleXByZXNzQ29tbWFuZHMpIHsKKyAgICBpZiAoa2V5cHJlc3NDb21tYW5kcyAm JiAhbmVlZFRvUmVtb3ZlU29mdFNwYWNlKSB7CiAgICAgICAgIEFTU0VSVChyZXBsYWNlbWVudFJh bmdlLmxvY2F0aW9uID09IE5TTm90Rm91bmQpOwogICAgICAgICBXZWJDb3JlOjpLZXlwcmVzc0Nv bW1hbmQgY29tbWFuZCgiaW5zZXJ0VGV4dDoiLCB0ZXh0KTsKICAgICAgICAga2V5cHJlc3NDb21t YW5kcy0+YXBwZW5kKGNvbW1hbmQpOwo=