153326 2016-01-21 14:44:42 -0800 [iOS] Crash in _endPotentialTapAndEnableDoubleTapGesturesIfNecessary 2016-01-21 15:36:49 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dino dino oldest_to_newest 1157438 0 dino 2016-01-21 14:44:42 -0800 We're getting a lot of reports of crashes in -[WKContentView(WKInteraction) _endPotentialTapAndEnableDoubleTapGesturesIfNecessary] <rdar://problem/24264339> 1157451 1 269500 dino 2016-01-21 15:07:11 -0800 Created attachment 269500 Patch 1157457 2 269500 andersca 2016-01-21 15:17:05 -0800 Comment on attachment 269500 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269500&action=review > Source/WebKit2/UIProcess/ios/WKContentView.h:78 > +- (void)_disconnectWebView; Maybe call this _webViewDestroyed instead? > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1259 > - if (_webView._allowsDoubleTapGestures) > + if (_webView && _webView._allowsDoubleTapGestures) No need to check _webView for nil here. _allowsDoubleTapGestures will return false if _webView is nil. 1157466 3 dino 2016-01-21 15:36:49 -0800 Committed r195424: <http://trac.webkit.org/changeset/195424> 269500 2016-01-21 15:07:11 -0800 2016-01-21 15:17:05 -0800 Patch bug-153326-20160122100638.patch text/plain 3836 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1NDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTc5NmQ2ZDAwN2Q0MDlm OTkxYTk1ZmIxNzNlMjZlNzcyZTYyY2FlZi4uNjY4M2NhNWJmNGEwMTI4YjEwMDVmNjMwOGIyNDQ0 NmVkNzY4MjI3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE2LTAxLTIxICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBDcmFzaCBpbiBfZW5k UG90ZW50aWFsVGFwQW5kRW5hYmxlRG91YmxlVGFwR2VzdHVyZXNJZk5lY2Vzc2FyeQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMzI2CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yNDI2NDMzOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBVSUtpdCdzIFVJR2VzdHVyZVJlY29nbml6ZXIgY291bGQgY2Fs bCBiYWNrIGludG8gdGhlIFdLQ29udGVudFZpZXcKKyAgICAgICAgYWZ0ZXIgdGhlIGFzc29jaWF0 ZWQgV0tXZWJWaWV3IGhhcyBkaXNhcHBlYXJlZC4gVGhlIGZpeCBpcyB0bworICAgICAgICBleHBs aWNpdGx5IG51bGwgdGhlIFdLV2ViVmlldyByZWZlcmVuY2UgYXMgd2UgZGVhbGxvY2F0ZS4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAoLVtX S1dlYlZpZXcgZGVhbGxvY10pOiBUZWxsIHRoZSBXS0NvbnRlbnRWaWV3IHdlIGFyZSBnb2luZyBh d2F5LgorICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50Vmll dyBfZGlzY29ubmVjdFdlYlZpZXddKToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVu dFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZW5kUG90ZW50 aWFsVGFwQW5kRW5hYmxlRG91YmxlVGFwR2VzdHVyZXNJZk5lY2Vzc2FyeV0pOgorICAgICAgICBP bmx5IGRvIHNvbWV0aGluZyBpZiB0aGUgV0tXZWJWaWV3IGlzIHN0aWxsIGFyb3VuZC4KKwogMjAx Ni0wMS0xOSAgQWRhIENoYW4gIDxhZGFjaGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBNYWtlIGl0 IHBvc3NpYmxlIHRvIGVuYWJsZSBWSURFT19QUkVTRU5UQVRJT05fTU9ERSBvbiBvdGhlciBDb2Nv YSBwbGF0Zm9ybXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJWaWV3Lm1tCmluZGV4IDIyNzI3YTIzZDlmMTZkMzY1MWFmYTYxZDJlY2I0NmJiZDVhYTVmNDgu LmU4NjI5NDg0MjQ2Njc4NmQyZGMyN2U0ODI5ZWVmMjg3YjBkNWQ3NDUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCkBAIC00ODQsNiArNDg0 LDggQEAgc3RhdGljIFdlYkNvcmU6OkRhdGFEZXRlY3RvclR5cGVzIGZyb21XS0RhdGFEZXRlY3Rv clR5cGVzKHVpbnQzMl90IHR5cGVzKQogI2VuZGlmCiAKICNpZiBQTEFURk9STShJT1MpCisgICAg W19jb250ZW50VmlldyBfZGlzY29ubmVjdFdlYlZpZXddOworCiAgICAgaWYgKF9yZW1vdGVPYmpl Y3RSZWdpc3RyeSkKICAgICAgICAgX3BhZ2UtPnByb2Nlc3MoKS5wcm9jZXNzUG9vbCgpLnJlbW92 ZU1lc3NhZ2VSZWNlaXZlcihNZXNzYWdlczo6UmVtb3RlT2JqZWN0UmVnaXN0cnk6Om1lc3NhZ2VS ZWNlaXZlck5hbWUoKSwgX3BhZ2UtPnBhZ2VJRCgpKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXcuaAppbmRleCAwMzcwODZiMGYyZTZhMzRhNjliZDU4ODQw YzBjZTFlNDA1MWM1NjE2Li5jZmNlYWJkMWIwNjkxZjY4NzUwOGJlZmUyYWM0NDRiYzM2YWU0ZjVh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcu aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcuaApAQCAt NzUsNiArNzUsOCBAQCBjbGFzcyBXZWJQcm9jZXNzUG9vbDsKIC0gKHZvaWQpZGlkWm9vbVRvU2Nh bGU6KENHRmxvYXQpc2NhbGU7CiAtICh2b2lkKXdpbGxTdGFydFpvb21PclNjcm9sbDsKIAorLSAo dm9pZClfZGlzY29ubmVjdFdlYlZpZXc7CisKIC0gKHN0ZDo6dW5pcXVlX3B0cjxXZWJLaXQ6OkRy YXdpbmdBcmVhUHJveHk+KV9jcmVhdGVEcmF3aW5nQXJlYVByb3h5OwogLSAodm9pZClfcHJvY2Vz c0RpZEV4aXQ7CiAtICh2b2lkKV9kaWRSZWxhdW5jaFByb2Nlc3M7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggMmNhMmU0MGQxOTk0NTZlMWQz NDM5MmVhM2ZlYmYwZmIxMTU2MTU3Ny4uYTYxZjdmZWRmZDcwNzczOTQwYmEwZTZiYTMxY2YxNzVl OGQ5Mjc4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll dy5tbQpAQCAtNDUzLDYgKzQ1MywxMSBAQCBzdGF0aWMgdm9pZCBzdG9yZUFjY2Vzc2liaWxpdHlS ZW1vdGVDb25uZWN0aW9uSW5mb3JtYXRpb24oaWQgZWxlbWVudCwgcGlkX3QgcGlkLAogICAgIH0K IH0KIAorLSAodm9pZClfZGlzY29ubmVjdFdlYlZpZXcKK3sKKyAgICBfd2ViVmlldyA9IG5pbDsK K30KKwogI3ByYWdtYSBtYXJrIFBhZ2VDbGllbnRJbXBsIG1ldGhvZHMKIAogLSAoc3RkOjp1bmlx dWVfcHRyPERyYXdpbmdBcmVhUHJveHk+KV9jcmVhdGVEcmF3aW5nQXJlYVByb3h5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlv bi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0 aW9uLm1tCmluZGV4IDgzYTA3MjM1ODVhZTJhOTQzNDQ5ZGFmMWYyNzczYTAxNjFlMjI4OTYuLjgw NTdkYzVmOWE2YWUyZDQyZDBhODA2ZTc5MzE4NDE2OTczNTVhMDQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CkBAIC0xMjU2LDcgKzEyNTYsNyBAQCBzdGF0aWMgaW5saW5lIGJvb2wgaXNTYW1lUGFpcihVSUdl c3R1cmVSZWNvZ25pemVyICphLCBVSUdlc3R1cmVSZWNvZ25pemVyICpiLCBVSQogCiAtICh2b2lk KV9lbmRQb3RlbnRpYWxUYXBBbmRFbmFibGVEb3VibGVUYXBHZXN0dXJlc0lmTmVjZXNzYXJ5CiB7 Ci0gICAgaWYgKF93ZWJWaWV3Ll9hbGxvd3NEb3VibGVUYXBHZXN0dXJlcykKKyAgICBpZiAoX3dl YlZpZXcgJiYgX3dlYlZpZXcuX2FsbG93c0RvdWJsZVRhcEdlc3R1cmVzKQogICAgICAgICBbc2Vs ZiBfc2V0RG91YmxlVGFwR2VzdHVyZXNFbmFibGVkOllFU107CiAKICAgICBfcG90ZW50aWFsVGFw SW5Qcm9ncmVzcyA9IE5POwo=