153312 2016-01-21 11:25:00 -0800 [B3][Win64] Compile fixes. 2016-01-21 15:46:01 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1157370 0 peavo 2016-01-21 11:25:00 -0800 The MSVC runtime library has several overloads of sin, cos, pow, and log. We need to specify which overload we want to use. 1157372 1 269475 peavo 2016-01-21 11:31:28 -0800 Created attachment 269475 Patch 1157385 2 269475 achristensen 2016-01-21 12:07:41 -0800 Comment on attachment 269475 Patch This should be done the same way as https://bugs.webkit.org/show_bug.cgi?id=153127 1157395 3 269484 peavo 2016-01-21 12:55:18 -0800 Created attachment 269484 Patch 1157396 4 peavo 2016-01-21 12:55:59 -0800 (In reply to comment #2) > Comment on attachment 269475 [details] > Patch > > This should be done the same way as > https://bugs.webkit.org/show_bug.cgi?id=153127 Thanks for reviewing :) Updated patch. 1157441 5 commit-queue 2016-01-21 14:50:16 -0800 The commit-queue encountered the following flaky tests while processing attachment 269484: editing/selection/extend-selection-home-end.html bug 50944 (authors: kalman@chromium.org and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1157442 6 commit-queue 2016-01-21 14:50:18 -0800 The commit-queue encountered the following flaky tests while processing attachment 269484: The commit-queue is continuing to process your patch. 1157472 7 269484 commit-queue 2016-01-21 15:45:55 -0800 Comment on attachment 269484 Patch Clearing flags on attachment: 269484 Committed r195425: <http://trac.webkit.org/changeset/195425> 1157473 8 commit-queue 2016-01-21 15:46:01 -0800 All reviewed patches have been landed. Closing bug. 269475 2016-01-21 11:31:28 -0800 2016-01-21 12:55:09 -0800 Patch bug-153312-20160121203113.patch text/plain 2562 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1NDE2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTAxLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBbQjNdW1dpbjY0XSBDb21waWxlIGZpeGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgTVNWQyBoYXMgc2V2ZXJhbCBvdmVybG9hZHMg b2Ygc2luLCBjb3MsIHBvdywgYW5kIGxvZywgd2UgbmVlZCB0byBzcGVjaWZ5CisgICAgICAgIHdo aWNoIG9uZSB3ZSB3YW50IHRvIHVzZS4KKworICAgICAgICAqIGZ0bC9GVExCM091dHB1dC5oOgor ICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZG91YmxlU2luKToKKyAgICAgICAgKEpTQzo6RlRM OjpPdXRwdXQ6OmRvdWJsZUNvcyk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVQ b3cpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZG91YmxlTG9nKToKKwogMjAxNi0wMS0y MSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg YnVnIGluIFR5cGVkQXJyYXkucHJvdG90eXBlLnNldCBhbmQgYWRkIHRlc3RzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzT3V0cHV0LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExCM091dHB1dC5oCShyZXZpc2lvbiAxOTU0MTUpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzT3V0cHV0LmgJKHdvcmtpbmcgY29weSkKQEAg LTE1OCwxNiArMTU4LDE2IEBAIHB1YmxpYzoKICAgICBMVmFsdWUgZG91YmxlQWJzKExWYWx1ZSB2 YWx1ZSkgeyByZXR1cm4gbV9ibG9jay0+YXBwZW5kTmV3PEIzOjpWYWx1ZT4obV9wcm9jLCBCMzo6 QWJzLCBvcmlnaW4oKSwgdmFsdWUpOyB9CiAgICAgTFZhbHVlIGRvdWJsZUNlaWwoTFZhbHVlIG9w ZXJhbmQpIHsgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFsdWU+KG1fcHJvYywgQjM6 OkNlaWwsIG9yaWdpbigpLCBvcGVyYW5kKTsgfQogCi0gICAgTFZhbHVlIGRvdWJsZVNpbihMVmFs dWUgdmFsdWUpIHsgcmV0dXJuIGNhbGxXaXRob3V0U2lkZUVmZmVjdHMoQjM6OkRvdWJsZSwgc2lu LCB2YWx1ZSk7IH0KLSAgICBMVmFsdWUgZG91YmxlQ29zKExWYWx1ZSB2YWx1ZSkgeyByZXR1cm4g Y2FsbFdpdGhvdXRTaWRlRWZmZWN0cyhCMzo6RG91YmxlLCBjb3MsIHZhbHVlKTsgfQorICAgIExW YWx1ZSBkb3VibGVTaW4oTFZhbHVlIHZhbHVlKSB7IHJldHVybiBjYWxsV2l0aG91dFNpZGVFZmZl Y3RzKEIzOjpEb3VibGUsIHN0YXRpY19jYXN0PGRvdWJsZSgqKShkb3VibGUpPihzaW4pLCB2YWx1 ZSk7IH0KKyAgICBMVmFsdWUgZG91YmxlQ29zKExWYWx1ZSB2YWx1ZSkgeyByZXR1cm4gY2FsbFdp dGhvdXRTaWRlRWZmZWN0cyhCMzo6RG91YmxlLCBzdGF0aWNfY2FzdDxkb3VibGUoKikoZG91Ymxl KT4oY29zKSwgdmFsdWUpOyB9CiAKLSAgICBMVmFsdWUgZG91YmxlUG93KExWYWx1ZSB4T3BlcmFu ZCwgTFZhbHVlIHlPcGVyYW5kKSB7IHJldHVybiBjYWxsV2l0aG91dFNpZGVFZmZlY3RzKEIzOjpE b3VibGUsIHBvdywgeE9wZXJhbmQsIHlPcGVyYW5kKTsgfQorICAgIExWYWx1ZSBkb3VibGVQb3co TFZhbHVlIHhPcGVyYW5kLCBMVmFsdWUgeU9wZXJhbmQpIHsgcmV0dXJuIGNhbGxXaXRob3V0U2lk ZUVmZmVjdHMoQjM6OkRvdWJsZSwgc3RhdGljX2Nhc3Q8ZG91YmxlKCopKGRvdWJsZSwgZG91Ymxl KT4ocG93KSwgeE9wZXJhbmQsIHlPcGVyYW5kKTsgfQogCiAgICAgTFZhbHVlIGRvdWJsZVBvd2ko TFZhbHVlIHhPcGVyYW5kLCBMVmFsdWUgeU9wZXJhbmQpOwogCiAgICAgTFZhbHVlIGRvdWJsZVNx cnQoTFZhbHVlIHZhbHVlKSB7IHJldHVybiBtX2Jsb2NrLT5hcHBlbmROZXc8QjM6OlZhbHVlPiht X3Byb2MsIEIzOjpTcXJ0LCBvcmlnaW4oKSwgdmFsdWUpOyB9CiAKLSAgICBMVmFsdWUgZG91Ymxl TG9nKExWYWx1ZSB2YWx1ZSkgeyByZXR1cm4gY2FsbFdpdGhvdXRTaWRlRWZmZWN0cyhCMzo6RG91 YmxlLCBsb2csIHZhbHVlKTsgfQorICAgIExWYWx1ZSBkb3VibGVMb2coTFZhbHVlIHZhbHVlKSB7 IHJldHVybiBjYWxsV2l0aG91dFNpZGVFZmZlY3RzKEIzOjpEb3VibGUsIHN0YXRpY19jYXN0PGRv dWJsZSgqKShkb3VibGUpPihsb2cpLCB2YWx1ZSk7IH0KIAogICAgIHN0YXRpYyBib29sIGhhc1Nl bnNpYmxlRG91YmxlVG9JbnQoKTsKICAgICBMVmFsdWUgZG91YmxlVG9JbnQoTFZhbHVlKTsK 269484 2016-01-21 12:55:18 -0800 2016-01-21 15:45:55 -0800 Patch bug-153312-20160121215450.patch text/plain 2712 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1NDE2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTAxLTIxICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBbQjNdW1dpbjY0XSBDb21waWxlIGZpeGVzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU2luY2UgTVNWQyBoYXMgc2V2ZXJhbCBvdmVybG9hZHMg b2Ygc2luLCBjb3MsIHBvdywgYW5kIGxvZywgd2UgbmVlZCB0byBzcGVjaWZ5CisgICAgICAgIHdo aWNoIG9uZSB3ZSB3YW50IHRvIHVzZS4KKworICAgICAgICAqIGZ0bC9GVExCM091dHB1dC5oOgor ICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZG91YmxlU2luKToKKyAgICAgICAgKEpTQzo6RlRM OjpPdXRwdXQ6OmRvdWJsZUNvcyk6CisgICAgICAgIChKU0M6OkZUTDo6T3V0cHV0Ojpkb3VibGVQ b3cpOgorICAgICAgICAoSlNDOjpGVEw6Ok91dHB1dDo6ZG91YmxlTG9nKToKKwogMjAxNi0wMS0y MSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXgg YnVnIGluIFR5cGVkQXJyYXkucHJvdG90eXBlLnNldCBhbmQgYWRkIHRlc3RzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzT3V0cHV0LmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL2Z0bC9GVExCM091dHB1dC5oCShyZXZpc2lvbiAxOTU0MTUpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTEIzT3V0cHV0LmgJKHdvcmtpbmcgY29weSkKQEAg LTE1OCwxNiArMTU4LDMyIEBAIHB1YmxpYzoKICAgICBMVmFsdWUgZG91YmxlQWJzKExWYWx1ZSB2 YWx1ZSkgeyByZXR1cm4gbV9ibG9jay0+YXBwZW5kTmV3PEIzOjpWYWx1ZT4obV9wcm9jLCBCMzo6 QWJzLCBvcmlnaW4oKSwgdmFsdWUpOyB9CiAgICAgTFZhbHVlIGRvdWJsZUNlaWwoTFZhbHVlIG9w ZXJhbmQpIHsgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFsdWU+KG1fcHJvYywgQjM6 OkNlaWwsIG9yaWdpbigpLCBvcGVyYW5kKTsgfQogCi0gICAgTFZhbHVlIGRvdWJsZVNpbihMVmFs dWUgdmFsdWUpIHsgcmV0dXJuIGNhbGxXaXRob3V0U2lkZUVmZmVjdHMoQjM6OkRvdWJsZSwgc2lu LCB2YWx1ZSk7IH0KLSAgICBMVmFsdWUgZG91YmxlQ29zKExWYWx1ZSB2YWx1ZSkgeyByZXR1cm4g Y2FsbFdpdGhvdXRTaWRlRWZmZWN0cyhCMzo6RG91YmxlLCBjb3MsIHZhbHVlKTsgfQotCi0gICAg TFZhbHVlIGRvdWJsZVBvdyhMVmFsdWUgeE9wZXJhbmQsIExWYWx1ZSB5T3BlcmFuZCkgeyByZXR1 cm4gY2FsbFdpdGhvdXRTaWRlRWZmZWN0cyhCMzo6RG91YmxlLCBwb3csIHhPcGVyYW5kLCB5T3Bl cmFuZCk7IH0KKyAgICBMVmFsdWUgZG91YmxlU2luKExWYWx1ZSB2YWx1ZSkKKyAgICB7CisgICAg ICAgIGRvdWJsZSAoKnNpbkRvdWJsZSkoZG91YmxlKSA9IHNpbjsKKyAgICAgICAgcmV0dXJuIGNh bGxXaXRob3V0U2lkZUVmZmVjdHMoQjM6OkRvdWJsZSwgc2luRG91YmxlLCB2YWx1ZSk7CisgICAg fQorICAgIExWYWx1ZSBkb3VibGVDb3MoTFZhbHVlIHZhbHVlKQorICAgIHsKKyAgICAgICAgZG91 YmxlICgqY29zRG91YmxlKShkb3VibGUpID0gY29zOworICAgICAgICByZXR1cm4gY2FsbFdpdGhv dXRTaWRlRWZmZWN0cyhCMzo6RG91YmxlLCBjb3NEb3VibGUsIHZhbHVlKTsKKyAgICB9CisKKyAg ICBMVmFsdWUgZG91YmxlUG93KExWYWx1ZSB4T3BlcmFuZCwgTFZhbHVlIHlPcGVyYW5kKQorICAg IHsKKyAgICAgICAgZG91YmxlICgqcG93RG91YmxlKShkb3VibGUsIGRvdWJsZSkgPSBwb3c7Cisg ICAgICAgIHJldHVybiBjYWxsV2l0aG91dFNpZGVFZmZlY3RzKEIzOjpEb3VibGUsIHBvd0RvdWJs ZSwgeE9wZXJhbmQsIHlPcGVyYW5kKTsKKyAgICB9CiAKICAgICBMVmFsdWUgZG91YmxlUG93aShM VmFsdWUgeE9wZXJhbmQsIExWYWx1ZSB5T3BlcmFuZCk7CiAKICAgICBMVmFsdWUgZG91YmxlU3Fy dChMVmFsdWUgdmFsdWUpIHsgcmV0dXJuIG1fYmxvY2stPmFwcGVuZE5ldzxCMzo6VmFsdWU+KG1f cHJvYywgQjM6OlNxcnQsIG9yaWdpbigpLCB2YWx1ZSk7IH0KIAotICAgIExWYWx1ZSBkb3VibGVM b2coTFZhbHVlIHZhbHVlKSB7IHJldHVybiBjYWxsV2l0aG91dFNpZGVFZmZlY3RzKEIzOjpEb3Vi bGUsIGxvZywgdmFsdWUpOyB9CisgICAgTFZhbHVlIGRvdWJsZUxvZyhMVmFsdWUgdmFsdWUpCisg ICAgeworICAgICAgICBkb3VibGUgKCpsb2dEb3VibGUpKGRvdWJsZSkgPSBsb2c7CisgICAgICAg IHJldHVybiBjYWxsV2l0aG91dFNpZGVFZmZlY3RzKEIzOjpEb3VibGUsIGxvZ0RvdWJsZSwgdmFs dWUpOworICAgIH0KIAogICAgIHN0YXRpYyBib29sIGhhc1NlbnNpYmxlRG91YmxlVG9JbnQoKTsK ICAgICBMVmFsdWUgZG91YmxlVG9JbnQoTFZhbHVlKTsK