153297 2016-01-20 19:11:26 -0800 Revert to dispatching the popstate event synchronously 2016-02-19 01:29:41 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes beidson bfulgham cdumez commit-queue darin enrica esprehn+autocc japhet kangil.han rniwa sam thorton oldest_to_newest 1157167 0 aestes 2016-01-20 19:11:26 -0800 Re-enable synchronous popstate event for safari-601-branch 1157168 1 aestes 2016-01-20 19:11:57 -0800 rdar://problem/24154417 1157175 2 269416 aestes 2016-01-20 19:29:56 -0800 Created attachment 269416 Patch 1157329 3 269416 bfulgham 2016-01-21 10:13:16 -0800 Comment on attachment 269416 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269416&action=review r=me. This should only be landed in the branch. > LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt:-8 > -Set hash to #foo It seems weird that we don't output this. Surely the "Set hash to #foo" step is being taken, right? 1157514 4 269416 aestes 2016-01-21 17:44:18 -0800 Comment on attachment 269416 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269416&action=review >> LayoutTests/fast/loader/stateobjects/popstate-is-asynchronous-expected.txt:-8 >> -Set hash to #foo > > It seems weird that we don't output this. Surely the "Set hash to #foo" step is being taken, right? It is weird, but expected. The popstate event handler finishes the test when it fires in response to setting location.hash to "#foo". With synchronous event dispatch, that means the test finishes before we get to the next line that logs "Set hash to #foo". 1166367 5 aestes 2016-02-19 01:29:41 -0800 Committed r196807: <http://trac.webkit.org/changeset/196807> 269416 2016-01-20 19:29:56 -0800 2016-01-21 10:13:16 -0800 Patch bug-153297-20160120192929.patch text/plain 6154 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWEwNGM1MTIzMTI1YmMz NjljYTFmMmY4YjhmNTQwODg2YjQ4OWVkYy4uODg5OTZjNDkxNTM0MzhiMDhmNTcwOGU3MTYwNjU2 OTBjNGFjMTA5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM2IEBACisyMDE2LTAxLTIwICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSZS1lbmFibGUgc3luY2hyb25v dXMgcG9wc3RhdGUgZXZlbnQgZm9yIHNhZmFyaS02MDEtYnJhbmNoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMyOTcKKyAgICAgICAgcmRhcjovL3By b2JsZW0vMjQxNTQ0MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICByMTkyMzY5IG1hZGUgdGhlIHBvcHN0YXRlIGV2ZW50IGRpc3BhdGNoIGFzeW5jaHJv bm91c2x5LCB3aGljaCBtYXRjaGVzIHdoYXQgdGhlIEhUTUw1IHNwZWMgc2F5cyB0byBkby4gSG93 ZXZlciwKKyAgICAgICAgZHVlIHRvIGNvbXBhdGliaWxpdHkgcmVncmVzc2lvbnMsIHdlIGRvIG5v dCB3YW50IHRvIGluY2x1ZGUgdGhpcyBiZWhhdmlvciBjaGFuZ2UgaW4gc2FmYXJpLTYwMS1icmFu Y2guIFRoaXMKKyAgICAgICAgY2hhbmdlIHJldmVydHMgcjE5MjM2OSdzIGNoYW5nZXMgdG8gRG9j dW1lbnQuY3BwLCBidXQgcmV0YWlucyB0aGUgbmV3IHRlc3RzLiBUaGlzIGNoYW5nZSBpcyBpbnRl bmRlZCBvbmx5IGZvcgorICAgICAgICBzYWZhcmktNjAxLWJyYW5jaCBhbmQgaXRzIGNvcGllcy4g VGhlIHBvcHN0YXRlIGV2ZW50IHNob3VsZCByZW1haW4gYXN5bmNocm9ub3VzIGluIHRydW5rLgor CisgICAgICAgIEZpcmluZyBwb3BzdGF0ZSBzeW5jaHJvbm91c2x5IG1ha2VzIGJvdGggZmFzdC9s b2FkZXIvcmVtb3ZlLWlmcmFtZS1kdXJpbmctaGlzdG9yeS1uYXZpZ2F0aW9uLWRpZmZlcmVudC5o dG1sIGFuZAorICAgICAgICBmYXN0L2xvYWRlci9yZW1vdmUtaWZyYW1lLWR1cmluZy1oaXN0b3J5 LW5hdmlnYXRpb24tc2FtZS5odG1sIGNyYXNoLCBiZWNhdXNlIHRoZWlyIG9ucG9wc3RhdGUgaGFu ZGxlcnMgcmVtb3ZlCisgICAgICAgIGZyYW1lcyBmcm9tIHRoZSBkb2N1bWVudCB0aGF0IHdpbGwg bGF0ZXIgYmUgYWNjZXNzZWQgYnkgSGlzdG9yeUNvbnRyb2xsZXI6OnJlY3Vyc2l2ZUdvVG9JdGVt KCkuCisKKyAgICAgICAgVG8gcHJldmVudCB0aGUgY3Jhc2hlcywgdGhpcyBjaGFuZ2UgZG9lcyB0 d28gdGhpbmdzOgorICAgICAgICAxLiBLZWVwIGEgcmVmZXJlbmNlIHRvIHRoZSBjdXJyZW50IGZy YW1lIGluc2lkZSBGcmFtZUxvYWRlcjo6bG9hZFNhbWVEb2N1bWVudEl0ZW0oKSwgc2luY2UgY2Fs bGluZworICAgICAgICAgICBsb2FkSW5TYW1lRG9jdW1lbnQoKSBtaWdodCBvdGhlcndpc2UgZGVs ZXRlIGl0LgorICAgICAgICAyLiBIYW5kbGUgYSBudWxsIGZyYW1lIHdoZW4gaXRlcmF0aW5nIGEg SGlzdG9yeUl0ZW0ncyBjaGlsZCBmcmFtZXMgaW4gSGlzdG9yeUNvbnRyb2xsZXI6OnJlY3Vyc2l2 ZUdvVG9JdGVtKCksCisgICAgICAgICAgIHNpbmNlIGNhbGxpbmcgZ29Ub0l0ZW0oKSBvbiBvbmUg ZnJhbWUgbWlnaHQgY2F1c2UgYW5vdGhlciBmcmFtZSB0byBiZSBkZWxldGVkLgorCisgICAgICAg IENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuIGZhc3QvbG9hZGVyL3N0YXRlb2JqZWN0cy9wb3Bz dGF0ZS1pcy1hc3luY2hyb25vdXMtZXhwZWN0ZWQudHh0IHdhcyB1cGRhdGVkIHRvIGV4cGVjdAor ICAgICAgICBwb3BzdGF0ZSB0byBiZSBzeW5jaHJvbm91cy4KKworICAgICAgICAqIGRvbS9Eb2N1 bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6ZW5xdWV1ZVBvcHN0YXRlRXZl bnQpOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpGcmFtZUxvYWRlcjo6bG9hZFNhbWVEb2N1bWVudEl0ZW0pOgorICAgICAgICAqIGxvYWRlci9I aXN0b3J5Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3J5Q29udHJvbGxl cjo6cmVjdXJzaXZlR29Ub0l0ZW0pOgorCiAyMDE2LTAxLTIwICBUaW1vdGh5IEhhdGNoZXIgIDx0 aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0b3JDU1NB Z2VudCBkb2VzIG5vdCBjYWxsIGRpc2FibGUgaW4gd2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tl bmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDllNGVmZDA4ZDEyOTQ0ZjhjNjAyY2RiODFm OWMyNmEyYjA4NDUwN2IuLjdmZGY4ZTUwNzVjOTM2ZjE2YzVhMTNkOWE5YzdhNWU5YmY4OWMxNDYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNTUyNCw3ICs1NTI0LDcgQEAgdm9pZCBEb2N1 bWVudDo6ZW5xdWV1ZUhhc2hjaGFuZ2VFdmVudChjb25zdCBTdHJpbmcmIG9sZFVSTCwgY29uc3Qg U3RyaW5nJiBuZXdVUkwKIAogdm9pZCBEb2N1bWVudDo6ZW5xdWV1ZVBvcHN0YXRlRXZlbnQoUGFz c1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHN0YXRlT2JqZWN0KQogewotICAgIGVucXVl dWVXaW5kb3dFdmVudChQb3BTdGF0ZUV2ZW50OjpjcmVhdGUoc3RhdGVPYmplY3QsIG1fZG9tV2lu ZG93ID8gbV9kb21XaW5kb3ctPmhpc3RvcnkoKSA6IG51bGxwdHIpKTsKKyAgICBkaXNwYXRjaFdp bmRvd0V2ZW50KFBvcFN0YXRlRXZlbnQ6OmNyZWF0ZShzdGF0ZU9iamVjdCwgbV9kb21XaW5kb3cg PyBtX2RvbVdpbmRvdy0+aGlzdG9yeSgpIDogbnVsbHB0cikpOwogfQogCiB2b2lkIERvY3VtZW50 OjphZGRNZWRpYUNhblN0YXJ0TGlzdGVuZXIoTWVkaWFDYW5TdGFydExpc3RlbmVyKiBsaXN0ZW5l cikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IDBmZjViMjk5ZDhjNjJj MDVjMDAxY2QxYzI2ZmY2ZTgxZDhhNDg3YzEuLjljYjI3NjEzMGQ4NDM5NmE1MWM0NWI2NDIxMTgy NzM5ZGYxZWQ0YjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzI0 NSw2ICszMjQ1LDggQEAgdm9pZCBGcmFtZUxvYWRlcjo6bG9hZFNhbWVEb2N1bWVudEl0ZW0oSGlz dG9yeUl0ZW0mIGl0ZW0pCiB7CiAgICAgQVNTRVJUKGl0ZW0uZG9jdW1lbnRTZXF1ZW5jZU51bWJl cigpID09IGhpc3RvcnkoKS5jdXJyZW50SXRlbSgpLT5kb2N1bWVudFNlcXVlbmNlTnVtYmVyKCkp OwogCisgICAgUmVmPEZyYW1lPiBwcm90ZWN0KG1fZnJhbWUpOworCiAgICAgLy8gU2F2ZSB1c2Vy IHZpZXcgc3RhdGUgdG8gdGhlIGN1cnJlbnQgaGlzdG9yeSBpdGVtIGhlcmUgc2luY2Ugd2UgZG9u J3QgZG8gYSBub3JtYWwgbG9hZC4KICAgICAvLyBGSVhNRTogRG9lcyBmb3JtIHN0YXRlIG5lZWQg dG8gYmUgc2F2ZWQgaGVyZSB0b28/CiAgICAgaGlzdG9yeSgpLnNhdmVTY3JvbGxQb3NpdGlvbkFu ZFZpZXdTdGF0ZVRvSXRlbShoaXN0b3J5KCkuY3VycmVudEl0ZW0oKSk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvbG9hZGVyL0hpc3RvcnlDb250cm9sbGVyLmNwcAppbmRleCAzYTZlYTcxNmYyOWFhMDcxNDU5 MmRkZTIwYjk0M2I5YjlhMzdhZjhjLi4zNDY3MWNiYWI4ZTAyN2ZlMzBlZmU1NmI5NDVlY2VhZGIy ODc4OTFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvSGlzdG9yeUNvbnRyb2xs ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9IaXN0b3J5Q29udHJvbGxlci5jcHAK QEAgLTc1NCw5ICs3NTQsOCBAQCB2b2lkIEhpc3RvcnlDb250cm9sbGVyOjpyZWN1cnNpdmVHb1Rv SXRlbShIaXN0b3J5SXRlbSYgaXRlbSwgSGlzdG9yeUl0ZW0qIGZyb21JdAogCiAgICAgICAgIEhp c3RvcnlJdGVtKiBmcm9tQ2hpbGRJdGVtID0gZnJvbUl0ZW0tPmNoaWxkSXRlbVdpdGhUYXJnZXQo Y2hpbGRGcmFtZU5hbWUpOwogICAgICAgICBBU1NFUlQoZnJvbUNoaWxkSXRlbSk7Ci0gICAgICAg IEZyYW1lKiBjaGlsZEZyYW1lID0gbV9mcmFtZS50cmVlKCkuY2hpbGQoY2hpbGRGcmFtZU5hbWUp OwotICAgICAgICBBU1NFUlQoY2hpbGRGcmFtZSk7Ci0gICAgICAgIGNoaWxkRnJhbWUtPmxvYWRl cigpLmhpc3RvcnkoKS5yZWN1cnNpdmVHb1RvSXRlbShjb25zdF9jYXN0PEhpc3RvcnlJdGVtJj4o Y2hpbGRJdGVtLmdldCgpKSwgZnJvbUNoaWxkSXRlbSwgdHlwZSk7CisgICAgICAgIGlmIChGcmFt ZSogY2hpbGRGcmFtZSA9IG1fZnJhbWUudHJlZSgpLmNoaWxkKGNoaWxkRnJhbWVOYW1lKSkKKyAg ICAgICAgICAgIGNoaWxkRnJhbWUtPmxvYWRlcigpLmhpc3RvcnkoKS5yZWN1cnNpdmVHb1RvSXRl bShjb25zdF9jYXN0PEhpc3RvcnlJdGVtJj4oY2hpbGRJdGVtLmdldCgpKSwgZnJvbUNoaWxkSXRl bSwgdHlwZSk7CiAgICAgfQogfQogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGRjZDdiOGVkZjFlZjNkMjIyZWQwMDU4YzYx ZjYxMjk0ZGFhZWViZS4uMDZiMGM1NDE2OGJmMDZmZWRjOTJiYTQxZTA2ODNkYWQ2NGZjNWUxNyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTAxLTIwICBBbmR5IEVzdGVzICA8YWVzdGVzQGFw cGxlLmNvbT4KKworICAgICAgICBSZS1lbmFibGUgc3luY2hyb25vdXMgcG9wc3RhdGUgZXZlbnQg Zm9yIHNhZmFyaS02MDEtYnJhbmNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTMyOTcKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjQxNTQ0MTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvbG9h ZGVyL3N0YXRlb2JqZWN0cy9wb3BzdGF0ZS1pcy1hc3luY2hyb25vdXMtZXhwZWN0ZWQudHh0OiBV cGRhdGVkIHRvIGV4cGVjdCBwb3BzdGF0ZSB0byBiZSBkaXNwYXRjaGVkIHN5bmNocm9ub3VzbHku CisKIDIwMTYtMDEtMjAgIFJ5YW4gSGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAg ICAgICAgVXBkYXRlIGlvcy1zaW11bGF0b3Igc3BlY2lmaWMgLWV4cGVjdGVkLnR4dCBmaWxlcyBh ZnRlciBtb3N0IHJlY2VudCBXUFQgcmV2aXNpb24gaW4gcjE5NDU4MApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvZmFzdC9sb2FkZXIvc3RhdGVvYmplY3RzL3BvcHN0YXRlLWlzLWFzeW5jaHJvbm91 cy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvcG9w c3RhdGUtaXMtYXN5bmNocm9ub3VzLWV4cGVjdGVkLnR4dAppbmRleCBjZGNmZDdjM2ZiZjUwOTdh ZWY5MzJkYWI5NzIyZGRkMmFmZWE3YWZiLi4wNWIyODdmNmQxMTFlY2EyNDE5OWRmMGM5YjNjODM4 NGJhZjM3OGRjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVj dHMvcG9wc3RhdGUtaXMtYXN5bmNocm9ub3VzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2xvYWRlci9zdGF0ZW9iamVjdHMvcG9wc3RhdGUtaXMtYXN5bmNocm9ub3VzLWV4cGVj dGVkLnR4dApAQCAtNSw3ICs1LDYgQEAgT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVz IG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUKIG9ubG9hZCBm aXJlZAogcG9wc3RhdGUgZmlyZWQKIFNldHRpbmcgaGFzaCB0byAjZm9vCi1TZXQgaGFzaCB0byAj Zm9vCiBwb3BzdGF0ZSBmaXJlZAogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCg==