153290 2016-01-20 15:36:22 -0800 [GTK] Red sqiuggly line under misspelled word disappears when cursor is on word 2018-01-11 09:14:45 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux NEW P2 Minor --- 153291 1 mcatanzaro webkit-unassigned bugs-noreply commit-queue jdiggs mcatanzaro mike oldest_to_newest 1157086 0 mcatanzaro 2016-01-20 15:36:22 -0800 I will use the ^ to indicate the character that the cursor is positioned immediately IN FRONT OF. Type this in a text field: sqigggly ^ Note the one space after the word, needed to trigger the spellchecker to consider it a misspelled word. Now press the left arrow key once, so you get this: sqigggly ^ The red squiggly line goes away. It also goes away if you right click on it to show the context menu. I dunno if this is how spellcheckers work on Mac, but that's not expected behavior on Linux. 1157090 1 jdiggs 2016-01-20 15:52:27 -0800 This issue has some interesting implications for screen reader users who navigate into the text. Orca uses the accessible text attributes to identify the presence of the red squiggly and speak "misspelled" when that attribute is present. (Note: At the moment there are some other, accessibility-related bugs which are interfering with the aforementioned functionality. But when those are addressed, it would be nice if arrowing into the error didn't make the error indication vanish. So that Orca could make this presentation.) 1163447 2 270985 aplazas 2016-02-10 06:21:58 -0800 Created attachment 270985 Don't erase spelling markers after selection change on GTK+. 1163452 3 270985 calvaris 2016-02-10 07:13:16 -0800 Comment on attachment 270985 Don't erase spelling markers after selection change on GTK+. View in context: https://bugs.webkit.org/attachment.cgi?id=270985&action=review > Source/WebKit2/ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + * WebProcess/WebCoreSupport/WebEditorClient.cpp: You could either write an explanation between this two lines or in the function section, but you'd need at least something 1163453 4 270988 aplazas 2016-02-10 07:25:30 -0800 Created attachment 270988 Don't erase spelling markers after selection change on GTK+. 1164991 5 270988 mcatanzaro 2016-02-15 17:42:08 -0800 Comment on attachment 270988 Don't erase spelling markers after selection change on GTK+. Well, I agree with the change in this patch, to return type != TextCheckingTypeSpelling here like the other ports do. It seems to do the right thing, fixing both of my complaints: the squiggly line disappearing when you right click to get a context menu, and the squiggly line disappearing when you move the cursor back one position. But it breaks spellchecking of contractions, e.g. "wasn't." Strange, Mac port must be handling contractions differently somewhere else. 1388071 6 mike 2018-01-10 20:57:28 -0800 This sounds a lit like Bug 153290. Is there some overlap? 1388074 7 mike 2018-01-10 20:58:07 -0800 Err, I mean Bug 32770. Apologies! 1388255 8 mcatanzaro 2018-01-11 09:14:45 -0800 (In reply to Michael Gratton from comment #6) > This sounds a lit like Bug 153290. Is there some overlap? I think bug #32770 is completely different. That bug complains that spelling suggests do not appear when right-clicking on the word unless the word is selected. That's definitely not the case today, so I'll close that bug as obsolete. 270985 2016-02-10 06:21:58 -0800 2016-02-10 07:25:30 -0800 Don't erase spelling markers after selection change on GTK+. patch text/plain 1442 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YzAxOTA4Li5mZjllOTA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTYtMDItMTAgIEFkcmllbiBQbGF6YXMgIDxhcGxhemFzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gUmVkIHNxaXVnZ2x5IGxpbmUgdW5kZXIgbWlzc3BlbGxlZCB3b3JkIGRpc2Fw cGVhcnMgd2hlbiBjdXJzb3IgaXMgb24gd29yZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRv ckNsaWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkVkaXRvckNsaWVudDo6c2hvdWxkRXJh c2VNYXJrZXJzQWZ0ZXJDaGFuZ2VTZWxlY3Rpb24pOgorCiAyMDE2LTAyLTA2ICBEYW5pZWwgQmF0 ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBDYWxsIENGUmVsZWFzZSgpIG9uIFNl Y1JlcXVpcmVtZW50UmVmIHdoZW4gbm8gbG9uZ2VyIG5lZWRlZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQuY3BwIGIv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQu Y3BwCmluZGV4IGMyYWMyYmUuLjNiZWE4ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5jcHAKQEAg LTQzMCw3ICs0MzAsNyBAQCB2b2lkIFdlYkVkaXRvckNsaWVudDo6dGV4dFdpbGxCZURlbGV0ZWRJ blRleHRGaWVsZChFbGVtZW50KiBlbGVtZW50KQogYm9vbCBXZWJFZGl0b3JDbGllbnQ6OnNob3Vs ZEVyYXNlTWFya2Vyc0FmdGVyQ2hhbmdlU2VsZWN0aW9uKFdlYkNvcmU6OlRleHRDaGVja2luZ1R5 cGUgdHlwZSkgY29uc3QKIHsKICAgICAvLyBUaGlzIHByZXZlbnRzIGVyYXNpbmcgc3BlbGxpbmcg bWFya2VycyBvbiBPUyBYIExpb24gb3IgbGF0ZXIgdG8gbWF0Y2ggQXBwS2l0IG9uIHRoZXNlIE1h YyBPUyBYIHZlcnNpb25zLgotI2lmIFBMQVRGT1JNKENPQ09BKSB8fCBQTEFURk9STShFRkwpCisj aWYgUExBVEZPUk0oQ09DT0EpIHx8IFBMQVRGT1JNKEVGTCkgfHwgUExBVEZPUk0oR1RLKQogICAg IHJldHVybiB0eXBlICE9IFRleHRDaGVja2luZ1R5cGVTcGVsbGluZzsKICNlbHNlCiAgICAgVU5V U0VEX1BBUkFNKHR5cGUpOwo= 270988 2016-02-10 07:25:30 -0800 2016-02-15 17:42:08 -0800 Don't erase spelling markers after selection change on GTK+. patch text/plain 1650 aplazas ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3NjE0Zjg4Li5kYWNkYjIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTYtMDItMTAgIEFkcmllbiBQbGF6YXMgIDxhcGxhemFzQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gUmVkIHNxaXVnZ2x5IGxpbmUgdW5kZXIgbWlzc3BlbGxlZCB3b3JkIGRpc2Fw cGVhcnMgd2hlbiBjdXJzb3IgaXMgb24gd29yZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQXNrIG5vdCB0byBlcmFzZSBzcGVsbGluZyBtYXJrZXJzIGFm dGVyIGEgc2VsZWN0aW9uIGNoYW5nZSBvbiBHVEsrLgorCisgICAgICAgIFRoaXMgYWxsb3dzIHRv IGtlZXAgdGhlIHNwZWxsaW5nIGVycm9yIG1hcmtlcnMgd2hlbiBhIGN1cnNvciBpcyBvbgorICAg ICAgICBhIG1pc3NwZWxsZWQgd29yZCBpZiBpdCBpc24ndCBiZWluZyBtb2RpZmllZC4KKworICAg ICAgICAqIFdlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViRWRpdG9yQ2xpZW50OjpzaG91bGRFcmFzZU1hcmtlcnNBZnRlckNo YW5nZVNlbGVjdGlvbik6CisKIDIwMTYtMDItMDkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dh cmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE5NjE4Myk6IFtHVEtdIEJy b2tlIFRlc3RJbnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50LmNwcAppbmRleCBjMmFjMmJlLi4z YmVhOGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYkNvcmVTdXBw b3J0L1dlYkVkaXRvckNsaWVudC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQuY3BwCkBAIC00MzAsNyArNDMwLDcgQEAgdm9p ZCBXZWJFZGl0b3JDbGllbnQ6OnRleHRXaWxsQmVEZWxldGVkSW5UZXh0RmllbGQoRWxlbWVudCog ZWxlbWVudCkKIGJvb2wgV2ViRWRpdG9yQ2xpZW50OjpzaG91bGRFcmFzZU1hcmtlcnNBZnRlckNo YW5nZVNlbGVjdGlvbihXZWJDb3JlOjpUZXh0Q2hlY2tpbmdUeXBlIHR5cGUpIGNvbnN0CiB7CiAg ICAgLy8gVGhpcyBwcmV2ZW50cyBlcmFzaW5nIHNwZWxsaW5nIG1hcmtlcnMgb24gT1MgWCBMaW9u IG9yIGxhdGVyIHRvIG1hdGNoIEFwcEtpdCBvbiB0aGVzZSBNYWMgT1MgWCB2ZXJzaW9ucy4KLSNp ZiBQTEFURk9STShDT0NPQSkgfHwgUExBVEZPUk0oRUZMKQorI2lmIFBMQVRGT1JNKENPQ09BKSB8 fCBQTEFURk9STShFRkwpIHx8IFBMQVRGT1JNKEdUSykKICAgICByZXR1cm4gdHlwZSAhPSBUZXh0 Q2hlY2tpbmdUeXBlU3BlbGxpbmc7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTSh0eXBlKTsK