153287 2016-01-20 14:25:12 -0800 [JSC] The register allocator can use a dangling pointer when selecting a spill candidate 2016-01-20 17:45:24 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1157050 0 benjamin 2016-01-20 14:25:12 -0800 [JSC] The register allocator can use a dangling pointer when selecting a spill candidate 1157054 1 269386 benjamin 2016-01-20 14:34:04 -0800 Created attachment 269386 Patch 1157055 2 commit-queue 2016-01-20 14:36:24 -0800 Attachment 269386 did not pass style-queue: ERROR: Source/JavaScriptCore/ChangeLog:28: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1157056 3 269386 mark.lam 2016-01-20 14:39:28 -0800 Comment on attachment 269386 Patch r=me 1157058 4 269388 benjamin 2016-01-20 14:46:52 -0800 Created attachment 269388 Patch for landing 1157059 5 269388 mark.lam 2016-01-20 14:47:43 -0800 Comment on attachment 269388 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=269388&action=review > Source/JavaScriptCore/dfg/DFGCommon.h:42 > -#define FTL_USES_B3 0 > +#define FTL_USES_B3 1 > Please undo this. 1157064 6 269390 benjamin 2016-01-20 14:57:49 -0800 Created attachment 269390 Patch for landing 1157074 7 269390 commit-queue 2016-01-20 15:11:44 -0800 Comment on attachment 269390 Patch for landing Clearing flags on attachment: 269390 Committed r195387: <http://trac.webkit.org/changeset/195387> 1157075 8 commit-queue 2016-01-20 15:11:47 -0800 All reviewed patches have been landed. Closing bug. 1157142 9 fpizlo 2016-01-20 17:45:24 -0800 I encountered the same thing. I think I'll keep my version of UseCounts from https://bugs.webkit.org/show_bug.cgi?id=153200, which returns a pointer that may be null, since it feels perfectly ordinary for a phase to add tmps and still query UseCounts. I'm not sure whether to keep your version or my version of the fix in IRC. The benefit of my fix is that querying unspillableTmps before adding to spillWorklist is probably better than querying unspillableTmps for every member of spillWorklist every time selectSpill() is called. 269386 2016-01-20 14:34:04 -0800 2016-01-20 14:46:49 -0800 Patch bug-153287-20160120143336.patch text/plain 3310 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZmRmZmVmMTE5MzYwMDMxODI0ZmNmZDJlMGY3ODY0ZTI2YTQ5Y2NmLi4yYjVlZjg3YzgwYjliNjdh ZWU2ZDNhMTI1YWQxYzNjMzUzZGM0OGRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAxNi0wMS0yMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gVGhlIHJlZ2lzdGVyIGFsbG9jYXRvciBjYW4gdXNlIGEg ZGFuZ2xpbmcgcG9pbnRlciB3aGVuIHNlbGVjdGluZyBhIHNwaWxsIGNhbmRpZGF0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQSB0cmlja3kgYnVnIEkg ZGlzY292ZXJlZCB3aGlsZSBleHBlcmltZW50aW5nIHdpdGggbGl2ZSByYW5nZSBicmVha2luZy4K KworICAgICAgICBXZSBoYXZlIHRoZSBmb2xsb3dpbmcgaW5pdGlhbCBjb25kaXRpb25zOgorICAg ICAgICAtVXNlQ291bnRzIGlzIHNsb3csIHNvIHdlIG9ubHkgY29tcHV0ZSBpdCBvbmNlIGZvciBh bGwgdGhlIGl0ZXJhdGlvbnMKKyAgICAgICAgIG9mIHRoZSBhbGxvY2F0b3IuCisgICAgICAgIC1U aGUgb25seSBuZXcgVG1wcyB3ZSBjcmVhdGUgYXJlIGZvciBzcGlsbHMgYW5kIHJlZmlsbHMuIFRo ZXkgYXJlIHVuc3BpbGxhYmxlCisgICAgICAgICBieSBkZWZpbml0aW9uIHNvIGl0IGlzIGZpbmUg dG8gbm90IHVwZGF0ZSBVc2VDb3VudHMgYWNjb3JkaW5nbHkuCisKKyAgICAgICAgQnV0LCBpbiBz ZWxlY3RTcGlsbCgpLCB3ZSBnbyBvdmVyIGFsbCB0aGUgc3BpbGwgY2FuZGlkYXRlcyBhbmQgc2Vs ZWN0IHRoZSBiZXN0CisgICAgICAgIG9uZSBiYXNlZCBvbiBpdHMgc2NvcmUuIFRoZSBzY29yZSgp IGxhbWJkYSB1c2VzIHVzZUNvdW50cywgaXQgY2Fubm90IGJlIHVzZWQKKyAgICAgICAgd2l0aCBh IG5ldyBUbXBzIGNyZWF0ZWQgZm9yIHNvbWV0aGluZyB3ZSBhbHJlYWR5IHNwaWxsZWQuCisKKyAg ICAgICAgVGhlIGZpcnN0IHRpbWUgd2UgdXNlIHNjb3JlIGlzIGNvcnJlY3QsIHdlIHN0YXJ0ZWQg Ynkgc2tpcHBpbmcgYWxsIHRoZSB1bnNwaWxsYWJsZQorICAgICAgICBUbXBzIGZyb20gdGhlIGNh bmRpZGF0ZS4gVGhlIG5leHQgdXNlIHdhcyBpbmNvcnJlY3Q6IHdlIHdlcmUgY2hlY2tpbmcgdW5z cGlsbGFibGVUbXBzCisgICAgICAgICphZnRlciogY2FsbGluZyBzY29yZSgpLgorCisgICAgICAg IFRoZSBleGlzdGluZyB0ZXN0cyBkaWQgbm90IGNhdGNoIHRoaXMgZHVlIHRvIGJhY2sgbHVjay4g SSBhZGRlZCBhbiBhc3NlcnRpb24KKyAgICAgICAgdG8gZmluZCBzaW1pbGFyIHByb2JsZW1zIGlu IHRoZSBmdXR1cmUuCisKKyAgICAgICAgKiBiMy9haXIvQWlySXRlcmF0ZWRSZWdpc3RlckNvYWxl c2NpbmcuY3BwOgorICAgICAgICAqIGIzL2Fpci9BaXJVc2VDb3VudHMuaAorCiAyMDE2LTAxLTIw ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0Nd IEZpeCBhIHR5cG8gaW4gdGhlIEFpciBkZWZpbml0aW9uIG9mIENlaWxEb3VibGUvQ2VpbEZsb2F0 CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVn aXN0ZXJDb2FsZXNjaW5nLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlySXRl cmF0ZWRSZWdpc3RlckNvYWxlc2NpbmcuY3BwCmluZGV4IDdkZjY5YTljZjliNDI5MjExZmZjOTAz ZTcyM2ExMGNhOGRkMmUwMDAuLjlkODc4Mjg4Y2FiOTU5ZWUzOGM5ZmY3NTY0NWFhOTRhYzJhZDJi MGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlySXRlcmF0ZWRS ZWdpc3RlckNvYWxlc2NpbmcuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIv QWlySXRlcmF0ZWRSZWdpc3RlckNvYWxlc2NpbmcuY3BwCkBAIC05NjEsMTEgKzk2MSwxMSBAQCBw cml2YXRlOgogCiAgICAgICAgICsraXRlcmF0b3I7CiAgICAgICAgIGZvciAoO2l0ZXJhdG9yICE9 IG1fc3BpbGxXb3JrbGlzdC5lbmQoKTsgKytpdGVyYXRvcikgeworICAgICAgICAgICAgaWYgKG1f dW5zcGlsbGFibGVUbXBzLmNvbnRhaW5zKCppdGVyYXRvcikpCisgICAgICAgICAgICAgICAgY29u dGludWU7CisKICAgICAgICAgICAgIGRvdWJsZSB0bXBTY29yZSA9IHNjb3JlKEFic29sdXRlVG1w TWFwcGVyPHR5cGU+Ojp0bXBGcm9tQWJzb2x1dGVJbmRleCgqaXRlcmF0b3IpKTsKICAgICAgICAg ICAgIGlmICh0bXBTY29yZSA+IG1heFNjb3JlKSB7Ci0gICAgICAgICAgICAgICAgaWYgKG1fdW5z cGlsbGFibGVUbXBzLmNvbnRhaW5zKCppdGVyYXRvcikpCi0gICAgICAgICAgICAgICAgICAgIGNv bnRpbnVlOwotCiAgICAgICAgICAgICAgICAgdmljdGltSXRlcmF0b3IgPSBpdGVyYXRvcjsKICAg ICAgICAgICAgICAgICBtYXhTY29yZSA9IHRtcFNjb3JlOwogICAgICAgICAgICAgfQpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJVc2VDb3VudHMuaCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyVXNlQ291bnRzLmgKaW5kZXggOWJjNDkzYjYyMDJm ZWYxZjJlMDE5MWJlNzNmZjY3NWU2NmIwY2RkNS4uN2Y0ZGMwOTI1NGUxZTNjZjAyNzNkNmQ5NmY2 NzM0OTc5YmM2ZGViYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fpci9B aXJVc2VDb3VudHMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0FpclVzZUNv dW50cy5oCkBAIC05Nyw3ICs5NywxMSBAQCBwdWJsaWM6CiAgICAgICAgIH0KICAgICB9CiAKLSAg ICBjb25zdCBDb3VudHMmIG9wZXJhdG9yW10oY29uc3QgVGhpbmcmIGFyZykgY29uc3QgeyByZXR1 cm4gbV9jb3VudHMuZmluZChhcmcpLT52YWx1ZTsgfQorICAgIGNvbnN0IENvdW50cyYgb3BlcmF0 b3JbXShjb25zdCBUaGluZyYgYXJnKSBjb25zdAorICAgIHsKKyAgICAgICAgQVNTRVJUKG1fY291 bnRzLmNvbnRhaW5zKGFyZykpOworICAgICAgICByZXR1cm4gbV9jb3VudHMuZmluZChhcmcpLT52 YWx1ZTsKKyAgICB9CiAKICAgICB2b2lkIGR1bXAoUHJpbnRTdHJlYW0mIG91dCkgY29uc3QKICAg ICB7Cg== 269388 2016-01-20 14:46:52 -0800 2016-01-20 14:57:46 -0800 Patch for landing bug-153287-20160120144624.patch text/plain 3918 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NDAxM2IyZWEyOTkyZGQyNjNkZTU1NDZmMmNlODA2MTliNzFlMzhiLi5hYTllODE5M2UyNmQ3ODVl OWQ2MDU5NDI1YzVkZGY2NGJiY2ZkMGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAxNi0wMS0yMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gVGhlIHJlZ2lzdGVyIGFsbG9jYXRvciBjYW4gdXNlIGEg ZGFuZ2xpbmcgcG9pbnRlciB3aGVuIHNlbGVjdGluZyBhIHNwaWxsIGNhbmRpZGF0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgQSB0cmlja3kgYnVnIEkgZGlzY292 ZXJlZCB3aGlsZSBleHBlcmltZW50aW5nIHdpdGggbGl2ZSByYW5nZSBicmVha2luZy4KKworICAg ICAgICBXZSBoYXZlIHRoZSBmb2xsb3dpbmcgaW5pdGlhbCBjb25kaXRpb25zOgorICAgICAgICAt VXNlQ291bnRzIGlzIHNsb3csIHNvIHdlIG9ubHkgY29tcHV0ZSBpdCBvbmNlIGZvciBhbGwgdGhl IGl0ZXJhdGlvbnMKKyAgICAgICAgIG9mIHRoZSBhbGxvY2F0b3IuCisgICAgICAgIC1UaGUgb25s eSBuZXcgVG1wcyB3ZSBjcmVhdGUgYXJlIGZvciBzcGlsbHMgYW5kIHJlZmlsbHMuIFRoZXkgYXJl IHVuc3BpbGxhYmxlCisgICAgICAgICBieSBkZWZpbml0aW9uIHNvIGl0IGlzIGZpbmUgdG8gbm90 IHVwZGF0ZSBVc2VDb3VudHMgYWNjb3JkaW5nbHkuCisKKyAgICAgICAgQnV0LCBpbiBzZWxlY3RT cGlsbCgpLCB3ZSBnbyBvdmVyIGFsbCB0aGUgc3BpbGwgY2FuZGlkYXRlcyBhbmQgc2VsZWN0IHRo ZSBiZXN0CisgICAgICAgIG9uZSBiYXNlZCBvbiBpdHMgc2NvcmUuIFRoZSBzY29yZSgpIGxhbWJk YSB1c2VzIHVzZUNvdW50cywgaXQgY2Fubm90IGJlIHVzZWQKKyAgICAgICAgd2l0aCBhIG5ldyBU bXBzIGNyZWF0ZWQgZm9yIHNvbWV0aGluZyB3ZSBhbHJlYWR5IHNwaWxsZWQuCisKKyAgICAgICAg VGhlIGZpcnN0IHRpbWUgd2UgdXNlIHNjb3JlIGlzIGNvcnJlY3QsIHdlIHN0YXJ0ZWQgYnkgc2tp cHBpbmcgYWxsIHRoZSB1bnNwaWxsYWJsZQorICAgICAgICBUbXBzIGZyb20gdGhlIGNhbmRpZGF0 ZS4gVGhlIG5leHQgdXNlIHdhcyBpbmNvcnJlY3Q6IHdlIHdlcmUgY2hlY2tpbmcgdW5zcGlsbGFi bGVUbXBzCisgICAgICAgICphZnRlciogY2FsbGluZyBzY29yZSgpLgorCisgICAgICAgIFRoZSBl eGlzdGluZyB0ZXN0cyBkaWQgbm90IGNhdGNoIHRoaXMgZHVlIHRvIGJhY2sgbHVjay4gSSBhZGRl ZCBhbiBhc3NlcnRpb24KKyAgICAgICAgdG8gZmluZCBzaW1pbGFyIHByb2JsZW1zIGluIHRoZSBm dXR1cmUuCisKKyAgICAgICAgKiBiMy9haXIvQWlySXRlcmF0ZWRSZWdpc3RlckNvYWxlc2Npbmcu Y3BwOgorICAgICAgICAqIGIzL2Fpci9BaXJVc2VDb3VudHMuaDoKKwogMjAxNi0wMS0xOSAgQmVu amFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBmaXhT cGlsbFNsb3RaRGVmKCkgY3Jhc2hlcyBvbiBBUk02NApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL2Fpci9BaXJJdGVyYXRlZFJlZ2lzdGVyQ29hbGVzY2luZy5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNjaW5nLmNw cAppbmRleCA3ZGY2OWE5Y2Y5YjQyOTIxMWZmYzkwM2U3MjNhMTBjYThkZDJlMDAwLi45ZDg3ODI4 OGNhYjk1OWVlMzhjOWZmNzU2NDVhYTk0YWMyYWQyYjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNjaW5nLmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNj aW5nLmNwcApAQCAtOTYxLDExICs5NjEsMTEgQEAgcHJpdmF0ZToKIAogICAgICAgICArK2l0ZXJh dG9yOwogICAgICAgICBmb3IgKDtpdGVyYXRvciAhPSBtX3NwaWxsV29ya2xpc3QuZW5kKCk7ICsr aXRlcmF0b3IpIHsKKyAgICAgICAgICAgIGlmIChtX3Vuc3BpbGxhYmxlVG1wcy5jb250YWlucygq aXRlcmF0b3IpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgICAgICBkb3Vi bGUgdG1wU2NvcmUgPSBzY29yZShBYnNvbHV0ZVRtcE1hcHBlcjx0eXBlPjo6dG1wRnJvbUFic29s dXRlSW5kZXgoKml0ZXJhdG9yKSk7CiAgICAgICAgICAgICBpZiAodG1wU2NvcmUgPiBtYXhTY29y ZSkgewotICAgICAgICAgICAgICAgIGlmIChtX3Vuc3BpbGxhYmxlVG1wcy5jb250YWlucygqaXRl cmF0b3IpKQotICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKLQogICAgICAgICAgICAgICAg IHZpY3RpbUl0ZXJhdG9yID0gaXRlcmF0b3I7CiAgICAgICAgICAgICAgICAgbWF4U2NvcmUgPSB0 bXBTY29yZTsKICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9haXIvQWlyVXNlQ291bnRzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fp clVzZUNvdW50cy5oCmluZGV4IDliYzQ5M2I2MjAyZmVmMWYyZTAxOTFiZTczZmY2NzVlNjZiMGNk ZDUuLjdmNGRjMDkyNTRlMWUzY2YwMjczZDZkOTZmNjczNDk3OWJjNmRlYmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyVXNlQ291bnRzLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJVc2VDb3VudHMuaApAQCAtOTcsNyArOTcsMTEgQEAg cHVibGljOgogICAgICAgICB9CiAgICAgfQogCi0gICAgY29uc3QgQ291bnRzJiBvcGVyYXRvcltd KGNvbnN0IFRoaW5nJiBhcmcpIGNvbnN0IHsgcmV0dXJuIG1fY291bnRzLmZpbmQoYXJnKS0+dmFs dWU7IH0KKyAgICBjb25zdCBDb3VudHMmIG9wZXJhdG9yW10oY29uc3QgVGhpbmcmIGFyZykgY29u c3QKKyAgICB7CisgICAgICAgIEFTU0VSVChtX2NvdW50cy5jb250YWlucyhhcmcpKTsKKyAgICAg ICAgcmV0dXJuIG1fY291bnRzLmZpbmQoYXJnKS0+dmFsdWU7CisgICAgfQogCiAgICAgdm9pZCBk dW1wKFByaW50U3RyZWFtJiBvdXQpIGNvbnN0CiAgICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdDb21tb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQ29tbW9uLmgKaW5kZXggYjAxNDNkNjczODk0YjY1ZjRmZDZjZDkwOGYyNDhiZjE5MzJkMDg2 Mi4uMTA5MGNkYzYxYTFkOGMwNzY0MWNhNjRlNjNkM2FmMjE4YjI2YjY1MSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdDb21tb24uaAorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvZGZnL0RGR0NvbW1vbi5oCkBAIC0zOCw3ICszOCw3IEBAIG5hbWVzcGFjZSBKU0Mg eyBuYW1lc3BhY2UgREZHIHsKIC8vIFdlIGFyZSBpbiB0aGUgbWlkZGxlIG9mIGFuIGV4cGVyaW1l bnRhbCB0cmFuc2l0aW9uIGZyb20gTExWTSB0byBCMyBhcyB0aGUgYmFja2VuZCBmb3IgdGhlIEZU TC4gV2UgZG9uJ3QKIC8vIHlldCBrbm93IGhvdyBpdCB3aWxsIHR1cm4gb3V0LiBGb3Igbm93LCB0 aGlzIGZsYWcgd2lsbCBjb250cm9sIHdoZXRoZXIgRlRMIHVzZXMgQjMuIFJlbWVtYmVyIHRvIHNl dCB0aGlzCiAvLyB0byAwIGJlZm9yZSBjb21taXR0aW5nIQotI2RlZmluZSBGVExfVVNFU19CMyAw CisjZGVmaW5lIEZUTF9VU0VTX0IzIDEKIAogc3RydWN0IE5vZGU7CiAK 269390 2016-01-20 14:57:49 -0800 2016-01-20 15:11:44 -0800 Patch for landing bug-153287-20160120145721.patch text/plain 3323 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NDAxM2IyZWEyOTkyZGQyNjNkZTU1NDZmMmNlODA2MTliNzFlMzhiLi5hYTllODE5M2UyNmQ3ODVl OWQ2MDU5NDI1YzVkZGY2NGJiY2ZkMGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMiBAQAorMjAxNi0wMS0yMCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CisKKyAgICAgICAgW0pTQ10gVGhlIHJlZ2lzdGVyIGFsbG9jYXRvciBjYW4gdXNlIGEg ZGFuZ2xpbmcgcG9pbnRlciB3aGVuIHNlbGVjdGluZyBhIHNwaWxsIGNhbmRpZGF0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjg3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTWFyayBMYW0uCisKKyAgICAgICAgQSB0cmlja3kgYnVnIEkgZGlzY292 ZXJlZCB3aGlsZSBleHBlcmltZW50aW5nIHdpdGggbGl2ZSByYW5nZSBicmVha2luZy4KKworICAg ICAgICBXZSBoYXZlIHRoZSBmb2xsb3dpbmcgaW5pdGlhbCBjb25kaXRpb25zOgorICAgICAgICAt VXNlQ291bnRzIGlzIHNsb3csIHNvIHdlIG9ubHkgY29tcHV0ZSBpdCBvbmNlIGZvciBhbGwgdGhl IGl0ZXJhdGlvbnMKKyAgICAgICAgIG9mIHRoZSBhbGxvY2F0b3IuCisgICAgICAgIC1UaGUgb25s eSBuZXcgVG1wcyB3ZSBjcmVhdGUgYXJlIGZvciBzcGlsbHMgYW5kIHJlZmlsbHMuIFRoZXkgYXJl IHVuc3BpbGxhYmxlCisgICAgICAgICBieSBkZWZpbml0aW9uIHNvIGl0IGlzIGZpbmUgdG8gbm90 IHVwZGF0ZSBVc2VDb3VudHMgYWNjb3JkaW5nbHkuCisKKyAgICAgICAgQnV0LCBpbiBzZWxlY3RT cGlsbCgpLCB3ZSBnbyBvdmVyIGFsbCB0aGUgc3BpbGwgY2FuZGlkYXRlcyBhbmQgc2VsZWN0IHRo ZSBiZXN0CisgICAgICAgIG9uZSBiYXNlZCBvbiBpdHMgc2NvcmUuIFRoZSBzY29yZSgpIGxhbWJk YSB1c2VzIHVzZUNvdW50cywgaXQgY2Fubm90IGJlIHVzZWQKKyAgICAgICAgd2l0aCBhIG5ldyBU bXBzIGNyZWF0ZWQgZm9yIHNvbWV0aGluZyB3ZSBhbHJlYWR5IHNwaWxsZWQuCisKKyAgICAgICAg VGhlIGZpcnN0IHRpbWUgd2UgdXNlIHNjb3JlIGlzIGNvcnJlY3QsIHdlIHN0YXJ0ZWQgYnkgc2tp cHBpbmcgYWxsIHRoZSB1bnNwaWxsYWJsZQorICAgICAgICBUbXBzIGZyb20gdGhlIGNhbmRpZGF0 ZS4gVGhlIG5leHQgdXNlIHdhcyBpbmNvcnJlY3Q6IHdlIHdlcmUgY2hlY2tpbmcgdW5zcGlsbGFi bGVUbXBzCisgICAgICAgICphZnRlciogY2FsbGluZyBzY29yZSgpLgorCisgICAgICAgIFRoZSBl eGlzdGluZyB0ZXN0cyBkaWQgbm90IGNhdGNoIHRoaXMgZHVlIHRvIGJhY2sgbHVjay4gSSBhZGRl ZCBhbiBhc3NlcnRpb24KKyAgICAgICAgdG8gZmluZCBzaW1pbGFyIHByb2JsZW1zIGluIHRoZSBm dXR1cmUuCisKKyAgICAgICAgKiBiMy9haXIvQWlySXRlcmF0ZWRSZWdpc3RlckNvYWxlc2Npbmcu Y3BwOgorICAgICAgICAqIGIzL2Fpci9BaXJVc2VDb3VudHMuaDoKKwogMjAxNi0wMS0xOSAgQmVu amFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBmaXhT cGlsbFNsb3RaRGVmKCkgY3Jhc2hlcyBvbiBBUk02NApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL2Fpci9BaXJJdGVyYXRlZFJlZ2lzdGVyQ29hbGVzY2luZy5jcHAgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNjaW5nLmNw cAppbmRleCA3ZGY2OWE5Y2Y5YjQyOTIxMWZmYzkwM2U3MjNhMTBjYThkZDJlMDAwLi45ZDg3ODI4 OGNhYjk1OWVlMzhjOWZmNzU2NDVhYTk0YWMyYWQyYjBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNjaW5nLmNwcAorKysg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fpckl0ZXJhdGVkUmVnaXN0ZXJDb2FsZXNj aW5nLmNwcApAQCAtOTYxLDExICs5NjEsMTEgQEAgcHJpdmF0ZToKIAogICAgICAgICArK2l0ZXJh dG9yOwogICAgICAgICBmb3IgKDtpdGVyYXRvciAhPSBtX3NwaWxsV29ya2xpc3QuZW5kKCk7ICsr aXRlcmF0b3IpIHsKKyAgICAgICAgICAgIGlmIChtX3Vuc3BpbGxhYmxlVG1wcy5jb250YWlucygq aXRlcmF0b3IpKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgICAgICBkb3Vi bGUgdG1wU2NvcmUgPSBzY29yZShBYnNvbHV0ZVRtcE1hcHBlcjx0eXBlPjo6dG1wRnJvbUFic29s dXRlSW5kZXgoKml0ZXJhdG9yKSk7CiAgICAgICAgICAgICBpZiAodG1wU2NvcmUgPiBtYXhTY29y ZSkgewotICAgICAgICAgICAgICAgIGlmIChtX3Vuc3BpbGxhYmxlVG1wcy5jb250YWlucygqaXRl cmF0b3IpKQotICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKLQogICAgICAgICAgICAgICAg IHZpY3RpbUl0ZXJhdG9yID0gaXRlcmF0b3I7CiAgICAgICAgICAgICAgICAgbWF4U2NvcmUgPSB0 bXBTY29yZTsKICAgICAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9haXIvQWlyVXNlQ291bnRzLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvYWlyL0Fp clVzZUNvdW50cy5oCmluZGV4IDliYzQ5M2I2MjAyZmVmMWYyZTAxOTFiZTczZmY2NzVlNjZiMGNk ZDUuLjgyMThmZGU1YTIyZWIzZDZmZDA0ZTNlYThjYjYwMTE4MDkwZDUwMzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvQWlyVXNlQ291bnRzLmgKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2IzL2Fpci9BaXJVc2VDb3VudHMuaApAQCAtOTcsNyArOTcsMTIgQEAg cHVibGljOgogICAgICAgICB9CiAgICAgfQogCi0gICAgY29uc3QgQ291bnRzJiBvcGVyYXRvcltd KGNvbnN0IFRoaW5nJiBhcmcpIGNvbnN0IHsgcmV0dXJuIG1fY291bnRzLmZpbmQoYXJnKS0+dmFs dWU7IH0KKyAgICBjb25zdCBDb3VudHMmIG9wZXJhdG9yW10oY29uc3QgVGhpbmcmIGFyZykgY29u c3QKKyAgICB7CisgICAgICAgIGF1dG8gaXRlcmF0b3IgPSBtX2NvdW50cy5maW5kKGFyZyk7Cisg ICAgICAgIEFTU0VSVChpdGVyYXRvciAhPSBtX2NvdW50cy5lbmQoKSk7CisgICAgICAgIHJldHVy biBpdGVyYXRvci0+dmFsdWU7CisgICAgfQogCiAgICAgdm9pZCBkdW1wKFByaW50U3RyZWFtJiBv dXQpIGNvbnN0CiAgICAgewo=