153279 2016-01-20 10:36:48 -0800 Use TinyLRUCache in caching the CGColorRef in WebCore::cachedCGColor() 2016-01-20 16:42:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152939 1 sabouhallawa sabouhallawa commit-queue simon.fraser oldest_to_newest 1156965 0 sabouhallawa 2016-01-20 10:36:48 -0800 This clean up is the second step to fix the bug https://bugs.webkit.org/show_bug.cgi?id=152939. 1156968 1 269361 sabouhallawa 2016-01-20 10:48:50 -0800 Created attachment 269361 Patch 1157092 2 simon.fraser 2016-01-20 16:04:41 -0800 It would be nice to get some data on whether 32 cached colors is enough. It's certainly not for some of the benchmarks. 1157110 3 269361 commit-queue 2016-01-20 16:41:57 -0800 Comment on attachment 269361 Patch Clearing flags on attachment: 269361 Committed r195392: <http://trac.webkit.org/changeset/195392> 1157111 4 commit-queue 2016-01-20 16:42:01 -0800 All reviewed patches have been landed. Closing bug. 269361 2016-01-20 10:48:50 -0800 2016-01-20 16:41:57 -0800 Patch bug-153279-20160120104822.patch text/plain 2533 sabouhallawa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NTM1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAxLTIwICBTYWlkIEFi b3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIFRpbnlM UlVDYWNoZSBpbiBjYWNoaW5nIHRoZSBDR0NvbG9yUmVmIGluIFdlYkNvcmU6OmNhY2hlZENHQ29s b3IoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUz Mjc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV1 c2UgdGhlIG5ldyB0ZW1wbGF0ZSBUaW55TFJVQ2FjaGUgaW4gY2FjaGluZyB0aGUgQ0dDb2xvciBp bnN0ZWFkIG9mCisgICAgICAgIGhhdmluZyB0aGUgc2FtZSBjb2RlIHJlcGVhdGVkIHR3aWNlLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2cvQ29sb3JDRy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpsZWFrQ0dDb2xvcik6CisgICAgICAgIChXZWJDb3JlOjpSZXRhaW5QdHI8Q0dDb2xv clJlZj4+OjpjcmVhdGVWYWx1ZUZvcktleSk6CisgICAgICAgIChXZWJDb3JlOjpjYWNoZWRDR0Nv bG9yKToKKwogMjAxNi0wMS0yMCAgU2FpZCBBYm91LUhhbGxhd2EgIDxzYWJvdWhhbGxhd2FAYXBw bGUuY29tPgogCiAgICAgICAgIFJlZmFjdG9yIEF0b21pY1N0cmluZ0tleWVkTVJVQ2FjaGUgdG8g YmUgYSBnZW5lcmljIExSVSBjYWNoZQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvQ29sb3JDRy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2cvQ29sb3JDRy5jcHAJKHJldmlzaW9uIDE5NTM1NikKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0NvbG9yQ0cuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zMSw2ICszMSw3IEBACiAjaW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0Q0cuaCIKICNpbmNsdWRl IDx3dGYvQXNzZXJ0aW9ucy5oPgogI2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KKyNpbmNsdWRl IDx3dGYvVGlueUxSVUNhY2hlLmg+CiAjaWYgIVBMQVRGT1JNKElPUykKICNpbmNsdWRlIDxBcHBs aWNhdGlvblNlcnZpY2VzL0FwcGxpY2F0aW9uU2VydmljZXMuaD4KICNlbHNlCkBAIC0xMDcsNiAr MTA4LDEyIEBAIHN0YXRpYyBDR0NvbG9yUmVmIGxlYWtDR0NvbG9yKGNvbnN0IENvbG8KICAgICBy ZXR1cm4gQ0dDb2xvckNyZWF0ZShzUkdCQ29sb3JTcGFjZVJlZigpLCBjb21wb25lbnRzKTsKIH0K IAordGVtcGxhdGU8PgorUmV0YWluUHRyPENHQ29sb3JSZWY+IFRpbnlMUlVDYWNoZVBvbGljeTxD b2xvciwgUmV0YWluUHRyPENHQ29sb3JSZWY+Pjo6Y3JlYXRlVmFsdWVGb3JLZXkoY29uc3QgQ29s b3ImIGNvbG9yKQoreworICAgIHJldHVybiBhZG9wdENGKGxlYWtDR0NvbG9yKGNvbG9yKSk7Cit9 CisKIENHQ29sb3JSZWYgY2FjaGVkQ0dDb2xvcihjb25zdCBDb2xvciYgY29sb3IpCiB7CiAgICAg c3dpdGNoIChjb2xvci5yZ2IoKSkgewpAQCAtMTI2LDI0ICsxMzMsOCBAQCBDR0NvbG9yUmVmIGNh Y2hlZENHQ29sb3IoY29uc3QgQ29sb3ImIGNvCiAKICAgICBBU1NFUlQoY29sb3IucmdiKCkpOwog Ci0gICAgY29uc3Qgc2l6ZV90IGNhY2hlU2l6ZSA9IDMyOwotICAgIHN0YXRpYyBSR0JBMzIgY2Fj aGVkUkdCQVZhbHVlc1tjYWNoZVNpemVdOwotICAgIHN0YXRpYyBSZXRhaW5QdHI8Q0dDb2xvclJl Zj4qIGNhY2hlZENHQ29sb3JzID0gbmV3IFJldGFpblB0cjxDR0NvbG9yUmVmPltjYWNoZVNpemVd OwotCi0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBjYWNoZVNpemU7ICsraSkgewotICAgICAg ICBpZiAoY2FjaGVkUkdCQVZhbHVlc1tpXSA9PSBjb2xvci5yZ2IoKSkKLSAgICAgICAgICAgIHJl dHVybiBjYWNoZWRDR0NvbG9yc1tpXS5nZXQoKTsKLSAgICB9Ci0KLSAgICBDR0NvbG9yUmVmIG5l d0NHQ29sb3IgPSBsZWFrQ0dDb2xvcihjb2xvcik7Ci0KLSAgICBzdGF0aWMgc2l6ZV90IGN1cnNv cjsKLSAgICBjYWNoZWRSR0JBVmFsdWVzW2N1cnNvcl0gPSBjb2xvci5yZ2IoKTsKLSAgICBjYWNo ZWRDR0NvbG9yc1tjdXJzb3JdID0gYWRvcHRDRihuZXdDR0NvbG9yKTsKLSAgICBpZiAoKytjdXJz b3IgPT0gY2FjaGVTaXplKQotICAgICAgICBjdXJzb3IgPSAwOwotCi0gICAgcmV0dXJuIG5ld0NH Q29sb3I7CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPFRpbnlMUlVDYWNoZTxDb2xvciwgUmV0 YWluUHRyPENHQ29sb3JSZWY+LCAzMj4+IGNhY2hlOworICAgIHJldHVybiBjYWNoZS5nZXQoKS5n ZXQoY29sb3IpLmdldCgpOwogfQogCiB9Cg==