153278 2016-01-20 10:36:12 -0800 [B3][Win64] Compile fix. 2016-01-20 12:00:09 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1156964 0 peavo 2016-01-20 10:36:12 -0800 MSVC does not accept that a class declared as exported also have members declared as exported. error C2487: '{dtor}': member of dll interface class may not be declared with dll interface 1156966 1 269359 peavo 2016-01-20 10:40:42 -0800 Created attachment 269359 Patch 1156983 2 peavo 2016-01-20 11:26:56 -0800 Thanks for reviewing :) 1157005 3 peavo 2016-01-20 12:00:09 -0800 Committed r195362: <http://trac.webkit.org/changeset/195362> 269359 2016-01-20 10:40:42 -0800 2016-01-20 10:52:03 -0800 Patch bug-153278-20160120194024.patch text/plain 2342 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1MzU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTAxLTIwICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBbQjNdW1dpbjY0XSBDb21waWxlIGZpeC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzI3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1TVkMgZG9lcyBub3QgYWNjZXB0IHRoYXQgYSBjbGFzcyBk ZWNsYXJlZCBhcyBleHBvcnRlZCBhbHNvIGhhdmUgbWVtYmVycyBkZWNsYXJlZCBhcyBleHBvcnRl ZC4KKworICAgICAgICAqIGIzL0IzQ29uc3QzMlZhbHVlLmg6CisgICAgICAgICogYjMvQjNDb250 cm9sVmFsdWUuaDoKKwogMjAxNi0wMS0xOSAgQW5keSBWYW5XYWdvbmVyICA8dGhldGFsZWNyYWZ0 ZXJAZ21haWwuY29tPgogCiAgICAgICAgIFtJTlRMXSBJbXBsZW1lbnQgRGF0ZS5wcm90b3R5cGUu dG9Mb2NhbGVEYXRlU3RyaW5nIGluIEVDTUEtNDAyCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvQjNDb25zdDMyVmFsdWUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvQjNDb25zdDMyVmFsdWUuaAkocmV2aXNpb24gMTk1MzQ1KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL0IzQ29uc3QzMlZhbHVlLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2 LDcgQEAgY2xhc3MgSlNfRVhQT1JUX1BSSVZBVEUgQ29uc3QzMlZhbHVlIDogcAogcHVibGljOgog ICAgIHN0YXRpYyBib29sIGFjY2VwdHMoT3Bjb2RlIG9wY29kZSkgeyByZXR1cm4gb3Bjb2RlID09 IENvbnN0MzI7IH0KICAgICAKLSAgICBKU19FWFBPUlRfUFJJVkFURSB+Q29uc3QzMlZhbHVlKCk7 CisgICAgfkNvbnN0MzJWYWx1ZSgpOwogICAgIAogICAgIGludDMyX3QgdmFsdWUoKSBjb25zdCB7 IHJldHVybiBtX3ZhbHVlOyB9CiAKQEAgLTcxLDcgKzcxLDcgQEAgcHVibGljOgogICAgIFRyaVN0 YXRlIGJlbG93RXF1YWxDb25zdGFudChjb25zdCBWYWx1ZSogb3RoZXIpIGNvbnN0IG92ZXJyaWRl OwogCiBwcm90ZWN0ZWQ6Ci0gICAgSlNfRVhQT1JUX1BSSVZBVEUgdm9pZCBkdW1wTWV0YShDb21t YVByaW50ZXImLCBQcmludFN0cmVhbSYpIGNvbnN0IG92ZXJyaWRlOworICAgIHZvaWQgZHVtcE1l dGEoQ29tbWFQcmludGVyJiwgUHJpbnRTdHJlYW0mKSBjb25zdCBvdmVycmlkZTsKIAogICAgIGZy aWVuZCBjbGFzcyBQcm9jZWR1cmU7CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9C M0NvbnRyb2xWYWx1ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9C M0NvbnRyb2xWYWx1ZS5oCShyZXZpc2lvbiAxOTUzNDUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYjMvQjNDb250cm9sVmFsdWUuaAkod29ya2luZyBjb3B5KQpAQCAtNTYsNyArNTYsNyBAQCBw dWJsaWM6CiAKICAgICB0eXBlZGVmIFZlY3RvcjxGcmVxdWVudGVkQmxvY2ssIDI+IFN1Y2Nlc3Nv ckxpc3Q7CiAKLSAgICBKU19FWFBPUlRfUFJJVkFURSB+Q29udHJvbFZhbHVlKCk7CisgICAgfkNv bnRyb2xWYWx1ZSgpOwogCiAgICAgdW5zaWduZWQgbnVtU3VjY2Vzc29ycygpIGNvbnN0IHsgcmV0 dXJuIG1fc3VjY2Vzc29ycy5zaXplKCk7IH0KICAgICBjb25zdCBGcmVxdWVudGVkQmxvY2smIHN1 Y2Nlc3Nvcih1bnNpZ25lZCBpbmRleCkgY29uc3QgeyByZXR1cm4gbV9zdWNjZXNzb3JzW2luZGV4 XTsgfQpAQCAtOTEsNyArOTEsNyBAQCBwdWJsaWM6CiAgICAgdm9pZCBjb252ZXJ0VG9Pb3BzKCk7 CiAKIHByb3RlY3RlZDoKLSAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIGR1bXBNZXRhKENvbW1h UHJpbnRlciYsIFByaW50U3RyZWFtJikgY29uc3Qgb3ZlcnJpZGU7CisgICAgdm9pZCBkdW1wTWV0 YShDb21tYVByaW50ZXImLCBQcmludFN0cmVhbSYpIGNvbnN0IG92ZXJyaWRlOwogCiAgICAgLy8g VXNlIHRoaXMgZm9yIHN1YmNsYXNzZXMuCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUuLi4gQXJndW1l bnRzPgo=