153274 2016-01-20 04:52:39 -0800 [jhbuild] build error in LLVM OCaml bindings 2016-03-11 10:54:00 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 155369 1 fred.wang fred.wang alex cgarcia commit-queue jdiggs lforschler mcatanzaro ossy rego oldest_to_newest 1156937 0 269350 fred.wang 2016-01-20 04:52:39 -0800 Created attachment 269350 Patch disabling OCaml bindings On Debian testing, update-webkitgtk-libs fails to build LLVM. The failure happens when compiling llvm_executionengine.ml with the error "Error: Unbound value Ctypes.raw_address_of_ptr" One workaround is to disable the OCaml bindings (see for example https://github.com/Homebrew/homebrew/commit/c246ee22c19e5c97d3c6b311877dc0aca342bae1) but I'm not sure whether this is problematic for WebKit's need, though. 1169802 1 272653 fred.wang 2016-03-02 03:04:34 -0800 Created attachment 272653 Patch 1169803 2 fred.wang 2016-03-02 03:05:01 -0800 I still have this problem. I'm not sure whether I'm the only one but I'm asking review to at least get feedback on whether OCaml binding is really needed for WebKit. If it's not then it's safe to take this patch, that will solve my problem and even speed-up update-webkitgtk-libs for everybody. 1169809 3 ossy 2016-03-02 06:08:56 -0800 Shouldn't we simply remove llvm from jhbuild? Now FTL JIT uses B3 and all LLVM related thing was removed from the trunk. 1169815 4 272653 mcatanzaro 2016-03-02 08:16:26 -0800 Comment on attachment 272653 Patch Yes, please just remove llvm, nothing needs it anymore. 1169843 5 272662 fred.wang 2016-03-02 09:50:26 -0800 Created attachment 272662 Patch 1170118 6 fred.wang 2016-03-02 22:37:28 -0800 Committed r197495: <http://trac.webkit.org/changeset/197495> 1173762 7 mcatanzaro 2016-03-11 09:56:59 -0800 joanie: mcatanzaro: (or anyone) http://www.fpaste.org/337290/18831145/ joanie: look familiar and/or hints? mcatanzaro: joanie: Ooops, it's my fault mcatanzaro: I told fwang to remove llvm from our internal jhbuild, because WebKit no longer diirectly depends on LLVM. I said "nothing depends on it anymore" mcatanzaro: joanie: But we still need it, else it's a crapshoot whether mesa will build, because LLVM has no stable API. mcatanzaro: The problem is the mesa is our jhbuild environment is way too old for the LLVM in Fedora 24 joanie: i downgraded this machine to f23 joanie: and figured it was something I did mcatanzaro: joanie: It's probably too old for the LLVM in F23, then 1173763 8 mcatanzaro 2016-03-11 09:57:35 -0800 joanie: so what do you suggest? mcatanzaro: joanie: I'm gonna roll out the change that broke it, then fwang can submit another patch joanie: thank you 1173770 9 commit-queue 2016-03-11 10:00:19 -0800 Re-opened since this is blocked by bug 155369 1173793 10 272653 commit-queue 2016-03-11 10:52:38 -0800 Comment on attachment 272653 Patch Clearing flags on attachment: 272653 Committed r198029: <http://trac.webkit.org/changeset/198029> 269350 2016-01-20 04:52:39 -0800 2016-03-02 03:04:23 -0800 Patch disabling OCaml bindings jhbuild-llvm.patch text/plain 948 fred.wang ZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhidWls ZC5tb2R1bGVzCmluZGV4IDRjOTc0MzYuLjFlMDRlOTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9q aGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtNDY2LDcg KzQ2Niw3IEBACiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMgaWQ9Imxsdm0iCi0gICAg ICAgICAgICAgYXV0b2dlbmFyZ3M9Ii0tZW5hYmxlLW9wdGltaXplZCAtLWRpc2FibGUtdGVybWlu Zm8gLS1kaXNhYmxlLXpsaWIgLS1lbmFibGUtdGFyZ2V0cz1ob3N0IC0tZGlzYWJsZS1iYWNrdHJh Y2VzIC0tZGlzYWJsZS1jcmFzaC1vdmVycmlkZXMgLS1kaXNhYmxlLWV4cGVuc2l2ZS1jaGVja3Mg LS1kaXNhYmxlLWRlYnVnLXJ1bnRpbWUgLS1kaXNhYmxlLWFzc2VydGlvbnMgLS1lbmFibGUtc2hh cmVkIj4KKyAgICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1lbmFibGUtb3B0aW1pemVkIC0tZGlz YWJsZS10ZXJtaW5mbyAtLWRpc2FibGUtemxpYiAtLWVuYWJsZS10YXJnZXRzPWhvc3QgLS1kaXNh YmxlLWJhY2t0cmFjZXMgLS1kaXNhYmxlLWNyYXNoLW92ZXJyaWRlcyAtLWRpc2FibGUtZXhwZW5z aXZlLWNoZWNrcyAtLWRpc2FibGUtZGVidWctcnVudGltZSAtLWRpc2FibGUtYXNzZXJ0aW9ucyAt LWVuYWJsZS1zaGFyZWQgLS1lbmFibGUtYmluZGluZ3M9bm9uZSI+CiAgICAgPGJyYW5jaCByZXBv PSJsbHZtLm9yZyIKICAgICAgICAgICAgIG1vZHVsZT0iL3JlbGVhc2VzLzMuNy4wL2xsdm0tMy43 LjAuc3JjLnRhci54eiIgdmVyc2lvbj0iMy43LjAiIGNoZWNrb3V0ZGlyPSJsbHZtLTMuNy4wIgog ICAgICAgICAgICAgaGFzaD0ic2hhMjU2OmFiNDU4OTVmOWRjZGFkMWUxNDBhM2E3OWZkNzA5ZjY0 YjA1YWQ3MzY0ZTMwOGMwZTU4MmM1YjAyZTljYzMxNTMiLz4K 272653 2016-03-02 03:04:34 -0800 2016-03-11 10:52:38 -0800 Patch bug-153274-20160302120418.patch text/plain 1670 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3MTYzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTZmMTE5MmRkYmY5MTNhYWY5NWE0NmE0Y2E1YzM5NTBm MTc3ZWM2MC4uYzE1ZjMzNGQ1ZWNlNmVlMjY1ZTRkOGUwNzFlYmIzMTM4ODgwMGVkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTAzLTAyICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAg ICAgICBbamhidWlsZF0gRGlzYWJsZSBMTFZNIE9DYW1sIGJpbmRpbmdzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjc0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBndGsvamhidWlsZC5tb2R1bGVz OiBkaXNhYmxlIGFsbCAoYWN0dWFsbHkgb25seSBPQ2FtbCkgYmluZGluZ3MgZm9yIExMVk0uCisK IDIwMTYtMDItMjYgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4K IAogICAgICAgICBXM0MgdGVzdCBpbXBvcnRlciBzaG91bGQgaGF2ZSBhbiBvcHRpb24gdG8gY2xl YW4gdGhlIGRlc3RpbmF0aW9uIGRpcmVjdG9yeQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2poYnVp bGQubW9kdWxlcyBiL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggNmNiZjRmNjU3ZjFm ZmM2YTMyMDgzYzdhNWFiZDExZmU1YmVmYWUzNi4uM2Q3NzY4MjczZmU0NDU3MjU3NDhkY2ZiMTNl YWY5MzZhZDlmMDczZiAxMDA2NDQKLS0tIGEvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysg Yi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCkBAIC00NjgsNyArNDY4LDcgQEAKICAgPC9hdXRv dG9vbHM+CiAKICAgPGF1dG90b29scyBpZD0ibGx2bSIKLSAgICAgICAgICAgICBhdXRvZ2VuYXJn cz0iLS1lbmFibGUtb3B0aW1pemVkIC0tZGlzYWJsZS10ZXJtaW5mbyAtLWRpc2FibGUtemxpYiAt LWVuYWJsZS10YXJnZXRzPWhvc3QgLS1kaXNhYmxlLWJhY2t0cmFjZXMgLS1kaXNhYmxlLWNyYXNo LW92ZXJyaWRlcyAtLWRpc2FibGUtZXhwZW5zaXZlLWNoZWNrcyAtLWRpc2FibGUtZGVidWctcnVu dGltZSAtLWRpc2FibGUtYXNzZXJ0aW9ucyAtLWVuYWJsZS1zaGFyZWQiPgorICAgICAgICAgICAg IGF1dG9nZW5hcmdzPSItLWVuYWJsZS1vcHRpbWl6ZWQgLS1kaXNhYmxlLXRlcm1pbmZvIC0tZGlz YWJsZS16bGliIC0tZW5hYmxlLXRhcmdldHM9aG9zdCAtLWRpc2FibGUtYmFja3RyYWNlcyAtLWRp c2FibGUtY3Jhc2gtb3ZlcnJpZGVzIC0tZGlzYWJsZS1leHBlbnNpdmUtY2hlY2tzIC0tZGlzYWJs ZS1kZWJ1Zy1ydW50aW1lIC0tZGlzYWJsZS1hc3NlcnRpb25zIC0tZW5hYmxlLXNoYXJlZCAtLWVu YWJsZS1iaW5kaW5ncz1ub25lIj4KICAgICA8YnJhbmNoIHJlcG89Imxsdm0ub3JnIgogICAgICAg ICAgICAgbW9kdWxlPSIvcmVsZWFzZXMvMy43LjAvbGx2bS0zLjcuMC5zcmMudGFyLnh6IiB2ZXJz aW9uPSIzLjcuMCIgY2hlY2tvdXRkaXI9Imxsdm0tMy43LjAiCiAgICAgICAgICAgICBoYXNoPSJz aGEyNTY6YWI0NTg5NWY5ZGNkYWQxZTE0MGEzYTc5ZmQ3MDlmNjRiMDVhZDczNjRlMzA4YzBlNTgy YzViMDJlOWNjMzE1MyIvPgo= 272662 2016-03-02 09:50:26 -0800 2016-03-02 09:54:26 -0800 Patch bug-153274-20160302185010.patch text/plain 2571 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NDQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTBkYmM4YWQ5NDRhMDhiZjJhNzFhMmRiYjVjM2FjNjJm NDJkODA5MS4uODEwZGU5NzQxMTAzYjBlMWMxM2EyNzI3N2YxMzYzN2Y0YjFlZmRjMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTAzLTAyICBGcmVkZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAg ICAgICBbamhidWlsZF0gUmVtb3ZlIExMVk0gZGVwZW5kZW5jeS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzI3NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3RrL2poYnVpbGQubW9kdWxlczoKKwog MjAxNi0wMy0wMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAg ICAgIERpc2FibGUgRlRMIEpJVCB0ZXN0aW5nIG9uIDMyLWJpdCBKU0MgdGVzdGVyIGJvdHMKZGlm ZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhidWlsZC5t b2R1bGVzCmluZGV4IDA0MGZlZGM2NTYzN2RhOTdlOTU2YzBmZmRiNmM3MGQ4NmU5YWYzZmEuLjQ1 YWU5MGE2MjQ2OWRiODZjYjliNGVmZjc3NDE1N2RiOGMwYmY4ZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xz L2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAt MjgsNyArMjgsNiBAQAogICAgICAgPGRlcCBwYWNrYWdlPSJnc3QtcGx1Z2lucy1iYWQiLz4KICAg ICAgIDxkZXAgcGFja2FnZT0iZ3N0LWxpYmF2Ii8+CiAgICAgICA8ZGVwIHBhY2thZ2U9Im9wZW53 ZWJydGMiLz4KLSAgICAgIDxkZXAgcGFja2FnZT0ibGx2bSIvPgogICAgICAgPGRlcCBwYWNrYWdl PSJzaGFyZWQtbWltZS1pbmZvIi8+CiAgICAgICA8aWYgY29uZGl0aW9uLXNldD0ibGludXgiPgog ICAgICAgICAgIDxkZXAgcGFja2FnZT0ieHNlcnZlciIvPgpAQCAtNjgsOCArNjcsNiBAQAogICAg ICAgaHJlZj0iaHR0cDovL2Fub25naXQuZnJlZWRlc2t0b3Aub3JnL2dpdCIvPgogICA8cmVwb3Np dG9yeSB0eXBlPSJ0YXJiYWxsIiBuYW1lPSJwZW9wbGUuZnJlZWRlc2t0b3Aub3JnIgogICAgICAg aHJlZj0iaHR0cDovL3Blb3BsZS5mcmVlZGVza3RvcC5vcmciLz4KLSAgPHJlcG9zaXRvcnkgdHlw ZT0idGFyYmFsbCIgbmFtZT0ibGx2bS5vcmciCi0gICAgICBocmVmPSJodHRwOi8vbGx2bS5vcmci Lz4KIAogICA8YXV0b3Rvb2xzIGlkPSJjYWlybyI+CiAgICAgPGlmIGNvbmRpdGlvbi1zZXQ9Imxp bnV4Ij4KQEAgLTQzMCw5ICs0MjcsNiBAQAogICAgICAgICAgICAgcmVwbz0icGVvcGxlLmZyZWVk ZXNrdG9wLm9yZyIKICAgICAgICAgICAgIGhhc2g9InNoYTI1Njo4MzQwZTY0Y2RjOTE5OTk4NDA0 MDRjMjExNDk2ZjNkZTM4ZTdiNGNiMzhkYjM0ZTJmNzJmMTY0MmM1MTM0NzYwIj4KICAgICA8L2Jy YW5jaD4KLSAgICA8ZGVwZW5kZW5jaWVzPgotICAgICAgPGRlcCBwYWNrYWdlPSJsbHZtIi8+Ci0g ICAgPC9kZXBlbmRlbmNpZXM+CiAgIDwvYXV0b3Rvb2xzPgogCiAgIDxhdXRvdG9vbHMgaWQ9Imxp YnVzcnNjdHAiIHN1cHBvcnRzLW5vbi1zcmNkaXItYnVpbGRzPSJubyIgYXV0b2dlbi1zaD0iLi9i b290c3RyYXA7IC4vY29uZmlndXJlIC0tZGlzYWJsZS13YXJuaW5ncy1hcy1lcnJvcnMiPgpAQCAt NDY4LDEzICs0NjIsNiBAQAogICAgIDxicmFuY2ggcmVwbz0iZ2l0aHViLmNvbSIgbW9kdWxlPSJF cmljc3NvblJlc2VhcmNoL29wZW53ZWJydGMuZ2l0IiBjaGVja291dGRpcj0ib3BlbndlYnJ0YyIg dGFnPSIxMzUxNmM3Zjc5YTBjNDhiYjQxMTQ2NGY3NjEzZDRiNDI2YzcwZjViIi8+CiAgIDwvYXV0 b3Rvb2xzPgogCi0gIDxhdXRvdG9vbHMgaWQ9Imxsdm0iCi0gICAgICAgICAgICAgYXV0b2dlbmFy Z3M9Ii0tZW5hYmxlLW9wdGltaXplZCAtLWRpc2FibGUtdGVybWluZm8gLS1kaXNhYmxlLXpsaWIg LS1lbmFibGUtdGFyZ2V0cz1ob3N0IC0tZGlzYWJsZS1iYWNrdHJhY2VzIC0tZGlzYWJsZS1jcmFz aC1vdmVycmlkZXMgLS1kaXNhYmxlLWV4cGVuc2l2ZS1jaGVja3MgLS1kaXNhYmxlLWRlYnVnLXJ1 bnRpbWUgLS1kaXNhYmxlLWFzc2VydGlvbnMgLS1lbmFibGUtc2hhcmVkIj4KLSAgICA8YnJhbmNo IHJlcG89Imxsdm0ub3JnIgotICAgICAgICAgICAgbW9kdWxlPSIvcmVsZWFzZXMvMy43LjAvbGx2 bS0zLjcuMC5zcmMudGFyLnh6IiB2ZXJzaW9uPSIzLjcuMCIgY2hlY2tvdXRkaXI9Imxsdm0tMy43 LjAiCi0gICAgICAgICAgICBoYXNoPSJzaGEyNTY6YWI0NTg5NWY5ZGNkYWQxZTE0MGEzYTc5ZmQ3 MDlmNjRiMDVhZDczNjRlMzA4YzBlNTgyYzViMDJlOWNjMzE1MyIvPgotICA8L2F1dG90b29scz4K LQogICA8YXV0b3Rvb2xzIGlkPSJnc2V0dGluZ3MtZGVza3RvcC1zY2hlbWFzIiBhdXRvZ2VuLXNo PSJjb25maWd1cmUiPgogICAgIDxkZXBlbmRlbmNpZXM+CiAgICAgICA8ZGVwIHBhY2thZ2U9Imds aWIiLz4K