15326 2007-09-30 02:19:30 -0700 innerHTML updates layout every time (hurts celtickane JS benchmark) 2007-10-02 20:11:40 -0700 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) All OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 57430 0 mjs 2007-09-30 02:19:30 -0700 innerHTML updates layout every time it is read. This can be seen on "http://celtickane.com/projects/jsspeed2007.php", where on the DOM test (actually primarily a test of innerHTML) we are currently the slowest of any browser. 57431 1 16467 mjs 2007-09-30 02:21:42 -0700 Created attachment 16467 don't update layout for innerHTML 57443 2 16467 eric 2007-09-30 06:48:22 -0700 Comment on attachment 16467 don't update layout for innerHTML I also looked, it appears that createMarkup(Node*... does not actually touch the render tree (renderer()) so I agree, this looks safe. r=me 57621 3 mjs 2007-10-02 01:23:10 -0700 Incidentally this patch is a 65% speedup on that one test in the benchmark. 16467 2007-09-30 02:21:42 -0700 2007-09-30 06:48:22 -0700 don't update layout for innerHTML faster-innerhtml.patch.txt text/plain 1171 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI1ODA5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDctMDkt MjkgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gZml4ZWQgImlubmVySFRN TCB1cGRhdGVzIGxheW91dCBldmVyeSB0aW1lICh2ZXJ5IGJhZCBpZiBhZGRpbmcgdG8gaXQgaW4g YSBsb29wKSIKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTUzMjYKKworICAgICAgICAqIGVkaXRpbmcvbWFya3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmNyZWF0ZU1hcmt1cCk6IFRoZSBOb2RlIHZlcnNpb24gb2YgdGhpcyBmdW5jdGlvbiBjdXJyZW50 bHkgbmV2ZXIgdXNlcworICAgICAgICB0aGUgcmVuZGVyIHRyZWUsIHNvIGRvbid0IGJvdGhlciB0 byB1cGRhdGUgbGF5b3V0LiBUaGlzIGlzIHRoZSB2ZXJzaW9uIHVzZWQgZm9yCisgICAgICAgIGlu bmVySFRNTC4KKwogMjAwNy0wOS0yOSAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNr ZUBzZWxmaXNoLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJrLgpJbmRleDogZWRpdGlu Zy9tYXJrdXAuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGVkaXRpbmcvbWFya3VwLmNwcAkocmV2aXNpb24g MjU4MDkpCisrKyBlZGl0aW5nL21hcmt1cC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcyOSw3ICs3 MjksNiBAQCBEZXByZWNhdGVkU3RyaW5nIGNyZWF0ZU1hcmt1cChjb25zdCBOb2RlCiAgICAgICAg IGRlbGV0ZUJ1dHRvbi0+ZGlzYWJsZSgpOwogICAgIH0KIAotICAgIGRvY3VtZW50LT51cGRhdGVM YXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKICAgICBEZXByZWNhdGVkU3RyaW5nIHJl c3VsdChtYXJrdXAoY29uc3RfY2FzdDxOb2RlKj4obm9kZSksIGluY2x1ZGVDaGlsZHJlbiwgbm9k ZXMpKTsKIAogICAgIGlmIChkZWxldGVCdXR0b24pCg==