153254 2016-01-19 14:42:55 -0800 Move away from NSSpellChecker's showCandidates method 2016-01-19 16:57:21 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bdakin webkit-unassigned commit-queue oldest_to_newest 1156748 0 bdakin 2016-01-19 14:42:55 -0800 Move away from NSSpellChecker's showCandidates method rdar://problem/24216292 1156749 1 269299 bdakin 2016-01-19 14:46:00 -0800 Created attachment 269299 Patch 1156750 2 commit-queue 2016-01-19 14:47:51 -0800 Attachment 269299 did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:1172: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1156792 3 bdakin 2016-01-19 16:47:59 -0800 Thanks Tim! http://trac.webkit.org/changeset/195324 1156793 4 bdakin 2016-01-19 16:57:21 -0800 Build fix for 32 bit: 195327 269299 2016-01-19 14:46:00 -0800 2016-01-19 16:45:29 -0800 Patch for-review.txt text/plain 3225 bdakin SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5NTMxNikKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAxLTE5 ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGF3YXkgZnJv bSBOU1NwZWxsQ2hlY2tlcidzIHNob3dDYW5kaWRhdGVzIG1ldGhvZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjU0CisgICAgICAgIC1hbmQgY29y cmVzcG9uZGluZy0KKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjQyMTYyOTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dl YkVkaXRvckNsaWVudC5tbToKKyAgICAgICAgKFdlYkVkaXRvckNsaWVudDo6aGFuZGxlUmVxdWVz dGVkQ2FuZGlkYXRlcyk6CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAo LVtXZWJWaWV3IHVwZGF0ZVdlYlZpZXdBZGRpdGlvbnNdKToKKyAgICAgICAgKC1bV2ViVmlldyBz aG93Q2FuZGlkYXRlczpmb3JTdHJpbmc6aW5SZWN0OnZpZXc6Y29tcGxldGlvbkhhbmRsZXI6XSk6 CisgICAgICAgICogV2ViVmlldy9XZWJWaWV3SW50ZXJuYWwuaDoKKwogMjAxNi0wMS0xOSAgQ29t bWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjE5NTMwMC4KSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVT dXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21h Yy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGllbnQubW0JKHJldmlzaW9uIDE5NTI5NykKKysr IFNvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVudC5tbQkod29y a2luZyBjb3B5KQpAQCAtMTE2OSw3ICsxMTY5LDcgQEAgdm9pZCBXZWJFZGl0b3JDbGllbnQ6Omhh bmRsZVJlcXVlc3RlZENhbgogICAgICAgICByZWN0Rm9yU2VsZWN0aW9uQ2FuZGlkYXRlcyA9IGZy YW1lLT52aWV3KCktPmNvbnRlbnRzVG9XaW5kb3cocXVhZHNbMF0uZW5jbG9zaW5nQm91bmRpbmdC b3goKSk7CiAKICAgICBhdXRvIHdlYWtFZGl0b3IgPSBtX3dlYWtQdHJGYWN0b3J5LmNyZWF0ZVdl YWtQdHIoKTsKLSAgICBbW05TU3BlbGxDaGVja2VyIHNoYXJlZFNwZWxsQ2hlY2tlcl0gc2hvd0Nh bmRpZGF0ZXM6Y2FuZGlkYXRlcyBmb3JTdHJpbmc6ZnJhbWUtPmVkaXRvcigpLnN0cmluZ0ZvckNh bmRpZGF0ZVJlcXVlc3QoKSBpblJlY3Q6cmVjdEZvclNlbGVjdGlvbkNhbmRpZGF0ZXMgdmlldzpt X3dlYlZpZXcgY29tcGxldGlvbkhhbmRsZXI6W3dlYWtFZGl0b3JdKE5TVGV4dENoZWNraW5nUmVz dWx0ICphY2NlcHRlZENhbmRpZGF0ZSkgeworICAgIFttX3dlYlZpZXcgc2hvd0NhbmRpZGF0ZXM6 Y2FuZGlkYXRlcyBmb3JTdHJpbmc6ZnJhbWUtPmVkaXRvcigpLnN0cmluZ0ZvckNhbmRpZGF0ZVJl cXVlc3QoKSBpblJlY3Q6cmVjdEZvclNlbGVjdGlvbkNhbmRpZGF0ZXMgdmlldzptX3dlYlZpZXcg Y29tcGxldGlvbkhhbmRsZXI6W3dlYWtFZGl0b3JdKE5TVGV4dENoZWNraW5nUmVzdWx0ICphY2Nl cHRlZENhbmRpZGF0ZSkgewogICAgICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFp bl9xdWV1ZSgpLCBeewogICAgICAgICAgICAgaWYgKCF3ZWFrRWRpdG9yKQogICAgICAgICAgICAg ICAgIHJldHVybjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHJldmlz aW9uIDE5NTI5NykKKysrIFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkod29y a2luZyBjb3B5KQpAQCAtNjYwNSw2ICs2NjA1LDEwIEBAIC0gKHZvaWQpdXBkYXRlV2ViVmlld0Fk ZGl0aW9ucwogewogfQogCistICh2b2lkKXNob3dDYW5kaWRhdGVzOihOU0FycmF5PE5TVGV4dENo ZWNraW5nUmVzdWx0ICo+ICopY2FuZGlkYXRlcyBmb3JTdHJpbmc6KE5TU3RyaW5nICopc3RyaW5n IGluUmVjdDooTlNSZWN0KXJlY3RPZlR5cGVkU3RyaW5nIHZpZXc6KE5TVmlldyAqKXZpZXcgY29t cGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5TVGV4dENoZWNraW5nUmVzdWx0ICphY2NlcHRlZENh bmRpZGF0ZSkpY29tcGxldGlvbkJsb2NrCit7Cit9CisKIEBlbmQKICNlbmRpZiAvLyBQTEFURk9S TShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMjAwICYmIFVT RShBUFBMRV9JTlRFUk5BTF9TREspCiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcv V2ViVmlld0ludGVybmFsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9tYWMvV2ViVmll dy9XZWJWaWV3SW50ZXJuYWwuaAkocmV2aXNpb24gMTk1Mjk3KQorKysgU291cmNlL1dlYktpdC9t YWMvV2ViVmlldy9XZWJWaWV3SW50ZXJuYWwuaAkod29ya2luZyBjb3B5KQpAQCAtMjkxLDQgKzI5 MSw1IEBAIEBpbnRlcmZhY2UgV2ViVmlldyAoV2ViVmlld090aGVySW50ZXJuYWwKIAogQGludGVy ZmFjZSBXZWJWaWV3IChXZWJVcGRhdGVXZWJWaWV3QWRkaXRpb25zKQogLSAodm9pZCl1cGRhdGVX ZWJWaWV3QWRkaXRpb25zOworLSAodm9pZClzaG93Q2FuZGlkYXRlczooTlNBcnJheTxOU1RleHRD aGVja2luZ1Jlc3VsdCAqPiAqKWNhbmRpZGF0ZXMgZm9yU3RyaW5nOihOU1N0cmluZyAqKXN0cmlu ZyBpblJlY3Q6KE5TUmVjdClyZWN0T2ZUeXBlZFN0cmluZyB2aWV3OihOU1ZpZXcgKil2aWV3IGNv bXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU1RleHRDaGVja2luZ1Jlc3VsdCAqYWNjZXB0ZWRD YW5kaWRhdGUpKWNvbXBsZXRpb25CbG9jazsKIEBlbmQK