153248 2016-01-19 14:03:55 -0800 REGRESSION: Web Inspector: Hovering linkified node references should show node highlight 2016-01-19 15:04:05 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1156727 0 joepeck 2016-01-19 14:03:55 -0800 * SUMMARY Hovering linkified node references should show node highlight. Not sure when this regressed, probably when we switched to a default parameter. 1156729 1 webkit-bug-importer 2016-01-19 14:04:29 -0800 <rdar://problem/24245518> 1156732 2 269290 joepeck 2016-01-19 14:06:44 -0800 Created attachment 269290 [PATCH] Proposed Fix 1156733 3 269290 joepeck 2016-01-19 14:08:15 -0800 Comment on attachment 269290 [PATCH] Proposed Fix Looking around at other code, I think I found another issue. 1156734 4 269290 joepeck 2016-01-19 14:09:46 -0800 Comment on attachment 269290 [PATCH] Proposed Fix Nevermind! In that case it was expected to hide the highlight. 1156757 5 269290 commit-queue 2016-01-19 15:04:01 -0800 Comment on attachment 269290 [PATCH] Proposed Fix Clearing flags on attachment: 269290 Committed r195318: <http://trac.webkit.org/changeset/195318> 1156758 6 commit-queue 2016-01-19 15:04:05 -0800 All reviewed patches have been landed. Closing bug. 269290 2016-01-19 14:06:44 -0800 2016-01-19 15:04:01 -0800 [PATCH] Proposed Fix node-highlight.patch text/plain 1680 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ1N2EyMWMuLmE2YzAyMDAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAxLTE5ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogV2ViIEluc3Bl Y3RvcjogSG92ZXJpbmcgbGlua2lmaWVkIG5vZGUgcmVmZXJlbmNlcyBzaG91bGQgc2hvdyBub2Rl IGhpZ2hsaWdodAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTUzMjQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNDI0NTUxOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFz ZS9ET01VdGlsaXRpZXMuanM6CisgICAgICAgIFNob3cgdGhlIGNvbXBsZXRlIG5vZGUgaGlnaGxp Z2h0IGRldGFpbHMgKGNvbG9ycyBhbmQgbm9kZSBpbmZvKS4KKwogMjAxNi0wMS0xMyAgSm9zZXBo IFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6 IEluc3BlY3RvciBzaG91bGQgdXNlIHRoZSBsYXN0IHNvdXJjZVVSTCAvIHNvdXJjZU1hcHBpbmdV UkwgZGlyZWN0aXZlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9CYXNlL0RPTVV0aWxpdGllcy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0Jhc2UvRE9NVXRpbGl0aWVzLmpzCmluZGV4IDIyMjUxZWYuLmNhNzEyOTggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvRE9NVXRpbGl0 aWVzLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvRE9N VXRpbGl0aWVzLmpzCkBAIC05OCw3ICs5OCw3IEBAIFdlYkluc3BlY3Rvci5saW5raWZ5Tm9kZVJl ZmVyZW5jZSA9IGZ1bmN0aW9uKG5vZGUpCiAgICAgbGluay50aXRsZSA9IGRpc3BsYXlOYW1lOwog CiAgICAgbGluay5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIFdlYkluc3BlY3Rvci5kb21UcmVl TWFuYWdlci5pbnNwZWN0RWxlbWVudC5iaW5kKFdlYkluc3BlY3Rvci5kb21UcmVlTWFuYWdlciwg bm9kZS5pZCkpOwotICAgIGxpbmsuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdmVyIiwgV2ViSW5z cGVjdG9yLmRvbVRyZWVNYW5hZ2VyLmhpZ2hsaWdodERPTU5vZGUuYmluZChXZWJJbnNwZWN0b3Iu ZG9tVHJlZU1hbmFnZXIsIG5vZGUuaWQsICIiKSk7CisgICAgbGluay5hZGRFdmVudExpc3RlbmVy KCJtb3VzZW92ZXIiLCBXZWJJbnNwZWN0b3IuZG9tVHJlZU1hbmFnZXIuaGlnaGxpZ2h0RE9NTm9k ZS5iaW5kKFdlYkluc3BlY3Rvci5kb21UcmVlTWFuYWdlciwgbm9kZS5pZCwgImFsbCIpKTsKICAg ICBsaW5rLmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlb3V0IiwgV2ViSW5zcGVjdG9yLmRvbVRyZWVN YW5hZ2VyLmhpZGVET01Ob2RlSGlnaGxpZ2h0LmJpbmQoV2ViSW5zcGVjdG9yLmRvbVRyZWVNYW5h Z2VyKSk7CiAKICAgICByZXR1cm4gbGluazsK