153234 2016-01-19 07:01:27 -0800 [B3][Win64] Compile and warning fixes. 2016-01-19 13:49:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue fpizlo keith_miller mark.lam msaboff saam oldest_to_newest 1156601 0 peavo 2016-01-19 07:01:27 -0800 The size of 'long' is 4 bytes on Win64. We can use 'long long' instead, when we want the size to be 8 bytes. 1156602 1 269267 peavo 2016-01-19 07:05:48 -0800 Created attachment 269267 Patch 1156694 2 peavo 2016-01-19 12:51:29 -0800 Thanks for the review :) 1156723 3 269267 commit-queue 2016-01-19 13:49:24 -0800 Comment on attachment 269267 Patch Clearing flags on attachment: 269267 Committed r195314: <http://trac.webkit.org/changeset/195314> 1156724 4 commit-queue 2016-01-19 13:49:28 -0800 All reviewed patches have been landed. Closing bug. 269267 2016-01-19 07:05:48 -0800 2016-01-19 13:49:24 -0800 Patch bug-153234-20160119160527.patch text/plain 2391 peavo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk1Mjg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE2LTAxLTE5ICBQZXIgQXJuZSBWb2xsYW4gIDxwZWF2b0BvdXRsb29rLmNvbT4KKworICAg ICAgICBbQjNdW1dpbjY0XSBDb21waWxlIGFuZCB3YXJuaW5nIGZpeGVzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjM0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHNpemUgb2YgJ2xvbmcnIGlz IDQgYnl0ZXMgb24gV2luNjQuIFdlIGNhbiB1c2UgJ2xvbmcgbG9uZycgaW5zdGVhZCwKKyAgICAg ICAgd2hlbiB3ZSB3YW50IHRoZSBzaXplIHRvIGJlIDggYnl0ZXMuCisKKyAgICAgICAgKiBiMy9C M0xvd2VyTWFjcm9zQWZ0ZXJPcHRpbWl6YXRpb25zLmNwcDoKKyAgICAgICAgKiBiMy9CM1JlZHVj ZVN0cmVuZ3RoLmNwcDoKKwogMjAxNi0wMS0xOCAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxl LmNvbT4KIAogICAgICAgICBhc3NlcnRpb25zIGluIEJ5dGVjb2RlVXNlRGVmLmggYWJvdXQgb3Bj b2RlIGxlbmd0aCBhcmUgb2ZmIGJ5IG9uZQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Iz L0IzTG93ZXJNYWNyb3NBZnRlck9wdGltaXphdGlvbnMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9CM0xvd2VyTWFjcm9zQWZ0ZXJPcHRpbWl6YXRpb25zLmNwcAko cmV2aXNpb24gMTk1Mjg2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzTG93ZXJNYWNy b3NBZnRlck9wdGltaXphdGlvbnMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw3ICs3OCw3IEBA IHByaXZhdGU6CiAKICAgICAgICAgICAgICAgICBWYWx1ZSogbWFzayA9IG51bGxwdHI7CiAgICAg ICAgICAgICAgICAgaWYgKG1fdmFsdWUtPnR5cGUoKSA9PSBEb3VibGUpCi0gICAgICAgICAgICAg ICAgICAgIG1hc2sgPSBtX2luc2VydGlvblNldC5pbnNlcnQ8Q29uc3REb3VibGVWYWx1ZT4obV9p bmRleCwgbV9vcmlnaW4sIGJpdHdpc2VfY2FzdDxkb3VibGU+KH4oMWwgPDwgNjMpKSk7CisgICAg ICAgICAgICAgICAgICAgIG1hc2sgPSBtX2luc2VydGlvblNldC5pbnNlcnQ8Q29uc3REb3VibGVW YWx1ZT4obV9pbmRleCwgbV9vcmlnaW4sIGJpdHdpc2VfY2FzdDxkb3VibGU+KH4oMWxsIDw8IDYz KSkpOwogICAgICAgICAgICAgICAgIGVsc2UgaWYgKG1fdmFsdWUtPnR5cGUoKSA9PSBGbG9hdCkK ICAgICAgICAgICAgICAgICAgICAgbWFzayA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydDxDb25zdEZs b2F0VmFsdWU+KG1faW5kZXgsIG1fb3JpZ2luLCBiaXR3aXNlX2Nhc3Q8ZmxvYXQ+KH4oMSA8PCAz MSkpKTsKICAgICAgICAgICAgICAgICBlbHNlCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2IzL0IzUmVkdWNlU3RyZW5ndGguY3BwCShyZXZpc2lvbiAxOTUyODYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTU5Nyw3ICs1OTcsNyBAQCBwcml2YXRlOgogICAgICAgICAgICAgaWYgKG1fdmFsdWUtPmNoaWxk KDApLT5vcGNvZGUoKSA9PSBCaXR3aXNlQ2FzdCkgewogICAgICAgICAgICAgICAgIFZhbHVlKiBt YXNrOwogICAgICAgICAgICAgICAgIGlmIChtX3ZhbHVlLT50eXBlKCkgPT0gRG91YmxlKQotICAg ICAgICAgICAgICAgICAgICBtYXNrID0gbV9pbnNlcnRpb25TZXQuaW5zZXJ0PENvbnN0NjRWYWx1 ZT4obV9pbmRleCwgbV92YWx1ZS0+b3JpZ2luKCksIH4oMWwgPDwgNjMpKTsKKyAgICAgICAgICAg ICAgICAgICAgbWFzayA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydDxDb25zdDY0VmFsdWU+KG1faW5k ZXgsIG1fdmFsdWUtPm9yaWdpbigpLCB+KDFsbCA8PCA2MykpOwogICAgICAgICAgICAgICAgIGVs c2UKICAgICAgICAgICAgICAgICAgICAgbWFzayA9IG1faW5zZXJ0aW9uU2V0Lmluc2VydDxDb25z dDMyVmFsdWU+KG1faW5kZXgsIG1fdmFsdWUtPm9yaWdpbigpLCB+KDFsIDw8IDMxKSk7CiAK