153233 2016-01-19 06:48:34 -0800 [GTK] Runtime critical warnings when loading a URL after a session restore 2016-01-19 08:50:18 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1156597 0 cgarcia 2016-01-19 06:48:34 -0800 This happens when doing a normal load after restoring the back forward list form session state and the list contained forward items. In that case the forward items are removed from the list and we try to reference a WebBackForwardListItem wrapper that hasn't been created. We create the wrappers on demand, and when the back forward list is populated form session state, items are added to the list without creating their wrappers. That was not possible before, and that's why we assumed that any item that is removed from the list should have a wrapper already created. I wrote a new test case for this: /webkit2/WebKitWebView/navigation-after-session-restore: (bin/TestWebKitAPI/WebKit2Gtk/TestBackForwardList:31773): GLib-GObject-CRITICAL **: g_object_ref: assertion 'G_IS_OBJECT (object)' failed 1156598 1 269266 cgarcia 2016-01-19 06:51:16 -0800 Created attachment 269266 Patch 1156599 2 commit-queue 2016-01-19 06:52:58 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1156600 3 269266 mcatanzaro 2016-01-19 06:58:20 -0800 Comment on attachment 269266 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269266&action=review > Source/WebKit2/ChangeLog:9 > + forward list form session state and the list contained forward form -> from > Source/WebKit2/ChangeLog:13 > + the back forward list is populated form session state, items are form -> from > Source/WebKit2/ChangeLog:16 > + removed from the list should have a wrapper already created. Good job! :p > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:378 > + // forward items doesn't produce any runtime critical warning. See bug # See bug #153233. > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:395 > + // A normal load after a session restore should remove the forward list, add the new item and updated the current one. updated -> update 1156607 4 cgarcia 2016-01-19 08:48:28 -0800 (In reply to comment #3) > Comment on attachment 269266 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269266&action=review Thanks for the review. > > Source/WebKit2/ChangeLog:9 > > + forward list form session state and the list contained forward > > form -> from > > > Source/WebKit2/ChangeLog:13 > > + the back forward list is populated form session state, items are > > form -> from > > > Source/WebKit2/ChangeLog:16 > > + removed from the list should have a wrapper already created. > > Good job! :p :-D It's seems I don't know how to type from. > > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:378 > > + // forward items doesn't produce any runtime critical warning. See bug # > > See bug #153233. I had already changed this, but forgot to save the files changes :-P > > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:395 > > + // A normal load after a session restore should remove the forward list, add the new item and updated the current one. > > updated -> update Thanks! 1156608 5 cgarcia 2016-01-19 08:50:18 -0800 Committed r195288: <http://trac.webkit.org/changeset/195288> 269266 2016-01-19 06:51:16 -0800 2016-01-19 06:58:20 -0800 Patch wk2-session-restore-warnings.diff text/plain 6399 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YTY1ZTk2Li4wNTJjNjkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTYtMDEtMTkgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFJ1bnRpbWUgY3JpdGljYWwgd2FybmluZ3Mgd2hlbiBsb2FkaW5n IGEgVVJMIGFmdGVyIGEgc2Vzc2lvbiByZXN0b3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMyMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGhhcHBlbnMgd2hlbiBkb2luZyBhIG5vcm1hbCBs b2FkIGFmdGVyIHJlc3RvcmluZyB0aGUgYmFjaworICAgICAgICBmb3J3YXJkIGxpc3QgZm9ybSBz ZXNzaW9uIHN0YXRlIGFuZCB0aGUgbGlzdCBjb250YWluZWQgZm9yd2FyZAorICAgICAgICBpdGVt cy4gSW4gdGhhdCBjYXNlIHRoZSBmb3J3YXJkIGl0ZW1zIGFyZSByZW1vdmVkIGZyb20gdGhlIGxp c3QKKyAgICAgICAgYW5kIHdlIHRyeSB0byByZWZlcmVuY2UgYSBXZWJCYWNrRm9yd2FyZExpc3RJ dGVtIHdyYXBwZXIgdGhhdAorICAgICAgICBoYXNuJ3QgYmVlbiBjcmVhdGVkLiBXZSBjcmVhdGUg dGhlIHdyYXBwZXJzIG9uIGRlbWFuZCwgYW5kIHdoZW4KKyAgICAgICAgdGhlIGJhY2sgZm9yd2Fy ZCBsaXN0IGlzIHBvcHVsYXRlZCBmb3JtIHNlc3Npb24gc3RhdGUsIGl0ZW1zIGFyZQorICAgICAg ICBhZGRlZCB0byB0aGUgbGlzdCB3aXRob3V0IGNyZWF0aW5nIHRoZWlyIHdyYXBwZXJzLiBUaGF0 IHdhcyBub3QKKyAgICAgICAgcG9zc2libGUgYmVmb3JlLCBhbmQgdGhhdCdzIHdoeSB3ZSBhc3N1 bWVkIHRoYXQgYW55IGl0ZW0gdGhhdCBpcworICAgICAgICByZW1vdmVkIGZyb20gdGhlIGxpc3Qg c2hvdWxkIGhhdmUgYSB3cmFwcGVyIGFscmVhZHkgY3JlYXRlZC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ3RrL1dlYktpdEJhY2tGb3J3YXJkTGlzdC5jcHA6CisgICAgICAgICh3ZWJraXRC YWNrRm9yd2FyZExpc3RDaGFuZ2VkKTogSWYgd2UgZG9uJ3QgaGF2ZSBhIHdyYXBwZXIgZm9yIHRo ZQorICAgICAgICByZW1vdmVkIGl0ZW0sIGNyZWF0ZSBhIG5ldyBvbmUgdG8gYmUgcGFzc2VkIHRv IHRoZSBzaWduYWwsIGJ1dAorICAgICAgICB3aXRob3V0IGFkZGluZyBpdCB0byB0aGUgbWFwLgor CiAyMDE2LTAxLTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAg IENoYXJhY3RlckRhdGE6OnNldERhdGEgZG9lc24ndCBuZWVkIEV4Y2VwdGlvbkNvZGUgYXMgYW4g b3V0IGFyZ3VtZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRCYWNrRm9yd2FyZExpc3QuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0QmFja0ZvcndhcmRMaXN0LmNwcAppbmRleCAwMWUyODEwLi4wNzYyZDAyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRCYWNrRm9y d2FyZExpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dEJhY2tGb3J3YXJkTGlzdC5jcHAKQEAgLTEzNSw4ICsxMzUsMTUgQEAgdm9pZCB3ZWJraXRCYWNr Rm9yd2FyZExpc3RDaGFuZ2VkKFdlYktpdEJhY2tGb3J3YXJkTGlzdCogYmFja0ZvcndhcmRMaXN0 LCBXZWJCYWMKIAogICAgIFdlYktpdEJhY2tGb3J3YXJkTGlzdFByaXZhdGUqIHByaXYgPSBiYWNr Rm9yd2FyZExpc3QtPnByaXY7CiAgICAgZm9yIChhdXRvJiB3ZWJJdGVtIDogd2ViUmVtb3ZlZEl0 ZW1zKSB7Ci0gICAgICAgIHJlbW92ZWRJdGVtcyA9IGdfbGlzdF9wcmVwZW5kKHJlbW92ZWRJdGVt cywgZ19vYmplY3RfcmVmKHByaXYtPml0ZW1zTWFwLmdldCh3ZWJJdGVtLmdldCgpKS5nZXQoKSkp OwotICAgICAgICBwcml2LT5pdGVtc01hcC5yZW1vdmUod2ViSXRlbS5nZXQoKSk7CisgICAgICAg IC8vIEFmdGVyIGEgc2Vzc2lvbiByZXN0b3JlLCB3ZSBzdGlsbCBkb24ndCBoYXZlIHdyYXBwZXJz IGZvciB0aGUgbmV3bHkgYWRkZWQgaXRlbXMsIHNvIGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRoYXQK KyAgICAgICAgLy8gdGhlIHJlbW92ZWQgaXRlbXMgYXJlIG5vdCBpbiB0aGUgbWFwLiBJbiB0aGF0 IGNhc2Ugd2UgY3JlYXRlIGEgd3JhcHBlciBub3cgdG8gcGFzcyBpdCB0aGUgY2hhbmdlZCBzaWdu YWwsIGJ1dAorICAgICAgICAvLyB3aXRob3V0IGFkZGluZyBpdCB0byB0aGUgaXRlbSBtYXAuIFNl ZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjMzLgorICAgICAg ICBHUmVmUHRyPFdlYktpdEJhY2tGb3J3YXJkTGlzdEl0ZW0+IHJlbW92ZWRJdGVtID0gcHJpdi0+ aXRlbXNNYXAuZ2V0KHdlYkl0ZW0uZ2V0KCkpOworICAgICAgICBpZiAocmVtb3ZlZEl0ZW0pIHsK KyAgICAgICAgICAgIHJlbW92ZWRJdGVtcyA9IGdfbGlzdF9wcmVwZW5kKHJlbW92ZWRJdGVtcywg Z19vYmplY3RfcmVmKHJlbW92ZWRJdGVtLmdldCgpKSk7CisgICAgICAgICAgICBwcml2LT5pdGVt c01hcC5yZW1vdmUod2ViSXRlbS5nZXQoKSk7CisgICAgICAgIH0gZWxzZQorICAgICAgICAgICAg cmVtb3ZlZEl0ZW1zID0gZ19saXN0X3ByZXBlbmQocmVtb3ZlZEl0ZW1zLCB3ZWJraXRCYWNrRm9y d2FyZExpc3RJdGVtR2V0T3JDcmVhdGUod2ViSXRlbS5nZXQoKSkpOwogICAgIH0KIAogICAgIGdf c2lnbmFsX2VtaXQoYmFja0ZvcndhcmRMaXN0LCBzaWduYWxzW0NIQU5HRURdLCAwLCBhZGRlZEl0 ZW0sIHJlbW92ZWRJdGVtcywgbnVsbHB0cik7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDE5ZDkxNy4uM2RmN2RkOSAxMDA2NDQKLS0tIGEvVG9v bHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE2 LTAxLTE5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAorICAg ICAgICBbR1RLXSBSdW50aW1lIGNyaXRpY2FsIHdhcm5pbmdzIHdoZW4gbG9hZGluZyBhIFVSTCBh ZnRlciBhIHNlc3Npb24gcmVzdG9yZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTUzMjMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQWRkIG5ldyB0ZXN0IGNhc2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdEJhY2tGb3J3YXJkTGlzdC5jcHA6CisgICAgICAgICh2 aWV3TG9hZENoYW5nZWQpOgorICAgICAgICAodGVzdFdlYktpdFdlYlZpZXdOYXZpZ2F0aW9uQWZ0 ZXJTZXNzaW9uUmVzdG9yZSk6CisgICAgICAgIChiZWZvcmVBbGwpOgorCisyMDE2LTAxLTE5ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RL XSBBZGQgc3VwcG9ydCB0byBsb2FkL3NhdmUgc2Vzc2lvbiBpbiBNaW5pQnJvd3NlcgogICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjAxCiAKZGlmZiAt LWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0QmFja0Zvcndh cmRMaXN0LmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0QmFj a0ZvcndhcmRMaXN0LmNwcAppbmRleCBmN2FiZDVlLi42ZGQ5YTE3IDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdEJhY2tGb3J3YXJkTGlzdC5jcHAK KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RCYWNrRm9yd2Fy ZExpc3QuY3BwCkBAIC0zNjYsNiArMzY2LDM4IEBAIHN0YXRpYyB2b2lkIHRlc3RXZWJLaXRXZWJW aWV3U2Vzc2lvblN0YXRlV2l0aEZvcm1EYXRhKEJhY2tGb3J3YXJkTGlzdFRlc3QqIHRlc3QsCiAg ICAgd2Via2l0X3dlYl92aWV3X3Nlc3Npb25fc3RhdGVfdW5yZWYoc3RhdGUpOwogfQogCitzdGF0 aWMgdm9pZCB2aWV3TG9hZENoYW5nZWQoV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0TG9h ZEV2ZW50IGxvYWRFdmVudCwgR01haW5Mb29wKiBtYWluTG9vcCkKK3sKKyAgICBpZiAobG9hZEV2 ZW50ID09IFdFQktJVF9MT0FEX0ZJTklTSEVEKQorICAgICAgICBnX21haW5fbG9vcF9xdWl0KG1h aW5Mb29wKTsKK30KKworc3RhdGljIHZvaWQgdGVzdFdlYktpdFdlYlZpZXdOYXZpZ2F0aW9uQWZ0 ZXJTZXNzaW9uUmVzdG9yZShCYWNrRm9yd2FyZExpc3RUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVy KQoreworICAgIC8vIFRoaXMgdGVzdCBjaGVja3MgdGhhdCBhIG5vcm1hbCBsb2FkIGFmdGVyIGEg c2Vzc2lvbiByZXN0b3JlIHdpdGggYSBCYWNrRm9yYXJkIGxpc3QgaGF2aW5nCisgICAgLy8gZm9y d2FyZCBpdGVtcyBkb2Vzbid0IHByb2R1Y2UgYW55IHJ1bnRpbWUgY3JpdGljYWwgd2FybmluZy4g U2VlIGJ1ZyAjCisgICAgR1JlZlB0cjxXZWJLaXRXZWJWaWV3PiB2aWV3ID0gV0VCS0lUX1dFQl9W SUVXKHdlYmtpdF93ZWJfdmlld19uZXcoKSk7CisgICAgZ19zaWduYWxfY29ubmVjdCh2aWV3Lmdl dCgpLCAibG9hZC1jaGFuZ2VkIiwgR19DQUxMQkFDSyh2aWV3TG9hZENoYW5nZWQpLCB0ZXN0LT5t X21haW5Mb29wKTsKKworICAgIHdlYmtpdF93ZWJfdmlld19sb2FkX3VyaSh2aWV3LmdldCgpLCBr U2VydmVyLT5nZXRVUklGb3JQYXRoKCIvUGFnZTEiKS5kYXRhKCkpOworICAgIGdfbWFpbl9sb29w X3J1bih0ZXN0LT5tX21haW5Mb29wKTsKKyAgICB3ZWJraXRfd2ViX3ZpZXdfbG9hZF91cmkodmll dy5nZXQoKSwga1NlcnZlci0+Z2V0VVJJRm9yUGF0aCgiL1BhZ2UyIikuZGF0YSgpKTsKKyAgICBn X21haW5fbG9vcF9ydW4odGVzdC0+bV9tYWluTG9vcCk7CisgICAgd2Via2l0X3dlYl92aWV3X2xv YWRfdXJpKHZpZXcuZ2V0KCksIGtTZXJ2ZXItPmdldFVSSUZvclBhdGgoIi9QYWdlMyIpLmRhdGEo KSk7CisgICAgZ19tYWluX2xvb3BfcnVuKHRlc3QtPm1fbWFpbkxvb3ApOworICAgIHdlYmtpdF93 ZWJfdmlld19nb19iYWNrKHZpZXcuZ2V0KCkpOworICAgIGdfbWFpbl9sb29wX3J1bih0ZXN0LT5t X21haW5Mb29wKTsKKworICAgIFdlYktpdFdlYlZpZXdTZXNzaW9uU3RhdGUqIHN0YXRlID0gd2Vi a2l0X3dlYl92aWV3X2dldF9zZXNzaW9uX3N0YXRlKHZpZXcuZ2V0KCkpOworICAgIHdlYmtpdF93 ZWJfdmlld19yZXN0b3JlX3Nlc3Npb25fc3RhdGUodGVzdC0+bV93ZWJWaWV3LCBzdGF0ZSk7Cisg ICAgd2Via2l0X3dlYl92aWV3X3Nlc3Npb25fc3RhdGVfdW5yZWYoc3RhdGUpOworCisgICAgLy8g QSBub3JtYWwgbG9hZCBhZnRlciBhIHNlc3Npb24gcmVzdG9yZSBzaG91bGQgcmVtb3ZlIHRoZSBm b3J3YXJkIGxpc3QsIGFkZCB0aGUgbmV3IGl0ZW0gYW5kIHVwZGF0ZWQgdGhlIGN1cnJlbnQgb25l LgorICAgIHRlc3QtPm1fY2hhbmdlZEZsYWdzID0gQmFja0ZvcndhcmRMaXN0VGVzdDo6Q3VycmVu dEl0ZW0gfCBCYWNrRm9yd2FyZExpc3RUZXN0OjpBZGRlZEl0ZW0gfCBCYWNrRm9yd2FyZExpc3RU ZXN0OjpSZW1vdmVkSXRlbXM7CisgICAgdGVzdC0+bG9hZFVSSShrU2VydmVyLT5nZXRVUklGb3JQ YXRoKCIvUGFnZTQiKS5kYXRhKCkpOworICAgIHRlc3QtPndhaXRVbnRpbExvYWRGaW5pc2hlZCgp OworfQorCiB2b2lkIGJlZm9yZUFsbCgpCiB7CiAgICAga1NlcnZlciA9IG5ldyBXZWJLaXRUZXN0 U2VydmVyKCk7CkBAIC0zNzUsNiArNDA3LDcgQEAgdm9pZCBiZWZvcmVBbGwoKQogICAgIEJhY2tG b3J3YXJkTGlzdFRlc3Q6OmFkZCgiQmFja0ZvcndhcmRMaXN0IiwgImxpc3QtbGltaXQtYW5kLWNh Y2hlIiwgdGVzdEJhY2tGb3J3YXJkTGlzdExpbWl0QW5kQ2FjaGUpOwogICAgIEJhY2tGb3J3YXJk TGlzdFRlc3Q6OmFkZCgiV2ViS2l0V2ViVmlldyIsICJzZXNzaW9uLXN0YXRlIiwgdGVzdFdlYktp dFdlYlZpZXdTZXNzaW9uU3RhdGUpOwogICAgIEJhY2tGb3J3YXJkTGlzdFRlc3Q6OmFkZCgiV2Vi S2l0V2ViVmlldyIsICJzZXNzaW9uLXN0YXRlLXdpdGgtZm9ybS1kYXRhIiwgdGVzdFdlYktpdFdl YlZpZXdTZXNzaW9uU3RhdGVXaXRoRm9ybURhdGEpOworICAgIEJhY2tGb3J3YXJkTGlzdFRlc3Q6 OmFkZCgiV2ViS2l0V2ViVmlldyIsICJuYXZpZ2F0aW9uLWFmdGVyLXNlc3Npb24tcmVzdG9yZSIs IHRlc3RXZWJLaXRXZWJWaWV3TmF2aWdhdGlvbkFmdGVyU2Vzc2lvblJlc3RvcmUpOwogfQogCiB2 b2lkIGFmdGVyQWxsKCkK