15322 2007-09-29 09:04:27 -0700 On designMode=on, <hr> elements should be ignored when moving the caret 2012-06-06 12:15:55 -0700 1 1 1 Unclassified WebKit HTML Editing 523.x (Safari 3) All All NEW P2 Normal --- 12250 9915 1 webkit webkit-unassigned michael.vm parag rniwa oldest_to_newest 57348 0 webkit 2007-09-29 09:04:27 -0700 When designMode=on, using the keyboard or the mouse to move the caret inside the document should ignore <hr> elements. Today, it seams that the caret is placed in front of the <hr>, but it has a buggy and inconsistent placement. A TC will be provided for it. 57349 1 16454 webkit 2007-09-29 09:06:39 -0700 Created attachment 16454 TC This TC makes it easy to spot the problem. It's enough to compare WebKit's results against Firefox 2 or Opera 9.5 results. 63523 2 justin.garcia 2007-12-06 13:32:57 -0800 We offer a caret position before and after the horizontal rule so that it can be deleted. The correct solution though is to give horizontal rules "control" selections, like we plan to do for images, that will allow for deletion, among other things. 642346 3 145985 parag 2012-06-06 03:44:57 -0700 Created attachment 145985 Praposed patch Patch to skip 'hr' element while arrow key navigation. could there be any more such elements which should be skipped? I will report a new bug to make hr control selectable. Please give your feed back. 642682 4 145985 rniwa 2012-06-06 12:15:01 -0700 Comment on attachment 145985 Praposed patch This isn't a right solution. previous/nextLeafWithSameEditability is used for other purposes than just caret movement. Furthermore, as Justin said, we need to add control selection on HR before skipping HR or else users won't be able to delete HR. 16454 2007-09-29 09:06:39 -0700 2007-09-29 09:06:39 -0700 TC hr_caret.html text/html 785 webkit PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBYSFRNTCAxLjAgVHJhbnNpdGlvbmFs Ly9FTiIgImh0dHA6Ly93d3cudzMub3JnL1RSL3hodG1sMS9EVEQveGh0bWwxLXRyYW5zaXRpb25h bC5kdGQiPg0KPGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KPGhl YWQ+DQoJPHRpdGxlPkhSIENhcmV0IFBvc2l0aW9uPC90aXRsZT4NCgk8c2NyaXB0IHR5cGU9InRl eHQvamF2YXNjcmlwdCI+DQoNCndpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpDQp7DQoJZG9jdW1l bnQuZGVzaWduTW9kZSA9ICdvbicgOw0KfQ0KDQoJPC9zY3JpcHQ+DQo8L2hlYWQ+DQo8Ym9keT4N Cgk8cD4NCgkJTGluZSAxLg0KCTwvcD4NCgk8aHIgLz4NCgk8cD4NCgkJTGluZSAyLg0KCTwvcD4N Cgk8cD4NCgkJVGVzdGluZyBzdGVwczoNCgk8L3A+DQoJPG9sPg0KCQk8bGk+UGxhY2UgdGhlIGNh cmV0IGF0IHRoZSBiZWdpbm5pbmcgb2YgIkxpbmUgMiIuIDwvbGk+DQoJCTxsaT5IaXQgdGhlIHVw LWFycm93IGtleS4gPC9saT4NCgkJPGxpPlR5cGUgImEiLiA8L2xpPg0KCQk8bGk+SGl0IHRoZSBk b3duLWFycm93IGtleS4gPC9saT4NCgkJPGxpPlR5cGUgImEiLjwvbGk+DQoJPC9vbD4NCgk8cD4N CgkJRXhwZWN0ZWQgcmVzdWx0czogdGhlICZsdDtociZndDsgc2hvdWxkIGJlIGNvbXBsZXRlbGx5 IGlnbm9yZWQgYW5kIHRoZSBjYXJldCBzaG91bGQNCgkJbW92ZSBpbnNpZGUgdGhlIHBhcmFncmFw aHMgY29udGVudHMgb25seS4NCgk8L3A+DQo8L2JvZHk+DQo8L2h0bWw+DQo= 145985 2012-06-06 03:44:57 -0700 2012-06-06 12:15:01 -0700 Praposed patch bug-15322-20120606161451.patch text/plain 5293 parag SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExOTU3OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA2LTA2ICBQYXJhZyBS YWRrZSAgPHBhcmFnQG1vdG9yb2xhLmNvbT4KKworICAgICAgICBPbiBkZXNpZ25Nb2RlPW9uLCA8 aHI+IGVsZW1lbnRzIHNob3VsZCBiZSBpZ25vcmVkIHdoZW4gbW92aW5nIHRoZSBjYXJldAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUbyBza2lwIGhvcml6 b250YWwgcnVsZXMgaW4gYXJyb3cga2V5IG5hdmlnYXRpb24uCisKKyAgICAgICAgVGVzdDogZWRp dGluZy9pbnNlcnRpbmcvc2tpcHBpbmctaHItd2hpbGUtY2FyZXQtYXJyb3ctbW92ZS5odG1sCisK KyAgICAgICAgKiBlZGl0aW5nL3Zpc2libGVfdW5pdHMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 cHJldmlvdXNMZWFmV2l0aFNhbWVFZGl0YWJpbGl0eSk6IEFkZGVkIGEgY2hlY2sgdG8gc2tpcCBo ciBlbGVtZW50LgorICAgICAgICAoV2ViQ29yZTo6bmV4dExlYWZXaXRoU2FtZUVkaXRhYmlsaXR5 KTogZGl0dG8uCisKIDIwMTItMDYtMDYgIE1pY2hhZWwgQnLDvG5pbmcgIDxtaWNoYWVsLmJydW5p bmdAbm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gRml4IGhhcm1hdHRhbiBidWlsZHMgYnJva2Vu IGJ5IHIxMTkyNDcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL3Zpc2libGVfdW5pdHMu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91bml0cy5j cHAJKHJldmlzaW9uIDExOTQ4MykKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvdmlzaWJsZV91 bml0cy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAgc3RhdGljIE5vZGUqIHBy ZXZpb3VzTGVhZldpdGhTYW1lRWRpdGFiaQogICAgIGJvb2wgZWRpdGFibGUgPSBub2RlLT5yZW5k ZXJlcklzRWRpdGFibGUoZWRpdGFibGVUeXBlKTsKICAgICBub2RlID0gbm9kZS0+cHJldmlvdXNM ZWFmTm9kZSgpOwogICAgIHdoaWxlIChub2RlKSB7Ci0gICAgICAgIGlmIChlZGl0YWJsZSA9PSBu b2RlLT5yZW5kZXJlcklzRWRpdGFibGUoZWRpdGFibGVUeXBlKSkKKyAgICAgICAgaWYgKGVkaXRh YmxlID09IG5vZGUtPnJlbmRlcmVySXNFZGl0YWJsZShlZGl0YWJsZVR5cGUpICYmICFub2RlLT5o YXNUYWdOYW1lKGhyVGFnKSkKICAgICAgICAgICAgIHJldHVybiBub2RlOwogICAgICAgICBub2Rl ID0gbm9kZS0+cHJldmlvdXNMZWFmTm9kZSgpOwogICAgIH0KQEAgLTY4LDcgKzY4LDcgQEAgc3Rh dGljIE5vZGUqIG5leHRMZWFmV2l0aFNhbWVFZGl0YWJpbGl0eQogICAgIGJvb2wgZWRpdGFibGUg PSBub2RlLT5yZW5kZXJlcklzRWRpdGFibGUoZWRpdGFibGVUeXBlKTsKICAgICBub2RlID0gbm9k ZS0+bmV4dExlYWZOb2RlKCk7CiAgICAgd2hpbGUgKG5vZGUpIHsKLSAgICAgICAgaWYgKGVkaXRh YmxlID09IG5vZGUtPnJlbmRlcmVySXNFZGl0YWJsZShlZGl0YWJsZVR5cGUpKQorICAgICAgICBp ZiAoZWRpdGFibGUgPT0gbm9kZS0+cmVuZGVyZXJJc0VkaXRhYmxlKGVkaXRhYmxlVHlwZSkgJiYg IW5vZGUtPmhhc1RhZ05hbWUoaHJUYWcpKQogICAgICAgICAgICAgcmV0dXJuIG5vZGU7CiAgICAg ICAgIG5vZGUgPSBub2RlLT5uZXh0TGVhZk5vZGUoKTsKICAgICB9CkluZGV4OiBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv biAxMTk1NzkpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxNSBAQAorMjAxMi0wNi0wNiAgUGFyYWcgUmFka2UgIDxwYXJhZ0Btb3Rvcm9sYS5jb20+ CisKKyAgICAgICAgT24gZGVzaWduTW9kZT1vbiwgPGhyPiBlbGVtZW50cyBzaG91bGQgYmUgaWdu b3JlZCB3aGVuIG1vdmluZyB0aGUgY2FyZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1MzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkZWQgYSB0ZXN0IGNhc2UgdG8gdGVzdCBhcnJvdyBrZXkgbmF2 aWdhdGlvbiBiZWhhdmlvdXIgYWNyb3NzIGhvcml6b250YWwgcnVsZXMuCisKKyAgICAgICAgKiBl ZGl0aW5nL2luc2VydGluZy9za2lwcGluZy1oci13aGlsZS1jYXJldC1hcnJvdy1tb3ZlLWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvc2tpcHBpbmctaHIt d2hpbGUtY2FyZXQtYXJyb3ctbW92ZS5odG1sOiBBZGRlZC4KKwogMjAxMi0wNi0wNiAgU2VyZ2lv IFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCB1cGRhdGVkIFRlc3RFeHBlY3RhdGlvbnMgYWZ0ZXIgc2V2ZXJhbCB0ZXN0cyBoYXZlIGJlZW4K SW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3NraXBwaW5nLWhyLXdoaWxlLWNh cmV0LWFycm93LW1vdmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Vk aXRpbmcvaW5zZXJ0aW5nL3NraXBwaW5nLWhyLXdoaWxlLWNhcmV0LWFycm93LW1vdmUtZXhwZWN0 ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvc2tp cHBpbmctaHItd2hpbGUtY2FyZXQtYXJyb3ctbW92ZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDAp CkBAIC0wLDAgKzEsMTEgQEAKK1RoaXMgdGVzdCBpbnNlcnRzIGEgJ3gnIGFmdGVyIGEgaG9yaXpv bnRhbCBydWxlLgorCitUbyBtYW51YWxseSBydW4gdGhpcyB0ZXN0IGNhc2UgcGxhY2UgdGhlIGNh cmV0IGF0IHRoZSBzdGFydCBvZiBmb28sIHByZXNzIGRvd24gYXJyb3cga2V5IGl0IHNob3VsZCBz a2lwIHRoZSBob3Jpem9udGFsIGxpbmUgYW5kIHNob3VsZCBwbGFjZSB0aGUgY2FyZXQgcmlnaHQg YmVmb3JlIGJhci4KKworZm9vCit4YmFyCitQQVNTIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdk aXYnKS5pbm5lckhUTUwgaXMgImZvbzxocj54YmFyIgorUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQg aXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRl c3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3NraXBwaW5nLWhyLXdoaWxlLWNhcmV0LWFycm93LW1vdmUt ZXhwZWN0ZWQudHh0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KQWRkZWQ6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoKSW5k ZXg6IExheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3NraXBwaW5nLWhyLXdoaWxlLWNhcmV0 LWFycm93LW1vdmUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9za2lwcGluZy1oci13aGlsZS1jYXJldC1hcnJvdy1tb3ZlLmh0bWwJKHJldmlzaW9uIDAp CisrKyBMYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9za2lwcGluZy1oci13aGlsZS1jYXJl dC1hcnJvdy1tb3ZlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjkgQEAKKzwhRE9DVFlQ RSBodG1sPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291 cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRoaXMg dGVzdCBpbnNlcnRzIGEgJ3gnIGFmdGVyIGEgaG9yaXpvbnRhbCBydWxlLjwvcD4KKzxwPlRvIG1h bnVhbGx5IHJ1biB0aGlzIHRlc3QgY2FzZSBwbGFjZSB0aGUgY2FyZXQgYXQgdGhlIHN0YXJ0IG9m IGZvbywgcHJlc3MgZG93biBhcnJvdyBrZXkgaXQgc2hvdWxkIHNraXAgdGhlIGhvcml6b250YWwg bGluZSBhbmQgc2hvdWxkIHBsYWNlIAorICAgdGhlIGNhcmV0IHJpZ2h0IGJlZm9yZSBiYXIuPC9w PgorPGRpdiBpZD0iZGl2Ij5mb288aHI+YmFyPC9kaXY+Cis8cHJlIGlkPSJjb25zb2xlIj48L3By ZT4KKzxzY3JpcHQ+Citkb2N1bWVudC5kZXNpZ25Nb2RlID0gJ29uJyA7Citkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiZGl2IikuYWRkRXZlbnRMaXN0ZW5lcigidGV4dElucHV0IiwgZnVuY3Rpb24g KGV2dCkgeyBldnQudGFyZ2V0LnN0eWxlLndpZHRoID0gMTAwOyB9KTsKKyAgICB2YXIgc2VsID0g d2luZG93LmdldFNlbGVjdGlvbigpOworICAgIHZhciBkaXYgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiZGl2Iik7CisgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAg ICAgICBkaXYuYWRkRXZlbnRMaXN0ZW5lcigna2V5ZG93bicpOworICAgICAgICAgICAgc2VsLnNl dFBvc2l0aW9uKGRpdiwgMCk7CisgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCdkb3du QXJyb3cnKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIngiKTsKKyAgICAgICAg ICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygiZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2Rpdicp LmlubmVySFRNTCIsICJmb288aHI+eGJhciIpOworICAgICAgICAgICAgZmluaXNoSlNUZXN0KCk7 CisgICAgICAgICAgICB9LDApOword2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworPC9zY3Jp cHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0Lmpz Ij48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KClByb3BlcnR5IGNoYW5nZXMgb246IExheW91 dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3NraXBwaW5nLWhyLXdoaWxlLWNhcmV0LWFycm93LW1v dmUuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46ZW9sLXN0eWxlCiAgICsgTEYKCg==