153216 2016-01-18 18:17:35 -0800 [GTK][EFL] Layout tests abort with PulseAudioSanitizer instance has no attribute '_pa_module_index' when the build is not ready. 2016-01-18 20:05:38 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez bugs-noreply commit-queue glenn lforschler mjs rniwa oldest_to_newest 1156497 0 clopez 2016-01-18 18:17:35 -0800 When the build is not ready, trying to run run-webkit-tests will cause this: $ Tools/Scripts/run-webkit-tests --release --gtk Using port 'gtk-wk2' Test configuration: <, x86, release> Placing test results in /home/slave/testbuild/WebKit/WebKitBuild/Release/layout-test-results Baseline search path: gtk -> wk2 -> generic Using Release build Pixel tests disabled Regular timeout: 6000, slow test timeout: 30000 Command line: /home/slave/testbuild/WebKit/Tools/jhbuild/jhbuild-wrapper --gtk run /home/slave/testbuild/WebKit/WebKitBuild/Release/bin/WebKitTestRunner - Found 43415 tests; running 38964, skipping 4451. WebKitTestRunner was not found at /home/slave/testbuild/WebKit/WebKitBuild/Release/bin/WebKitTestRunner Build check failed AttributeError raised: PulseAudioSanitizer instance has no attribute '_pa_module_index' Traceback (most recent call last): File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 77, in main run_details = run(port, options, args, stderr) File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 409, in run run_details = manager.run(args) File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 229, in run self._clean_up_run() File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 279, in _clean_up_run self._port.clean_up_test_run() File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 110, in clean_up_test_run self._pulseaudio_sanitizer.restore_pulseaudio_module() File "/home/slave/testbuild/WebKit/Tools/Scripts/webkitpy/port/pulseaudio_sanitizer.py", line 81, in restore_pulseaudio_module if self._pa_module_index != -1: AttributeError: PulseAudioSanitizer instance has no attribute '_pa_module_index' The variable PulseAudioSanitizer._pa_module_index is set when PulseAudioSanitizer.unload_pulseaudio_module() is called from Port.setup_test_run(), which is done before calling PulseAudioSanitizer.restore_pulseaudio_module() which checks for this variable to be != -1 The issue is that when the build is not ready, Port.setup_test_run() is not run therefore the variable PulseAudioSanitizer.restore_pulseaudio_module() is not set causing this. 1156500 1 269251 clopez 2016-01-18 18:21:56 -0800 Created attachment 269251 Patch 1156532 2 269251 commit-queue 2016-01-18 20:05:34 -0800 Comment on attachment 269251 Patch Clearing flags on attachment: 269251 Committed r195245: <http://trac.webkit.org/changeset/195245> 1156533 3 commit-queue 2016-01-18 20:05:38 -0800 All reviewed patches have been landed. Closing bug. 269251 2016-01-18 18:21:56 -0800 2016-01-18 20:05:34 -0800 Patch bug-153216-20160119032126.patch text/plain 1536 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MjQyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMmE0MWVkZWU5OTE5YWIzMTM0MTRiMTJmNGUyMmVjYzA3 Y2M2YWQ1Ny4uOWI4ZmRkN2ZkNjMyMjA4MzM0MDMyNTA4ZmNhNTFiYzg2NmQ5MWE4ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAxLTE4ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdW0VGTF0gTGF5b3V0IHRlc3RzIGFib3J0IHdpdGggUHVs c2VBdWRpb1Nhbml0aXplciBpbnN0YW5jZSBoYXMgbm8gYXR0cmlidXRlICdfcGFfbW9kdWxlX2lu ZGV4JyB3aGVuIHRoZSBidWlsZCBpcyBub3QgcmVhZHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMyMTYKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9wdWxzZWF1 ZGlvX3Nhbml0aXplci5weToKKyAgICAgICAgKFB1bHNlQXVkaW9TYW5pdGl6ZXIuX19pbml0X18p OiBpbml0aWFsaXplIF9wYV9tb2R1bGVfaW5kZXggaW4gdGhlIGNvbnN0cnVjdG9yLgorCiAyMDE2 LTAxLTE4ICBOYW4gV2FuZyAgPG5fd2FuZ0BhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IFtNYWNd IEltcGxlbWVudCBuZXh0L3ByZXZpb3VzIHRleHQgbWFya2VyIGZ1bmN0aW9ucyB1c2luZyBUZXh0 SXRlcmF0b3IKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9wdWxzZWF1 ZGlvX3Nhbml0aXplci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9wdWxzZWF1ZGlv X3Nhbml0aXplci5weQppbmRleCA0NjViOTIxNTgxMGUyMThhNjNmOTBiMmM5ZGYwNzdkYjc2NDdk MjE4Li5hZWRhYTM4MjVjYzZhYmU1MDdlZDVlMjkyMDk2ZWUwNTNkYzA0YzljIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvcHVsc2VhdWRpb19zYW5pdGl6ZXIucHkKKysr IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3B1bHNlYXVkaW9fc2FuaXRpemVyLnB5CkBA IC0zNyw2ICszNyw5IEBAIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcihfX25hbWVfXykKIAogIyBT aGFyZWQgYnkgR1RLIGFuZCBFRkwgZm9yIHB1bHNlYXVkaW8gc2FuaXRpemluZyBiZWZvcmUgcnVu bmluZyB0ZXN0cy4KIGNsYXNzIFB1bHNlQXVkaW9TYW5pdGl6ZXI6CisgICAgZGVmIF9faW5pdF9f KHNlbGYpOgorICAgICAgICBzZWxmLl9wYV9tb2R1bGVfaW5kZXggPSAtMQorCiAgICAgZGVmIHVu bG9hZF9wdWxzZWF1ZGlvX21vZHVsZShzZWxmKToKICAgICAgICAgIyBVbmxvYWQgcHVsc2VhdWRp bydzIG1vZHVsZS1zdHJlYW0tcmVzdG9yZSwgc2luY2UgaXQgcmVtZW1iZXJzCiAgICAgICAgICMg dm9sdW1lIHNldHRpbmdzIGZyb20gZGlmZmVyZW50IHJ1bnMsIGFuZCBjb3VsZCBhZmZlY3QK