153214 2016-01-18 16:43:40 -0800 SVG tear offs should return a const reference if possible 2016-03-16 20:36:16 -0700 1 1 1 Unclassified WebKit SVG WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nikos.andronikos nikos.andronikos commit-queue zimmermann oldest_to_newest 1156480 0 nikos.andronikos 2016-01-18 16:43:40 -0800 The getters SVGAnimatedStaticPropertyTearOff::baseVal() and SVGAnimatedStaticPropertyTearOff::animVal() return a reference to an SVG property object. E.g. template<typename PropertyType> class SVGAnimatedStaticPropertyTearOff : public SVGAnimatedProperty { public: virtual PropertyType& baseVal() { return m_property; } It would be preferable for the returned reference to PropertypType to be const. 1175579 1 274243 nikos.andronikos 2016-03-16 17:08:42 -0700 Created attachment 274243 Patch 1175627 2 274243 commit-queue 2016-03-16 20:36:13 -0700 Comment on attachment 274243 Patch Clearing flags on attachment: 274243 Committed r198316: <http://trac.webkit.org/changeset/198316> 1175628 3 commit-queue 2016-03-16 20:36:16 -0700 All reviewed patches have been landed. Closing bug. 274243 2016-03-16 17:08:42 -0700 2016-03-16 20:36:13 -0700 Patch bug-153214-20160317110712.patch text/plain 3280 nikos.andronikos U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4MzA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTY3NzU0MDhmOTYzYWQ4 ZGNjZjZmODY2MjkyZjBlNjYyNmRiMmFiYi4uMDJlNDU2Nzk2YWRiOTExMWIxZWQzY2I4NTI5MTc3 ZDAzMDU4ZWRkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTE2ICBOaWtv cyBBbmRyb25pa29zICA8bmlrb3MuYW5kcm9uaWtvcy13ZWJraXRAY2lzcmEuY2Fub24uY29tLmF1 PgorCisgICAgICAgIFNWRyB0ZWFyIG9mZnMgc2hvdWxkIHJldHVybiBhIGNvbnN0IHJlZmVyZW5j ZSBpZiBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTUzMjE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQSBzbWFsbGVyIGNoYW5nZSB0aGFuIGV4cGVjdGVkIGJlY2F1c2UgdGhlIHJldHVybmVk IHJlZmVyZW5jZSBpcyBiZWluZyBjb3BpZWQgaW50byBhIHZhbHVlIGluIGFkZGl0aW9uYWwgbG9j YXRpb25zIHRoYXQgYmFzZVZhbCBhbmQgYW5pbVZhbCBhcmUgdXNlZC4KKworICAgICAgICBObyBu ZXcgdGVzdHMgYXMgdGhlcmUgaXMgbm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAgICAq IHN2Zy9wcm9wZXJ0aWVzL1NWR0FuaW1hdGVkRW51bWVyYXRpb25Qcm9wZXJ0eVRlYXJPZmYuaDoK KyAgICAgICAgKiBzdmcvcHJvcGVydGllcy9TVkdBbmltYXRlZFN0YXRpY1Byb3BlcnR5VGVhck9m Zi5oOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQW5pbWF0ZWRTdGF0aWNQcm9wZXJ0eVRlYXJPZmY6 OmJhc2VWYWwpOgorICAgICAgICAoV2ViQ29yZTo6U1ZHQW5pbWF0ZWRTdGF0aWNQcm9wZXJ0eVRl YXJPZmY6OmFuaW1WYWwpOgorCiAyMDE2LTAzLTE2ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlz dGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IGFzc2VydGlvbiBmYWlsdXJlIG9uIGRy aXZlLmdvb2dsZS5jb20gYWZ0ZXIgcjE5NjA1MgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv c3ZnL3Byb3BlcnRpZXMvU1ZHQW5pbWF0ZWRFbnVtZXJhdGlvblByb3BlcnR5VGVhck9mZi5oIGIv U291cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHQW5pbWF0ZWRFbnVtZXJhdGlvblByb3Bl cnR5VGVhck9mZi5oCmluZGV4IGQ1MWI5NzM4MmE2ZTg5ZjEwNzlhZTkzZWM0ZDUwZDgxYzBiZjNk NmMuLjRmMGRjZDBjZjdhNGI4ZWMwNTg1ZWQ3MGE5NzY4ODJkZWZlODBlMzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9wZXJ0aWVzL1NWR0FuaW1hdGVkRW51bWVyYXRpb25Qcm9w ZXJ0eVRlYXJPZmYuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvcHJvcGVydGllcy9TVkdBbmlt YXRlZEVudW1lcmF0aW9uUHJvcGVydHlUZWFyT2ZmLmgKQEAgLTI5LDkgKzI5LDkgQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogdGVtcGxhdGU8dHlwZW5hbWUgRW51bVR5cGU+CiBjbGFzcyBTVkdBbmlt YXRlZEVudW1lcmF0aW9uUHJvcGVydHlUZWFyT2ZmIGZpbmFsIDogcHVibGljIFNWR0FuaW1hdGVk U3RhdGljUHJvcGVydHlUZWFyT2ZmPHVuc2lnbmVkPiB7CiBwdWJsaWM6Ci0gICAgdW5zaWduZWQm IGJhc2VWYWwoKSBvdmVycmlkZQorICAgIGNvbnN0IHVuc2lnbmVkJiBiYXNlVmFsKCkgb3ZlcnJp ZGUKICAgICB7Ci0gICAgICAgIHVuc2lnbmVkJiBiYXNlVmFsID0gU1ZHQW5pbWF0ZWRTdGF0aWNQ cm9wZXJ0eVRlYXJPZmY6OmJhc2VWYWwoKTsKKyAgICAgICAgY29uc3QgdW5zaWduZWQmIGJhc2VW YWwgPSBTVkdBbmltYXRlZFN0YXRpY1Byb3BlcnR5VGVhck9mZjo6YmFzZVZhbCgpOwogCiAgICAg ICAgIGlmIChiYXNlVmFsID4gU1ZHSURMRW51bUxpbWl0czxFbnVtVHlwZT46OmhpZ2hlc3RFeHBv c2VkRW51bVZhbHVlKCkpCiAgICAgICAgICAgICByZXR1cm4gbV9vdXRPZlJhbmdlRW51bVZhbHVl OwpAQCAtMzksOSArMzksOSBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBiYXNlVmFsOwogICAg IH0KIAotICAgIHVuc2lnbmVkJiBhbmltVmFsKCkgb3ZlcnJpZGUKKyAgICBjb25zdCB1bnNpZ25l ZCYgYW5pbVZhbCgpIG92ZXJyaWRlCiAgICAgewotICAgICAgICB1bnNpZ25lZCYgYW5pbVZhbCA9 IFNWR0FuaW1hdGVkU3RhdGljUHJvcGVydHlUZWFyT2ZmOjphbmltVmFsKCk7CisgICAgICAgIGNv bnN0IHVuc2lnbmVkJiBhbmltVmFsID0gU1ZHQW5pbWF0ZWRTdGF0aWNQcm9wZXJ0eVRlYXJPZmY6 OmFuaW1WYWwoKTsKIAogICAgICAgICBpZiAoYW5pbVZhbCA+IFNWR0lETEVudW1MaW1pdHM8RW51 bVR5cGU+OjpoaWdoZXN0RXhwb3NlZEVudW1WYWx1ZSgpKQogICAgICAgICAgICAgcmV0dXJuIG1f b3V0T2ZSYW5nZUVudW1WYWx1ZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9wcm9w ZXJ0aWVzL1NWR0FuaW1hdGVkU3RhdGljUHJvcGVydHlUZWFyT2ZmLmggYi9Tb3VyY2UvV2ViQ29y ZS9zdmcvcHJvcGVydGllcy9TVkdBbmltYXRlZFN0YXRpY1Byb3BlcnR5VGVhck9mZi5oCmluZGV4 IDZhZDU3ZDRjOWI4YmVlNmRiYWY2Y2Q4MDdjYmVhZGVlNDE1N2FiODYuLmQ0MjU3YTIyNWVkMTE5 ODA5OGNmOTNmMDQ3ZGNhYjJlNTE3Y2VmODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2 Zy9wcm9wZXJ0aWVzL1NWR0FuaW1hdGVkU3RhdGljUHJvcGVydHlUZWFyT2ZmLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvc3ZnL3Byb3BlcnRpZXMvU1ZHQW5pbWF0ZWRTdGF0aWNQcm9wZXJ0eVRlYXJP ZmYuaApAQCAtMzEsMTIgKzMxLDEyIEBAIGNsYXNzIFNWR0FuaW1hdGVkU3RhdGljUHJvcGVydHlU ZWFyT2ZmIDogcHVibGljIFNWR0FuaW1hdGVkUHJvcGVydHkgewogcHVibGljOgogICAgIHR5cGVk ZWYgUHJvcGVydHlUeXBlIENvbnRlbnRUeXBlOwogCi0gICAgdmlydHVhbCBQcm9wZXJ0eVR5cGUm IGJhc2VWYWwoKQorICAgIHZpcnR1YWwgY29uc3QgUHJvcGVydHlUeXBlJiBiYXNlVmFsKCkKICAg ICB7CiAgICAgICAgIHJldHVybiBtX3Byb3BlcnR5OwogICAgIH0KIAotICAgIHZpcnR1YWwgUHJv cGVydHlUeXBlJiBhbmltVmFsKCkKKyAgICB2aXJ0dWFsIGNvbnN0IFByb3BlcnR5VHlwZSYgYW5p bVZhbCgpCiAgICAgewogICAgICAgICBpZiAobV9hbmltYXRlZFByb3BlcnR5KQogICAgICAgICAg ICAgcmV0dXJuICptX2FuaW1hdGVkUHJvcGVydHk7Cg==