153169 2016-01-15 18:11:00 -0800 Give RuleSet a BumpArena and start using it for RuleDataVectors. 2016-01-19 15:52:26 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified REOPENED Performance P2 Normal --- 1 kling kling cdumez commit-queue dewei_zhu koivisto oldest_to_newest 1156065 0 kling 2016-01-15 18:11:00 -0800 RuleSet only needs to support append operations, so it's a great candidate for BumpArena optimizations. 1156069 1 269135 kling 2016-01-15 18:12:14 -0800 Created attachment 269135 Patch 1156201 2 koivisto 2016-01-16 11:46:14 -0800 r=me 1156210 3 269135 commit-queue 2016-01-16 12:37:38 -0800 Comment on attachment 269135 Patch Clearing flags on attachment: 269135 Committed r195173: <http://trac.webkit.org/changeset/195173> 1156211 4 commit-queue 2016-01-16 12:37:42 -0800 All reviewed patches have been landed. Closing bug. 1156701 5 cdumez 2016-01-19 13:00:07 -0800 Reverted r195173 for reason: It relies on r195141 which was rolled out Committed r195309: <http://trac.webkit.org/changeset/195309> 1156773 6 dewei_zhu 2016-01-19 15:52:26 -0800 This change will crash JetStream on "bigfib.cpp". 269135 2016-01-15 18:12:14 -0800 2016-01-16 12:37:38 -0800 Patch bug-153169.diff text/plain 4532 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAyMmUwZjg4Li5mMzBkNmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTYtMDEtMTUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29tPgorCisgICAg ICAgIEdpdmUgUnVsZVNldCBhIEJ1bXBBcmVuYSBhbmQgc3RhcnQgdXNpbmcgaXQgZm9yIFJ1bGVE YXRhVmVjdG9ycy4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE1MzE2OT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBSdWxlU2V0 IG9ubHkgc3VwcG9ydHMgYXBwZW5kaW5nIHJ1bGVzIGFuZCBkb2Vzbid0IG5lZWQgdG8gd29ycnkg YWJvdXQgcmVtb3ZpbmcgdGhlbSwKKyAgICAgICAgaXQncyBhIGdyZWF0IGNhbmRpZGF0ZSBmb3Ig QnVtcEFyZW5hIG9wdGltaXphdGlvbnMuCisKKyAgICAgICAgR2l2ZSBlYWNoIFJ1bGVTZXQgaXRz IG93biBCdW1wQXJlbmEgYW5kIHRlYWNoIHRoZW0gaG93IHRvIGFsbG9jYXRlIFJ1bGVEYXRhVmVj dG9yIG9iamVjdHMKKyAgICAgICAgb3V0IG9mIHRoZW0uCisKKyAgICAgICAgVGhlcmUgYXJlIG1v cmUgdGhpbmdzIHRoYXQgY2FuIGJlIGRvbmUgaGVyZSwgaWRlYWxseSBhbGwgdGhlIHN1Yi1hbGxv Y2F0aW9ucyBpbnNpZGUgUnVsZVNldAorICAgICAgICB0aGF0IGhhcHBlbiB2aWEgZS5nIFZlY3Rv ciBhbmQgSGFzaE1hcCB3b3VsZCBhbHNvIGNvbWUgb3V0IG9mIHRoZSBCdW1wQXJlbmEuCisKKyAg ICAgICAgKiBjc3MvUnVsZVNldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSdWxlU2V0OjpSdWxl U2V0KToKKyAgICAgICAgKFdlYkNvcmU6OlJ1bGVTZXQ6OmFkZFRvUnVsZVNldCk6CisgICAgICAg IChXZWJDb3JlOjpSdWxlU2V0Ojpjb3B5U2hhZG93UHNldWRvRWxlbWVudFJ1bGVzRnJvbSk6Cisg ICAgICAgICogY3NzL1J1bGVTZXQuaDoKKyAgICAgICAgKFdlYkNvcmU6OlJ1bGVTZXQ6OlJ1bGVE YXRhVmVjdG9yOjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29yZTo6UnVsZVNldDo6UnVsZVNldCk6 IERlbGV0ZWQuCisKIDIwMTYtMDEtMTUgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgRGF0YSBkZXRlY3RvciB5ZWxsb3cgaGlnaGxpZ2h0IGxvY2F0aW9u IGlzIHZlcnRpY2FsbHkgbWlycm9yZWQgaW4gV2ViS2l0MQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvY3NzL1J1bGVTZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL1J1bGVTZXQuY3BwCmlu ZGV4IDRjODU0NTEuLmI4MTZlY2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxl U2V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5jcHAKQEAgLTE4MywxMyAr MTgzLDE4IEBAIHN0YXRpYyB2b2lkIGNvbGxlY3RGZWF0dXJlc0Zyb21SdWxlRGF0YShSdWxlRmVh dHVyZVNldCYgZmVhdHVyZXMsIGNvbnN0IFJ1bGVEYXRhCiAgICAgICAgIGZlYXR1cmVzLnVuY29t bW9uQXR0cmlidXRlUnVsZXMuYXBwZW5kKFJ1bGVGZWF0dXJlKHJ1bGVEYXRhLnJ1bGUoKSwgcnVs ZURhdGEuc2VsZWN0b3JJbmRleCgpLCBydWxlRGF0YS5oYXNEb2N1bWVudFNlY3VyaXR5T3JpZ2lu KCkpKTsKIH0KIAorUnVsZVNldDo6UnVsZVNldCgpCisgICAgOiBtX2FyZW5hKFdURjo6QnVtcEFy ZW5hOjpjcmVhdGUoKSkKK3sKK30KKwogdm9pZCBSdWxlU2V0OjphZGRUb1J1bGVTZXQoQXRvbWlj U3RyaW5nSW1wbCoga2V5LCBBdG9tUnVsZU1hcCYgbWFwLCBjb25zdCBSdWxlRGF0YSYgcnVsZURh dGEpCiB7CiAgICAgaWYgKCFrZXkpCiAgICAgICAgIHJldHVybjsKICAgICBhdXRvJiBydWxlcyA9 IG1hcC5hZGQoa2V5LCBudWxscHRyKS5pdGVyYXRvci0+dmFsdWU7CiAgICAgaWYgKCFydWxlcykK LSAgICAgICAgcnVsZXMgPSBzdGQ6Om1ha2VfdW5pcXVlPFJ1bGVEYXRhVmVjdG9yPigpOworICAg ICAgICBydWxlcyA9IFJ1bGVEYXRhVmVjdG9yOjpjcmVhdGUobV9hcmVuYS5nZXQoKSk7CiAgICAg cnVsZXMtPmFwcGVuZChydWxlRGF0YSk7CiB9CiAKQEAgLTM5OSw3ICs0MDQsNyBAQCBib29sIFJ1 bGVTZXQ6Omhhc1NoYWRvd1BzZXVkb0VsZW1lbnRSdWxlcygpIGNvbnN0CiB2b2lkIFJ1bGVTZXQ6 OmNvcHlTaGFkb3dQc2V1ZG9FbGVtZW50UnVsZXNGcm9tKGNvbnN0IFJ1bGVTZXQmIG90aGVyKQog ewogICAgIGZvciAoYXV0byYga2V5VmFsdWVQYWlyIDogb3RoZXIubV9zaGFkb3dQc2V1ZG9FbGVt ZW50UnVsZXMpCi0gICAgICAgIG1fc2hhZG93UHNldWRvRWxlbWVudFJ1bGVzLmFkZChrZXlWYWx1 ZVBhaXIua2V5LCBzdGQ6Om1ha2VfdW5pcXVlPFJ1bGVEYXRhVmVjdG9yPigqa2V5VmFsdWVQYWly LnZhbHVlKSk7CisgICAgICAgIG1fc2hhZG93UHNldWRvRWxlbWVudFJ1bGVzLmFkZChrZXlWYWx1 ZVBhaXIua2V5LCBSdWxlRGF0YVZlY3Rvcjo6Y3JlYXRlKG1fYXJlbmEuZ2V0KCksICprZXlWYWx1 ZVBhaXIudmFsdWUpKTsKIAogI2lmIEVOQUJMRShWSURFT19UUkFDSykKICAgICAvLyBGSVhNRTog V2UgcHJvYmFibHkgc2hvdWxkbid0IHRyZWF0IFdlYlZUVCBhcyBhdXRob3Igc3R5bGFibGUgdXNl ciBhZ2VudCBzaGFkb3cgdHJlZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxl U2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9jc3MvUnVsZVNldC5oCmluZGV4IDkyNjg2MWYuLjEyNmFj ZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9SdWxlU2V0LmgKKysrIGIvU291cmNl L1dlYkNvcmUvY3NzL1J1bGVTZXQuaApAQCAtMjUsNiArMjUsNyBAQAogI2luY2x1ZGUgIlJ1bGVG ZWF0dXJlLmgiCiAjaW5jbHVkZSAiU2VsZWN0b3JDb21waWxlci5oIgogI2luY2x1ZGUgIlN0eWxl UnVsZS5oIgorI2luY2x1ZGUgPHd0Zi9CdW1wQXJlbmEuaD4KICNpbmNsdWRlIDx3dGYvRm9yd2Fy ZC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoTWFwLmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4K QEAgLTE1OCw3ICsxNTksMTkgQEAgcHVibGljOgogCiAgICAgUnVsZVNldCgpOwogCi0gICAgdHlw ZWRlZiBWZWN0b3I8UnVsZURhdGEsIDE+IFJ1bGVEYXRhVmVjdG9yOworICAgIGNsYXNzIFJ1bGVE YXRhVmVjdG9yIDogcHVibGljIFZlY3RvcjxSdWxlRGF0YSwgMT4geworICAgICAgICBXVEZfTUFL RV9CVU1QQVJFTkFfQUxMT0NBVEVEOworICAgIHB1YmxpYzoKKyAgICAgICAgc3RhdGljIHN0ZDo6 dW5pcXVlX3B0cjxSdWxlRGF0YVZlY3Rvcj4gY3JlYXRlKEJ1bXBBcmVuYSYgYXJlbmEpCisgICAg ICAgIHsKKyAgICAgICAgICAgIHJldHVybiBzdGQ6OnVuaXF1ZV9wdHI8UnVsZURhdGFWZWN0b3I+ KG5ldyAoJmFyZW5hKSBSdWxlRGF0YVZlY3Rvcik7CisgICAgICAgIH0KKyAgICAgICAgc3RhdGlj IHN0ZDo6dW5pcXVlX3B0cjxSdWxlRGF0YVZlY3Rvcj4gY3JlYXRlKEJ1bXBBcmVuYSYgYXJlbmEs IGNvbnN0IFJ1bGVEYXRhVmVjdG9yJiBvdGhlcikKKyAgICAgICAgeworICAgICAgICAgICAgcmV0 dXJuIHN0ZDo6dW5pcXVlX3B0cjxSdWxlRGF0YVZlY3Rvcj4obmV3ICgmYXJlbmEpIFJ1bGVEYXRh VmVjdG9yKG90aGVyKSk7CisgICAgICAgIH0KKyAgICB9OworCiAgICAgdHlwZWRlZiBIYXNoTWFw PEF0b21pY1N0cmluZ0ltcGwqLCBzdGQ6OnVuaXF1ZV9wdHI8UnVsZURhdGFWZWN0b3I+PiBBdG9t UnVsZU1hcDsKIAogICAgIHZvaWQgYWRkUnVsZXNGcm9tU2hlZXQoU3R5bGVTaGVldENvbnRlbnRz JiwgY29uc3QgTWVkaWFRdWVyeUV2YWx1YXRvciYsIFN0eWxlUmVzb2x2ZXIqID0gMCk7CkBAIC0y MTMsMTggKzIyNiwxMyBAQCBwcml2YXRlOgogICAgIFJ1bGVEYXRhVmVjdG9yIG1fZm9jdXNQc2V1 ZG9DbGFzc1J1bGVzOwogICAgIFJ1bGVEYXRhVmVjdG9yIG1fdW5pdmVyc2FsUnVsZXM7CiAgICAg VmVjdG9yPFN0eWxlUnVsZVBhZ2UqPiBtX3BhZ2VSdWxlczsKLSAgICB1bnNpZ25lZCBtX3J1bGVD b3VudDsKLSAgICBib29sIG1fYXV0b1Nocmlua1RvRml0RW5hYmxlZDsKKyAgICB1bnNpZ25lZCBt X3J1bGVDb3VudCB7IDAgfTsKKyAgICBib29sIG1fYXV0b1Nocmlua1RvRml0RW5hYmxlZCB7IHRy dWUgfTsKICAgICBSdWxlRmVhdHVyZVNldCBtX2ZlYXR1cmVzOwogICAgIFZlY3RvcjxSdWxlU2V0 U2VsZWN0b3JQYWlyPiBtX3JlZ2lvblNlbGVjdG9yc0FuZFJ1bGVTZXRzOworICAgIFJlZjxCdW1w QXJlbmE+IG1fYXJlbmE7CiB9OwogCi1pbmxpbmUgUnVsZVNldDo6UnVsZVNldCgpCi0gICAgOiBt X3J1bGVDb3VudCgwKQotICAgICwgbV9hdXRvU2hyaW5rVG9GaXRFbmFibGVkKHRydWUpCi17Ci19 Ci0KIGlubGluZSBjb25zdCBSdWxlU2V0OjpSdWxlRGF0YVZlY3RvciogUnVsZVNldDo6dGFnUnVs ZXMoQXRvbWljU3RyaW5nSW1wbCoga2V5LCBib29sIGlzSFRNTE5hbWUpIGNvbnN0CiB7CiAgICAg Y29uc3QgQXRvbVJ1bGVNYXAqIHRhZ1J1bGVzOwo=