153147 2016-01-15 14:24:18 -0800 Drop obsolete DocumentType.entities / notations 2016-01-19 09:50:40 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez commit-queue darin esprehn+autocc kangil.han kling koivisto kondapallykalyan rniwa oldest_to_newest 1155933 0 cdumez 2016-01-15 14:24:18 -0800 Drop obsolete DocumentType.entities / notations. Firefox and Chrome already dropped those. We already dropped support for entities and notations so these always return null. 1155938 1 269100 cdumez 2016-01-15 14:30:35 -0800 Created attachment 269100 Patch 1156010 2 269100 commit-queue 2016-01-15 16:08:57 -0800 Comment on attachment 269100 Patch Clearing flags on attachment: 269100 Committed r195157: <http://trac.webkit.org/changeset/195157> 1156011 3 commit-queue 2016-01-15 16:09:02 -0800 All reviewed patches have been landed. Closing bug. 1156460 4 269100 darin 2016-01-18 14:43:55 -0800 Comment on attachment 269100 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=269100&action=review > Source/WebCore/dom/DocumentType.h:40 > + // These is needed by native bindings for backward compatibility. “These is needed” -> “These are needed”. I’m not sure that “native bindings” is a clear name for the Objective-C and GTK bindings. 1156614 5 cdumez 2016-01-19 09:50:40 -0800 (In reply to comment #4) > Comment on attachment 269100 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=269100&action=review > > > Source/WebCore/dom/DocumentType.h:40 > > + // These is needed by native bindings for backward compatibility. > > “These is needed” -> “These are needed”. > > I’m not sure that “native bindings” is a clear name for the Objective-C and > GTK bindings. Updated comment in <http://trac.webkit.org/changeset/195294>. 269100 2016-01-15 14:30:35 -0800 2016-01-15 16:08:57 -0800 Patch bug-153147-20160115143005.patch text/plain 4676 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNlZDRkYWQ0YjYwMWY3 NmU2YzVkZTkzZmRhZGNhN2VlNDA3YjA3Mi4uMWUwMzRkZTMwZjBiZjhjMzk5ZWNkZDZkNzdjMWI3 NWNkNTJhMGRlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTE1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBvYnNvbGV0ZSBEb2N1 bWVudFR5cGUuZW50aXRpZXMgLyBub3RhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzE0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERyb3Agb2Jzb2xldGUgRG9jdW1lbnRUeXBlLmVudGl0aWVz IC8gbm90YXRpb25zIGF0dHJpYnV0ZXMuCisKKyAgICAgICAgRmlyZWZveCBhbmQgQ2hyb21lIGFs cmVhZHkgZHJvcHBlZCB0aG9zZS4gV2UgYWxyZWFkeSBkcm9wcGVkIHN1cHBvcnQgZm9yCisgICAg ICAgIGVudGl0aWVzIGFuZCBub3RhdGlvbnMgc28gdGhlc2UgYWx3YXlzIHJldHVybmVkIG51bGwu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVz dHMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnRUeXBlLmg6CisgICAgICAgICogZG9tL0RvY3Vt ZW50VHlwZS5pZGw6CisKIDIwMTYtMDEtMTUgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+ CiAKICAgICAgICAgQXZvaWQgZG93bmxvYWRpbmcgdGhlIHdyb25nIGltYWdlIGZvciA8cGljdHVy ZT4gZWxlbWVudHMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRUeXBl LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnRUeXBlLmgKaW5kZXggODZmOGYyOTcwM2Vm N2FkNWVjMGViZmM5MWY5MDU2NzE3YzMyMTA2NS4uMmQ0OTIzMjEyMDg5N2RiOWZmZTY0YTcwM2Q4 ZTUxMjgxMWM5Y2ZhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50VHlw ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFR5cGUuaApAQCAtMzcsOSArMzcs OSBAQCBwdWJsaWM6CiAgICAgICAgIHJldHVybiBhZG9wdFJlZigqbmV3IERvY3VtZW50VHlwZShk b2N1bWVudCwgbmFtZSwgcHVibGljSWQsIHN5c3RlbUlkKSk7CiAgICAgfQogCi0gICAgLy8gRklY TUU6IFdlIHJldHVybiBudWxsIGVudGl0aWVzIGFuZCBub3RhdGlvbnMuIEN1cnJlbnQgaW1wbGVt ZW50YXRpb24gb2YgTmFtZWROb2RlTWFwIGRvZXNuJ3Qgd29yayB3aXRob3V0IGFuIGFzc29jaWF0 ZWQgRWxlbWVudCB5ZXQuCi0gICAgTmFtZWROb2RlTWFwKiBlbnRpdGllcygpIGNvbnN0IHsgcmV0 dXJuIG51bGxwdHI7IH0KLSAgICBOYW1lZE5vZGVNYXAqIG5vdGF0aW9ucygpIGNvbnN0IHsgcmV0 dXJuIG51bGxwdHI7IH0KKyAgICAvLyBUaGVzZSBpcyBuZWVkZWQgYnkgbmF0aXZlIGJpbmRpbmdz IGZvciBiYWNrd2FyZCBjb21wYXRpYmlsaXR5LgorICAgIE5hbWVkTm9kZU1hcCogZW50aXRpZXNG b3JCaW5kaW5ncygpIGNvbnN0IHsgcmV0dXJuIG51bGxwdHI7IH0KKyAgICBOYW1lZE5vZGVNYXAq IG5vdGF0aW9uc0ZvckJpbmRpbmdzKCkgY29uc3QgeyByZXR1cm4gbnVsbHB0cjsgfQogCiAgICAg Y29uc3QgU3RyaW5nJiBuYW1lKCkgY29uc3QgeyByZXR1cm4gbV9uYW1lOyB9CiAgICAgY29uc3Qg U3RyaW5nJiBwdWJsaWNJZCgpIGNvbnN0IHsgcmV0dXJuIG1fcHVibGljSWQ7IH0KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudFR5cGUuaWRsIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50VHlwZS5pZGwKaW5kZXggYTk2MzhiZTU5YzFlM2QwNTVjZmFmZGNiODllYTRi YzhkYzc1MDI4OC4uM2Q1ZGE2Mjc4MjhkZjA2ODM2NmY4OTE4Mjk3ODU0ZDhkZjlkMDhlNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50VHlwZS5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL0RvY3VtZW50VHlwZS5pZGwKQEAgLTI1LDggKzI1LDExIEBACiAgICAgLy8g RE9NIExldmVsIDEKIAogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgbmFtZTsKLSAg ICByZWFkb25seSBhdHRyaWJ1dGUgTmFtZWROb2RlTWFwIGVudGl0aWVzOwotICAgIHJlYWRvbmx5 IGF0dHJpYnV0ZSBOYW1lZE5vZGVNYXAgbm90YXRpb25zOworCisjaWYgIWRlZmluZWQoTEFOR1VB R0VfSkFWQVNDUklQVCkgfHwgIUxBTkdVQUdFX0pBVkFTQ1JJUFQKKyAgICBbSW1wbGVtZW50ZWRB cz1lbnRpdGllc0ZvckJpbmRpbmdzXSByZWFkb25seSBhdHRyaWJ1dGUgTmFtZWROb2RlTWFwIGVu dGl0aWVzOworICAgIFtJbXBsZW1lbnRlZEFzPW5vdGF0aW9uc0ZvckJpbmRpbmdzXSByZWFkb25s eSBhdHRyaWJ1dGUgTmFtZWROb2RlTWFwIG5vdGF0aW9uczsKKyNlbmRpZgogCiAgICAgLy8gRE9N IExldmVsIDIKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5kZXggODEyMDNiNGUxNGIy N2I5ZmFmYjBjMTljYzM5YjYxYzY0YzUwZTMzMi4uMmE0ZmU0NDYyNzQ1MzQ3MzE0ZDk1N2RiNWE4 Yzk0YTEzMDQ3YTRmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5n ZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTYtMDEtMTUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAg ICAgICBEcm9wIG9ic29sZXRlIERvY3VtZW50VHlwZS5lbnRpdGllcyAvIG5vdGF0aW9ucworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMTQ3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmViYXNlbGluZSBX M0MgdGVzdCBub3cgdGhhdCBtb3JlIGNoZWNrcyBhcmUgcGFzc2luZy4KKworICAgICAgICAqIHdl Yi1wbGF0Zm9ybS10ZXN0cy9kb20vaGlzdG9yaWNhbC1leHBlY3RlZC50eHQ6CisKIDIwMTYtMDEt MTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFibGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAg ICBbU3RyZWFtcyBBUEldIEV4cG9zZSBSZWFkYWJsZVN0cmVhbSBhbmQgcmVsYXRpdmVzIHRvIFdv cmtlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9kb20vaGlzdG9yaWNhbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93 M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9oaXN0b3JpY2FsLWV4cGVjdGVkLnR4dAppbmRleCBl YTVkMWExNjUzMWZlNTA2ZDVhY2RkMjE1MzhiNTdhMjI5ZWFmZWUxLi5mNDFkZTczNjViY2I2NzJh MDc1MGE5YmNjMDMzOGI1ZDYwMmFiNjZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9oaXN0b3JpY2FsLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2RvbS9oaXN0b3Jp Y2FsLWV4cGVjdGVkLnR4dApAQCAtMzUsOCArMzUsOCBAQCBQQVNTIEhpc3RvcmljYWwgRE9NIGZl YXR1cmVzIG11c3QgYmUgcmVtb3ZlZDogc2NoZW1hVHlwZUluZm8KIFBBU1MgSGlzdG9yaWNhbCBE T00gZmVhdHVyZXMgbXVzdCBiZSByZW1vdmVkOiBzZXRJZEF0dHJpYnV0ZSAKIFBBU1MgSGlzdG9y aWNhbCBET00gZmVhdHVyZXMgbXVzdCBiZSByZW1vdmVkOiBzZXRJZEF0dHJpYnV0ZU5TIAogUEFT UyBIaXN0b3JpY2FsIERPTSBmZWF0dXJlcyBtdXN0IGJlIHJlbW92ZWQ6IHNldElkQXR0cmlidXRl Tm9kZSAKLUZBSUwgRG9jdW1lbnRUeXBlIG1lbWJlciBtdXN0IGJlIG51a2VkOiBlbnRpdGllcyBh c3NlcnRfZXF1YWxzOiBleHBlY3RlZCAodW5kZWZpbmVkKSB1bmRlZmluZWQgYnV0IGdvdCAob2Jq ZWN0KSBudWxsCi1GQUlMIERvY3VtZW50VHlwZSBtZW1iZXIgbXVzdCBiZSBudWtlZDogbm90YXRp b25zIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICh1bmRlZmluZWQpIHVuZGVmaW5lZCBidXQgZ290 IChvYmplY3QpIG51bGwKK1BBU1MgRG9jdW1lbnRUeXBlIG1lbWJlciBtdXN0IGJlIG51a2VkOiBl bnRpdGllcyAKK1BBU1MgRG9jdW1lbnRUeXBlIG1lbWJlciBtdXN0IGJlIG51a2VkOiBub3RhdGlv bnMgCiBGQUlMIERvY3VtZW50VHlwZSBtZW1iZXIgbXVzdCBiZSBudWtlZDogaW50ZXJuYWxTdWJz ZXQgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgKHVuZGVmaW5lZCkgdW5kZWZpbmVkIGJ1dCBnb3Qg KG9iamVjdCkgbnVsbAogUEFTUyBUZXh0IG1lbWJlciBtdXN0IGJlIG51a2VkOiBpc0VsZW1lbnRD b250ZW50V2hpdGVzcGFjZSAKIEZBSUwgVGV4dCBtZW1iZXIgbXVzdCBiZSBudWtlZDogcmVwbGFj ZVdob2xlVGV4dCBhc3NlcnRfZXF1YWxzOiBleHBlY3RlZCAodW5kZWZpbmVkKSB1bmRlZmluZWQg YnV0IGdvdCAoZnVuY3Rpb24pIGZ1bmN0aW9uICJmdW5jdGlvbiByZXBsYWNlV2hvbGVUZXh0KCkg ewo=