<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>153135</bug_id>
          
          <creation_ts>2016-01-15 10:40:49 -0800</creation_ts>
          <short_desc>[EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO</short_desc>
          <delta_ts>2016-01-18 07:17:46 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>153134</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Olivier Blin">olivier.blin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1155825</commentid>
    <comment_count>0</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 10:40:49 -0800</bug_when>
    <thetext>GStreamer builds fail when WebAudio is enabled but VIDEO disabled.

In file included from WebKit/Source/WTF/wtf/FastMalloc.h:26:0,
                 from WebKit/Source/WebKit2/config.h:44,
                 from WebKit/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:29:
WebKit/Source/WTF/wtf/StdLibExtras.h: In instantiation of ‘typename std::_Unique_if&lt;T&gt;::_Single_object std::make_unique(Args&amp;&amp; ...) [with T = WebKit::PageClientImpl; Args = {_GtkWidget*&amp;}; typename std::_Unique_if&lt;T&gt;::_Single_object = std::unique_ptr&lt;WebKit::PageClientImpl&gt;]’:
WebKit/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:493:67:   required from here
WebKit/Source/WTF/wtf/StdLibExtras.h:311:60: error: invalid new-expression of abstract class type ‘WebKit::PageClientImpl’
     return unique_ptr&lt;T&gt;(new T(std::forward&lt;Args&gt;(args)...));
                                                            ^
In file included from WebKit/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:39:0:
WebKit/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:45:7: note:   because the following virtual functions are pure within ‘WebKit::PageClientImpl’:
 class PageClientImpl : public PageClient
       ^
In file included from WebKit/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h:33:0,
                 from WebKit/Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:39:
WebKit/Source/WebKit2/UIProcess/PageClient.h:356:18: note:  virtual bool WebKit::PageClient::decicePolicyForInstallMissingMediaPluginsPermissionRequest&amp;)
     virtual bool decicePolicyForInstallMissingMediaPluginsPermissionRequest(InstallMissingMediaPluginsPermissionRequest&amp;) = 0;
                  ^</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155828</commentid>
    <comment_count>1</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 10:41:21 -0800</bug_when>
    <thetext>See also bug 153134 for a related fix in WebCore.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155834</commentid>
    <comment_count>2</comment_count>
      <attachid>269068</attachid>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 10:47:01 -0800</bug_when>
    <thetext>Created attachment 269068
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155857</commentid>
    <comment_count>3</comment_count>
      <attachid>269068</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-01-15 11:44:13 -0800</bug_when>
    <thetext>Comment on attachment 269068
Patch

Thanks for your patch. I agree these #ifdefs are incorrect, but I think the right fix is to run the permission request even when video is not enabled. For instance, say you navigate to a page that attempts to play MP3 media; the browser ought to be notified if the appropriate GStreamer plugin is not available.

Carlos, why did you decide to use ENABLE(VIDEO) to guard this code?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156004</commentid>
    <comment_count>4</comment_count>
      <attachid>269114</attachid>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 15:55:16 -0800</bug_when>
    <thetext>Created attachment 269114
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156005</commentid>
    <comment_count>5</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 15:57:02 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Comment on attachment 269068 [details]
&gt; Patch
&gt; 
&gt; Thanks for your patch. I agree these #ifdefs are incorrect, but I think the
&gt; right fix is to run the permission request even when video is not enabled.
&gt; For instance, say you navigate to a page that attempts to play MP3 media;
&gt; the browser ought to be notified if the appropriate GStreamer plugin is not
&gt; available.

This makes sense, I have updated the patch to do so.
Build tested with and without video enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156076</commentid>
    <comment_count>6</comment_count>
      <attachid>269114</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-01-15 18:41:00 -0800</bug_when>
    <thetext>Comment on attachment 269114
Patch

Hm, I see there&apos;s a significant amount of code in WebKitInstallMissingMediaPluginsPermissionRequest.cpp that is still guarded by ENABLE(VIDEO), so even though this compiles, this feature will surely be broken. Also, the permission request is never emitted due to the ENABLE(VIDEO) guard in WebKitWebView.cpp.

This code was added in r188121. At the time, I noticed the ENABLE_VIDEO guards but assumed that ENABLE_WEB_AUDIO depended on ENABLE_VIDEO; that is not correct. Carlos, what do you think about this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156149</commentid>
    <comment_count>7</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2016-01-16 01:42:23 -0800</bug_when>
    <thetext>HTMLMediaElement si the one starting the requestInstallMissingPlugins IIRC, and HTMLMediaElement is only compiled if ENABLE(VIDEO).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156158</commentid>
    <comment_count>8</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-16 03:28:03 -0800</bug_when>
    <thetext>There does not seem to be any code in WebKitWebAudioSourceGStreamer to detect missing codecs, so it is worth enabling this for WebAudio as well?

If not, should I just resubmit the initial patch with a fixed ChangeLog?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156169</commentid>
    <comment_count>9</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-01-16 07:58:51 -0800</bug_when>
    <thetext>(In reply to comment #8)
&gt; There does not seem to be any code in WebKitWebAudioSourceGStreamer to
&gt; detect missing codecs, so it is worth enabling this for WebAudio as well?
&gt; 
&gt; If not, should I just resubmit the initial patch with a fixed ChangeLog?

Yeah, looks like my initial review was wrong. #if ENABLE(VIDEO) it is, then! Thanks again for upstreaming this fix.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156369</commentid>
    <comment_count>10</comment_count>
      <attachid>269213</attachid>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-18 02:09:21 -0800</bug_when>
    <thetext>Created attachment 269213
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156370</commentid>
    <comment_count>11</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-18 02:12:16 -0800</bug_when>
    <thetext>Rolled back to the initial (In reply to comment #9)
&gt; (In reply to comment #8)
&gt; &gt; If not, should I just resubmit the initial patch with a fixed ChangeLog?
&gt; 
&gt; Yeah, looks like my initial review was wrong. #if ENABLE(VIDEO) it is, then!
&gt; Thanks again for upstreaming this fix.

I overlooked this as well when writing the patch, thank you both for your comments and review.

I have attached the initial version back, with an updated ChangeLog.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156402</commentid>
    <comment_count>12</comment_count>
      <attachid>269213</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-01-18 07:17:43 -0800</bug_when>
    <thetext>Comment on attachment 269213
Patch

Clearing flags on attachment: 269213

Committed r195231: &lt;http://trac.webkit.org/changeset/195231&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1156403</commentid>
    <comment_count>13</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-01-18 07:17:46 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>269068</attachid>
            <date>2016-01-15 10:47:01 -0800</date>
            <delta_ts>2016-01-15 15:55:08 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153135-20160115194630.patch</filename>
            <type>text/plain</type>
            <size>5565</size>
            <attacher name="Olivier Blin">olivier.blin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2YzN2FkMzFkYjk4M2Mw
OTMwNWIwYjQ0M2YxNjg0MDI0YTE4N2Q0NC4uMDViN2ZlMzYxY2MwYTE3MDdlZDEzMWFkNmFmMzM0
YWVjMTI5Yzk2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDE2LTAxLTE1ICBPbGl2
aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0VGTF1b
R1RLXVtXSzJdIEZpeCBVSVByb2Nlc3MgYnVpbGQgd2l0aCBHU3RyZWFtZXIgYW5kIHdpdGhvdXQg
VklERU8KKworICAgICAgICBHU3RyZWFtZXIgYnVpbGRzIGZhaWwgd2hlbiBXZWJBdWRpbyBpcyBl
bmFibGVkIGJ1dCBWSURFTyBkaXNhYmxlZC4KKworICAgICAgICBUaGlzIGNoYW5nZSBtYWtlcyBm
bGFnIG1vcmUgY29uc2lzdGVudCBhcm91bmQgdGhlCisgICAgICAgIGRlY2ljZVBvbGljeUZvcklu
c3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoKSBtZXRob2Q6CisgICAg
ICAgIEVOQUJMRShWSURFTykgJiYgVVNFKEdTVFJFQU1FUikgZXZlcnl3aGVyZSwgd2hpbGUgdGhl
IGNvZGUgdXNlZCB0bworICAgICAgICB0ZXN0IGVpdGhlciBvbmUgb3IgdGhlIG90aGVyLgorCisg
ICAgICAgIEl0IGFsc28gZml4ZXMgYSBuYW1pbmcgdHlwbyBmb3IgdGhlIGZvbGxvd2luZyBtZXRo
b2Q6CisgICAgICAgIGRlY2lkZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVy
bWlzc2lvblJlcXVlc3QoKQorCisgICAgICAgIFtFRkxdW0dUS11bV0syXSBGaXggVUlQcm9jZXNz
IGJ1aWxkIHdpdGggR1N0cmVhbWVyIGFuZCB3aXRob3V0IFZJREVPCisgICAgICAgIGh0dHBzOi8v
YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMxMzUKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VD
bGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmRlY2lkZVBv
bGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QpOgorICAg
ICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmg6CisgICAgICAgICogVUlQ
cm9jZXNzL1BhZ2VDbGllbnQuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvZWZsL1dlYlZpZXdFZmwu
aDoKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3N0cmVhbWVyL1dlYlBhZ2VQcm94eUdTdHJlYW1lci5j
cHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cmVxdWVzdEluc3RhbGxNaXNzaW5n
TWVkaWFQbHVnaW5zKToKKwogMjAxNi0wMS0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy
QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgd29ya2Fyb3VuZCBmb3IgcmRhcjovL3Byb2Js
ZW0vMjM2MjM2NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr
L1BhZ2VDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1Bh
Z2VDbGllbnRJbXBsLmNwcAppbmRleCBkZmNiZDkyZjgwNmRmNjdiM2JmNzk0NDMyNTE2NjZkYzhm
NzAxZDZhLi4wYTg2NzVkMzUzYWQ3MTA2ZTUyYThkOTk5ZWRiMGYyMjYwNjkyYjBjIDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAK
KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuY3Bw
CkBAIC00MzksOCArNDM5LDggQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6ZGVyZWZWaWV3KCkKICAg
ICBnX29iamVjdF91bnJlZihtX3ZpZXdXaWRnZXQpOwogfQogCi0jaWYgRU5BQkxFKFZJREVPKQot
Ym9vbCBQYWdlQ2xpZW50SW1wbDo6ZGVjaWNlUG9saWN5Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBs
dWdpbnNQZXJtaXNzaW9uUmVxdWVzdChJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Np
b25SZXF1ZXN0JiByZXF1ZXN0KQorI2lmIEVOQUJMRShWSURFTykgJiYgVVNFKEdTVFJFQU1FUikK
K2Jvb2wgUGFnZUNsaWVudEltcGw6OmRlY2lkZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQ
bHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNz
aW9uUmVxdWVzdCYgcmVxdWVzdCkKIHsKICAgICBpZiAoIVdFQktJVF9JU19XRUJfVklFVyhtX3Zp
ZXdXaWRnZXQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi
S2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oIGIvU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaAppbmRleCA3OGZjNjg4NTNiNjUyMTk0
ZjliNjdhODJiNjVjMzc4YWM2OTU5ODI3Li43YWYyYjliNmNjY2I5OWZiM2VkOTVkYjg2YjQ1NTNm
MTY1MTk0NjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9Q
YWdlQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1Bh
Z2VDbGllbnRJbXBsLmgKQEAgLTE0MSw4ICsxNDEsOCBAQCBwcml2YXRlOgogCiAgICAgdmlydHVh
bCB2b2lkIGRpZFJlc3RvcmVTY3JvbGxQb3NpdGlvbigpIG92ZXJyaWRlIHsgfQogCi0jaWYgRU5B
QkxFKFZJREVPKQotICAgIHZpcnR1YWwgYm9vbCBkZWNpY2VQb2xpY3lGb3JJbnN0YWxsTWlzc2lu
Z01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0KEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5z
UGVybWlzc2lvblJlcXVlc3QmKSBvdmVycmlkZTsKKyNpZiBFTkFCTEUoVklERU8pICYmIFVTRShH
U1RSRUFNRVIpCisgICAgdmlydHVhbCBib29sIGRlY2lkZVBvbGljeUZvckluc3RhbGxNaXNzaW5n
TWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQ
ZXJtaXNzaW9uUmVxdWVzdCYpIG92ZXJyaWRlOwogI2VuZGlmCiAKICAgICAvLyBNZW1iZXJzIG9m
IFBhZ2VDbGllbnRJbXBsIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvUGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaApp
bmRleCBkY2JjNmQxOGI1MDZmMDRhMzU3YTE1NzJjMGFhMTIwZWU1NmVhMmJjLi44MDNiOWM3ZTVi
OTQ3NjBiMjU4MjVlZDdkMjUzMDNmNThiMjllYWVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0
Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Q
YWdlQ2xpZW50LmgKQEAgLTM1Miw4ICszNTIsOCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lk
IHJlZlZpZXcoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmVmlldygpID0gMDsKIAotI2lm
IFVTRShHU1RSRUFNRVIpCi0gICAgdmlydHVhbCBib29sIGRlY2ljZVBvbGljeUZvckluc3RhbGxN
aXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBs
dWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpID0gMDsKKyNpZiBFTkFCTEUoVklERU8pICYmIFVTRShH
U1RSRUFNRVIpCisgICAgdmlydHVhbCBib29sIGRlY2lkZVBvbGljeUZvckluc3RhbGxNaXNzaW5n
TWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQ
ZXJtaXNzaW9uUmVxdWVzdCYpID0gMDsKICNlbmRpZgogCiAgICAgdmlydHVhbCB2b2lkIGRpZFJl
c3RvcmVTY3JvbGxQb3NpdGlvbigpID0gMDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9lZmwvV2ViVmlld0VmbC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9X
ZWJWaWV3RWZsLmgKaW5kZXggZDFlZjgzZjBkMTE3Nzc5NDE2ZTcwODYyYThkODM2NTdhZGFmOGJh
Yi4uYjRiY2Q5M2E2MDkwZmY3NjRiNWY2OTZkNWJjMzBiY2Q3NjAyYzhkYiAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmgKKysrIGIvU291cmNlL1dl
YktpdDIvVUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmgKQEAgLTk1LDggKzk1LDggQEAgcHJpdmF0
ZToKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRSZXN0b3JlU2Nyb2xsUG9zaXRpb24oKSBvdmVycmlk
ZSBmaW5hbCB7IH0KIAotI2lmIFVTRShHU1RSRUFNRVIpCi0gICAgdmlydHVhbCBib29sIGRlY2lj
ZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5z
dGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpIG92ZXJyaWRlIGZpbmFs
IHsgcmV0dXJuIGZhbHNlOyB9OworI2lmIEVOQUJMRShWSURFTykgJiYgVVNFKEdTVFJFQU1FUikK
KyAgICB2aXJ0dWFsIGJvb2wgZGVjaWRlUG9saWN5Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdp
bnNQZXJtaXNzaW9uUmVxdWVzdChJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25S
ZXF1ZXN0Jikgb3ZlcnJpZGUgZmluYWwgeyByZXR1cm4gZmFsc2U7IH07CiAjZW5kaWYKIAogcHJp
dmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nc3RyZWFtZXIvV2Vi
UGFnZVByb3h5R1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nc3RyZWFt
ZXIvV2ViUGFnZVByb3h5R1N0cmVhbWVyLmNwcAppbmRleCBhOTdkY2FhYTUwZWYyYTg5YjcwYjVk
M2Y4NjZkNDEyYjRhMmYxZDEyLi4yZWQ5YzM0Y2ZlYWEwYjk1ZjIyMDJlZGI0NGFhYmY4OTE5MGQz
NmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3N0cmVhbWVyL1dlYlBh
Z2VQcm94eUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2dzdHJl
YW1lci9XZWJQYWdlUHJveHlHU3RyZWFtZXIuY3BwCkBAIC0zNSw3ICszNSw3IEBAIG5hbWVzcGFj
ZSBXZWJLaXQgewogdm9pZCBXZWJQYWdlUHJveHk6OnJlcXVlc3RJbnN0YWxsTWlzc2luZ01lZGlh
UGx1Z2lucyhjb25zdCBTdHJpbmcmIGRldGFpbHMsIGNvbnN0IFN0cmluZyYgZGVzY3JpcHRpb24p
CiB7CiAgICAgUmVmUHRyPEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVl
c3Q+IHJlcXVlc3QgPSBJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0
OjpjcmVhdGUoKnRoaXMsIGRldGFpbHMsIGRlc2NyaXB0aW9uKTsKLSAgICBpZiAobV9wYWdlQ2xp
ZW50LmRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJl
cXVlc3QoKnJlcXVlc3QpKQorICAgIGlmIChtX3BhZ2VDbGllbnQuZGVjaWRlUG9saWN5Rm9ySW5z
dGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCgqcmVxdWVzdCkpCiAgICAg
ICAgIHJldHVybjsKIAogICAgIHJlcXVlc3QtPmRlbnkoKTsK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>269114</attachid>
            <date>2016-01-15 15:55:16 -0800</date>
            <delta_ts>2016-01-18 02:09:14 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153135-20160116005445.patch</filename>
            <type>text/plain</type>
            <size>5321</size>
            <attacher name="Olivier Blin">olivier.blin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2YzN2FkMzFkYjk4M2Mw
OTMwNWIwYjQ0M2YxNjg0MDI0YTE4N2Q0NC4uNmFjM2QwZTBjOWI5Mzg5MmE0NzdmZTkyMzgwMjQ1
MmZiMDJjYzE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE2LTAxLTE1ICBPbGl2
aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0VGTF1b
R1RLXVtXSzJdIEZpeCBVSVByb2Nlc3MgYnVpbGQgd2l0aCBHU3RyZWFtZXIgYW5kIHdpdGhvdXQg
VklERU8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1
MzEzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdT
dHJlYW1lciBidWlsZHMgZmFpbCB3aGVuIFdlYkF1ZGlvIGlzIGVuYWJsZWQgYnV0IFZJREVPIGRp
c2FibGVkLgorCisgICAgICAgIFRoaXMgY2hhbmdlIG1ha2VzIHRoZSBmbGFnIG1vcmUgY29uc2lz
dGVudCBhcm91bmQgdGhlCisgICAgICAgIGRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVk
aWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoKSBtZXRob2Q6CisgICAgICAgIHVzZSBVU0UoR1NU
UkVBTUVSKSBldmVyeXdoZXJlLCBpbmRlcGVuZGVudGx5IG9mIEVOQUJMRShWSURFTykuCisgICAg
ICAgIFRoaXMgYWxsb3dzIHRvIHJlcXVlc3QgYXVkaW8gcGx1Z2lucyBpZiBuZWVkZWQuCisKKyAg
ICAgICAgSXQgYWxzbyBmaXhlcyBhIG5hbWluZyB0eXBvIGZvciB0aGUgZm9sbG93aW5nIG1ldGhv
ZDoKKyAgICAgICAgZGVjaWRlUG9saWN5Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJt
aXNzaW9uUmVxdWVzdCgpCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50
SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpkZWNpZGVQb2xpY3lG
b3JJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0KToKKyAgICAgICAg
KiBVSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAgICAqIFVJUHJvY2Vz
cy9QYWdlQ2xpZW50Lmg6CisgICAgICAgICogVUlQcm9jZXNzL2dzdHJlYW1lci9XZWJQYWdlUHJv
eHlHU3RyZWFtZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6OnJlcXVlc3RJ
bnN0YWxsTWlzc2luZ01lZGlhUGx1Z2lucyk6CisKIDIwMTYtMDEtMTQgIFNpbW9uIEZyYXNlciAg
PHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmVtb3ZlIHdvcmthcm91bmQgZm9y
IHJkYXI6Ly9wcm9ibGVtLzIzNjIzNjcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5jcHAKaW5kZXggZGZjYmQ5MmY4MDZkZjY3YjNiZjc5
NDQzMjUxNjY2ZGM4ZjcwMWQ2YS4uMGNiYTRiODliODI5MDk5MmQwZGFhNmJjN2NjN2YxNTc3YTZj
ZjE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNs
aWVudEltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VD
bGllbnRJbXBsLmNwcApAQCAtNDM5LDggKzQzOSw4IEBAIHZvaWQgUGFnZUNsaWVudEltcGw6OmRl
cmVmVmlldygpCiAgICAgZ19vYmplY3RfdW5yZWYobV92aWV3V2lkZ2V0KTsKIH0KIAotI2lmIEVO
QUJMRShWSURFTykKLWJvb2wgUGFnZUNsaWVudEltcGw6OmRlY2ljZVBvbGljeUZvckluc3RhbGxN
aXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBs
dWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYgcmVxdWVzdCkKKyNpZiBVU0UoR1NUUkVBTUVSKQorYm9v
bCBQYWdlQ2xpZW50SW1wbDo6ZGVjaWRlUG9saWN5Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdp
bnNQZXJtaXNzaW9uUmVxdWVzdChJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25S
ZXF1ZXN0JiByZXF1ZXN0KQogewogICAgIGlmICghV0VCS0lUX0lTX1dFQl9WSUVXKG1fdmlld1dp
ZGdldCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQy
L1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCmluZGV4IDc4ZmM2ODg1M2I2NTIxOTRmOWI2
N2E4MmI2NWMzNzhhYzY5NTk4MjcuLjEwOTkyODJjZWM4YzlhMWU0MDllZDhlYjQzNDIxNjNiMDA0
YTliNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VD
bGllbnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNs
aWVudEltcGwuaApAQCAtMTQxLDggKzE0MSw4IEBAIHByaXZhdGU6CiAKICAgICB2aXJ0dWFsIHZv
aWQgZGlkUmVzdG9yZVNjcm9sbFBvc2l0aW9uKCkgb3ZlcnJpZGUgeyB9CiAKLSNpZiBFTkFCTEUo
VklERU8pCi0gICAgdmlydHVhbCBib29sIGRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVk
aWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJt
aXNzaW9uUmVxdWVzdCYpIG92ZXJyaWRlOworI2lmIFVTRShHU1RSRUFNRVIpCisgICAgdmlydHVh
bCBib29sIGRlY2lkZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lv
blJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpIG92
ZXJyaWRlOwogI2VuZGlmCiAKICAgICAvLyBNZW1iZXJzIG9mIFBhZ2VDbGllbnRJbXBsIGNsYXNz
CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oIGIvU291
cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaAppbmRleCBkY2JjNmQxOGI1MDZmMDRh
MzU3YTE1NzJjMGFhMTIwZWU1NmVhMmJjLi45ZDljZDRkYWU5OGE2OWQ2YjljZjAyNmNhOTU5ZTI1
MDc1YjBjZGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVu
dC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgKQEAgLTM1Myw3
ICszNTMsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmVmlldygpID0gMDsKIAog
I2lmIFVTRShHU1RSRUFNRVIpCi0gICAgdmlydHVhbCBib29sIGRlY2ljZVBvbGljeUZvckluc3Rh
bGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRp
YVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpID0gMDsKKyAgICB2aXJ0dWFsIGJvb2wgZGVjaWRl
UG9saWN5Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdChJbnN0
YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0JikgPSAwOwogI2VuZGlmCiAK
ICAgICB2aXJ0dWFsIHZvaWQgZGlkUmVzdG9yZVNjcm9sbFBvc2l0aW9uKCkgPSAwOwpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmggYi9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYlZpZXdFZmwuaAppbmRleCBkMWVmODNmMGQxMTc3Nzk0
MTZlNzA4NjJhOGQ4MzY1N2FkYWY4YmFiLi4zOTg3ZTkyZTljMjNmNWIxN2M4ZDE1NzIxMTBkYWUy
ZGE2NmFjOWQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYlZp
ZXdFZmwuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYlZpZXdFZmwuaApA
QCAtOTYsNyArOTYsNyBAQCBwcml2YXRlOgogICAgIHZpcnR1YWwgdm9pZCBkaWRSZXN0b3JlU2Ny
b2xsUG9zaXRpb24oKSBvdmVycmlkZSBmaW5hbCB7IH0KIAogI2lmIFVTRShHU1RSRUFNRVIpCi0g
ICAgdmlydHVhbCBib29sIGRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5z
UGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVx
dWVzdCYpIG92ZXJyaWRlIGZpbmFsIHsgcmV0dXJuIGZhbHNlOyB9OworICAgIHZpcnR1YWwgYm9v
bCBkZWNpZGVQb2xpY3lGb3JJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1
ZXN0KEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QmKSBvdmVycmlk
ZSBmaW5hbCB7IHJldHVybiBmYWxzZTsgfTsKICNlbmRpZgogCiBwcml2YXRlOgpkaWZmIC0tZ2l0
IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2dzdHJlYW1lci9XZWJQYWdlUHJveHlHU3RyZWFt
ZXIuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2dzdHJlYW1lci9XZWJQYWdlUHJveHlH
U3RyZWFtZXIuY3BwCmluZGV4IGE5N2RjYWFhNTBlZjJhODliNzBiNWQzZjg2NmQ0MTJiNGEyZjFk
MTIuLjJlZDljMzRjZmVhYTBiOTVmMjIwMmVkYjQ0YWFiZjg5MTkwZDM2ZWIgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9nc3RyZWFtZXIvV2ViUGFnZVByb3h5R1N0cmVhbWVy
LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3N0cmVhbWVyL1dlYlBhZ2VQcm94
eUdTdHJlYW1lci5jcHAKQEAgLTM1LDcgKzM1LDcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiB2b2lk
IFdlYlBhZ2VQcm94eTo6cmVxdWVzdEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zKGNvbnN0IFN0
cmluZyYgZGV0YWlscywgY29uc3QgU3RyaW5nJiBkZXNjcmlwdGlvbikKIHsKICAgICBSZWZQdHI8
SW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdD4gcmVxdWVzdCA9IElu
c3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3Q6OmNyZWF0ZSgqdGhpcywg
ZGV0YWlscywgZGVzY3JpcHRpb24pOwotICAgIGlmIChtX3BhZ2VDbGllbnQuZGVjaWNlUG9saWN5
Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCgqcmVxdWVzdCkp
CisgICAgaWYgKG1fcGFnZUNsaWVudC5kZWNpZGVQb2xpY3lGb3JJbnN0YWxsTWlzc2luZ01lZGlh
UGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0KCpyZXF1ZXN0KSkKICAgICAgICAgcmV0dXJuOwogCiAg
ICAgcmVxdWVzdC0+ZGVueSgpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>269213</attachid>
            <date>2016-01-18 02:09:21 -0800</date>
            <delta_ts>2016-01-18 07:17:43 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153135-20160118110851.patch</filename>
            <type>text/plain</type>
            <size>5637</size>
            <attacher name="Olivier Blin">olivier.blin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggY2YzN2FkMzFkYjk4M2Mw
OTMwNWIwYjQ0M2YxNjg0MDI0YTE4N2Q0NC4uYmNiNTE3NzYxODdhMjNhYTc1ZWQyN2JhMzZiY2Iz
ZTQzYjBkMzM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE2LTAxLTE1ICBPbGl2
aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0VGTF1b
R1RLXVtXSzJdIEZpeCBVSVByb2Nlc3MgYnVpbGQgd2l0aCBHU3RyZWFtZXIgYW5kIHdpdGhvdXQg
VklERU8KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1
MzEzNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdT
dHJlYW1lciBidWlsZHMgZmFpbCB3aGVuIFdlYkF1ZGlvIGlzIGVuYWJsZWQgYnV0IFZJREVPIGRp
c2FibGVkLgorCisgICAgICAgIFRoaXMgY2hhbmdlIG1ha2VzIHRoZSBmbGFnIG1vcmUgY29uc2lz
dGVudCBhcm91bmQgdGhlCisgICAgICAgIGRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVk
aWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoKSBtZXRob2Q6CisgICAgICAgIEVOQUJMRShWSURF
TykgJiYgVVNFKEdTVFJFQU1FUikgZXZlcnl3aGVyZSwgd2hpbGUgdGhlIGNvZGUgdXNlZCB0bwor
ICAgICAgICB0ZXN0IGVpdGhlciBvbmUgb3IgdGhlIG90aGVyLgorCisgICAgICAgIFRoaXMgZG9l
cyBub3QgZW5hYmxlIEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zIGZvciBXZWJBdWRpbywgc2lu
Y2Ugbm8KKyAgICAgICAgY29kZSBtYWtlcyB1c2Ugb2YgdGhpcyBpbiBXZWJLaXRXZWJBdWRpb1Nv
dXJjZUdTdHJlYW1lci4KKworICAgICAgICBJdCBhbHNvIGZpeGVzIGEgbmFtaW5nIHR5cG8gZm9y
IHRoZSBmb2xsb3dpbmcgbWV0aG9kOgorICAgICAgICBkZWNpZGVQb2xpY3lGb3JJbnN0YWxsTWlz
c2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0KCkKKworICAgICAgICAqIFVJUHJvY2Vz
cy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UGFnZUNsaWVu
dEltcGw6OmRlY2lkZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lv
blJlcXVlc3QpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmg6
CisgICAgICAgICogVUlQcm9jZXNzL1BhZ2VDbGllbnQuaDoKKyAgICAgICAgKiBVSVByb2Nlc3Mv
ZWZsL1dlYlZpZXdFZmwuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3N0cmVhbWVyL1dlYlBhZ2VQ
cm94eUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6cmVxdWVz
dEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zKToKKwogMjAxNi0wMS0xNCAgU2ltb24gRnJhc2Vy
ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgd29ya2Fyb3VuZCBm
b3IgcmRhcjovL3Byb2JsZW0vMjM2MjM2NzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmNwcAppbmRleCBkZmNiZDkyZjgwNmRmNjdiM2Jm
Nzk0NDMyNTE2NjZkYzhmNzAxZDZhLi4wYTg2NzVkMzUzYWQ3MTA2ZTUyYThkOTk5ZWRiMGYyMjYw
NjkyYjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdl
Q2xpZW50SW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFn
ZUNsaWVudEltcGwuY3BwCkBAIC00MzksOCArNDM5LDggQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6
ZGVyZWZWaWV3KCkKICAgICBnX29iamVjdF91bnJlZihtX3ZpZXdXaWRnZXQpOwogfQogCi0jaWYg
RU5BQkxFKFZJREVPKQotYm9vbCBQYWdlQ2xpZW50SW1wbDo6ZGVjaWNlUG9saWN5Rm9ySW5zdGFs
bE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdChJbnN0YWxsTWlzc2luZ01lZGlh
UGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0JiByZXF1ZXN0KQorI2lmIEVOQUJMRShWSURFTykgJiYg
VVNFKEdTVFJFQU1FUikKK2Jvb2wgUGFnZUNsaWVudEltcGw6OmRlY2lkZVBvbGljeUZvckluc3Rh
bGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRp
YVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYgcmVxdWVzdCkKIHsKICAgICBpZiAoIVdFQktJVF9J
U19XRUJfVklFVyhtX3ZpZXdXaWRnZXQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CmRpZmYgLS1n
aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oIGIv
U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvUGFnZUNsaWVudEltcGwuaAppbmRleCA3
OGZjNjg4NTNiNjUyMTk0ZjliNjdhODJiNjVjMzc4YWM2OTU5ODI3Li43YWYyYjliNmNjY2I5OWZi
M2VkOTVkYjg2YjQ1NTNmMTY1MTk0NjJjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy
b2Nlc3MvQVBJL2d0ay9QYWdlQ2xpZW50SW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9BUEkvZ3RrL1BhZ2VDbGllbnRJbXBsLmgKQEAgLTE0MSw4ICsxNDEsOCBAQCBwcml2YXRl
OgogCiAgICAgdmlydHVhbCB2b2lkIGRpZFJlc3RvcmVTY3JvbGxQb3NpdGlvbigpIG92ZXJyaWRl
IHsgfQogCi0jaWYgRU5BQkxFKFZJREVPKQotICAgIHZpcnR1YWwgYm9vbCBkZWNpY2VQb2xpY3lG
b3JJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Blcm1pc3Npb25SZXF1ZXN0KEluc3RhbGxNaXNz
aW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QmKSBvdmVycmlkZTsKKyNpZiBFTkFCTEUo
VklERU8pICYmIFVTRShHU1RSRUFNRVIpCisgICAgdmlydHVhbCBib29sIGRlY2lkZVBvbGljeUZv
ckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3Np
bmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpIG92ZXJyaWRlOwogI2VuZGlmCiAKICAg
ICAvLyBNZW1iZXJzIG9mIFBhZ2VDbGllbnRJbXBsIGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz
L1BhZ2VDbGllbnQuaAppbmRleCBkY2JjNmQxOGI1MDZmMDRhMzU3YTE1NzJjMGFhMTIwZWU1NmVh
MmJjLi44MDNiOWM3ZTViOTQ3NjBiMjU4MjVlZDdkMjUzMDNmNThiMjllYWVhIDEwMDY0NAotLS0g
YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCisrKyBiL1NvdXJjZS9XZWJL
aXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50LmgKQEAgLTM1Miw4ICszNTIsOCBAQCBwdWJsaWM6CiAg
ICAgdmlydHVhbCB2b2lkIHJlZlZpZXcoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmVmll
dygpID0gMDsKIAotI2lmIFVTRShHU1RSRUFNRVIpCi0gICAgdmlydHVhbCBib29sIGRlY2ljZVBv
bGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFs
bE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpID0gMDsKKyNpZiBFTkFCTEUo
VklERU8pICYmIFVTRShHU1RSRUFNRVIpCisgICAgdmlydHVhbCBib29sIGRlY2lkZVBvbGljeUZv
ckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlzc2lvblJlcXVlc3QoSW5zdGFsbE1pc3Np
bmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYpID0gMDsKICNlbmRpZgogCiAgICAgdmly
dHVhbCB2b2lkIGRpZFJlc3RvcmVTY3JvbGxQb3NpdGlvbigpID0gMDsKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViVmlld0VmbC5oIGIvU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmgKaW5kZXggZDFlZjgzZjBkMTE3Nzc5NDE2ZTcwODYy
YThkODM2NTdhZGFmOGJhYi4uYjRiY2Q5M2E2MDkwZmY3NjRiNWY2OTZkNWJjMzBiY2Q3NjAyYzhk
YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmgK
KysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2VmbC9XZWJWaWV3RWZsLmgKQEAgLTk1LDgg
Kzk1LDggQEAgcHJpdmF0ZToKIAogICAgIHZpcnR1YWwgdm9pZCBkaWRSZXN0b3JlU2Nyb2xsUG9z
aXRpb24oKSBvdmVycmlkZSBmaW5hbCB7IH0KIAotI2lmIFVTRShHU1RSRUFNRVIpCi0gICAgdmly
dHVhbCBib29sIGRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5zUGVybWlz
c2lvblJlcXVlc3QoSW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCYp
IG92ZXJyaWRlIGZpbmFsIHsgcmV0dXJuIGZhbHNlOyB9OworI2lmIEVOQUJMRShWSURFTykgJiYg
VVNFKEdTVFJFQU1FUikKKyAgICB2aXJ0dWFsIGJvb2wgZGVjaWRlUG9saWN5Rm9ySW5zdGFsbE1p
c3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdChJbnN0YWxsTWlzc2luZ01lZGlhUGx1
Z2luc1Blcm1pc3Npb25SZXF1ZXN0Jikgb3ZlcnJpZGUgZmluYWwgeyByZXR1cm4gZmFsc2U7IH07
CiAjZW5kaWYKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz
cy9nc3RyZWFtZXIvV2ViUGFnZVByb3h5R1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ
UHJvY2Vzcy9nc3RyZWFtZXIvV2ViUGFnZVByb3h5R1N0cmVhbWVyLmNwcAppbmRleCBhOTdkY2Fh
YTUwZWYyYTg5YjcwYjVkM2Y4NjZkNDEyYjRhMmYxZDEyLi4yZWQ5YzM0Y2ZlYWEwYjk1ZjIyMDJl
ZGI0NGFhYmY4OTE5MGQzNmViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv
Z3N0cmVhbWVyL1dlYlBhZ2VQcm94eUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv
VUlQcm9jZXNzL2dzdHJlYW1lci9XZWJQYWdlUHJveHlHU3RyZWFtZXIuY3BwCkBAIC0zNSw3ICsz
NSw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogdm9pZCBXZWJQYWdlUHJveHk6OnJlcXVlc3RJbnN0
YWxsTWlzc2luZ01lZGlhUGx1Z2lucyhjb25zdCBTdHJpbmcmIGRldGFpbHMsIGNvbnN0IFN0cmlu
ZyYgZGVzY3JpcHRpb24pCiB7CiAgICAgUmVmUHRyPEluc3RhbGxNaXNzaW5nTWVkaWFQbHVnaW5z
UGVybWlzc2lvblJlcXVlc3Q+IHJlcXVlc3QgPSBJbnN0YWxsTWlzc2luZ01lZGlhUGx1Z2luc1Bl
cm1pc3Npb25SZXF1ZXN0OjpjcmVhdGUoKnRoaXMsIGRldGFpbHMsIGRlc2NyaXB0aW9uKTsKLSAg
ICBpZiAobV9wYWdlQ2xpZW50LmRlY2ljZVBvbGljeUZvckluc3RhbGxNaXNzaW5nTWVkaWFQbHVn
aW5zUGVybWlzc2lvblJlcXVlc3QoKnJlcXVlc3QpKQorICAgIGlmIChtX3BhZ2VDbGllbnQuZGVj
aWRlUG9saWN5Rm9ySW5zdGFsbE1pc3NpbmdNZWRpYVBsdWdpbnNQZXJtaXNzaW9uUmVxdWVzdCgq
cmVxdWVzdCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIHJlcXVlc3QtPmRlbnkoKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>