<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>153133</bug_id>
          
          <creation_ts>2016-01-15 09:43:05 -0800</creation_ts>
          <short_desc>[GTK] Fix build of RenderThemeGtk without VIDEO by including HTMLInputElement</short_desc>
          <delta_ts>2016-01-15 15:23:01 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>Other</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Olivier Blin">olivier.blin</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>glenn</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>zan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1155809</commentid>
    <comment_count>0</comment_count>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 09:43:05 -0800</bug_when>
    <thetext>Gtk build fails when VIDEO is disabled:

WebKit/Source/WebCore/rendering/RenderThemeGtk.cpp: In member function ‘virtual bool WebCore::RenderThemeGtk::shouldHaveCapsLockIndicator(WebCore::HTMLInputElement&amp;) const’:
WebKit/Source/WebCore/rendering/RenderThemeGtk.cpp:1045:19: error: invalid use of incomplete type ‘class WebCore::HTMLInputElement’
     return element.isPasswordField();
                   ^</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155810</commentid>
    <comment_count>1</comment_count>
      <attachid>269062</attachid>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 09:51:38 -0800</bug_when>
    <thetext>Created attachment 269062
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155861</commentid>
    <comment_count>2</comment_count>
      <attachid>269062</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2016-01-15 11:51:40 -0800</bug_when>
    <thetext>Comment on attachment 269062
Patch

Thanks. Please fix the changelog entry though; there should be the title of the bug only once, then the URL of the bug, the reviewed by line, then your description of the issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155934</commentid>
    <comment_count>3</comment_count>
      <attachid>269098</attachid>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 14:27:23 -0800</bug_when>
    <thetext>Created attachment 269098
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155937</commentid>
    <comment_count>4</comment_count>
      <attachid>269099</attachid>
    <who name="Olivier Blin">olivier.blin</who>
    <bug_when>2016-01-15 14:29:08 -0800</bug_when>
    <thetext>Created attachment 269099
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155989</commentid>
    <comment_count>5</comment_count>
      <attachid>269099</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-01-15 15:22:59 -0800</bug_when>
    <thetext>Comment on attachment 269099
Patch

Clearing flags on attachment: 269099

Committed r195153: &lt;http://trac.webkit.org/changeset/195153&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1155990</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-01-15 15:23:01 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>269062</attachid>
            <date>2016-01-15 09:51:38 -0800</date>
            <delta_ts>2016-01-15 14:27:12 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153133-20160115185108.patch</filename>
            <type>text/plain</type>
            <size>1584</size>
            <attacher name="Olivier Blin">olivier.blin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNWMwOGNjMGIwNmY5
ZDEzMDdhNGM2ZjkzMmYxMDY3YTdhYWNlMC4uOGQ3MGQyYTkwMzhjYTNmMWE3ZTFlNmVkOGI4OGNm
MGM4MTIxNzlkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTAxLTE1ICBPbGl2
aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0dUS10g
Rml4IGJ1aWxkIG9mIFJlbmRlclRoZW1lR3RrIHdpdGhvdXQgVklERU8gYnkgaW5jbHVkaW5nIEhU
TUxJbnB1dEVsZW1lbnQKKworICAgICAgICBCdWlsZCB3YXMgZmluZSB3aXRoIFZJREVPIGVuYWJs
ZWQsIHNpbmNlIEhUTUxJbnB1dEVsZW1lbnQuaCB3YXMKKyAgICAgICAgaW5jbHVkZWQgYnkgdHJh
bnNpdGl2aXR5IHRocm91Z2ggTWVkaWFDb250cm9sRWxlbWVudHMuaCBhbmQKKyAgICAgICAgTWVk
aWFDb250cm9sRWxlbWVudFR5cGVzLmguCisKKyAgICAgICAgVGhpcyBzZWVtcyB0byBiZSBicm9r
ZW4gc2luY2UgcjE5NDg0Ny4KKworICAgICAgICBbR1RLXSBGaXggYnVpbGQgb2YgUmVuZGVyVGhl
bWVHdGsgd2l0aG91dCBWSURFTyBieSBpbmNsdWRpbmcgSFRNTElucHV0RWxlbWVudAorICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMTMzCisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNp
bmNlIHRoaXMgaXMganVzdCBhIGJ1aWxkIGZpeC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k
ZXJUaGVtZUd0ay5jcHA6CisKIDIwMTYtMDEtMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm4uZmFi
bGV0QGNyZi5jYW5vbi5mcj4KIAogICAgICAgICBbU3RyZWFtcyBBUEldIEV4cG9zZSBSZWFkYWJs
ZVN0cmVhbSBhbmQgcmVsYXRpdmVzIHRvIFdvcmtlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv
cmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu
Zy9SZW5kZXJUaGVtZUd0ay5jcHAKaW5kZXggOGJiOGNiNTMyMDU0ZjlkYmFiOWQ2OWU4MDMxYjIx
NWM4YmM0MmUzNy4uNGI2MjJlYWMyYWI4YjY0NGUxNTllMTI1ODJiNjNlNmVkMjRjYTZmYSAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcAorKysg
Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwCkBAIC0zNSw2ICsz
NSw3IEBACiAjaW5jbHVkZSAiR3JhZGllbnQuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQu
aCIKICNpbmNsdWRlICJHdGtWZXJzaW9uaW5nLmgiCisjaW5jbHVkZSAiSFRNTElucHV0RWxlbWVu
dC5oIgogI2luY2x1ZGUgIkhUTUxNZWRpYUVsZW1lbnQuaCIKICNpbmNsdWRlICJMb2NhbGl6ZWRT
dHJpbmdzLmgiCiAjaW5jbHVkZSAiTWVkaWFDb250cm9sRWxlbWVudHMuaCIK
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>269098</attachid>
            <date>2016-01-15 14:27:23 -0800</date>
            <delta_ts>2016-01-15 14:28:50 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153133-20160115232652.patch</filename>
            <type>text/plain</type>
            <size>1495</size>
            <attacher name="Olivier Blin">olivier.blin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNWMwOGNjMGIwNmY5
ZDEzMDdhNGM2ZjkzMmYxMDY3YTdhYWNlMC4uZWU2YzYwZjA2ZjZiYTUwNjgwZmJmYmY5ZDkxMGQz
YzM1OWEwNzJiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTE1ICBPbGl2
aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0dUS10g
Rml4IGJ1aWxkIG9mIFJlbmRlclRoZW1lR3RrIHdpdGhvdXQgVklERU8gYnkgaW5jbHVkaW5nIEhU
TUxJbnB1dEVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE1MzEzMworCisgICAgICAgIEJ1aWxkIHdhcyBmaW5lIHdpdGggVklERU8gZW5hYmxl
ZCwgc2luY2UgSFRNTElucHV0RWxlbWVudC5oIHdhcworICAgICAgICBpbmNsdWRlZCBieSB0cmFu
c2l0aXZpdHkgdGhyb3VnaCBNZWRpYUNvbnRyb2xFbGVtZW50cy5oIGFuZAorICAgICAgICBNZWRp
YUNvbnRyb2xFbGVtZW50VHlwZXMuaC4KKworICAgICAgICBUaGlzIHNlZW1zIHRvIGJlIGJyb2tl
biBzaW5jZSByMTk0ODQ3LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGlzIGp1c3QgYSBidWlsZCBmaXguCisK
KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwOgorCiAyMDE2LTAxLTE1ICBZ
b3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW1N0
cmVhbXMgQVBJXSBFeHBvc2UgUmVhZGFibGVTdHJlYW0gYW5kIHJlbGF0aXZlcyB0byBXb3JrZXIK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUd0ay5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwCmluZGV4IDhiYjhj
YjUzMjA1NGY5ZGJhYjlkNjllODAzMWIyMTVjOGJjNDJlMzcuLjRiNjIyZWFjMmFiOGI2NDRlMTU5
ZTEyNTgyYjYzZTZlZDI0Y2E2ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu
Zy9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl
clRoZW1lR3RrLmNwcApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUgIkdyYWRpZW50LmgiCiAj
aW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiR3RrVmVyc2lvbmluZy5oIgor
I2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MTWVkaWFFbGVtZW50
LmgiCiAjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogI2luY2x1ZGUgIk1lZGlhQ29udHJv
bEVsZW1lbnRzLmgiCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>269099</attachid>
            <date>2016-01-15 14:29:08 -0800</date>
            <delta_ts>2016-01-15 15:22:59 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-153133-20160115232837.patch</filename>
            <type>text/plain</type>
            <size>1495</size>
            <attacher name="Olivier Blin">olivier.blin</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNWMwOGNjMGIwNmY5
ZDEzMDdhNGM2ZjkzMmYxMDY3YTdhYWNlMC4uMWY0N2ZhZDg1MmY1NDAxZDVjMzUwODBjMWZjNDMx
M2U5YWY5Mzg4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTAxLTE1ICBPbGl2
aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0dUS10g
Rml4IGJ1aWxkIG9mIFJlbmRlclRoZW1lR3RrIHdpdGhvdXQgVklERU8gYnkgaW5jbHVkaW5nIEhU
TUxJbnB1dEVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTE1MzEzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIEJ1aWxkIHdhcyBmaW5lIHdpdGggVklERU8gZW5hYmxlZCwgc2luY2UgSFRNTElucHV0
RWxlbWVudC5oIHdhcworICAgICAgICBpbmNsdWRlZCBieSB0cmFuc2l0aXZpdHkgdGhyb3VnaCBN
ZWRpYUNvbnRyb2xFbGVtZW50cy5oIGFuZAorICAgICAgICBNZWRpYUNvbnRyb2xFbGVtZW50VHlw
ZXMuaC4KKworICAgICAgICBUaGlzIHNlZW1zIHRvIGJlIGJyb2tlbiBzaW5jZSByMTk0ODQ3Lgor
CisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5jZSB0aGlzIGlzIGp1c3QgYSBidWlsZCBmaXguCisK
KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwOgorCiAyMDE2LTAxLTE1ICBZ
b3Vlbm4gRmFibGV0ICA8eW91ZW5uLmZhYmxldEBjcmYuY2Fub24uZnI+CiAKICAgICAgICAgW1N0
cmVhbXMgQVBJXSBFeHBvc2UgUmVhZGFibGVTdHJlYW0gYW5kIHJlbGF0aXZlcyB0byBXb3JrZXIK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUd0ay5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwCmluZGV4IDhiYjhj
YjUzMjA1NGY5ZGJhYjlkNjllODAzMWIyMTVjOGJjNDJlMzcuLjRiNjIyZWFjMmFiOGI2NDRlMTU5
ZTEyNTgyYjYzZTZlZDI0Y2E2ZmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu
Zy9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl
clRoZW1lR3RrLmNwcApAQCAtMzUsNiArMzUsNyBAQAogI2luY2x1ZGUgIkdyYWRpZW50LmgiCiAj
aW5jbHVkZSAiR3JhcGhpY3NDb250ZXh0LmgiCiAjaW5jbHVkZSAiR3RrVmVyc2lvbmluZy5oIgor
I2luY2x1ZGUgIkhUTUxJbnB1dEVsZW1lbnQuaCIKICNpbmNsdWRlICJIVE1MTWVkaWFFbGVtZW50
LmgiCiAjaW5jbHVkZSAiTG9jYWxpemVkU3RyaW5ncy5oIgogI2luY2x1ZGUgIk1lZGlhQ29udHJv
bEVsZW1lbnRzLmgiCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>