153129 2016-01-15 07:52:56 -0800 Remove the SKIP_UNUSED_PARAM define 2016-01-18 05:27:07 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue oldest_to_newest 1155766 0 ossy 2016-01-15 07:52:56 -0800 http://trac.webkit.org/changeset/192464 (bug150166) introduced SKIP_UNUSED_PARAM define instead of "ENABLE(STREAMS_API) || ENABLE(MEDIA_STREAM)". It is used only in Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.cpp file. I think it is confusing, the parameters are used/unused in cpp, there is no reason to determine this fact in a different place. 1155767 1 269052 ossy 2016-01-15 07:57:56 -0800 Created attachment 269052 Patch 1156384 2 269052 commit-queue 2016-01-18 05:27:05 -0800 Comment on attachment 269052 Patch Clearing flags on attachment: 269052 Committed r195218: <http://trac.webkit.org/changeset/195218> 1156385 3 commit-queue 2016-01-18 05:27:07 -0800 All reviewed patches have been landed. Closing bug. 269052 2016-01-15 07:57:56 -0800 2016-01-18 05:27:05 -0800 Patch bug-153129-20160115165726.patch text/plain 2368 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNWMwOGNjMGIwNmY5 ZDEzMDdhNGM2ZjkzMmYxMDY3YTdhYWNlMC4uNDg2NGU5YzI3MWY5YmNmM2VhODg1ZTJmOTdjZjFh YzNmZjNmNjdlOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAxLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHRoZSBT S0lQX1VOVVNFRF9QQVJBTSBkZWZpbmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1MzEyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogYmluZGluZ3MvanMvV2ViQ29yZUpTQnVpbHRpbkludGVybmFscy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpKU0J1aWx0aW5JbnRlcm5hbEZ1bmN0aW9uczo6dmlzaXQp OgorICAgICAgICAoV2ViQ29yZTo6SlNCdWlsdGluSW50ZXJuYWxGdW5jdGlvbnM6OmluaXRpYWxp emUpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuaDoK KwogMjAxNi0wMS0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZy PgogCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gRXhwb3NlIFJlYWRhYmxlU3RyZWFtIGFuZCByZWxh dGl2ZXMgdG8gV29ya2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9X ZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuY3BwCmluZGV4IDZmY2VhYjAxYjY0ZGNhMTRhNzFl OTllYWMwMzU4MTVhNjE0ZDdhODkuLmI4ZjVjZDhiNzcyOTM5MDg4NzNiNjdiMDBhNjdhZmM4ZWI5 Yzc4OGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0J1 aWx0aW5JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNv cmVKU0J1aWx0aW5JbnRlcm5hbHMuY3BwCkBAIC02MSw3ICs2MSw3IEBAIHZvaWQgSlNCdWlsdGlu SW50ZXJuYWxGdW5jdGlvbnM6OnZpc2l0KEpTQzo6U2xvdFZpc2l0b3ImIHZpc2l0b3IpCiAgICAg bV9zdHJlYW1JbnRlcm5hbHNGdW5jdGlvbnMudmlzaXQodmlzaXRvcik7CiAgICAgbV93cml0YWJs ZVN0cmVhbUludGVybmFsc0Z1bmN0aW9ucy52aXNpdCh2aXNpdG9yKTsKICNlbmRpZgotI2lmbmRl ZiBTS0lQX1VOVVNFRF9QQVJBTQorI2lmICFFTkFCTEUoU1RSRUFNU19BUEkpICYmICFFTkFCTEUo TUVESUFfU1RSRUFNKQogICAgIFVOVVNFRF9QQVJBTSh2aXNpdG9yKTsKICNlbmRpZgogfQpAQCAt MTA5LDcgKzEwOSw3IEBAIHZvaWQgSlNCdWlsdGluSW50ZXJuYWxGdW5jdGlvbnM6OmluaXRpYWxp emUoSlNET01HbG9iYWxPYmplY3QmIGdsb2JhbE9iamVjdCwgVk0mCiAKICAgICBnbG9iYWxPYmpl Y3QuYWRkU3RhdGljR2xvYmFscyhzdGF0aWNHbG9iYWxzLCBXVEZfQVJSQVlfTEVOR1RIKHN0YXRp Y0dsb2JhbHMpKTsKICNlbmRpZgotI2lmbmRlZiBTS0lQX1VOVVNFRF9QQVJBTQorI2lmICFFTkFC TEUoU1RSRUFNU19BUEkpICYmICFFTkFCTEUoTUVESUFfU1RSRUFNKQogICAgIFVOVVNFRF9QQVJB TShnbG9iYWxPYmplY3QpOwogICAgIFVOVVNFRF9QQVJBTSh2bSk7CiAjZW5kaWYKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMu aCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMu aAppbmRleCAzN2I2NmIwYzAyZmExMzUzZTBkZmYxMWY0M2RkOGM5NjVkZGM1ZWM4Li5lMzFmMDUy MWM1OTI4ZWViYjQzNzA4MzU3YjRkNDFmNDU3OTc3MDBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmgKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvV2ViQ29yZUpTQnVpbHRpbkludGVybmFscy5oCkBAIC0zNywx MCArMzcsNiBAQAogI2luY2x1ZGUgIldyaXRhYmxlU3RyZWFtSW50ZXJuYWxzQnVpbHRpbnMuaCIK ICNlbmRpZgogCi0jaWYgRU5BQkxFKFNUUkVBTVNfQVBJKSB8fCBFTkFCTEUoTUVESUFfU1RSRUFN KQotI2RlZmluZSBTS0lQX1VOVVNFRF9QQVJBTQotI2VuZGlmCi0KIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAogY2xhc3MgSlNET01HbG9iYWxPYmplY3Q7Cg==