153128 2016-01-15 07:44:36 -0800 Fix the --minimal build due to missing VM.h include 2016-01-18 05:27:29 -0800 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 1 ossy ossy commit-queue oldest_to_newest 1155764 0 ossy 2016-01-15 07:44:36 -0800 EFL --minimal build is broken now: In file included from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.h:31:0, from ../../Source/WebCore/bindings/js/JSDOMWrapper.h:25, from DerivedSources/WebCore/JSNode.h:24, from DerivedSources/WebCore/JSCharacterData.h:25, from ../../Source/WebCore/bindings/js/JSCharacterDataCustom.cpp:27: ../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:51:48: error: expected ')' before '&' token In file included from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.h:31:0, from ../../Source/WebCore/bindings/js/JSDOMWrapper.h:25, from DerivedSources/WebCore/JSNode.h:24, from DerivedSources/WebCore/JSCharacterData.h:25, from ../../Source/WebCore/bindings/js/JSCharacterDataCustom.cpp:27: ../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:63:46: error: 'JSC::VM' has not been declared ../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:66:10: error: 'VM' in namespace 'JSC' does not name a type In file included from ../../Source/WebCore/bindings/js/JSDOMWrapper.h:25:0, from DerivedSources/WebCore/JSNode.h:24, from DerivedSources/WebCore/JSCharacterData.h:25, from ../../Source/WebCore/bindings/js/JSCharacterDataCustom.cpp:27: ../../Source/WebCore/bindings/js/JSDOMGlobalObject.h:92:21: error: prototype for 'void WebCore::JSBuiltinInternalFunctions::initialize(WebCore::JSDOMGlobalObject&, JSC::VM&)' does not match any in class 'WebCore::JSBuiltinInternalFunctions' In file included from ../../Source/WebCore/bindings/js/JSDOMGlobalObject.h:31:0, from ../../Source/WebCore/bindings/js/JSDOMWrapper.h:25, from DerivedSources/WebCore/JSNode.h:24, from DerivedSources/WebCore/JSCharacterData.h:25, from ../../Source/WebCore/bindings/js/JSCharacterDataCustom.cpp:27: ../../Source/WebCore/bindings/js/WebCoreJSBuiltinInternals.h:63:10: error: candidate is: void WebCore::JSBuiltinInternalFunctions::initialize(WebCore::JSDOMGlobalObject&, int&) 1155765 1 269051 ossy 2016-01-15 07:46:09 -0800 Created attachment 269051 Patch 1155770 2 269054 ossy 2016-01-15 08:20:35 -0800 Created attachment 269054 Patch 1155951 3 269054 mcatanzaro 2016-01-15 14:48:03 -0800 Comment on attachment 269054 Patch Feel empowered to commit build fixes without review. 1156386 4 269054 commit-queue 2016-01-18 05:27:27 -0800 Comment on attachment 269054 Patch Clearing flags on attachment: 269054 Committed r195219: <http://trac.webkit.org/changeset/195219> 1156387 5 commit-queue 2016-01-18 05:27:29 -0800 All reviewed patches have been landed. Closing bug. 269051 2016-01-15 07:46:09 -0800 2016-01-15 08:20:30 -0800 Patch bug-153128-20160115164539.patch text/plain 1200 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNWMwOGNjMGIwNmY5 ZDEzMDdhNGM2ZjkzMmYxMDY3YTdhYWNlMC4uYTMyODY1NjI2ZDRkNTE0ZGVlMGY4ZTg1NjJlZGVk N2FhYmM1YjBjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTAxLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAtLW1p bmltYWwgYnVpbGQgZHVlIHRvIG1pc3NpbmcgVk0uaCBpbmNsdWRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMxMjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1dlYkNvcmVKU0J1 aWx0aW5JbnRlcm5hbHMuaDoKKwogMjAxNi0wMS0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5m YWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gRXhwb3NlIFJlYWRh YmxlU3RyZWFtIGFuZCByZWxhdGl2ZXMgdG8gV29ya2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmgKaW5kZXggMzdiNjZi MGMwMmZhMTM1M2UwZGZmMTFmNDNkZDhjOTY1ZGRjNWVjOC4uYTYwZjhiYWRkMWU4YTVkZjlkZDg2 NzlkNTQyNmIwMDlhNDI2Y2VhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvV2ViQ29yZUpTQnVpbHRpbkludGVybmFscy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuaApAQCAtMjcsNiArMjcsOCBAQAogI2lm bmRlZiBXZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzX2gKICNkZWZpbmUgV2ViQ29yZUpTQnVpbHRp bkludGVybmFsc19oCiAKKyNpbmNsdWRlICJWTS5oIgorCiAjaWYgRU5BQkxFKE1FRElBX1NUUkVB TSkKICNpbmNsdWRlICJSVENQZWVyQ29ubmVjdGlvbkludGVybmFsc0J1aWx0aW5zLmgiCiAjZW5k aWYK 269054 2016-01-15 08:20:35 -0800 2016-01-18 05:27:27 -0800 Patch bug-153128-20160115172005.patch text/plain 1208 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyNWMwOGNjMGIwNmY5 ZDEzMDdhNGM2ZjkzMmYxMDY3YTdhYWNlMC4uYTMyODY1NjI2ZDRkNTE0ZGVlMGY4ZTg1NjJlZGVk N2FhYmM1YjBjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTAxLTE1ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAtLW1p bmltYWwgYnVpbGQgZHVlIHRvIG1pc3NpbmcgVk0uaCBpbmNsdWRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMxMjgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1dlYkNvcmVKU0J1 aWx0aW5JbnRlcm5hbHMuaDoKKwogMjAxNi0wMS0xNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5m YWJsZXRAY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFtTdHJlYW1zIEFQSV0gRXhwb3NlIFJlYWRh YmxlU3RyZWFtIGFuZCByZWxhdGl2ZXMgdG8gV29ya2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmggYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9XZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzLmgKaW5kZXggMzdiNjZi MGMwMmZhMTM1M2UwZGZmMTFmNDNkZDhjOTY1ZGRjNWVjOC4uODA3OWNmOTYxYTQyZjIxNGRkOWZh OTRkY2NkOGNjNjA0MTQzMWM2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvV2ViQ29yZUpTQnVpbHRpbkludGVybmFscy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL2pzL1dlYkNvcmVKU0J1aWx0aW5JbnRlcm5hbHMuaApAQCAtMjcsNiArMjcsOCBAQAogI2lm bmRlZiBXZWJDb3JlSlNCdWlsdGluSW50ZXJuYWxzX2gKICNkZWZpbmUgV2ViQ29yZUpTQnVpbHRp bkludGVybmFsc19oCiAKKyNpbmNsdWRlIDxydW50aW1lL1ZNLmg+CisKICNpZiBFTkFCTEUoTUVE SUFfU1RSRUFNKQogI2luY2x1ZGUgIlJUQ1BlZXJDb25uZWN0aW9uSW50ZXJuYWxzQnVpbHRpbnMu aCIKICNlbmRpZgo=