153122 2016-01-15 04:28:54 -0800 [GTK] List box selections stopped working again with GTK+ from current git master 2016-01-16 01:44:38 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1155735 0 cgarcia 2016-01-15 04:28:54 -0800 The problem is that the ListBox selection implementation is wrong. We are using a similar implementation to GtkEntry, but GtkTreeView doesn't have a child CSS node for selections. 1155736 1 269044 cgarcia 2016-01-15 04:31:55 -0800 Created attachment 269044 Patch 1156150 2 cgarcia 2016-01-16 01:44:38 -0800 Committed r195167: <http://trac.webkit.org/changeset/195167> 269044 2016-01-15 04:31:55 -0800 2016-01-15 06:58:59 -0800 Patch wcore-list-box-selections.diff text/plain 2675 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3ZmFkZTMzLi4yZTM3YjRhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTAxLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBMaXN0IGJveCBzZWxlY3Rpb25zIHN0b3BwZWQgd29ya2luZyBh Z2FpbiB3aXRoIEdUSysgZnJvbSBjdXJyZW50IGdpdCBtYXN0ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1MzEyMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgdGhlIExp c3RCb3ggc2VsZWN0aW9uIGltcGxlbWVudGF0aW9uIGlzCisgICAgICAgIHdyb25nLiBXZSBhcmUg dXNpbmcgYSBzaW1pbGFyIGltcGxlbWVudGF0aW9uIHRvIEd0a0VudHJ5LCBidXQKKyAgICAgICAg R3RrVHJlZVZpZXcgZG9lc24ndCBoYXZlIGEgY2hpbGQgQ1NTIG5vZGUgZm9yIHNlbGVjdGlvbnMu CisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGhlbWVHdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c3R5bGVDb2xvcik6IERvbid0IHVzZSBhIGNoaWxkIHN0eWxlIGNvbnRleHQgZm9yIExp c3RCb3ggc2VsZWN0aW9ucy4KKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZVN0eWxlQ29udGV4dCk6 IFJlbW92ZSBMaXN0Qm94U2VsZWN0aW9uLgorCiAyMDE2LTAxLTExICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBDbGVhbnVwIFJlbmRl clRoZW1lR3RrCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhl bWVHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lR3RrLmNwcApp bmRleCBhYzcxOWFlLi5kM2RlMTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyVGhlbWVHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUaGVtZUd0ay5jcHAKQEAgLTE1Nyw3ICsxNTcsNiBAQCBlbnVtIFJlbmRlclRoZW1lUGFydCB7 CiAgICAgUHJvZ3Jlc3NCYXJUcm91Z2gsCiAgICAgUHJvZ3Jlc3NCYXJQcm9ncmVzcywKICAgICBM aXN0Qm94LAotICAgIExpc3RCb3hTZWxlY3Rpb24sCiAgICAgU3BpbkJ1dHRvbiwKICAgICBTcGlu QnV0dG9uVXBCdXR0b24sCiAgICAgU3BpbkJ1dHRvbkRvd25CdXR0b24sCkBAIC0zMzMsMTQgKzMz Miw2IEBAIHN0YXRpYyBHUmVmUHRyPEd0a1N0eWxlQ29udGV4dD4gY3JlYXRlU3R5bGVDb250ZXh0 KFJlbmRlclRoZW1lUGFydCB0aGVtZVBhcnQsIEd0CiAjZW5kaWYKICAgICAgICAgZ3RrX3dpZGdl dF9wYXRoX2l0ZXJfYWRkX2NsYXNzKHBhdGguZ2V0KCksIC0xLCBHVEtfU1RZTEVfQ0xBU1NfVklF Vyk7CiAgICAgICAgIGJyZWFrOwotICAgIGNhc2UgTGlzdEJveFNlbGVjdGlvbjoKLSAgICAgICAg Z3RrX3dpZGdldF9wYXRoX2FwcGVuZF90eXBlKHBhdGguZ2V0KCksIEdUS19UWVBFX1RSRUVfVklF Vyk7Ci0jaWYgR1RLX0NIRUNLX1ZFUlNJT04oMywgMTksIDIpCi0gICAgICAgIGd0a193aWRnZXRf cGF0aF9pdGVyX3NldF9vYmplY3RfbmFtZShwYXRoLmdldCgpLCAtMSwgInNlbGVjdGlvbiIpOwot I2Vsc2UKLSAgICAgICAgZ3RrX3dpZGdldF9wYXRoX2l0ZXJfYWRkX2NsYXNzKHBhdGguZ2V0KCks IC0xLCBHVEtfU1RZTEVfQ0xBU1NfVklFVyk7Ci0jZW5kaWYKLSAgICAgICAgYnJlYWs7CiAgICAg Y2FzZSBTcGluQnV0dG9uOgogICAgICAgICBndGtfd2lkZ2V0X3BhdGhfYXBwZW5kX3R5cGUocGF0 aC5nZXQoKSwgR1RLX1RZUEVfU1BJTl9CVVRUT04pOwogI2lmIEdUS19DSEVDS19WRVJTSU9OKDMs IDE5LCAyKQpAQCAtMTI4OCwxMCArMTI3OSw5IEBAIHN0YXRpYyBDb2xvciBzdHlsZUNvbG9yKFJl bmRlclRoZW1lUGFydCB0aGVtZVBhcnQsIEd0a1N0YXRlRmxhZ3Mgc3RhdGUsIFN0eWxlQ29sCiB7 CiAgICAgR1JlZlB0cjxHdGtTdHlsZUNvbnRleHQ+IHBhcmVudENvbnRleHQ7CiAgICAgUmVuZGVy VGhlbWVQYXJ0IHBhcnQgPSB0aGVtZVBhcnQ7Ci0gICAgaWYgKHN0YXRlICYgR1RLX1NUQVRFX0ZM QUdfU0VMRUNURUQpIHsKLSAgICAgICAgcGFyZW50Q29udGV4dCA9IGNyZWF0ZVN0eWxlQ29udGV4 dCh0aGVtZVBhcnQpOwotICAgICAgICBBU1NFUlQodGhlbWVQYXJ0ID09IEVudHJ5IHx8IHRoZW1l UGFydCA9PSBMaXN0Qm94KTsKLSAgICAgICAgcGFydCA9IHRoZW1lUGFydCA9PSBFbnRyeSA/IEVu dHJ5U2VsZWN0aW9uIDogTGlzdEJveFNlbGVjdGlvbjsKKyAgICBpZiAodGhlbWVQYXJ0ID09IEVu dHJ5ICYmIChzdGF0ZSAmIEdUS19TVEFURV9GTEFHX1NFTEVDVEVEKSkgeworICAgICAgICBwYXJl bnRDb250ZXh0ID0gY3JlYXRlU3R5bGVDb250ZXh0KEVudHJ5KTsKKyAgICAgICAgcGFydCA9IEVu dHJ5U2VsZWN0aW9uOwogICAgIH0KIAogICAgIEdSZWZQdHI8R3RrU3R5bGVDb250ZXh0PiBjb250 ZXh0ID0gY3JlYXRlU3R5bGVDb250ZXh0KHBhcnQsIHBhcmVudENvbnRleHQuZ2V0KCkpOwo=