153106 2016-01-14 13:50:51 -0800 [webkitdirs] Replaced grep invocation with perl code 2016-01-15 19:57:43 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned achristensen commit-queue dbates lforschler ossy oldest_to_newest 1155566 0 annulen 2016-01-14 13:50:51 -0800 As proposed in https://bugs.webkit.org/show_bug.cgi?id=152959#c9 Also, removed outdated comment. 1155567 1 269000 annulen 2016-01-14 13:51:59 -0800 Created attachment 269000 Patch 1155637 2 269000 commit-queue 2016-01-14 16:50:29 -0800 Comment on attachment 269000 Patch Clearing flags on attachment: 269000 Committed r195083: <http://trac.webkit.org/changeset/195083> 1155638 3 commit-queue 2016-01-14 16:50:32 -0800 All reviewed patches have been landed. Closing bug. 1155744 4 ossy 2016-01-15 06:06:28 -0800 (In reply to comment #2) > Comment on attachment 269000 [details] > Patch > > Clearing flags on attachment: 269000 > > Committed r195083: <http://trac.webkit.org/changeset/195083> It broke the WinCairo build: List form of pipe open not implemented at C:/Users/Alex/Documents/WinCairoBot/win-cairo-release/build/Tools/Scripts/webkitdirs.pm line 342. Compilation failed in require at ./Tools/Scripts/build-webkit line 44. BEGIN failed--compilation aborted at ./Tools/Scripts/build-webkit line 44. 1155750 5 annulen 2016-01-15 06:23:55 -0800 I guess different Perl versions are used in WinCairo and Win builders. However, this is very easy to fix, I just wasn't aware that list form of open has portability issues 1155760 6 annulen 2016-01-15 07:30:53 -0800 Reopening to attach new patch. 1155761 7 269050 annulen 2016-01-15 07:30:57 -0800 Created attachment 269050 Patch 1156091 8 269050 commit-queue 2016-01-15 19:57:40 -0800 Comment on attachment 269050 Patch Clearing flags on attachment: 269050 Committed r195163: <http://trac.webkit.org/changeset/195163> 1156092 9 commit-queue 2016-01-15 19:57:43 -0800 All reviewed patches have been landed. Closing bug. 269000 2016-01-14 13:51:59 -0800 2016-01-14 16:50:29 -0800 Patch bug-153106-20160115005129.patch text/plain 1807 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MDcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzExNjFhODllNTRkZDM5OTg1ZDBhMDBmNGVlMjE3OGVl MmJkOTA1ZS4uYjAwYmM2NGNhOWUwNzUzZDQ2YzFmNWYwZmMxYzllNjBhY2Y3MDBiOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAxLTE0ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICBbd2Via2l0ZGlyc10gUmVwbGFjZWQgZ3JlcCBpbnZvY2F0aW9uIHdpdGggcGVy bCBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTMxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAgICAgICAgKGRldGVybWluZUFyY2hpdGVjdHVyZSk6 CisKIDIwMTYtMDEtMTQgIEphc29uIE1hcmNlbGwgIDxqbWFyY2VsbEBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIGEgdW5pdCB0ZXN0IHRvIHRlc3QgQnVpbGRib3RRdWV1ZVZpZXcuX2FwcGVuZFBl bmRpbmdSZXZpc2lvbkNvdW50LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDBlMGQ0Njc2YzAzZGJjYmE2 YmJjMWMxNDk2NWFmOWNmNGNiM2NjYTUuLjc0MjJmNTg4MmI4NmE4ZDk1MTcwNDhmMjI2MDY1MzI0 YmI4ODFiOGMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTMzOSwxMSArMzM5LDE2IEBAIHN1YiBkZXRl cm1pbmVBcmNoaXRlY3R1cmUKICAgICAgICAgfQogICAgIH0gZWxzaWYgKGlzQ01ha2VCdWlsZCgp KSB7CiAgICAgICAgIG15ICRob3N0X3Byb2Nlc3NvciA9ICIiOwotICAgICAgICAkaG9zdF9wcm9j ZXNzb3IgPSBgY21ha2UgLS1zeXN0ZW0taW5mb3JtYXRpb24gfCBncmVwIENNQUtFX1NZU1RFTV9Q Uk9DRVNTT1JgOwotICAgICAgICBpZiAoJGhvc3RfcHJvY2Vzc29yID1+IG0vXkNNQUtFX1NZU1RF TV9QUk9DRVNTT1IgXCIoW14iXSspXCIvKSB7Ci0gICAgICAgICAgICAjIFdlIGhhdmUgYSBjb25m aWd1cmVkIGJ1aWxkIHRyZWU7IHVzZSBpdC4KLSAgICAgICAgICAgICRhcmNoaXRlY3R1cmUgPSAk MTsKLSAgICAgICAgICAgICRhcmNoaXRlY3R1cmUgPSAneDg2XzY0JyBpZiAkYXJjaGl0ZWN0dXJl IGVxICdhbWQ2NCc7CisgICAgICAgIGlmIChvcGVuIG15ICRjbWFrZV9zeXNpbmZvLCAiLXwiLCAi Y21ha2UiLCAiLS1zeXN0ZW0taW5mb3JtYXRpb24iKSB7CisgICAgICAgICAgICB3aGlsZSAoPCRj bWFrZV9zeXNpbmZvPikgeworICAgICAgICAgICAgICAgIG5leHQgdW5sZXNzIGluZGV4KCRfLCAn Q01BS0VfU1lTVEVNX1BST0NFU1NPUicpID09IDA7CisgICAgICAgICAgICAgICAgaWYgKC9eQ01B S0VfU1lTVEVNX1BST0NFU1NPUiBcIihbXiJdKylcIi8pIHsKKyAgICAgICAgICAgICAgICAgICAg JGFyY2hpdGVjdHVyZSA9ICQxOworICAgICAgICAgICAgICAgICAgICAkYXJjaGl0ZWN0dXJlID0g J3g4Nl82NCcgaWYgJGFyY2hpdGVjdHVyZSBlcSAnYW1kNjQnOworICAgICAgICAgICAgICAgICAg ICBsYXN0OworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGNs b3NlICRjbWFrZV9zeXNpbmZvOwogICAgICAgICB9CiAgICAgfQogCg== 269050 2016-01-15 07:30:57 -0800 2016-01-15 19:57:40 -0800 Patch bug-153106-20160115183026.patch text/plain 1323 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk1MTMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmRhNzg5Zjc4ZmU5Y2EzYTRmNDNlM2VmMWQ2N2U2ZDNk OGE4ZDI0MS4uNTI5YzBlOTBiNzdjMDZkYTRhOTNmZDhmZmQ2OTdhM2I4NzdkNjE4YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTAxLTE1ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5ydT4K KworICAgICAgICBbd2Via2l0ZGlyc10gQXZvaWQgbGlzdCBmb3JtIG9mIG9wZW4gYmVjYXVzZSBp dCBicm9rZSBXaW5DYWlybworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTUzMTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVBcmNo aXRlY3R1cmUpOgorCiAyMDE2LTAxLTE0ICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlh bmRleC5ydT4KIAogICAgICAgICBbd2Via2l0ZGlyc10gUmVwbGFjZWQgZ3JlcCBpbnZvY2F0aW9u IHdpdGggcGVybCBjb2RlCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0g Yi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggNzQyMmY1ODgyYjg2YThkOTUxNzA0 OGYyMjYwNjUzMjRiYjg4MWI4Yy4uZDBkYzIxNDA3YTkwOWE3YmVhNjIyNzhiZmRmYjQ2MDA0ZTNj MThlYyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMzM5LDcgKzMzOSw3IEBAIHN1YiBkZXRlcm1pbmVB cmNoaXRlY3R1cmUKICAgICAgICAgfQogICAgIH0gZWxzaWYgKGlzQ01ha2VCdWlsZCgpKSB7CiAg ICAgICAgIG15ICRob3N0X3Byb2Nlc3NvciA9ICIiOwotICAgICAgICBpZiAob3BlbiBteSAkY21h a2Vfc3lzaW5mbywgIi18IiwgImNtYWtlIiwgIi0tc3lzdGVtLWluZm9ybWF0aW9uIikgeworICAg ICAgICBpZiAob3BlbiBteSAkY21ha2Vfc3lzaW5mbywgImNtYWtlIC0tc3lzdGVtLWluZm9ybWF0 aW9uIHwiKSB7CiAgICAgICAgICAgICB3aGlsZSAoPCRjbWFrZV9zeXNpbmZvPikgewogICAgICAg ICAgICAgICAgIG5leHQgdW5sZXNzIGluZGV4KCRfLCAnQ01BS0VfU1lTVEVNX1BST0NFU1NPUicp ID09IDA7CiAgICAgICAgICAgICAgICAgaWYgKC9eQ01BS0VfU1lTVEVNX1BST0NFU1NPUiBcIihb XiJdKylcIi8pIHsK