153076 2016-01-13 13:04:31 -0800 [GTK] Consistently use virtual and override specifiers in ScrollbarThemeGtk 2016-01-13 14:29:18 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1155191 0 mcatanzaro 2016-01-13 13:04:31 -0800 Carlos made ScrollbarThemeGtk a final class, which I guess serves as an opt-in for new Clang warnings: [4498/5928] Building CXX object Source...r/platform/gtk/ScrollbarThemeGtk.cpp.o In file included from ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:27: ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void themeChanged(); ^ ../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here virtual void themeChanged() {} ^ 1 warning generated. [4500/5928] Building CXX object Source...GTK.dir/rendering/RenderThemeGtk.cpp.o In file included from ../../Source/WebCore/rendering/RenderThemeGtk.cpp:48: ../../Source/WebCore/platform/gtk/ScrollbarThemeGtk.h:63:10: warning: 'themeChanged' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void themeChanged(); ^ ../../Source/WebCore/platform/ScrollbarTheme.h:63:18: note: overridden virtual function is here virtual void themeChanged() {} ^ 1 warning generated. While we're at it... most of these functions have redundant virtual specifiers and override, while the rest have only override. I prefer to omit virtual when unneeded, and we don't currently have consistency within WebKit, but most of the other functions here use it, so let's do that. 1155193 1 mcatanzaro 2016-01-13 13:07:30 -0800 (In reply to comment #0) > Carlos made ScrollbarThemeGtk a final class, which I guess serves as an > opt-in for new Clang warnings: Nah, the problem is that none of the functions were previously marked override. 1155194 2 268896 mcatanzaro 2016-01-13 13:08:04 -0800 Created attachment 268896 Patch 1155240 3 268896 commit-queue 2016-01-13 14:29:15 -0800 Comment on attachment 268896 Patch Clearing flags on attachment: 268896 Committed r194984: <http://trac.webkit.org/changeset/194984> 1155241 4 commit-queue 2016-01-13 14:29:18 -0800 All reviewed patches have been landed. Closing bug. 268896 2016-01-13 13:08:04 -0800 2016-01-13 14:29:15 -0800 Patch bug-153076-20160113150734.patch text/plain 2480 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjczYjZiMzU5ZjZkYmY0 OWVkMzNiNzMwZjFkN2UwOWU0MjUwOGU5MS4uZGQ5Y2JhM2ZmNzlhYmJjMGI1YWVmOTk4ODU3YTMy ZDFjNTcxYTE0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTAxLTEzICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBD b25zaXN0ZW50bHkgdXNlIHZpcnR1YWwgYW5kIG92ZXJyaWRlIHNwZWNpZmllcnMgaW4gU2Nyb2xs YmFyVGhlbWVHdGsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1MzA3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9TY3JvbGxi YXJUaGVtZUd0ay5oOgorCiAyMDE2LTAxLTEzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxl LmNvbT4KIAogICAgICAgICBVc2UgQnVtcEFyZW5hIGZvciBzdHlsZSBzaGVldCBvYmplY3QgdHJl ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9TY3JvbGxiYXJUaGVt ZUd0ay5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmgK aW5kZXggZmMwNTdhNmRiMzQyY2MzYjcxZWVjYTljN2EyODgzMmVlMmJhODI3ZS4uMWJjNWMwNDMy YTgzOGFlNDBjYzhhMzRjMjkyMjhkYzEyNDI0MWU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmgKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1Njcm9sbGJhclRoZW1lR3RrLmgKQEAgLTQ4LDEwICs0OCwxMCBAQCBwdWJs aWM6CiAKICAgICB1c2luZyBTY3JvbGxiYXJUaGVtZUNvbXBvc2l0ZTo6dGh1bWJSZWN0OwogICAg IEludFJlY3QgdGh1bWJSZWN0KFNjcm9sbGJhciYsIGNvbnN0IEludFJlY3QmIHVuY29uc3RyYWlu ZWRUcmFja1JlY3QpOwotICAgIGJvb2wgcGFpbnQoU2Nyb2xsYmFyJiwgR3JhcGhpY3NDb250ZXh0 JiwgY29uc3QgSW50UmVjdCYgZGFtYWdlUmVjdCkgb3ZlcnJpZGU7Ci0gICAgdm9pZCBwYWludFNj cm9sbGJhckJhY2tncm91bmQoR3JhcGhpY3NDb250ZXh0JiwgU2Nyb2xsYmFyJikgb3ZlcnJpZGU7 Ci0gICAgdm9pZCBwYWludFRyYWNrQmFja2dyb3VuZChHcmFwaGljc0NvbnRleHQmLCBTY3JvbGxi YXImLCBjb25zdCBJbnRSZWN0Jikgb3ZlcnJpZGU7Ci0gICAgdm9pZCBwYWludFRodW1iKEdyYXBo aWNzQ29udGV4dCYsIFNjcm9sbGJhciYsIGNvbnN0IEludFJlY3QmKSBvdmVycmlkZTsKKyAgICB2 aXJ0dWFsIGJvb2wgcGFpbnQoU2Nyb2xsYmFyJiwgR3JhcGhpY3NDb250ZXh0JiwgY29uc3QgSW50 UmVjdCYgZGFtYWdlUmVjdCkgb3ZlcnJpZGU7CisgICAgdmlydHVhbCB2b2lkIHBhaW50U2Nyb2xs YmFyQmFja2dyb3VuZChHcmFwaGljc0NvbnRleHQmLCBTY3JvbGxiYXImKSBvdmVycmlkZTsKKyAg ICB2aXJ0dWFsIHZvaWQgcGFpbnRUcmFja0JhY2tncm91bmQoR3JhcGhpY3NDb250ZXh0JiwgU2Ny b2xsYmFyJiwgY29uc3QgSW50UmVjdCYpIG92ZXJyaWRlOworICAgIHZpcnR1YWwgdm9pZCBwYWlu dFRodW1iKEdyYXBoaWNzQ29udGV4dCYsIFNjcm9sbGJhciYsIGNvbnN0IEludFJlY3QmKSBvdmVy cmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRCdXR0b24oR3JhcGhpY3NDb250ZXh0JiwgU2Ny b2xsYmFyJiwgY29uc3QgSW50UmVjdCYsIFNjcm9sbGJhclBhcnQpIG92ZXJyaWRlOwogICAgIHZp cnR1YWwgYm9vbCBzaG91bGRDZW50ZXJPblRodW1iKFNjcm9sbGJhciYsIGNvbnN0IFBsYXRmb3Jt TW91c2VFdmVudCYpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgaW50IHNjcm9sbGJhclRoaWNrbmVz cyhTY3JvbGxiYXJDb250cm9sU2l6ZSkgb3ZlcnJpZGU7CkBAIC02MCw3ICs2MCw3IEBAIHB1Ymxp YzoKICAgICAvLyBUT0RPOiBUaGVzZSBhcmUgdGhlIGRlZmF1bHQgR1RLKyB2YWx1ZXMuIEF0IHNv bWUgcG9pbnQgd2Ugc2hvdWxkIHB1bGwgdGhlc2UgZnJvbSB0aGUgdGhlbWUgaXRzZWxmLgogICAg IHZpcnR1YWwgZG91YmxlIGluaXRpYWxBdXRvc2Nyb2xsVGltZXJEZWxheSgpIG92ZXJyaWRlIHsg cmV0dXJuIDAuMjA7IH0KICAgICB2aXJ0dWFsIGRvdWJsZSBhdXRvc2Nyb2xsVGltZXJEZWxheSgp IG92ZXJyaWRlIHsgcmV0dXJuIDAuMDI7IH0KLSAgICB2b2lkIHRoZW1lQ2hhbmdlZCgpOworICAg IHZpcnR1YWwgdm9pZCB0aGVtZUNoYW5nZWQoKSBvdmVycmlkZTsKIAogcHJpdmF0ZToKICAgICB2 b2lkIHVwZGF0ZVRoZW1lUHJvcGVydGllcygpOwo=