153074 2016-01-13 12:45:27 -0800 [GTK] Add comments above options declarations in OptionsGTK.cmake 2016-01-13 15:06:37 -0800 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro achristensen bugs-noreply commit-queue gyuyoung.kim mcatanzaro mrobinson oldest_to_newest 1155178 0 mcatanzaro 2016-01-13 12:45:27 -0800 This is to make the scheme more robust to wandering WebKit developers. 1155179 1 268894 mcatanzaro 2016-01-13 12:46:40 -0800 Created attachment 268894 Patch 1155181 2 mcatanzaro 2016-01-13 12:48:09 -0800 (This patch is only for GTK, but I think the EFL, Mac, and Windows ports should consider adopting this approach to managing build options as well.) 1155259 3 268894 commit-queue 2016-01-13 15:06:34 -0800 Comment on attachment 268894 Patch Clearing flags on attachment: 268894 Committed r194988: <http://trac.webkit.org/changeset/194988> 1155260 4 commit-queue 2016-01-13 15:06:37 -0800 All reviewed patches have been landed. Closing bug. 268894 2016-01-13 12:46:40 -0800 2016-01-13 15:06:34 -0800 Patch bug-153074-20160113144610.patch text/plain 3392 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGM2NzJj ZGI0ZjE0NTgyNzNmNTRmNGEwNGFmNzI3YWNjZDk5YmM5ZDcuLmViYjUyNWFjMDNhMzM1YTc2Y2Ew ZjIxZTNiNDBhNTYyZjRlNzVhOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC03Miw2ICs3Miw5 IEBAIGVsc2UgKCkKICAgICBzZXQoRU5BQkxFX0ZUTF9ERUZBVUxUIE9GRikKIGVuZGlmICgpCiAK KyMgUHVibGljIG9wdGlvbnMgc3BlY2lmaWMgdG8gdGhlIEdUSysgcG9ydC4gRG8gbm90IGFkZCBh bnkgb3B0aW9ucyBoZXJlIHVubGVzcworIyB0aGVyZSBpcyBhIHN0cm9uZyByZWFzb24gd2Ugc2hv dWxkIHN1cHBvcnQgY2hhbmdpbmcgdGhlIHZhbHVlIG9mIHRoZSBvcHRpb24sCisjIGFuZCB0aGUg b3B0aW9uIGlzIG5vdCByZWxldmFudCB0byBhbnkgb3RoZXIgV2ViS2l0IHBvcnRzLgogV0VCS0lU X09QVElPTl9ERUZJTkUoRU5BQkxFX0dMRVMyICJXaGV0aGVyIHRvIGVuYWJsZSBPcGVuR0wgRVMg Mi4wLiIgUFVCTElDICR7RU5BQkxFX0dMRVMyX0RFRkFVTFR9KQogV0VCS0lUX09QVElPTl9ERUZJ TkUoRU5BQkxFX0dUS0RPQyAiV2hldGhlciBvciBub3QgdG8gdXNlIGdlbmVyYXRlIGd0a2RvYy4i IFBVQkxJQyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfSU5UUk9TUEVDVElPTiAi V2hldGhlciB0byBlbmFibGUgR09iamVjdCBpbnRyb3NwZWN0aW9uLiIgUFVCTElDIE9OKQpAQCAt ODMsNiArODYsOCBAQCBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfV0FZTEFORF9UQVJHRVQg IldoZXRoZXIgdG8gZW5hYmxlIHN1cHBvcnQgZm9yIHRoZSBXYQogV0VCS0lUX09QVElPTl9ERUZJ TkUoVVNFX0xJQk5PVElGWSAiV2hldGhlciB0byBlbmFibGUgdGhlIGRlZmF1bHQgd2ViIG5vdGlm aWNhdGlvbiBpbXBsZW1lbnRhdGlvbi4iIFBVQkxJQyBPTikKIFdFQktJVF9PUFRJT05fREVGSU5F KFVTRV9MSUJIWVBIRU4gIldoZXRoZXIgdG8gZW5hYmxlIHRoZSBkZWZhdWx0IGF1dG9tYXRpYyBo eXBoZW5hdGlvbiBpbXBsZW1lbnRhdGlvbi4iIFBVQkxJQyBPTikKIAorIyBQcml2YXRlIG9wdGlv bnMgc3BlY2lmaWMgdG8gdGhlIEdUSysgcG9ydC4gQ2hhbmdpbmcgdGhlc2Ugb3B0aW9ucyBpcwor IyBjb21wbGV0ZWx5IHVuc3VwcG9ydGVkLiBUaGV5IGFyZSBpbnRlbmRlZCBmb3IgdXNlIG9ubHkg YnkgV2ViS2l0IGRldmVsb3BlcnMuCiBXRUJLSVRfT1BUSU9OX0RFRklORShVU0VfR1NUUkVBTUVS X0dMICJXaGV0aGVyIHRvIGVuYWJsZSBzdXBwb3J0IGZvciBHU3RyZWFtZXIgR0wiIFBSSVZBVEUg T0ZGKQogV0VCS0lUX09QVElPTl9ERUZJTkUoVVNFX0dTVFJFQU1FUl9NUEVHVFMgIldoZXRoZXIg dG8gZW5hYmxlIHN1cHBvcnQgZm9yIE1QRUctVFMiIFBSSVZBVEUgT0ZGKQogV0VCS0lUX09QVElP Tl9ERUZJTkUoVVNFX1JFRElSRUNURURfWENPTVBPU0lURV9XSU5ET1cgIldoZXRoZXIgdG8gdXNl IGEgUmVkaXJlY3RlZCBYQ29tcG9zaXRlIFdpbmRvdyBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRp bmcgaW4gWDExLiIgUFJJVkFURSBPTikKQEAgLTEyMiw2ICsxMjcsOSBAQCBlbHNlICgpCiAgICAg V0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01FTU9SWV9TQU1QTEVSIFBV QkxJQyBPRkYpCiBlbmRpZiAoKQogCisjIFB1YmxpYyBvcHRpb25zIHNoYXJlZCB3aXRoIG90aGVy IFdlYktpdCBwb3J0cy4gRG8gbm90IGFkZCBhbnkgb3B0aW9ucyBoZXJlCisjIHdpdGhvdXQgYXBw cm92YWwgZnJvbSBhIEdUSysgcmV2aWV3ZXIuIFRoZXJlIG11c3QgYmUgc3Ryb25nIHJlYXNvbiB0 byBzdXBwb3J0CisjIGNoYW5naW5nIHRoZSB2YWx1ZSBvZiB0aGUgb3B0aW9uLgogV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0FDQ0VMRVJBVEVEXzJEX0NBTlZBUyBQVUJM SUMgT0ZGKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0NSRURFTlRJ QUxfU1RPUkFHRSBQVUJMSUMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShF TkFCTEVfRFJBR19TVVBQT1JUIFBVQkxJQyBPTikKQEAgLTEzNSw2ICsxNDMsOSBAQCBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVklERU8gUFVCTElDIE9OKQogV0VCS0lU X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQl9BVURJTyBQVUJMSUMgT04pCiBX RUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShVU0VfU1lTVEVNX01BTExPQyBQVUJMSUMg T0ZGKQogCisjIFByaXZhdGUgb3B0aW9ucyBzaGFyZWQgd2l0aCBvdGhlciBXZWJLaXQgcG9ydHMu IEFkZCBvcHRpb25zIGhlcmUgd2hlbgorIyB3ZSBuZWVkIGEgdmFsdWUgZGlmZmVyZW50IGZyb20g dGhlIGRlZmF1bHQgZGVmaW5lZCBpbiBXZWJLaXRGZWF0dXJlcy5jbWFrZS4KKyMgQ2hhbmdpbmcg dGhlc2Ugb3B0aW9ucyBpcyBjb21wbGV0ZWx5IHVuc3VwcG9ydGVkLgogV0VCS0lUX09QVElPTl9E RUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFXzNEX1RSQU5TRk9STVMgUFJJVkFURSBPTikKIFdFQktJ VF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9BQ0NFU1NJQklMSVRZIFBSSVZBVEUg T04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQ0FOVkFTX1BBVEgg UFJJVkFURSBPRkYpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggM2M4 MDcxMTgzMTg5YzQ1NjBjNzEwZWFjNTM2NWNmNWYxYTNjYjhmOC4uMDNkZWE1NzE3OGIxNTg1Nzlm Mjg2ZDAzNThmZjc1M2JjZDMxNGM4NyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTAxLTEzICBNaWNoYWVsIENhdGFuemFybyAgPG1j YXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBBZGQgY29tbWVudHMgYWJvdmUg b3B0aW9ucyBkZWNsYXJhdGlvbnMgaW4gT3B0aW9uc0dUSy5jbWFrZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMDc0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dU Sy5jbWFrZToKKwogMjAxNi0wMS0xMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gVXBkYXRlIE9wdGlvbnNHVEsuY21ha2Ug YW5kIE5FV1MgZm9yIDIuMTEuMyByZWxlYXNlLgo=