153071 2016-01-13 10:52:58 -0800 [Win] Remove workarounds for fixed bugs in fmod and pow. 2016-01-14 00:53:22 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 152899 1 peavo webkit-unassigned achristensen benjamin bfulgham cdumez cmarcelo commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1155130 0 peavo 2016-01-13 10:52:58 -0800 WTF has workarounds for bugs in the MSVC implementation of fmod and pow. I believe these have been fixed, and we can remove the workarounds. 1155131 1 268880 peavo 2016-01-13 10:59:20 -0800 Created attachment 268880 Patch 1155133 2 peavo 2016-01-13 11:00:48 -0800 I have only tested the following code: double a = NAN; bool isNan = isnan(a); double b = 0; double res = pow(a, b); double x = 3; double y = INFINITY; bool isInf = isinf(y); double result = fmod(x, y); 1155137 3 268880 bfulgham 2016-01-13 11:08:53 -0800 Comment on attachment 268880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=268880&action=review I like this change, but please wait to land for the win EWS to complete. > Source/WTF/ChangeLog:11 > + (wtf_atan2): Please delete this line (you didn't change wtf_atan2), but prepare-ChangeLog thinks you did. 1155142 4 peavo 2016-01-13 11:22:12 -0800 (In reply to comment #3) > Comment on attachment 268880 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268880&action=review > > I like this change, but please wait to land for the win EWS to complete. > > > Source/WTF/ChangeLog:11 > > + (wtf_atan2): > > Please delete this line (you didn't change wtf_atan2), but prepare-ChangeLog > thinks you did. Thanks for reviewing :) I will wait for the win EWS before landing. 1155216 5 268901 peavo 2016-01-13 13:37:04 -0800 Created attachment 268901 Patch 1155217 6 peavo 2016-01-13 13:38:31 -0800 (In reply to comment #5) > Created attachment 268901 [details] > Patch Trying again, fixed compile error :) 1155218 7 268901 bfulgham 2016-01-13 13:40:38 -0800 Comment on attachment 268901 Patch r=me 1155395 8 peavo 2016-01-14 00:53:12 -0800 Committed r195011: <http://trac.webkit.org/changeset/195011>. 268880 2016-01-13 10:59:20 -0800 2016-01-13 13:36:54 -0800 Patch bug-153071-20160113195858.patch text/plain 1554 peavo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTQ5NjcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE2LTAxLTEzICBQZXIgQXJuZSBWb2xsYW4gIDxw ZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXSBSZW1vdmUgd29ya2Fyb3VuZHMgZm9y IGZpeGVkIGJ1Z3MgaW4gZm1vZCBhbmQgcG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1Z3MgaGF2ZSBiZWVuIGZpeGVkIGluIHRoZSBNU1ZD IENSVCwgYW5kIHdlIGNhbiByZW1vdmUgdGhlIHdvcmthcm91bmRzLgorCisgICAgICAgICogd3Rm L01hdGhFeHRyYXMuaDoKKyAgICAgICAgKHd0Zl9hdGFuMik6CisgICAgICAgICh3dGZfZm1vZCk6 IERlbGV0ZWQuCisgICAgICAgICh3dGZfcG93KTogRGVsZXRlZC4KKwogMjAxNi0wMS0xMyAgQW5k cmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CiAKICAgICAgICAgRnJhZ21lbnRhdGlvbi1m cmVlIGFsbG9jYXRvciBmb3IgdGltZWxlc3MgYW5kL29yIGNvdXBsZWQgYWxsb2NhdGlvbnMuCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvTWF0aEV4dHJhcy5oCShyZXZpc2lvbiAxOTQ5NjIpCisrKyBTb3VyY2UvV1RGL3d0Zi9N YXRoRXh0cmFzLmgJKHdvcmtpbmcgY29weSkKQEAgLTExOCwxNSArMTE4LDcgQEAgZXh0ZXJuICJD IiBpbmxpbmUgZG91YmxlIHd0Zl9hdGFuMihkb3VibAogICAgIHJldHVybiByZXN1bHQ7CiB9CiAK LS8vIFdvcmsgYXJvdW5kIGEgYnVnIGluIHRoZSBNaWNyb3NvZnQgQ1JULCB3aGVyZSBmbW9kKHgs ICstaW5maW5pdHkpIHlpZWxkcyBOYU4gaW5zdGVhZCBvZiB4LgotZXh0ZXJuICJDIiBpbmxpbmUg ZG91YmxlIHd0Zl9mbW9kKGRvdWJsZSB4LCBkb3VibGUgeSkgeyByZXR1cm4gKCFzdGQ6OmlzaW5m KHgpICYmIHN0ZDo6aXNpbmYoeSkpID8geCA6IGZtb2QoeCwgeSk7IH0KLQotLy8gV29yayBhcm91 bmQgYSBidWcgaW4gdGhlIE1pY3Jvc29mdCBDUlQsIHdoZXJlIHBvdyhOYU4sIDApIHlpZWxkcyBO YU4gaW5zdGVhZCBvZiAxLgotZXh0ZXJuICJDIiBpbmxpbmUgZG91YmxlIHd0Zl9wb3coZG91Ymxl IHgsIGRvdWJsZSB5KSB7IHJldHVybiB5ID09IDAgPyAxIDogcG93KHgsIHkpOyB9Ci0KICNkZWZp bmUgYXRhbjIoeCwgeSkgd3RmX2F0YW4yKHgsIHkpCi0jZGVmaW5lIGZtb2QoeCwgeSkgd3RmX2Zt b2QoeCwgeSkKLSNkZWZpbmUgcG93KHgsIHkpIHd0Zl9wb3coeCwgeSkKIAogI2VuZGlmIC8vIENP TVBJTEVSKE1TVkMpCiAK 268901 2016-01-13 13:37:04 -0800 2016-01-13 13:40:38 -0800 Patch bug-153071-20160113223643.patch text/plain 2739 peavo SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxOTQ5NjcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTAxLTEzICBQZXIgQXJuZSBWb2xsYW4gIDxw ZWF2b0BvdXRsb29rLmNvbT4KKworICAgICAgICBbV2luXSBSZW1vdmUgd29ya2Fyb3VuZHMgZm9y IGZpeGVkIGJ1Z3MgaW4gZm1vZCBhbmQgcG93LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMDcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGJ1Z3MgaGF2ZSBiZWVuIGZpeGVkIGluIHRoZSBNU1ZD IENSVCwgYW5kIHdlIGNhbiByZW1vdmUgdGhlIHdvcmthcm91bmRzLgorCisgICAgICAgICogd3Rm L01hdGhFeHRyYXMuaDoKKyAgICAgICAgKHd0Zl9mbW9kKTogRGVsZXRlZC4KKyAgICAgICAgKHd0 Zl9wb3cpOiBEZWxldGVkLgorCiAyMDE2LTAxLTEzICBBbmRyZWFzIEtsaW5nICA8YWtsaW5nQGFw cGxlLmNvbT4KIAogICAgICAgICBGcmFnbWVudGF0aW9uLWZyZWUgYWxsb2NhdG9yIGZvciB0aW1l bGVzcyBhbmQvb3IgY291cGxlZCBhbGxvY2F0aW9ucy4KSW5kZXg6IFNvdXJjZS9XVEYvd3RmL01h dGhFeHRyYXMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgJKHJl dmlzaW9uIDE5NDk2MikKKysrIFNvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAkod29ya2luZyBj b3B5KQpAQCAtMTE4LDE1ICsxMTgsNyBAQCBleHRlcm4gIkMiIGlubGluZSBkb3VibGUgd3RmX2F0 YW4yKGRvdWJsCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotLy8gV29yayBhcm91bmQgYSBidWcg aW4gdGhlIE1pY3Jvc29mdCBDUlQsIHdoZXJlIGZtb2QoeCwgKy1pbmZpbml0eSkgeWllbGRzIE5h TiBpbnN0ZWFkIG9mIHguCi1leHRlcm4gIkMiIGlubGluZSBkb3VibGUgd3RmX2Ztb2QoZG91Ymxl IHgsIGRvdWJsZSB5KSB7IHJldHVybiAoIXN0ZDo6aXNpbmYoeCkgJiYgc3RkOjppc2luZih5KSkg PyB4IDogZm1vZCh4LCB5KTsgfQotCi0vLyBXb3JrIGFyb3VuZCBhIGJ1ZyBpbiB0aGUgTWljcm9z b2Z0IENSVCwgd2hlcmUgcG93KE5hTiwgMCkgeWllbGRzIE5hTiBpbnN0ZWFkIG9mIDEuCi1leHRl cm4gIkMiIGlubGluZSBkb3VibGUgd3RmX3Bvdyhkb3VibGUgeCwgZG91YmxlIHkpIHsgcmV0dXJu IHkgPT0gMCA/IDEgOiBwb3coeCwgeSk7IH0KLQogI2RlZmluZSBhdGFuMih4LCB5KSB3dGZfYXRh bjIoeCwgeSkKLSNkZWZpbmUgZm1vZCh4LCB5KSB3dGZfZm1vZCh4LCB5KQotI2RlZmluZSBwb3co eCwgeSkgd3RmX3Bvdyh4LCB5KQogCiAjZW5kaWYgLy8gQ09NUElMRVIoTVNWQykKIApJbmRleDog U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwkocmV2aXNpb24gMTk0OTgxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDEtMTMgIFBlciBBcm5lIFZvbGxh biAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5dIFJlbW92ZSB3b3JrYXJvdW5k cyBmb3IgZml4ZWQgYnVncyBpbiBmbW9kIGFuZCBwb3cuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTMwNzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21waWxlIGZpeCwgaGVscCBNU1ZDIHBpY2sgY29y cmVjdCBwb3cgb3ZlcmxvYWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvc2hhcGVzL0JveFNoYXBl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFkanVzdFJhZGl1c0Zvck1hcmdpbkJveFNoYXBlKToK KwogMjAxNi0wMS0xMyAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE5NDk2My4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvQm94U2hhcGUuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9zaGFwZXMvQm94U2hhcGUuY3BwCShyZXZpc2lvbiAxOTQ5NjIp CisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc2hhcGVzL0JveFNoYXBlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDMsNyArNDMsNyBAQCBzdGF0aWMgaW5saW5lIExheW91dFVuaXQgYWRqdXN0 UmFkaXVzRm9yCiAKICAgICBMYXlvdXRVbml0IHJhdGlvID0gcmFkaXVzIC8gbWFyZ2luOwogICAg IGlmIChyYXRpbyA8IDEpCi0gICAgICAgIHJldHVybiByYWRpdXMgKyAobWFyZ2luICogKDEgKyBw b3cocmF0aW8gLSAxLCAzKSkpOworICAgICAgICByZXR1cm4gcmFkaXVzICsgKG1hcmdpbiAqICgx ICsgcG93KHJhdGlvIC0gMSwgMy4wKSkpOwogCiAgICAgcmV0dXJuIHJhZGl1cyArIG1hcmdpbjsK IH0K