153030 2016-01-12 12:32:28 -0800 Web Inspector: fix some common misspellings in localized strings 2016-01-12 12:53:54 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 bburg bburg bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1154834 0 bburg 2016-01-12 12:32:28 -0800 <rdar://problem/24153340> 1154836 1 268799 bburg 2016-01-12 12:34:16 -0800 Created attachment 268799 Proposed Fix 1154839 2 268799 joepeck 2016-01-12 12:37:02 -0800 Comment on attachment 268799 Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268799&action=review r=me! > Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:112 > + this._messageTextViewElement = WebInspector.createMessageTextView(WebInspector.UIString("An error occurred trying to\nread the “%s” table.").format(this.representedObject.name), true); Is the newline really needed in here too? 1154855 3 bburg 2016-01-12 12:52:38 -0800 Committed r194920: <http://trac.webkit.org/changeset/194920> 1154856 4 bburg 2016-01-12 12:53:46 -0800 (In reply to comment #2) > Comment on attachment 268799 [details] > Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268799&action=review > > r=me! > > > Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js:112 > > + this._messageTextViewElement = WebInspector.createMessageTextView(WebInspector.UIString("An error occurred trying to\nread the “%s” table.").format(this.representedObject.name), true); > > Is the newline really needed in here too? I removed it before landing. 268799 2016-01-12 12:34:16 -0800 2016-01-12 12:53:54 -0800 Proposed Fix bug-153030-20160112123345.patch text/plain 5603 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0ODkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 NTY1NWEyNGEwNWViNGU2ZWFjOTdhNDBlNzUzYmYxYzFiOWU3MDc3Li40NmM5MWYwYTgxMjE4YWEx YmZmZmJhZjE1MWU4OTA3MzVlNTkyMDBkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxNi0wMS0xMiAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBmaXggc29tZSBjb21tb24gbWlzc3BlbGxpbmdzIGluIGxv Y2FsaXplZCBzdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTMwMzAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI0MTUzMzQwPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2UgJ29jY3Vy ZWQnLCAndHJhbnNmZXJlZCcgd2l0aCAnb2NjdXJyZWQnIGFuZCAndHJhbnNmZXJyZWQnLgorCisg ICAgICAgICogTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAg ICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YWJhc2VUYWJsZUNvbnRlbnRWaWV3LmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFiYXNlVGFibGVDb250ZW50Vmlldy5wcm90b3R5cGUu X3F1ZXJ5RXJyb3IpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRD b250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3JrR3JpZENvbnRlbnRW aWV3KToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZVZpZXcu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lVmlldyk6CisgICAgICAg ICogVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsKToKKwogMjAx Ni0wMS0xMSAgRGV2aW4gUm91c3NvICA8ZGNyb3Vzc28rd2Via2l0QGdtYWlsLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBTdG9yYWdlIHRhYiBuYXZpZ2F0aW9uIGJhciBzaG91bGQgZml0 IG9uIGEgc2luZ2xlIGxpbmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2Nh bGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IGVl ODM4ODQ0ZTczYWI2Y2FiMGQwZTAyNTBhMTY5NWU1YmZiNzQ0ZTguLmU3YzQwNjY0Y2I0MjZhYzM4 ODk5OWE5NjRlMDJhNjQ5OGEzN2QzZmQgMTAwNjQ0CkdJVCBiaW5hcnkgcGF0Y2gKZGVsdGEgNzcK emNtZG5nIW4mKTRiO0RHdCQ9JVhZbGg7YXhLeHdfbms+KG9CYE9AMy1yNVI8IXJnc2BMRG92bEwj YmA5Vyl7djJGCmNhJVlqeV54MX10SmQ7bHI4QkRKUmlmcCR2VipKVnYwNXgrT1JzYUExCgpkZWx0 YSA0NQp3Y21kbmghbiYhMmI7REd0JHJHZ3xDYTskWWZ6bz0tLXFQRT5yNVJuc3JjWDN2Uk1AYFJr Zzs2PTBGMF4rKUJwZWcKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9EYXRhYmFzZVRhYmxlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhYmFzZVRhYmxlQ29udGVudFZpZXcuanMK aW5kZXggNTJkN2RlYjk2MmZkNWRiN2E2ZjU1YTAyZWNjOTkyYTAzMDY0MDUzMC4uOTMxMzQ1Yjlk Y2YxZmQ4Nzc0MjI3ZjdiYTRkODY1ODBiZmQxZjZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YWJhc2VUYWJsZUNvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFiYXNl VGFibGVDb250ZW50Vmlldy5qcwpAQCAtMTA5LDcgKzEwOSw3IEBAIFdlYkluc3BlY3Rvci5EYXRh YmFzZVRhYmxlQ29udGVudFZpZXcgPSBjbGFzcyBEYXRhYmFzZVRhYmxlQ29udGVudFZpZXcgZXh0 ZW5kcyBXCiAgICAgICAgIGlmICh0aGlzLl9tZXNzYWdlVGV4dFZpZXdFbGVtZW50KQogICAgICAg ICAgICAgdGhpcy5fbWVzc2FnZVRleHRWaWV3RWxlbWVudC5yZW1vdmUoKTsKIAotICAgICAgICB0 aGlzLl9tZXNzYWdlVGV4dFZpZXdFbGVtZW50ID0gV2ViSW5zcGVjdG9yLmNyZWF0ZU1lc3NhZ2VU ZXh0VmlldyhXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIkFuIGVycm9yIG9jY3VyZWQgdHJ5aW5nIHRv XG5yZWFkIHRoZSDigJwlc+KAnSB0YWJsZS4iKS5mb3JtYXQodGhpcy5yZXByZXNlbnRlZE9iamVj dC5uYW1lKSwgdHJ1ZSk7CisgICAgICAgIHRoaXMuX21lc3NhZ2VUZXh0Vmlld0VsZW1lbnQgPSBX ZWJJbnNwZWN0b3IuY3JlYXRlTWVzc2FnZVRleHRWaWV3KFdlYkluc3BlY3Rvci5VSVN0cmluZygi QW4gZXJyb3Igb2NjdXJyZWQgdHJ5aW5nIHRvXG5yZWFkIHRoZSDigJwlc+KAnSB0YWJsZS4iKS5m b3JtYXQodGhpcy5yZXByZXNlbnRlZE9iamVjdC5uYW1lKSwgdHJ1ZSk7CiAgICAgICAgIHRoaXMu ZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9tZXNzYWdlVGV4dFZpZXdFbGVtZW50KTsKICAgICB9 CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L05ldHdvcmtHcmlkQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9OZXR3b3JrR3JpZENvbnRlbnRWaWV3LmpzCmluZGV4IDA2ZTAyZmU4NjM4 ZTA4NDBiZjM3MGIzYmVjZDIzZjEyOGYxNGNmNjIuLjM2ZTZmYTNjMWVlYzE3OWQxZjgxZjQ4NDJj YzYzMDYzNWRmNWIyNjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL05ldHdvcmtHcmlkQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya0dyaWRDb250ZW50Vmlldy5qcwpA QCAtNjEsNyArNjEsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya0dyaWRDb250ZW50VmlldyA9IGNs YXNzIE5ldHdvcmtHcmlkQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbgogICAgICAgICBjb2x1bW5z LnNpemUud2lkdGggPSAiOCUiOwogICAgICAgICBjb2x1bW5zLnNpemUuYWxpZ25lZCA9ICJyaWdo dCI7CiAKLSAgICAgICAgY29sdW1ucy50cmFuc2ZlclNpemUudGl0bGUgPSBXZWJJbnNwZWN0b3Iu VUlTdHJpbmcoIlRyYW5zZmVyZWQiKTsKKyAgICAgICAgY29sdW1ucy50cmFuc2ZlclNpemUudGl0 bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlRyYW5zZmVycmVkIik7CiAgICAgICAgIGNvbHVt bnMudHJhbnNmZXJTaXplLndpZHRoID0gIjglIjsKICAgICAgICAgY29sdW1ucy50cmFuc2ZlclNp emUuYWxpZ25lZCA9ICJyaWdodCI7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGltZWxpbmVWaWV3LmpzCmlu ZGV4IDI3OTA4YWFkYzJiNzg1YzUyZGUwMDhjNWI5NTk1NjI0M2QwM2ViNGIuLjRlYzUxZmY0Njhm OWRhMDdhZWYzM2Y1YmIyYzVmY2Y5ZjE4MjE1ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUaW1lbGluZVZpZXcuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RpbWVsaW5l Vmlldy5qcwpAQCAtNjcsNyArNjcsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1RpbWVsaW5lVmll dyA9IGNsYXNzIE5ldHdvcmtUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0bwogICAgICAg ICBjb2x1bW5zLnNpemUud2lkdGggPSAiOCUiOwogICAgICAgICBjb2x1bW5zLnNpemUuYWxpZ25l ZCA9ICJyaWdodCI7CiAKLSAgICAgICAgY29sdW1ucy50cmFuc2ZlclNpemUudGl0bGUgPSBXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIlRyYW5zZmVyZWQiKTsKKyAgICAgICAgY29sdW1ucy50cmFuc2Zl clNpemUudGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlRyYW5zZmVycmVkIik7CiAgICAg ICAgIGNvbHVtbnMudHJhbnNmZXJTaXplLndpZHRoID0gIjglIjsKICAgICAgICAgY29sdW1ucy50 cmFuc2ZlclNpemUuYWxpZ25lZCA9ICJyaWdodCI7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5l bC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNl RGV0YWlsc1NpZGViYXJQYW5lbC5qcwppbmRleCBmN2ZlOTM5ZjdkZTBiMGJlNTQ5YTc5NTFkMDBm ZTJkNjQ0MjY1NDdlLi43OWZkZjFiZmRhNGExYTdmOWUzOGVkYTExNzA3M2NhNDhhZTkzNGQ4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNv dXJjZURldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC03NSw3 ICs3NSw3IEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFz cyBSZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwgZXh0CiAKICAgICAgICAgdGhpcy5fZW5jb2Rl ZFNpemVSb3cgPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0aW9uU2ltcGxlUm93KFdlYklu c3BlY3Rvci5VSVN0cmluZygiRW5jb2RlZCIpKTsKICAgICAgICAgdGhpcy5fZGVjb2RlZFNpemVS b3cgPSBuZXcgV2ViSW5zcGVjdG9yLkRldGFpbHNTZWN0aW9uU2ltcGxlUm93KFdlYkluc3BlY3Rv ci5VSVN0cmluZygiRGVjb2RlZCIpKTsKLSAgICAgICAgdGhpcy5fdHJhbnNmZXJTaXplUm93ID0g bmV3IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvblNpbXBsZVJvdyhXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlRyYW5zZmVyZWQiKSk7CisgICAgICAgIHRoaXMuX3RyYW5zZmVyU2l6ZVJvdyA9IG5l dyBXZWJJbnNwZWN0b3IuRGV0YWlsc1NlY3Rpb25TaW1wbGVSb3coV2ViSW5zcGVjdG9yLlVJU3Ry aW5nKCJUcmFuc2ZlcnJlZCIpKTsKIAogICAgICAgICB0aGlzLl9jb21wcmVzc2VkUm93ID0gbmV3 IFdlYkluc3BlY3Rvci5EZXRhaWxzU2VjdGlvblNpbXBsZVJvdyhXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIkNvbXByZXNzZWQiKSk7CiAgICAgICAgIHRoaXMuX2NvbXByZXNzaW9uUm93ID0gbmV3IFdl Ykluc3BlY3Rvci5EZXRhaWxzU2VjdGlvblNpbXBsZVJvdyhXZWJJbnNwZWN0b3IuVUlTdHJpbmco IkNvbXByZXNzaW9uIikpOwo=