153007 2016-01-12 00:49:52 -0800 Web Inspector: Sidebar's should remember their width's 2016-01-22 10:08:14 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1154645 0 hi 2016-01-12 00:49:52 -0800 r194879 <https://bugs.webkit.org/show_bug.cgi?id=152473> introduced the ability for sidebar panels to calculate their minimum widths. This functionality works correctly, but there is an issue when the user switches to a view with the sidebar collapsed and then switches back to the first view. Since the second view essentially had a sidebar width of 0, the first view recalculates the width of the sidebar to its minimum, regardless of how large the user had it before he changed views. It is very annoying to have to keep resizing the sidebar to a larger width, so I think it would be better to have the sidebar's remember their previous width and restore it (clamped to the min/max of the current inspector width) whenever a view changes. 1155653 1 webkit-bug-importer 2016-01-14 18:29:30 -0800 <rdar://problem/24200496> 1157597 2 269552 hi 2016-01-21 22:57:36 -0800 Created attachment 269552 Patch 1157707 3 269552 commit-queue 2016-01-22 10:08:09 -0800 Comment on attachment 269552 Patch Clearing flags on attachment: 269552 Committed r195456: <http://trac.webkit.org/changeset/195456> 1157708 4 commit-queue 2016-01-22 10:08:14 -0800 All reviewed patches have been landed. Closing bug. 269552 2016-01-21 22:57:36 -0800 2016-01-22 10:08:09 -0800 Patch bug-153007-20160121225709.patch text/plain 5175 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZjZTc1MDljYmY3ZDlhNGQ0NzhkMTA4ZGRkZjE3 N2FlMDBkZDczNzEuLmM1MzJjYjdlNDdhNjY1YzNiNDY4MTcxNjhjYzFmZmY0ZTczYWM0YTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMzIEBACiAyMDE2LTAxLTIxICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFNpZGViYXIncyBzaG91bGQgcmVtZW1iZXIgdGhlaXIgd2lkdGgncworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUzMDA3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1Zp ZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5DU1NTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLndpZHRoRGlkQ2hhbmdlKToK KyAgICAgICAgTm93IGNhbGxzIHN1cGVyY2xhc3MgZnVuY3Rpb24uCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL1NpZGViYXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2lkZWJh ci5wcm90b3R5cGUuc2V0IHNlbGVjdGVkU2lkZWJhclBhbmVsKToKKyAgICAgICAgTm93IGNhbGxz IF9yZWNhbGN1bGF0ZVdpZHRoIHdpdGggdGhlIHNhdmVkIHdpZHRoIHZhbHVlIG9mIHRoZSBzaWRl YmFyIGFzCisgICAgICAgIHRoZSBmaXJzdCBwYXJhbWV0ZXIuCisKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5TaWRlYmFyLnByb3RvdHlwZS5zZXQgY29sbGFwc2VkKToKKyAgICAgICAgTm93IG9ubHkg Y2FsbHMgX3JlY2FsY3VsYXRlV2lkdGggaWYgdGhlIHNlbGVjdGVkIHNpZGViYXIgcGFuZWwgaXMg dmlzaWJsZSwKKyAgICAgICAgc2VlaW5nIGFzIGlmIGl0IGlzIGhpZGRlbiB0aGUgd2lkdGggaXMg aXJyZWxldmFudC4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNpZGViYXJQYW5lbCk6CisgICAgICAgIENyZWF0 ZXMgYSBzZXR0aW5nIG9iamVjdCB1c2luZyB0aGUgcGFuZWwncyBpZGVudGlmaWVyIHRvIHN0b3Jl IHRoZSBjdXJyZW50IHdpZHRoLgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuU2lkZWJhclBhbmVs LnByb3RvdHlwZS5nZXQgc2F2ZWRXaWR0aCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuU2lkZWJh clBhbmVsLnByb3RvdHlwZS53aWR0aERpZENoYW5nZSk6CisgICAgICAgIFNvIGxvbmcgYXMgdGhl IGN1cnJlbnQgd2lkdGggaGFzIGEgdmFsdWUsIHNhdmUgaXQgdG8gdGhlIHNldHRpbmcgb2JqZWN0 LgorCisyMDE2LTAxLTIxICBEZXZpbiBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29t PgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFkZCB0b2dnbGUtYWJsZSBsaXN0IG9mIGNsYXNz ZXMgZm9yIGVhY2ggZWxlbWVudAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTUyNjc4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGV0YWlsc1NpZGVi YXJQYW5lbC5qcwppbmRleCA3MGNkODFjMTJmN2JjOTBjM2YxYWFiMzgyZDc3MzlkMmNiNzcwYWFm Li5lNWE4NjQ3ZGY0OWU2YTAyMTlmY2RmMTRmODlhMTYxZGFjMGIwNDkzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURldGFpbHNT aWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvQ1NTU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0xNzIsNiArMTcyLDggQEAg V2ViSW5zcGVjdG9yLkNTU1N0eWxlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIENTU1N0eWxl RGV0YWlsc1NpZGViYXJQYW5lbCBleHQKIAogICAgIHdpZHRoRGlkQ2hhbmdlKCkKICAgICB7Cisg ICAgICAgIHN1cGVyLndpZHRoRGlkQ2hhbmdlKCk7CisKICAgICAgICAgdGhpcy5fdXBkYXRlTm9G b3JjZWRQc2V1ZG9DbGFzc2VzU2Nyb2xsT2Zmc2V0KCk7CiAKICAgICAgICAgaWYgKHRoaXMuX3Nl bGVjdGVkUGFuZWwpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TaWRlYmFyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU2lkZWJhci5qcwppbmRleCA5NjUzODQ1NTYzMTc0ODVjYTlmNDdlYTc2YjBjNGZi YzdiYzI3MWMzLi41NDcwZTZmNTcwNjlmZGJkM2Y3OTIxMWU0ZGIyNDE2ZmM3ZDg0NDYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFy LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGVi YXIuanMKQEAgLTE0Nyw3ICsxNDcsNyBAQCBXZWJJbnNwZWN0b3IuU2lkZWJhciA9IGNsYXNzIFNp ZGViYXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAgaWYgKHRoaXMuX3Nl bGVjdGVkU2lkZWJhclBhbmVsLnZpc2libGUpIHsKICAgICAgICAgICAgICAgICB0aGlzLl9zZWxl Y3RlZFNpZGViYXJQYW5lbC5zaG93bigpOwogICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVk U2lkZWJhclBhbmVsLnZpc2liaWxpdHlEaWRDaGFuZ2UoKTsKLSAgICAgICAgICAgICAgICB0aGlz Ll9yZWNhbGN1bGF0ZVdpZHRoKCk7CisgICAgICAgICAgICAgICAgdGhpcy5fcmVjYWxjdWxhdGVX aWR0aCh0aGlzLl9zZWxlY3RlZFNpZGViYXJQYW5lbC5zYXZlZFdpZHRoKTsKICAgICAgICAgICAg IH0KICAgICAgICAgfQogCkBAIC0yMDAsMTQgKzIwMCwxMyBAQCBXZWJJbnNwZWN0b3IuU2lkZWJh ciA9IGNsYXNzIFNpZGViYXIgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAg dGhpcy5fbmF2aWdhdGlvbkJhci5uZWVkc0xheW91dCgpOwogCiAgICAgICAgIGlmICh0aGlzLl9z ZWxlY3RlZFNpZGViYXJQYW5lbCkgewotICAgICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGVkU2lk ZWJhclBhbmVsLnZpc2libGUpCisgICAgICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRTaWRlYmFy UGFuZWwudmlzaWJsZSkgewogICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBh bmVsLnNob3duKCk7Ci0gICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAgdGhpcy5fcmVj YWxjdWxhdGVXaWR0aCh0aGlzLl9zZWxlY3RlZFNpZGViYXJQYW5lbC5zYXZlZFdpZHRoKTsKKyAg ICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2lkZWJhclBh bmVsLmhpZGRlbigpOwogCiAgICAgICAgICAgICB0aGlzLl9zZWxlY3RlZFNpZGViYXJQYW5lbC52 aXNpYmlsaXR5RGlkQ2hhbmdlKCk7Ci0gICAgICAgICAgICB0aGlzLl9zZWxlY3RlZFNpZGViYXJQ YW5lbC53aWR0aERpZENoYW5nZSgpOwotICAgICAgICAgICAgdGhpcy5fcmVjYWxjdWxhdGVXaWR0 aCgpOwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMo V2ViSW5zcGVjdG9yLlNpZGViYXIuRXZlbnQuQ29sbGFwc2VkU3RhdGVEaWRDaGFuZ2UpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lkZWJh clBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2lk ZWJhclBhbmVsLmpzCmluZGV4IGJjZTg4ZWJkNjQwZjE5MjlkOGFhNDcwNjMxNmVkNzVkMDExM2Mx N2UuLjNhNzQyZmZmZmM2ZDMwZjYyMTA1OTQwMzdkYTUyNDc5YTNkYjhlM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NpZGViYXJQYW5lbC5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TaWRlYmFy UGFuZWwuanMKQEAgLTMzLDYgKzMzLDcgQEAgV2ViSW5zcGVjdG9yLlNpZGViYXJQYW5lbCA9IGNs YXNzIFNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAgICAgIHRoaXMu X2Rpc3BsYXlOYW1lID0gZGlzcGxheU5hbWU7CiAgICAgICAgIHRoaXMuX3NlbGVjdGVkID0gZmFs c2U7CiAKKyAgICAgICAgdGhpcy5fd2lkdGhTZXR0aW5nID0gbmV3IFdlYkluc3BlY3Rvci5TZXR0 aW5nKGlkZW50aWZpZXIgKyAiLXNpZGViYXItcGFuZWwtd2lkdGgiLCAwKTsKICAgICAgICAgdGhp cy5fc2F2ZWRTY3JvbGxQb3NpdGlvbiA9IDA7CiAKICAgICAgICAgdGhpcy5lbGVtZW50LmNsYXNz TGlzdC5hZGQoInBhbmVsIiwgaWRlbnRpZmllcik7CkBAIC04Nyw2ICs4OCwxMSBAQCBXZWJJbnNw ZWN0b3IuU2lkZWJhclBhbmVsID0gY2xhc3MgU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVj dG9yLlZpZXcKICAgICAgICAgcmV0dXJuIDA7CiAgICAgfQogCisgICAgZ2V0IHNhdmVkV2lkdGgo KQorICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMuX3dpZHRoU2V0dGluZy52YWx1ZTsKKyAgICB9 CisKICAgICBzaG93KCkKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5wYXJlbnRTaWRlYmFyKQpA QCAtMTQ4LDYgKzE1NCwxMCBAQCBXZWJJbnNwZWN0b3IuU2lkZWJhclBhbmVsID0gY2xhc3MgU2lk ZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgIHdpZHRoRGlkQ2hhbmdl KCkKICAgICB7CisgICAgICAgIGxldCB3aWR0aCA9IHRoaXMuZWxlbWVudC5yZWFsT2Zmc2V0V2lk dGg7CisgICAgICAgIGlmICh3aWR0aCAmJiB3aWR0aCAhPT0gdGhpcy5fd2lkdGhTZXR0aW5nLnZh bHVlKQorICAgICAgICAgICAgdGhpcy5fd2lkdGhTZXR0aW5nLnZhbHVlID0gd2lkdGg7CisKICAg ICAgICAgLy8gSW1wbGVtZW50ZWQgYnkgc3ViY2xhc3Nlcy4KICAgICB9CiAK