153003 2016-01-11 21:25:57 -0800 Web Inspector: creating a gradient in the Visual sidebar causes a crash 2016-01-14 11:31:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1154619 0 hi 2016-01-11 21:25:57 -0800 * STEPS TO REPRODUCE 1. Go to <www.apple.com> 2. Inspect the <body> 3. In the Visual sidebar, go to Background > Style 4. Click the + button on the list editor and select "Linear Gradient" in the dropdown next to "Type" 5. Click the swatch element immediately to the right of the "Type" label (the gradient editor should open) 6. Click slightly underneath the gradient preview area to add a color stop * Expected Color stop is added to (previously empty) gradient * Actual Crashes 1154621 1 268744 hi 2016-01-11 21:28:40 -0800 Created attachment 268744 Patch 1154630 2 bburg 2016-01-11 22:56:03 -0800 By crash, do you mean that WebCore crashed? We should also investigate fixing that, as invalid CSS from the inspector should never cause a segfault. 1154631 3 268744 bburg 2016-01-11 22:56:50 -0800 Comment on attachment 268744 Patch r=me 1154642 4 hi 2016-01-12 00:38:14 -0800 (In reply to comment #2) > By crash, do you mean that WebCore crashed? We should also investigate > fixing that, as invalid CSS from the inspector should never cause a segfault. Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I figured that that was considered a "crash" for the Web Inspector. Is there a better term for it? 1154745 5 bburg 2016-01-12 10:12:48 -0800 (In reply to comment #4) > (In reply to comment #2) > > By crash, do you mean that WebCore crashed? We should also investigate > > fixing that, as invalid CSS from the inspector should never cause a segfault. > > Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I > figured that that was considered a "crash" for the Web Inspector. Is there > a better term for it? That's an uncaught exception, and is less severe. The dialog only appears in engineering builds and can be dismissed. A crash occurs when the Web Inspector or Safari window disappears completely and a crash report is collected. If that happens, you can see the stack trace dumped to stdout or added to the list in Console.app. 1154753 6 hi 2016-01-12 10:30:10 -0800 (In reply to comment #5) > (In reply to comment #4) > > (In reply to comment #2) > > > By crash, do you mean that WebCore crashed? We should also investigate > > > fixing that, as invalid CSS from the inspector should never cause a segfault. > > > > Oh no just Web Inspector crashes. I get that "Uncaught Exception" page. I > > figured that that was considered a "crash" for the Web Inspector. Is there > > a better term for it? > > That's an uncaught exception, and is less severe. The dialog only appears in > engineering builds and can be dismissed. > > A crash occurs when the Web Inspector or Safari window disappears completely > and a crash report is collected. If that happens, you can see the stack > trace dumped to stdout or added to the list in Console.app. Ah OK that makes more sense. I'll refer to it as such in the future. Sorry for the confusion! 1154759 7 268744 commit-queue 2016-01-12 10:44:37 -0800 Comment on attachment 268744 Patch Clearing flags on attachment: 268744 Committed r194901: <http://trac.webkit.org/changeset/194901> 1154760 8 commit-queue 2016-01-12 10:44:41 -0800 All reviewed patches have been landed. Closing bug. 1155499 9 webkit-bug-importer 2016-01-14 11:31:08 -0800 <rdar://problem/24191708> 268744 2016-01-11 21:28:40 -0800 2016-01-12 10:44:37 -0800 Patch bug-153003-20160111212809.patch text/plain 1932 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ1NjU1YTI0YTA1ZWI0ZTZlYWM5N2E0MGU3NTNi ZjFjMWI5ZTcwNzcuLjFlYWNmM2Y0YjE4YjVkMzYxMGVjYmFhMjkzMjVjMGExZDM2NGM4ZWIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTAxLTExICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgogCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IGNyZWF0aW5nIGEgZ3JhZGllbnQgaW4gdGhlIFZpc3VhbCBzaWRlYmFyIGNhdXNlcyBh IGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NTMwMDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVCYWNrZ3JvdW5kUGlja2VyLmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlQmFja2dyb3VuZFBpY2tlci5wcm90b3R5cGUu X2dyYWRpZW50U3dhdGNoQ2xpY2tlZCk6CisgICAgICAgIElmIGEgZ3JhZGllbnQgZG9lcyBub3Qg YWxyZWFkeSBleGlzdCB3aGVuIHRoZSBzd2F0Y2ggaXMgY2xpY2tlZCwgY3JlYXRlIGEgYmFzaWMK KyAgICAgICAgZ3JhZGllbnQgdXNpbmcgdGhlIGN1cnJlbnQgdHlwZSBhbmQgdHdvICJ0cmFuc3Bh cmVudCIgY29sb3Igc3RvcHMgKGEgbWluaW11bSBvZgorICAgICAgICB0d28gY29sb3Igc3RvcHMg YXJlIG5lZWRlZCBmb3IgYSB2YWxpZCBncmFkaWVudCkuCisKKzIwMTYtMDEtMTEgIERldmluIFJv dXNzbyAgPGRjcm91c3NvK3dlYmtpdEBnbWFpbC5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogU3RvcmFnZSB0YWIgbmF2aWdhdGlvbiBiYXIgc2hvdWxkIGZpdCBvbiBhIHNpbmdsZSBsaW5l CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI0NzMK IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VmlzdWFsU3R5bGVCYWNrZ3JvdW5kUGlja2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVCYWNrZ3JvdW5kUGlja2VyLmpzCmluZGV4IDEw NWRlMmFmNjk0ODZhOWM3ZDM3NzE4NjU1OTkxYjZiM2UwZGExMWQuLjQyZGRmN2M3MDdkYWM2YTBl NTQ0YTBlZjdmMDY4ZGJhOWQwYTBiNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlQmFja2dyb3VuZFBpY2tlci5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZUJh Y2tncm91bmRQaWNrZXIuanMKQEAgLTE4Nyw2ICsxODcsOSBAQCBXZWJJbnNwZWN0b3IuVmlzdWFs U3R5bGVCYWNrZ3JvdW5kUGlja2VyID0gY2xhc3MgVmlzdWFsU3R5bGVCYWNrZ3JvdW5kUGlja2Vy IGV4dAogICAgICAgICBwb3BvdmVyLmNvbnRlbnQgPSBncmFkaWVudEVkaXRvci5lbGVtZW50Owog ICAgICAgICBwb3BvdmVyLnByZXNlbnQoYm91bmRzLnBhZCgyKSwgW1dlYkluc3BlY3Rvci5SZWN0 RWRnZS5NSU5fWF0pOwogCisgICAgICAgIGlmICghdGhpcy5fZ3JhZGllbnQpCisgICAgICAgICAg ICB0aGlzLl9ncmFkaWVudCA9IFdlYkluc3BlY3Rvci5HcmFkaWVudC5mcm9tU3RyaW5nKGAke3Ro aXMuX2N1cnJlbnRUeXBlfSh0cmFuc3BhcmVudCwgdHJhbnNwYXJlbnQpYCk7CisKICAgICAgICAg Z3JhZGllbnRFZGl0b3IuZ3JhZGllbnQgPSB0aGlzLl9ncmFkaWVudDsKICAgICB9CiAK