152991 2016-01-11 15:37:26 -0800 Web Inspector: Fix DataGrid row disclosure appearance and behavior 2016-01-14 12:40:08 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1154513 0 mattbaker 2016-01-11 15:37:26 -0800 * SUMMARY Fix DataGrid row disclosure appearance and behavior. Positioning and hit testing of the disclosure triangle has been broken for a while, but has gone unnoticed since it's not currently used. 1154517 1 268719 mattbaker 2016-01-11 15:43:58 -0800 Created attachment 268719 [Patch] Proposed Fix 1154771 2 268719 bburg 2016-01-12 11:00:45 -0800 Comment on attachment 268719 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=268719&action=review r=me Was there a specific regression, or was this a result of various stylesheet changes? > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1854 > + let computedLeftPadding = window.getComputedStyle(cell).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX); Fancy. 1154785 3 mattbaker 2016-01-12 11:22:39 -0800 (In reply to comment #2) > Comment on attachment 268719 [details] > [Patch] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268719&action=review > > r=me > > Was there a specific regression, or was this a result of various stylesheet > changes? Not sure. It's been so long since this has been used that I assumed the code just drifted over time and the breakage went unnoticed. > > > Source/WebInspectorUI/UserInterface/Views/DataGrid.js:1854 > > + let computedLeftPadding = window.getComputedStyle(cell).getPropertyCSSValue("padding-left").getFloatValue(CSSPrimitiveValue.CSS_PX); > > Fancy. Copied from TreeElement.prototype.isEventWithinDisclosureTriangle. 1154792 4 268719 commit-queue 2016-01-12 11:27:28 -0800 Comment on attachment 268719 [Patch] Proposed Fix Clearing flags on attachment: 268719 Committed r194906: <http://trac.webkit.org/changeset/194906> 1154793 5 commit-queue 2016-01-12 11:27:31 -0800 All reviewed patches have been landed. Closing bug. 1155528 6 webkit-bug-importer 2016-01-14 12:40:08 -0800 <rdar://problem/24193237> 268719 2016-01-11 15:43:58 -0800 2016-01-12 11:27:28 -0800 [Patch] Proposed Fix bug-152991-20160111154327.patch text/plain 3876 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTk0ODY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA3 MmQ5OTNlMWI0YzAzOTMzZDAyODhkZTQ2YjlhNjc0YmIyODdmYTM4Li41ODk3MTg4MmQ5NWM0MTk0 YTFkNDY3MDc3NmNiMDhiNDEwMDI0MGU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMiBAQAorMjAxNi0wMS0xMSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IERhdGFHcmlkIHJvdyBkaXNjbG9zdXJlIGFw cGVhcmFuY2UgYW5kIGJlaGF2aW9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTI5OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuY3NzOgorICAgICAg ICAoLmRhdGEtZ3JpZCB0ci5wYXJlbnQgdGQuZGlzY2xvc3VyZTo6YmVmb3JlKToKKyAgICAgICAg RW5zdXJlIHRyaWFuZ2xlIGlzIHZlcnRpY2FsbHkgYWxpZ25lZCBmb3IgYW55IHJvdyBoZWlnaHQu CisgICAgICAgICguZGF0YS1ncmlkIHRyOm5vdCgucGFyZW50KSB0ZC5kaXNjbG9zdXJlKToKKyAg ICAgICAgRml4IGluZGVudCBzaXplLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9E YXRhR3JpZC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZE5vZGUucHJvdG90eXBl LmNyZWF0ZUNlbGwpOgorICAgICAgICBBZGRlZCBgaWNvbmAgY29sdW1uIHByb3BlcnR5LCBlbmNh cHN1bGF0ZSBpY29uIGVsZW1lbnQgY3JlYXRpb24uCisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0 YUdyaWROb2RlLnByb3RvdHlwZS5pc0V2ZW50V2l0aGluRGlzY2xvc3VyZVRyaWFuZ2xlKToKKyAg ICAgICAgRml4IGhpdCB0ZXN0IGxvZ2ljIGJ5IGNvbXB1dGluZyBsZWZ0IHBhZGRpbmcuCisKIDIw MTYtMDEtMTAgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBFeGNlcHRpb24gc2VsZWN0aW5nIEluZGV4ZWREQiBo b3N0IGZvbGRlciBpbiBTdG9yYWdlIHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuY3NzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuY3NzCmluZGV4IDY1MDhjOGUwM2VlYzM0 MmJlMmE0ZWYxNjI4NDhjZjViNzg5NTRlYjUuLmFmMTM1NjBiOGY1MzMyZjQ2MjhmNDZiNDc5NGZm MjJkNGM3MDJiZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0RhdGFHcmlkLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5jc3MKQEAgLTIyNSwxMSArMjI1LDEyIEBAIGJvZHkud2lu ZG93LWluYWN0aXZlIC5kYXRhLWdyaWQgOm1hdGNoZXModGgsIHRkKTpub3QoOmxhc3QtY2hpbGQp IHsKICAgICBjb250ZW50OiAiIjsKIAogICAgIGJhY2tncm91bmQtaW1hZ2U6IHVybCguLi9JbWFn ZXMvRGlzY2xvc3VyZVRyaWFuZ2xlcy5zdmcjY2xvc2VkLW5vcm1hbCk7CisgICAgYmFja2dyb3Vu ZC1wb3NpdGlvbi15OiBjZW50ZXI7CiAgICAgYmFja2dyb3VuZC1zaXplOiAxM3B4IDEzcHg7CiAg ICAgYmFja2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsKIAogICAgIHdpZHRoOiAxM3B4OwotICAg IGhlaWdodDogMTNweDsKKyAgICBoZWlnaHQ6IDEwMCU7CiB9CiAKIC5kYXRhLWdyaWQgdHIucGFy ZW50LmV4cGFuZGVkIHRkLmRpc2Nsb3N1cmU6OmJlZm9yZSB7CkBAIC0yNTUsNyArMjU2LDcgQEAg Ym9keS53aW5kb3ctaW5hY3RpdmUgLmRhdGEtZ3JpZCA6bWF0Y2hlcyh0aCwgdGQpOm5vdCg6bGFz dC1jaGlsZCkgewogfQogCiAuZGF0YS1ncmlkIHRyOm5vdCgucGFyZW50KSB0ZC5kaXNjbG9zdXJl IHsKLSAgICB0ZXh0LWluZGVudDogMTBweDsKKyAgICB0ZXh0LWluZGVudDogMTNweDsKIH0KIAog LmRhdGEtZ3JpZCB0ZCAuc3VidGl0bGUgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwppbmRleCA1ZjY3NGE0NmMyMjY1ODIw MTA3N2M4Zjk1MWExOTlkYzc2NmUwM2VkLi45NDhjM2E1ZjM0OWY3NWYyMjM2ZDk5NDE5ZWFkYTUx OTIxZDNlNzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9EYXRhR3JpZC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwpAQCAtMTYwMyw2ICsxNjAzLDEyIEBAIFdlYkluc3BlY3Rv ci5EYXRhR3JpZE5vZGUgPSBjbGFzcyBEYXRhR3JpZE5vZGUgZXh0ZW5kcyBXZWJJbnNwZWN0b3Iu T2JqZWN0CiAgICAgICAgIHZhciBjb250ZW50ID0gdGhpcy5jcmVhdGVDZWxsQ29udGVudChjb2x1 bW5JZGVudGlmaWVyLCBjZWxsRWxlbWVudCk7CiAgICAgICAgIGRpdi5hcHBlbmQoY29udGVudCk7 CiAKKyAgICAgICAgaWYgKGNvbHVtblsiaWNvbiJdKSB7CisgICAgICAgICAgICBsZXQgaWNvbkVs ZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKKyAgICAgICAgICAgIGljb25F bGVtZW50LmNsYXNzTGlzdC5hZGQoImljb24iKTsKKyAgICAgICAgICAgIGRpdi5pbnNlcnRCZWZv cmUoaWNvbkVsZW1lbnQsIGRpdi5maXJzdENoaWxkKTsKKyAgICAgICAgfQorCiAgICAgICAgIGlm IChjb2x1bW5JZGVudGlmaWVyID09PSB0aGlzLmRhdGFHcmlkLmRpc2Nsb3N1cmVDb2x1bW5JZGVu dGlmaWVyKSB7CiAgICAgICAgICAgICBjZWxsRWxlbWVudC5jbGFzc0xpc3QuYWRkKCJkaXNjbG9z dXJlIik7CiAgICAgICAgICAgICBpZiAodGhpcy5sZWZ0UGFkZGluZykKQEAgLTE4NDEsMTEgKzE4 NDcsMTIgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkTm9kZSA9IGNsYXNzIERhdGFHcmlkTm9kZSBl eHRlbmRzIFdlYkluc3BlY3Rvci5PYmplY3QKICAgICB7CiAgICAgICAgIGlmICghdGhpcy5oYXND aGlsZHJlbikKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICAgICAgdmFyIGNlbGwgPSBl dmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFtZSgidGQiKTsKKyAgICAg ICAgbGV0IGNlbGwgPSBldmVudC50YXJnZXQuZW5jbG9zaW5nTm9kZU9yU2VsZldpdGhOb2RlTmFt ZSgidGQiKTsKICAgICAgICAgaWYgKCFjZWxsLmNsYXNzTGlzdC5jb250YWlucygiZGlzY2xvc3Vy ZSIpKQogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgIHZhciBsZWZ0ID0gY2Vs bC50b3RhbE9mZnNldExlZnQgKyB0aGlzLmxlZnRQYWRkaW5nOworICAgICAgICBsZXQgY29tcHV0 ZWRMZWZ0UGFkZGluZyA9IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGNlbGwpLmdldFByb3BlcnR5 Q1NTVmFsdWUoInBhZGRpbmctbGVmdCIpLmdldEZsb2F0VmFsdWUoQ1NTUHJpbWl0aXZlVmFsdWUu Q1NTX1BYKTsKKyAgICAgICAgbGV0IGxlZnQgPSBjZWxsLnRvdGFsT2Zmc2V0TGVmdCArIGNvbXB1 dGVkTGVmdFBhZGRpbmc7CiAgICAgICAgIHJldHVybiBldmVudC5wYWdlWCA+PSBsZWZ0ICYmIGV2 ZW50LnBhZ2VYIDw9IGxlZnQgKyB0aGlzLmRpc2Nsb3N1cmVUb2dnbGVXaWR0aDsKICAgICB9CiAK