152977 2016-01-11 10:01:28 -0800 REGRESSION(r190717): [GTK] Popup menus stop working after being dismissed without selecting an item 2016-01-11 23:16:26 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply oldest_to_newest 1154394 0 cgarcia 2016-01-11 10:01:28 -0800 This happens after r190717 when you open a popup menu and without selecting any option it's dismissed (press ESC or click somewhere else). This is because I removed the code to track when the menu is unmapped, thinking that it was no longer necessary. But we need to send the DidChangeSelectedIndexForActivePopupMenu to the WebProcess with -1 as index to keep the web process in sync. 1154396 1 268693 cgarcia 2016-01-11 10:03:53 -0800 Created attachment 268693 Patch 1154633 2 cgarcia 2016-01-11 23:16:26 -0800 Committed r194886: <http://trac.webkit.org/changeset/194886> 268693 2016-01-11 10:03:53 -0800 2016-01-11 13:17:37 -0800 Patch wk2-popup-menu-dismiss.diff text/plain 6229 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA4ODdlYjRmLi4yNmI4OTE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTYtMDEtMTEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjE5MDcxNyk6IFtHVEtdIFBvcHVwIG1lbnVzIHN0b3Ag d29ya2luZyBhZnRlciBiZWluZyBkaXNtaXNzZWQgd2l0aG91dCBzZWxlY3RpbmcgYW4gaXRlbQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyOTc3CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBoYXBw ZW5zIHNpbmNlIHIxOTA3MTcgd2hlbiB5b3Ugb3BlbiBhIHBvcHVwIG1lbnUgYW5kIHdpdGhvdXQK KyAgICAgICAgc2VsZWN0aW5nIGFueSBvcHRpb24gaXQncyBkaXNtaXNzZWQgKHByZXNzIEVTQyBv ciBjbGljayBzb21ld2hlcmUKKyAgICAgICAgZWxzZSkuIFRoaXMgaXMgYmVjYXVzZSBJIHJlbW92 ZWQgdGhlIGNvZGUgdG8gdHJhY2sgd2hlbiB0aGUgbWVudQorICAgICAgICBpcyB1bm1hcHBlZCwg dGhpbmtpbmcgdGhhdCBpdCB3YXMgbm8gbG9uZ2VyIG5lY2Vzc2FyeS4gQnV0IHdlIG5lZWQKKyAg ICAgICAgdG8gc2VuZCB0aGUgRGlkQ2hhbmdlU2VsZWN0ZWRJbmRleEZvckFjdGl2ZVBvcHVwTWVu dSB0byB0aGUKKyAgICAgICAgV2ViUHJvY2VzcyB3aXRoIC0xIGFzIGluZGV4IHRvIGtlZXAgdGhl IHdlYiBwcm9jZXNzIGluIHN5bmMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL1dlYlBvcHVw TWVudVByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUG9wdXBNZW51UHJveHlHdGs6 OldlYlBvcHVwTWVudVByb3h5R3RrKToKKyAgICAgICAgKFdlYktpdDo6V2ViUG9wdXBNZW51UHJv eHlHdGs6OnNob3dQb3B1cE1lbnUpOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVQcm94 eUd0azo6Y2FuY2VsVHJhY2tpbmcpOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVQcm94 eUd0azo6bWVudUl0ZW1BY3RpdmF0ZWQpOgorICAgICAgICAoV2ViS2l0OjpXZWJQb3B1cE1lbnVQ cm94eUd0azo6ZGlzbWlzc01lbnVUaW1lckZpcmVkKToKKyAgICAgICAgKFdlYktpdDo6V2ViUG9w dXBNZW51UHJveHlHdGs6Om1lbnVVbm1hcHBlZENhbGxiYWNrKToKKyAgICAgICAgKiBVSVByb2Nl c3MvZ3RrL1dlYlBvcHVwTWVudVByb3h5R3RrLmg6CisKIDIwMTYtMDEtMTEgIE1hcmlvIFNhbmNo ZXogUHJhZGEgIDxtYXJpb0BlbmRsZXNzbS5jb20+CiAKICAgICAgICAgW1dLMl1bR1RLXSBQcm9w YWdhdGUgbW90aW9uLW5vdGlmeS1ldmVudCBzaWduYWxzIGZyb20gdGhlIFdlYlZpZXcKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViUG9wdXBNZW51UHJveHlHdGsu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5j cHAKaW5kZXggOWQ2MjAxMS4uZGMxOThkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0ay5jcHAKQEAgLTQyLDExICs0MiwxMCBA QCBXZWJQb3B1cE1lbnVQcm94eUd0azo6V2ViUG9wdXBNZW51UHJveHlHdGsoR3RrV2lkZ2V0KiB3 ZWJWaWV3LCBXZWJQb3B1cE1lbnVQcm94eQogICAgIDogV2ViUG9wdXBNZW51UHJveHkoY2xpZW50 KQogICAgICwgbV93ZWJWaWV3KHdlYlZpZXcpCiAgICAgLCBtX3BvcHVwKGd0a19tZW51X25ldygp KQotICAgICwgbV9wcmV2aW91c0tleUV2ZW50Q2hhcmFjdGVyKDApCi0gICAgLCBtX3ByZXZpb3Vz S2V5RXZlbnRUaW1lc3RhbXAoMCkKLSAgICAsIG1fY3VycmVudGx5U2VsZWN0ZWRNZW51SXRlbShu dWxscHRyKQorICAgICwgbV9kaXNtaXNzTWVudVRpbWVyKFJ1bkxvb3A6Om1haW4oKSwgdGhpcywg JldlYlBvcHVwTWVudVByb3h5R3RrOjpkaXNtaXNzTWVudVRpbWVyRmlyZWQpCiB7CiAgICAgZ19z aWduYWxfY29ubmVjdChtX3BvcHVwLCAia2V5LXByZXNzLWV2ZW50IiwgR19DQUxMQkFDSyhrZXlQ cmVzc0V2ZW50Q2FsbGJhY2spLCB0aGlzKTsKKyAgICBnX3NpZ25hbF9jb25uZWN0KG1fcG9wdXAs ICJ1bm1hcCIsIEdfQ0FMTEJBQ0sobWVudVVubWFwcGVkQ2FsbGJhY2spLCB0aGlzKTsKIH0KIAog V2ViUG9wdXBNZW51UHJveHlHdGs6On5XZWJQb3B1cE1lbnVQcm94eUd0aygpCkBAIC04OSwxMiAr ODgsMTMgQEAgdm9pZCBXZWJQb3B1cE1lbnVQcm94eUd0azo6cG9wdWxhdGVQb3B1cE1lbnUoY29u c3QgVmVjdG9yPFdlYlBvcHVwSXRlbT4mIGl0ZW1zKQogCiB2b2lkIFdlYlBvcHVwTWVudVByb3h5 R3RrOjpzaG93UG9wdXBNZW51KGNvbnN0IEludFJlY3QmIHJlY3QsIFRleHREaXJlY3Rpb24sIGRv dWJsZSAvKiBwYWdlU2NhbGVGYWN0b3IgKi8sIGNvbnN0IFZlY3RvcjxXZWJQb3B1cEl0ZW0+JiBp dGVtcywgY29uc3QgUGxhdGZvcm1Qb3B1cE1lbnVEYXRhJiwgaW50MzJfdCBzZWxlY3RlZEluZGV4 KQogeworICAgIG1fZGlzbWlzc01lbnVUaW1lci5zdG9wKCk7CisKICAgICBwb3B1bGF0ZVBvcHVw TWVudShpdGVtcyk7CiAgICAgZ3RrX21lbnVfc2V0X2FjdGl2ZShHVEtfTUVOVShtX3BvcHVwKSwg c2VsZWN0ZWRJbmRleCk7CiAKICAgICByZXNldFR5cGVBaGVhZEZpbmRTdGF0ZSgpOwogCi0KICAg ICBJbnRQb2ludCBtZW51UG9zaXRpb24gPSBjb252ZXJ0V2lkZ2V0UG9pbnRUb1NjcmVlblBvaW50 KG1fd2ViVmlldywgcmVjdC5sb2NhdGlvbigpKTsKICAgICBtZW51UG9zaXRpb24ubW92ZSgwLCBy ZWN0LmhlaWdodCgpKTsKIApAQCAtMTU1LDYgKzE1NSw3IEBAIHZvaWQgV2ViUG9wdXBNZW51UHJv eHlHdGs6OmNhbmNlbFRyYWNraW5nKCkKICAgICBpZiAoIW1fcG9wdXApCiAgICAgICAgIHJldHVy bjsKIAorICAgIG1fZGlzbWlzc01lbnVUaW1lci5zdG9wKCk7CiAgICAgZ19zaWduYWxfaGFuZGxl cnNfZGlzY29ubmVjdF9tYXRjaGVkKG1fcG9wdXAsIEdfU0lHTkFMX01BVENIX0RBVEEsIDAsIDAs IG51bGxwdHIsIG51bGxwdHIsIHRoaXMpOwogICAgIGhpZGVQb3B1cE1lbnUoKTsKICAgICBndGtf d2lkZ2V0X2Rlc3Ryb3kobV9wb3B1cCk7CkBAIC0yNDEsMTAgKzI0MiwyOCBAQCB2b2lkIFdlYlBv cHVwTWVudVByb3h5R3RrOjpyZXNldFR5cGVBaGVhZEZpbmRTdGF0ZSgpCiAKIHZvaWQgV2ViUG9w dXBNZW51UHJveHlHdGs6Om1lbnVJdGVtQWN0aXZhdGVkKEd0a0FjdGlvbiogYWN0aW9uLCBXZWJQ b3B1cE1lbnVQcm94eUd0ayogcG9wdXBNZW51KQogeworICAgIHBvcHVwTWVudS0+bV9kaXNtaXNz TWVudVRpbWVyLnN0b3AoKTsKICAgICBpZiAocG9wdXBNZW51LT5tX2NsaWVudCkKICAgICAgICAg cG9wdXBNZW51LT5tX2NsaWVudC0+dmFsdWVDaGFuZ2VkRm9yUG9wdXBNZW51KHBvcHVwTWVudSwg R1BPSU5URVJfVE9fSU5UKGdfb2JqZWN0X2dldF9kYXRhKEdfT0JKRUNUKGFjdGlvbiksICJwb3B1 cC1tZW51LWFjdGlvbi1pbmRleCIpKSk7CiB9CiAKK3ZvaWQgV2ViUG9wdXBNZW51UHJveHlHdGs6 OmRpc21pc3NNZW51VGltZXJGaXJlZCgpCit7CisgICAgaWYgKG1fY2xpZW50KQorICAgICAgICBt X2NsaWVudC0+dmFsdWVDaGFuZ2VkRm9yUG9wdXBNZW51KHRoaXMsIC0xKTsKK30KKwordm9pZCBX ZWJQb3B1cE1lbnVQcm94eUd0azo6bWVudVVubWFwcGVkQ2FsbGJhY2soR3RrV2lkZ2V0KiwgV2Vi UG9wdXBNZW51UHJveHlHdGsqIHBvcHVwTWVudSkKK3sKKyAgICBpZiAoIXBvcHVwTWVudS0+bV9j bGllbnQpCisgICAgICAgIHJldHVybjsKKworICAgIC8vIFdoZW4gYW4gaXRlbSBpcyBhY3RpdmF0 ZWQsIHRoZSBtZW51IGlzIGZpcnN0IGhpZGRlbiBhbmQgdGhlbiBhY3RpdmF0ZSBzaWduYWwgaXMg ZW1pdHRlZCwgc28gYXQgdGhpcyBwb2ludCB3ZSBkb24ndCBrbm93CisgICAgLy8gaWYgdGhlIG1l bnUgaGFzIGJlZW4gaGlkZGVuIGJlY2F1c2UgYW4gaXRlbSBoYXMgYmVlbiBzZWxlY3RlZCBvciBi ZWNhdXNlIHRoZSBtZW51IGhhcyBiZWVuIGRpc21pc3NlZC4gV2FpdCB1bnRpbCB0aGUgbmV4dAor ICAgIC8vIG1haW4gbG9vcCBpdGVyYXRpb24gdG8gZGlzbWlzcyB0aGUgbWVudSwgaWYgYW4gaXRl bSBpcyBhY3RpdmF0ZWQgdGhlIHRpbWVyIHdpbGwgYmUgY2FuY2VsbGVkLgorICAgIHBvcHVwTWVu dS0+bV9kaXNtaXNzTWVudVRpbWVyLnN0YXJ0T25lU2hvdCgwKTsKK30KKwogdm9pZCBXZWJQb3B1 cE1lbnVQcm94eUd0azo6c2VsZWN0SXRlbUNhbGxiYWNrKEd0a1dpZGdldCogaXRlbSwgV2ViUG9w dXBNZW51UHJveHlHdGsqIHBvcHVwTWVudSkKIHsKICAgICBwb3B1cE1lbnUtPnNldEN1cnJlbnRs eVNlbGVjdGVkTWVudUl0ZW0oaXRlbSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvZ3RrL1dlYlBvcHVwTWVudVByb3h5R3RrLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvZ3RrL1dlYlBvcHVwTWVudVByb3h5R3RrLmgKaW5kZXggZDQ4Y2QzZS4uOWM2MzlmZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2d0ay9XZWJQb3B1cE1lbnVQcm94eUd0 ay5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViUG9wdXBNZW51UHJveHlH dGsuaApAQCAtMjEsNiArMjEsNyBAQAogI2RlZmluZSBXZWJQb3B1cE1lbnVQcm94eUd0a19oCiAK ICNpbmNsdWRlICJXZWJQb3B1cE1lbnVQcm94eS5oIgorI2luY2x1ZGUgPHd0Zi9SdW5Mb29wLmg+ CiAjaW5jbHVkZSA8d3RmL2dsaWIvR1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1dURlN0 cmluZy5oPgogCkBAIC01Myw2ICs1NCw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBzZXRDdXJyZW50 bHlTZWxlY3RlZE1lbnVJdGVtKEd0a1dpZGdldCogaXRlbSkgeyBtX2N1cnJlbnRseVNlbGVjdGVk TWVudUl0ZW0gPSBpdGVtOyB9CiAgICAgR3RrQWN0aW9uKiBjcmVhdGVHdGtBY3Rpb25Gb3JNZW51 SXRlbShjb25zdCBXZWJQb3B1cEl0ZW0mLCBpbnQgaXRlbUluZGV4KTsKICAgICB2b2lkIHBvcHVs YXRlUG9wdXBNZW51KGNvbnN0IFZlY3RvcjxXZWJQb3B1cEl0ZW0+Jik7CisgICAgdm9pZCBkaXNt aXNzTWVudVRpbWVyRmlyZWQoKTsKIAogICAgIGJvb2wgdHlwZUFoZWFkRmluZChHZGtFdmVudEtl eSopOwogICAgIHZvaWQgcmVzZXRUeXBlQWhlYWRGaW5kU3RhdGUoKTsKQEAgLTYwLDE0ICs2Miwx NyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyB2b2lkIG1lbnVJdGVtQWN0aXZhdGVkKEd0a0FjdGlv biosIFdlYlBvcHVwTWVudVByb3h5R3RrKik7CiAgICAgc3RhdGljIHZvaWQgc2VsZWN0SXRlbUNh bGxiYWNrKEd0a1dpZGdldCosIFdlYlBvcHVwTWVudVByb3h5R3RrKik7CiAgICAgc3RhdGljIGdi b29sZWFuIGtleVByZXNzRXZlbnRDYWxsYmFjayhHdGtXaWRnZXQqLCBHZGtFdmVudEtleSosIFdl YlBvcHVwTWVudVByb3h5R3RrKik7CisgICAgc3RhdGljIHZvaWQgbWVudVVubWFwcGVkQ2FsbGJh Y2soR3RrV2lkZ2V0KiwgV2ViUG9wdXBNZW51UHJveHlHdGsqKTsKIAotICAgIEd0a1dpZGdldCog bV93ZWJWaWV3OwotICAgIEd0a1dpZGdldCogbV9wb3B1cDsKKyAgICBHdGtXaWRnZXQqIG1fd2Vi VmlldyB7IG51bGxwdHIgfTsKKyAgICBHdGtXaWRnZXQqIG1fcG9wdXAgeyBudWxscHRyIH07CisK KyAgICBSdW5Mb29wOjpUaW1lcjxXZWJQb3B1cE1lbnVQcm94eUd0az4gbV9kaXNtaXNzTWVudVRp bWVyOwogCiAgICAgLy8gVHlwZWFoZWFkIGZpbmQuCi0gICAgdW5zaWduZWQgbV9wcmV2aW91c0tl eUV2ZW50Q2hhcmFjdGVyOwotICAgIHVpbnQzMl90IG1fcHJldmlvdXNLZXlFdmVudFRpbWVzdGFt cDsKLSAgICBHdGtXaWRnZXQqIG1fY3VycmVudGx5U2VsZWN0ZWRNZW51SXRlbTsKKyAgICB1bnNp Z25lZCBtX3ByZXZpb3VzS2V5RXZlbnRDaGFyYWN0ZXIgeyAwIH07CisgICAgdWludDMyX3QgbV9w cmV2aW91c0tleUV2ZW50VGltZXN0YW1wIHsgMCB9OworICAgIEd0a1dpZGdldCogbV9jdXJyZW50 bHlTZWxlY3RlZE1lbnVJdGVtIHsgbnVsbHB0ciB9OwogICAgIFN0cmluZyBtX2N1cnJlbnRTZWFy Y2hTdHJpbmc7CiB9OwogCg==