152974 2016-01-11 02:34:47 -0800 [WK2][GTK] Propagate motion-notify-event signals from the WebView 2016-01-11 03:32:28 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build All Linux RESOLVED FIXED Gtk P2 Normal --- 1 mario webkit-unassigned berto bugs-noreply cgarcia commit-queue gustavo mcatanzaro mrobinson philip.chimento oldest_to_newest 1154339 0 mario 2016-01-11 02:34:47 -0800 As it was brought up in the mailing list recently[1], there are some signals for which the default handlers in the WebView prevent them from being propagated as there is no way to know, in a multi-process model, when the WebProcess have actually processed them or not (they should be propagated when not processed). See more detailed explanation in [2]. Options proposed were, mainly, to either store the event in the UI process and re-emit later once we know the Web process has not been handled (as done for key events) or simply to return FALSE to always propagate them, which sounds like a good option for events like motion-event-notify, which do not act over any specific target (see [3] for a better explanation of the rationale behind). I discussed this with Carlos on IRC and he agrees on doing that change for motion events, so tracking that change here. [1] https://lists.webkit.org/pipermail/webkit-gtk/2016-January/002498.html [2] https://lists.webkit.org/pipermail/webkit-gtk/2016-January/002500.html [3] https://lists.webkit.org/pipermail/webkit-gtk/2016-January/002505.html 1154343 1 268681 mario 2016-01-11 02:51:23 -0800 Created attachment 268681 Patch proposal 1154344 2 commit-queue 2016-01-11 02:53:57 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1154348 3 mario 2016-01-11 03:32:28 -0800 Committed r194846: <http://trac.webkit.org/changeset/194846> 268681 2016-01-11 02:51:23 -0800 2016-01-11 02:53:04 -0800 Patch proposal patch text/plain 2484 mario Y29tbWl0IGIxOGYwODI3ZDM5YjVmZmJhMGMyNTBhNGQ5M2M3ZTFmMjJlMWZlNTgKQXV0aG9yOiBN YXJpbyBTYW5jaGV6IFByYWRhIDxtYXJpb0B3ZWJraXQub3JnPgpEYXRlOiAgIE1vbiBKYW4gMTEg MTA6NDU6NTUgMjAxNiArMDAwMAoKICAgIFtXSzJdW0dUS10gUHJvcGFnYXRlIG1vdGlvbi1ub3Rp ZnktZXZlbnQgc2lnbmFscyBmcm9tIHRoZSBXZWJWaWV3CiAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyOTc0CiAgICAKICAgIFJldmlld2VkIGJ5IENhcmxvcyBH YXJjaWEgQ2FtcG9zLgogICAgCiAgICBBbHdheXMgcHJvcGFnYXRlIG1vdGlvbi1ub3RpZnktZXZl bnQgc2lnbmFscywgcmVnYXJkbGVzcyBvZiB3aGF0IHRoZQogICAgd2ViIHByb2Nlc3MgZG9lcywg c28gdGhhdCB3ZSBjYW4gbGlzdGVuIGZvciB0aG9zZSBldmVudHMgKHdoaWNoIGRvZXMKICAgIG5v dCBhY3Qgb24gc3BlY2lmaWMgdGFyZ2V0cyBpbnNpZGUgdGhlIHdlYnZpZXcpIGZyb20gdGhlIGNv bnRhaW5lcgogICAgd2lkZ2V0IHRvbywgYW5kIG5vdCBqdXN0IGZyb20gdGhlIFdlYlZpZXcgaXRz ZWxmLgogICAgCiAgICBTb3VyY2UvV2ViS2l0MjoKICAgIAogICAgKiBVSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CiAgICAod2Via2l0V2ViVmlld0Jhc2VNb3Rpb25Ob3Rp ZnlFdmVudCk6IEVuc3VyZSB0aGUgc2lnbmFsIGdldHMgcHJvcGFnYXRlZC4KCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggOTAwODkxYy4uZmU0NThjMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTAx LTExICBNYXJpbyBTYW5jaGV6IFByYWRhICA8bWFyaW9AZW5kbGVzc20uY29tPgorCisgICAgICAg IFtXSzJdW0dUS10gUHJvcGFnYXRlIG1vdGlvbi1ub3RpZnktZXZlbnQgc2lnbmFscyBmcm9tIHRo ZSBXZWJWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTI5NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBbHdheXMgcHJvcGFnYXRlIG1vdGlvbi1ub3RpZnktZXZlbnQgc2lnbmFscywgcmVnYXJkbGVz cyBvZiB3aGF0IHRoZQorICAgICAgICB3ZWIgcHJvY2VzcyBkb2VzLCBzbyB0aGF0IHdlIGNhbiBs aXN0ZW4gZm9yIHRob3NlIGV2ZW50cyAod2hpY2ggZG9lcworICAgICAgICBub3QgYWN0IG9uIHNw ZWNpZmljIHRhcmdldHMgaW5zaWRlIHRoZSB3ZWJ2aWV3KSBmcm9tIHRoZSBjb250YWluZXIKKyAg ICAgICAgd2lkZ2V0IHRvbywgYW5kIG5vdCBqdXN0IGZyb20gdGhlIFdlYlZpZXcgaXRzZWxmLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwOgorICAg ICAgICAod2Via2l0V2ViVmlld0Jhc2VNb3Rpb25Ob3RpZnlFdmVudCk6IEVuc3VyZSB0aGUgc2ln bmFsIGdldHMgcHJvcGFnYXRlZC4KKwogMjAxNi0wMS0xMCAgRGFuIEJlcm5zdGVpbiAgPG1pdHpA YXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gRGlzYWJsZSBoZWFkZXIgcG9zdHByb2Nlc3Np bmcgd2hlbiBidWlsZGluZyBmb3IgRWwgQ2FwaXRhbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlld0Jhc2UuY3BwCmluZGV4IDBkZTlmNzUu LmM0NzEwMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYlZpZXdCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTc5MywxMSArNzkzLDExIEBAIHN0YXRpYyBnYm9v bGVhbiB3ZWJraXRXZWJWaWV3QmFzZU1vdGlvbk5vdGlmeUV2ZW50KEd0a1dpZGdldCogd2lkZ2V0 LCBHZGtFdmVudE1vCiAgICAgV2ViS2l0V2ViVmlld0Jhc2VQcml2YXRlKiBwcml2ID0gd2ViVmll d0Jhc2UtPnByaXY7CiAKICAgICBpZiAocHJpdi0+YXV0aGVudGljYXRpb25EaWFsb2cpCi0gICAg ICAgIHJldHVybiBUUlVFOworICAgICAgICByZXR1cm4gR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRf d2ViX3ZpZXdfYmFzZV9wYXJlbnRfY2xhc3MpLT5tb3Rpb25fbm90aWZ5X2V2ZW50KHdpZGdldCwg ZXZlbnQpOwogCiAgICAgcHJpdi0+cGFnZVByb3h5LT5oYW5kbGVNb3VzZUV2ZW50KE5hdGl2ZVdl Yk1vdXNlRXZlbnQocmVpbnRlcnByZXRfY2FzdDxHZGtFdmVudCo+KGV2ZW50KSwgMCAvKiBjdXJy ZW50Q2xpY2tDb3VudCAqLykpOwogCi0gICAgcmV0dXJuIFRSVUU7CisgICAgcmV0dXJuIEZBTFNF OwogfQogCiAjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykK