152971 2016-01-10 23:52:48 -0800 run-jsc-stress-tests should try to figure out a JSC path 2016-01-11 20:41:36 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver ossy sukolsak ysuzuki oldest_to_newest 1154324 0 saam 2016-01-10 23:52:48 -0800 If it does, we can run it just like this: `run-esc-stress-tests <directory/to/some/tests> <path/to/a/yaml>` 1154326 1 268677 saam 2016-01-11 00:06:17 -0800 Created attachment 268677 patch 1154331 2 268677 ysuzuki 2016-01-11 00:25:39 -0800 Comment on attachment 268677 patch View in context: https://bugs.webkit.org/attachment.cgi?id=268677&action=review r=me > Tools/Scripts/run-jsc-stress-tests:264 > + jscArg = Pathname.new(output).join("JavaScriptCore.framework").join("Resources").join("jsc") Nits: we can write this as `Pathname.new(output).join("JavaScriptCore.framework", "Resources", "jsc")`. > Tools/Scripts/run-jsc-stress-tests:265 > + end And by adding one more fallback, `Pathname.new(output).join("bin", "jsc")`, we can support EFL / GTK. 1154612 3 saam 2016-01-11 20:41:10 -0800 (In reply to comment #2) > Comment on attachment 268677 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=268677&action=review > > r=me > > > Tools/Scripts/run-jsc-stress-tests:264 > > + jscArg = Pathname.new(output).join("JavaScriptCore.framework").join("Resources").join("jsc") > > Nits: we can write this as > `Pathname.new(output).join("JavaScriptCore.framework", "Resources", "jsc")`. > > > Tools/Scripts/run-jsc-stress-tests:265 > > + end > > And by adding one more fallback, `Pathname.new(output).join("bin", "jsc")`, > we can support EFL / GTK. Thanks for the review 1154614 4 saam 2016-01-11 20:41:36 -0800 landed in: http://trac.webkit.org/changeset/194885 268677 2016-01-11 00:06:17 -0800 2016-01-11 00:25:39 -0800 patch a-backup.diff text/plain 3633 saam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5NDg0MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMwIEBACisyMDE2LTAxLTEwICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor CisgICAgICAgIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzIHNob3VsZCB0cnkgdG8gZmlndXJlIG91dCBh IEpTQyBwYXRoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTI5NzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGlzIHBhdGNoIG5vdyBhbGxvd3MgcnVuLWpzYy1zdHJlc3MtdGVzdHMgdG8gYmUgcnVuCisg ICAgICAgIHdpdGhvdXQgYSAiLS1qc2MgPGpzYy1wYXRoPiIgYXJndW1lbnQuIEl0IHRyaWVzCisg ICAgICAgIHRvIHRha2UgaXRzIGJlc3QgZ3Vlc3MgYXQgYSA8anNjLXBhdGg+IGF1dG9tYWdpY2Fs bHkuCisgICAgICAgIAorICAgICAgICBUaGlzIG1ha2VzIGl0IG11Y2ggZWFzaWVyIHRvIGp1c3Qg cnVuIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzCisgICAgICAgIHdpdGggYSBkaXJlY3Rvcnkgb3IgYSB5 YW1sIGZpbGUgYXMgYW4gYXJndW1lbnQuCisgICAgICAgIFlvdSBub3cganVzdCBkbyB0aGlzOgor ICAgICAgICBgcnVuLWpzYy1zdHJlc3MtdGVzdHMgPHBhdGgtdG8teWFtbD5gCisgICAgICAgIG9y CisgICAgICAgIGBydW4tanNjLXN0cmVzcy10ZXN0cyA8cGF0aC10by1kaXJlY3Rvcnktb2YtanMt ZmlsZXM+YAorICAgICAgICAKKyAgICAgICAgSSB3cm90ZSB0aGlzIHBhdGNoIGJlY2F1c2UgSSdk IG9mdGVuIGZpbmQgbXlzZWxmIGhhY2tpbmcgdGhlIAorICAgICAgICBydW4tamF2YXNjcmlwdGNv cmUtdGVzdHMgZmlsZSBqdXN0IHRvIHJ1biBhIHBhcnRpY3VsYXIgc3Vic2V0IG9mIHRlc3RzLgor ICAgICAgICBCZWNhdXNlIEkgYWx3YXlzIGZvcmdldCB0aGUgYXJndW1lbnRzIHRvIHJ1bi1qc2Mt c3RyZXNzLXRlc3RzICh3aGljaCBtZWFucworICAgICAgICBJIGFsd2F5cyBmb3Jnb3QgdG8gcHJv dmlkZSBhIC0tanNjIGFyZ3VtZW50KSwgSSBhbHdheXMgZm91bmQgaXQgZWFzaWVyIHRvIAorICAg ICAgICBqdXN0IGhhY2sgb24gdGhhdCBmaWxlIGluc3RlYWQgb2YgY2FsbGluZyBydW4tanNjLXN0 cmVzcy10ZXN0cyBkaXJlY3RseS4KKyAgICAgICAgTm8gbG9uZ2VyIGlzIHRoaXMgdHJ1ZSEKKwor ICAgICAgICAqIFNjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHM6CisKIDIwMTYtMDEtMTAgIFNh YW0gYmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IGEgc2Ft cGxpbmcgcHJvZmlsZXIKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNp b24gMTk0ODQwKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2lu ZyBjb3B5KQpAQCAtMTQ2LDYgKzE0Niw3IEBAIGRlZiB1c2FnZQogZW5kCiAKIGpzY0FyZyA9IG5p bAoraWZKU0NBcmdJc250UHJvdmlkZWRBcmVXZVJlbGVhc2VCdWlsZCA9IHRydWUKIAogR2V0b3B0 TG9uZy5uZXcoWyctLWhlbHAnLCAnLWgnLCBHZXRvcHRMb25nOjpOT19BUkdVTUVOVF0sCiAgICAg ICAgICAgICAgICBbJy0tanNjJywgJy1qJywgR2V0b3B0TG9uZzo6UkVRVUlSRURfQVJHVU1FTlRd LApAQCAtMTY3LDYgKzE2OCw4IEBAIEdldG9wdExvbmcubmV3KFsnLS1oZWxwJywgJy1oJywgR2V0 b3B0TG8KICAgICAgICAgICAgICAgIFsnLS1maWx0ZXInLCBHZXRvcHRMb25nOjpSRVFVSVJFRF9B UkdVTUVOVF0sCiAgICAgICAgICAgICAgICBbJy0tdmVyYm9zZScsICctdicsIEdldG9wdExvbmc6 Ok5PX0FSR1VNRU5UXSwKICAgICAgICAgICAgICAgIFsnLS1lbnYtdmFycycsIEdldG9wdExvbmc6 OlJFUVVJUkVEX0FSR1VNRU5UXSwKKyAgICAgICAgICAgICAgIFsnLS1kZWJ1ZycsIEdldG9wdExv bmc6Ok5PX0FSR1VNRU5UXSwKKyAgICAgICAgICAgICAgIFsnLS1yZWxlYXNlJywgR2V0b3B0TG9u Zzo6Tk9fQVJHVU1FTlRdLAogICAgICAgICAgICAgICAgWyctLXF1aWNrJywgJy1xJywgR2V0b3B0 TG9uZzo6Tk9fQVJHVU1FTlRdKS5lYWNoIHsKICAgICB8IG9wdCwgYXJnIHwKICAgICBjYXNlIG9w dApAQCAtMjE4LDYgKzIyMSwxMCBAQCBHZXRvcHRMb25nLm5ldyhbJy0taGVscCcsICctaCcsIEdl dG9wdExvCiAgICAgICAgICRlbnZWYXJzID0gYXJnLmdzdWIoL1xzKy8sICcgJykuc3BsaXQoJyAn KQogICAgIHdoZW4gJy0tcXVpY2snCiAgICAgICAgICRxdWlja01vZGUgPSB0cnVlCisgICAgd2hl biAnLS1kZWJ1ZycKKyAgICAgICAgaWZKU0NBcmdJc250UHJvdmlkZWRBcmVXZVJlbGVhc2VCdWls ZCA9IGZhbHNlCisgICAgd2hlbiAnLS1yZWxlYXNlJworICAgICAgICBpZkpTQ0FyZ0lzbnRQcm92 aWRlZEFyZVdlUmVsZWFzZUJ1aWxkID0gdHJ1ZQogICAgIGVuZAogfQogCkBAIC0yMzksOCArMjQ2 LDI5IEBAIGlmICRyZW1vdGVDb25maWdGaWxlCiBlbmQKIAogdW5sZXNzIGpzY0FyZwotICAgICRz dGRlcnIucHV0cyAiRXJyb3I6IG11c3Qgc3BlY2lmeSAtLWpzYyA8cGF0aD4iCi0gICAgZXhpdCAx CisgICAgIyBJZiB3ZSdyZSBub3QgcHJvdmlkZWQgYSBKU0MgcGF0aCwgdHJ5IHRvIGNvbWUgdXAg d2l0aCBhIHNlbnNpYmxlIEpTQyBwYXRoIGF1dG9tYWdpY2FsbHkuCisgICAgY29tbWFuZCA9IFND UklQVFNfUEFUSC5qb2luKCJ3ZWJraXQtYnVpbGQtZGlyZWN0b3J5IikudG9fcworICAgIGNvbW1h bmQgKz0gaWZKU0NBcmdJc250UHJvdmlkZWRBcmVXZVJlbGVhc2VCdWlsZCA/ICIgLS1yZWxlYXNl IiA6ICIgLS1kZWJ1ZyIKKyAgICBjb21tYW5kICs9ICIgLS1leGVjdXRhYmxlUGF0aCIKKworICAg IG91dHB1dCA9IGAje2NvbW1hbmR9YC5zcGxpdCgiXG4iKQorICAgIGlmICFvdXRwdXQubGVuZ3Ro CisgICAgICAgICRzdGRlcnIucHV0cyAiRXJyb3I6IG11c3Qgc3BlY2lmeSAtLWpzYyA8cGF0aD4i CisgICAgICAgIGV4aXQgMQorICAgIGVuZAorCisgICAgb3V0cHV0ID0gb3V0cHV0WzBdCisgICAg anNjQXJnID0gUGF0aG5hbWUubmV3KG91dHB1dCkuam9pbigianNjIikKKworICAgIGlmICFGaWxl LmZpbGU/KGpzY0FyZykKKyAgICAgICAganNjQXJnID0gUGF0aG5hbWUubmV3KG91dHB1dCkuam9p bigiSmF2YVNjcmlwdENvcmUuZnJhbWV3b3JrIikuam9pbigiUmVzb3VyY2VzIikuam9pbigianNj IikKKyAgICBlbmQKKyAgICBpZiAhRmlsZS5maWxlPyhqc2NBcmcpCisgICAgICAgICRzdGRlcnIu cHV0cyAiRXJyb3I6IG11c3Qgc3BlY2lmeSAtLWpzYyA8cGF0aD4iCisgICAgICAgIGV4aXQgMQor ICAgIGVuZAorCisgICAgcHV0cyAiVXNpbmcgdGhlIGZvbGxvd2luZyBqc2MgcGF0aDogI3tqc2NB cmd9IgogZW5kCiAKIGlmICRlbmFibGVGVEwgYW5kICEkaml0VGVzdHMK