152967 2016-01-10 16:56:35 -0800 Web Inspector: Visual sidebar minor bug fixes 2016-01-11 17:31:36 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1154289 0 hi 2016-01-10 16:56:35 -0800 r194737 (https://bugs.webkit.org/show_bug.cgi?id=148254) introduced a few minor bugs within the visual sidebar: - Clicking a keyword icon will cause it to be momentarily selected before reverting to the previous state - Bezier editors are very laggy (fighting against updates) - Number input's without units are editable by default (when "Unchanged" is selected) 1154307 1 268670 hi 2016-01-10 20:17:47 -0800 Created attachment 268670 Patch 1154574 2 268670 commit-queue 2016-01-11 17:31:33 -0800 Comment on attachment 268670 Patch Clearing flags on attachment: 268670 Committed r194875: <http://trac.webkit.org/changeset/194875> 1154575 3 commit-queue 2016-01-11 17:31:36 -0800 All reviewed patches have been landed. Closing bug. 268670 2016-01-10 20:17:47 -0800 2016-01-11 17:31:33 -0800 Patch bug-152967-20160110201716.patch text/plain 5217 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDcyZDk5M2UxYjRjMDM5MzNkMDI4OGRlNDZiOWE2 NzRiYjI4N2ZhMzguLmZkMDFmMDk4OGY4OTQ5YTliOWNjNmU0OGEwMGFkMGI0MjhhMzU3MmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE2LTAxLTEwICBEZXZp biBSb3Vzc28gIDxkY3JvdXNzbyt3ZWJraXRAZ21haWwuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFZpc3VhbCBzaWRlYmFyIG1pbm9yIGJ1ZyBmaXhlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTUyOTY3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3Vh bFN0eWxlRGV0YWlsc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxl RGV0YWlsc1BhbmVsLnByb3RvdHlwZS5yZWZyZXNoKToKKyAgICAgICAgT25seSB1cGRhdGUgc2Vj dGlvbnMgd2hlbiBpdCBpcyBub3QgYSBzaWduaWZpY2FudCBjaGFuZ2UsIGFzIHRoZXkgYXJlCisg ICAgICAgIHVwZGF0ZWQgd2hlbiB0aGUgc2VsZWN0b3IgY2hhbmdlcy4KKworICAgICAgICAoV2Vi SW5zcGVjdG9yLlZpc3VhbFN0eWxlRGV0YWlsc1BhbmVsLnByb3RvdHlwZS5fdXBkYXRlUHJvcGVy dGllcyk6CisgICAgICAgIE9ubHkgcmVzZXQgbGlua3MgaWYgdGhlIHJlZnJlc2ggaXMgYSBzaWdu aWZpY2FudCBjaGFuZ2UgKG5vZGUgb3Igc2VsZWN0ZWQKKyAgICAgICAgc3R5bGUgY2hhbmdlcyku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlTnVtYmVySW5wdXRC b3guanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveC5wcm90b3R5 cGUuZ2V0IHZhbHVlKToKKyAgICAgICAgUmVtb3ZlZCB1bnJlYWNoYWJsZSByZXR1cm4uCisKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZU51bWJlcklucHV0Qm94LnByb3RvdHlwZS5z ZXQgdmFsdWUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpc3VhbFN0eWxlTnVtYmVySW5wdXRC b3gucHJvdG90eXBlLl92YWx1ZU51bWJlcklucHV0S2V5RG93bi5hZGp1c3RWYWx1ZSk6CisgICAg ICAgIF91cGRhdGVkVmFsdWVzLnByb3BlcnR5TWlzc2luZyB3YXMgY2hhbmdlZCB0byBfcHJvcGVy dHlNaXNzaW5nIGluIGEKKyAgICAgICAgcHJpb3IgcGF0Y2guCisKIDIwMTYtMDEtMTAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBVbmNhdWdodCBFeGNlcHRpb24gc2VsZWN0aW5nIEluZGV4ZWREQiBob3N0IGZvbGRlciBpbiBT dG9yYWdlIHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvVmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZURldGFpbHNQYW5lbC5qcwppbmRleCAw MjE0ODczNGRlMDEwYjIwZTU3NWI2YjZkMTY5ZDI3MzZjZTdhYTM4Li5jODE1NDBlZDBiNzJhY2Zk ZWRhOThiZDk0YzNiYzZlMTc2ODc0N2MxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZURldGFpbHNQYW5lbC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxTdHlsZURldGFp bHNQYW5lbC5qcwpAQCAtMTAzLDggKzEwMywxMCBAQCBXZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVE ZXRhaWxzUGFuZWwgPSBjbGFzcyBWaXN1YWxTdHlsZURldGFpbHNQYW5lbCBleHRlbmRzIFdlYgog CiAgICAgcmVmcmVzaChzaWduaWZpY2FudENoYW5nZSkKICAgICB7Ci0gICAgICAgIHRoaXMuX3Nl bGVjdG9yU2VjdGlvbi51cGRhdGUodGhpcy5fbm9kZVN0eWxlcyk7Ci0gICAgICAgIHRoaXMuX3Vw ZGF0ZVNlY3Rpb25zKCk7CisgICAgICAgIGlmIChzaWduaWZpY2FudENoYW5nZSkKKyAgICAgICAg ICAgIHRoaXMuX3NlbGVjdG9yU2VjdGlvbi51cGRhdGUodGhpcy5fbm9kZVN0eWxlcyk7CisgICAg ICAgIGVsc2UKKyAgICAgICAgICAgIHRoaXMuX3VwZGF0ZVNlY3Rpb25zKCk7CiAKICAgICAgICAg c3VwZXIucmVmcmVzaCgpOwogICAgIH0KQEAgLTE3Miw3ICsxNzQsNyBAQCBXZWJJbnNwZWN0b3Iu VmlzdWFsU3R5bGVEZXRhaWxzUGFuZWwgPSBjbGFzcyBWaXN1YWxTdHlsZURldGFpbHNQYW5lbCBl eHRlbmRzIFdlYgogICAgICAgICBpZiAoIWdyb3VwLnNlY3Rpb24pCiAgICAgICAgICAgICByZXR1 cm47CiAKLSAgICAgICAgaWYgKGdyb3VwLmxpbmtzKSB7CisgICAgICAgIGlmIChmb3JjZVN0eWxl VXBkYXRlICYmIGdyb3VwLmxpbmtzKSB7CiAgICAgICAgICAgICBmb3IgKGxldCBrZXkgaW4gZ3Jv dXAubGlua3MpCiAgICAgICAgICAgICAgICAgZ3JvdXAubGlua3Nba2V5XS5saW5rZWQgPSBmYWxz ZTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveC5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Zpc3VhbFN0eWxlTnVtYmVySW5wdXRCb3guanMK aW5kZXggNGRiNmU3MDRkMDZiMzMwZjljOTFmZDgzZWQzZTQ1NzZlNjdlZjk2NC4uMTdjMDRkZDJl OTA2M2I1MTE3MGNjMGVlYmJiMTA2ZjQzNTg1M2Y2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveC5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaXN1YWxT dHlsZU51bWJlcklucHV0Qm94LmpzCkBAIC04OSwxMiArODksMTAgQEAgV2ViSW5zcGVjdG9yLlZp c3VhbFN0eWxlTnVtYmVySW5wdXRCb3ggPSBjbGFzcyBWaXN1YWxTdHlsZU51bWJlcklucHV0Qm94 IGV4dGVuZHMKIAogICAgICAgICB0aGlzLmNvbnRlbnRFbGVtZW50LmFwcGVuZENoaWxkKHRoaXMu X251bWJlclVuaXRzQ29udGFpbmVyKTsKIAotICAgICAgICB0aGlzLl9udW1iZXJJbnB1dElzRWRp dGFibGUgPSB0cnVlOwotICAgICAgICB0aGlzLmNvbnRlbnRFbGVtZW50LmNsYXNzTGlzdC5hZGQo Im51bWJlci1pbnB1dC1lZGl0YWJsZSIpOworICAgICAgICB0aGlzLl9zZXROdW1iZXJJbnB1dElz RWRpdGFibGUodHJ1ZSk7CiAgICAgICAgIHRoaXMuX3ZhbHVlTnVtYmVySW5wdXRFbGVtZW50LnZh bHVlID0gbnVsbDsKICAgICAgICAgdGhpcy5fdmFsdWVOdW1iZXJJbnB1dEVsZW1lbnQuc2V0QXR0 cmlidXRlKCJwbGFjZWhvbGRlciIsIDApOwotICAgICAgICBpZiAodGhpcy5faGFzVW5pdHMpCi0g ICAgICAgICAgICB0aGlzLl91bml0c0VsZW1lbnRUZXh0Q29udGVudCA9IHRoaXMuX2tleXdvcmRT ZWxlY3RFbGVtZW50LnZhbHVlID0gdGhpcy52YWx1ZUlzU3VwcG9ydGVkVW5pdCgicHgiKSA/ICJw eCIgOiB0aGlzLl9wb3NzaWJsZVVuaXRzLmJhc2ljWzBdOworICAgICAgICB0aGlzLl91bml0c0Vs ZW1lbnRUZXh0Q29udGVudCA9IHRoaXMuX2tleXdvcmRTZWxlY3RFbGVtZW50LnZhbHVlID0gdGhp cy52YWx1ZUlzU3VwcG9ydGVkVW5pdCgicHgiKSA/ICJweCIgOiB0aGlzLl9wb3NzaWJsZVVuaXRz LmJhc2ljWzBdOwogICAgIH0KIAogICAgIC8vIFB1YmxpYwpAQCAtMTAzLDExICsxMDEsNyBAQCBX ZWJJbnNwZWN0b3IuVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveCA9IGNsYXNzIFZpc3VhbFN0eWxl TnVtYmVySW5wdXRCb3ggZXh0ZW5kcwogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX251bWJlcklu cHV0SXNFZGl0YWJsZSkKICAgICAgICAgICAgIHJldHVybiBwYXJzZUZsb2F0KHRoaXMuX3ZhbHVl TnVtYmVySW5wdXRFbGVtZW50LnZhbHVlKTsKLQotICAgICAgICBpZiAoIXRoaXMuX251bWJlcklu cHV0SXNFZGl0YWJsZSkKLSAgICAgICAgICAgIHJldHVybiB0aGlzLl9rZXl3b3JkU2VsZWN0RWxl bWVudC52YWx1ZTsKLQotICAgICAgICByZXR1cm4gbnVsbDsKKyAgICAgICAgcmV0dXJuIHRoaXMu X2tleXdvcmRTZWxlY3RFbGVtZW50LnZhbHVlIHx8IG51bGw7CiAgICAgfQogCiAgICAgc2V0IHZh bHVlKHZhbHVlKQpAQCAtMTE1LDcgKzEwOSw3IEBAIFdlYkluc3BlY3Rvci5WaXN1YWxTdHlsZU51 bWJlcklucHV0Qm94ID0gY2xhc3MgVmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveCBleHRlbmRzCiAg ICAgICAgIGlmICh2YWx1ZSAmJiB2YWx1ZSA9PT0gdGhpcy52YWx1ZSkKICAgICAgICAgICAgIHJl dHVybjsKIAotICAgICAgICBpZiAodGhpcy5fdXBkYXRlZFZhbHVlcy5wcm9wZXJ0eU1pc3Npbmcp IHsKKyAgICAgICAgaWYgKHRoaXMuX3Byb3BlcnR5TWlzc2luZykgewogICAgICAgICAgICAgaWYg KHZhbHVlIHx8IHRoaXMuX3VwZGF0ZWRWYWx1ZXMucGxhY2Vob2xkZXIpCiAgICAgICAgICAgICAg ICAgdGhpcy5zcGVjaWFsUHJvcGVydHlQbGFjZWhvbGRlckVsZW1lbnQudGV4dENvbnRlbnQgPSAo dmFsdWUgfHwgdGhpcy5fdXBkYXRlZFZhbHVlcy5wbGFjZWhvbGRlcikgKyAodGhpcy5fdXBkYXRl ZFZhbHVlcy51bml0cyB8fCAiIik7CiAKQEAgLTI4MCw3ICsyNzQsNyBAQCBXZWJJbnNwZWN0b3Iu VmlzdWFsU3R5bGVOdW1iZXJJbnB1dEJveCA9IGNsYXNzIFZpc3VhbFN0eWxlTnVtYmVySW5wdXRC b3ggZXh0ZW5kcwogICAgICAgICAgICAgaWYgKCF0aGlzLl9hbGxvd05lZ2F0aXZlVmFsdWVzICYm IG5ld1ZhbHVlIDwgMCkKICAgICAgICAgICAgICAgICBuZXdWYWx1ZSA9IDA7CiAKLSAgICAgICAg ICAgIHRoaXMuX3VwZGF0ZWRWYWx1ZXMucHJvcGVydHlNaXNzaW5nID0gZmFsc2U7CisgICAgICAg ICAgICB0aGlzLl9wcm9wZXJ0eU1pc3NpbmcgPSBmYWxzZTsKICAgICAgICAgICAgIHRoaXMudmFs dWUgPSBNYXRoLnJvdW5kKG5ld1ZhbHVlICogMTAwKSAvIDEwMDsKICAgICAgICAgICAgIHRoaXMu X3ZhbHVlRGlkQ2hhbmdlKCk7CiAgICAgICAgIH0K